Change in simtrace2[master]: cardemu: different init for simtrace board which uses uart timers
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23617 ) Change subject: cardemu: different init for simtrace board which uses uart timers .. Abandoned not needed -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I464f0ce1ec5e60be5f9377186b7d13a5e6dc637e Gerrit-Change-Number: 23617 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: abandon
Change in simtrace2[master]: cardemu: different init for simtrace board which uses uart timers
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23617 ) Change subject: cardemu: different init for simtrace board which uses uart timers .. Patch Set 2: Code-Review-1 I have the feeling this should not be a separate patch. Ater all, at the point this patch is in the series, the "simtrace board" is not using uart timers yet. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I464f0ce1ec5e60be5f9377186b7d13a5e6dc637e Gerrit-Change-Number: 23617 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Sun, 04 Apr 2021 21:25:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in simtrace2[master]: cardemu: different init for simtrace board which uses uart timers
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23617 ) Change subject: cardemu: different init for simtrace board which uses uart timers .. Patch Set 1: the goal is probably to move away from the tc_etu for all of the boards. I will review this and take it further. One problem with this patch is that it means tc_etu.o is still required for some boards (qemu, owhw) but not for others (simtrace). -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I464f0ce1ec5e60be5f9377186b7d13a5e6dc637e Gerrit-Change-Number: 23617 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Sun, 04 Apr 2021 18:03:15 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in simtrace2[master]: cardemu: different init for simtrace board which uses uart timers
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23617 to review the following change. Change subject: cardemu: different init for simtrace board which uses uart timers .. cardemu: different init for simtrace board which uses uart timers Change-Id: I464f0ce1ec5e60be5f9377186b7d13a5e6dc637e --- M firmware/libcommon/source/mode_cardemu.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/17/23617/1 diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c index 1dbd2d3..c6c129d 100644 --- a/firmware/libcommon/source/mode_cardemu.c +++ b/firmware/libcommon/source/mode_cardemu.c @@ -429,7 +429,20 @@ /* configure USART as ISO-7816 slave (e.g. card) */ ISO7816_Init(_inst[0].usart_info, CLK_SLAVE); +#ifdef BOARD_simtrace + /* simtrace board uses uart timeouts */ + + /* don't use receive timeout timer for now */ + cardem_inst[0].usart_info.base->US_RTOR = 0; + /* enable interrupts to indicate when data has been received or timeout occurred */ + USART_EnableIt(cardem_inst[0].usart_info.base, US_IER_RXRDY | US_IER_TIMEOUT); +#else + /* enable interrupts to indicate when data has been received */ + USART_EnableIt(cardem_inst[0].usart_info.base, US_IER_RXRDY ); +#endif + /* enable interrupt requests for the USART peripheral */ NVIC_EnableIRQ(USART1_IRQn); + PIO_ConfigureIt(_usim1_rst, usim1_rst_irqhandler); PIO_EnableIt(_usim1_rst); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I464f0ce1ec5e60be5f9377186b7d13a5e6dc637e Gerrit-Change-Number: 23617 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: newchange
