Change in simtrace2[master]: minor : fix typo in comment

2019-12-02 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/16417 )

Change subject: minor : fix typo in comment
..

minor : fix typo in comment

Change-Id: Ie310143fe713a51fa1adf8bf7599374282341f2e
---
M firmware/libcommon/source/simtrace_iso7816.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/firmware/libcommon/source/simtrace_iso7816.c 
b/firmware/libcommon/source/simtrace_iso7816.c
index 889ca2d..8ee3f8c 100644
--- a/firmware/libcommon/source/simtrace_iso7816.c
+++ b/firmware/libcommon/source/simtrace_iso7816.c
@@ -80,7 +80,7 @@
 }

 /*
- *  char_stat is zero if no error occured.
+ *  char_stat is zero if no error occurred.
  *  Otherwise it is filled with the content of the status register.
  */
 void mode_trace_usart1_irq(void)
@@ -110,7 +110,7 @@
rbuf_write(_rcv_buf, c);
} else {
TRACE_DEBUG("e %x st: %x\n", c, stat);
-   }   /* else: error occured */
+   }   /* else: error occurred */

char_stat = stat;
}

--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16417
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie310143fe713a51fa1adf8bf7599374282341f2e
Gerrit-Change-Number: 16417
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: tsaitgaist 
Gerrit-MessageType: merged

Change in simtrace2[master]: minor : fix typo in comment

2019-12-02 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/16417 )

Change subject: minor : fix typo in comment
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16417
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie310143fe713a51fa1adf8bf7599374282341f2e
Gerrit-Change-Number: 16417
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: tsaitgaist 
Gerrit-Comment-Date: Mon, 02 Dec 2019 18:43:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in simtrace2[master]: minor : fix typo in comment

2019-12-02 Thread laforge 
Hello tsaitgaist,

I'd like you to do a code review. Please visit

https://gerrit.osmocom.org/c/simtrace2/+/16417

to review the following change.


Change subject: minor : fix typo in comment
..

minor : fix typo in comment

Change-Id: Ie310143fe713a51fa1adf8bf7599374282341f2e
---
M firmware/libcommon/source/simtrace_iso7816.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/17/16417/1

diff --git a/firmware/libcommon/source/simtrace_iso7816.c 
b/firmware/libcommon/source/simtrace_iso7816.c
index 889ca2d..8ee3f8c 100644
--- a/firmware/libcommon/source/simtrace_iso7816.c
+++ b/firmware/libcommon/source/simtrace_iso7816.c
@@ -80,7 +80,7 @@
 }

 /*
- *  char_stat is zero if no error occured.
+ *  char_stat is zero if no error occurred.
  *  Otherwise it is filled with the content of the status register.
  */
 void mode_trace_usart1_irq(void)
@@ -110,7 +110,7 @@
rbuf_write(_rcv_buf, c);
} else {
TRACE_DEBUG("e %x st: %x\n", c, stat);
-   }   /* else: error occured */
+   }   /* else: error occurred */

char_stat = stat;
}

--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16417
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie310143fe713a51fa1adf8bf7599374282341f2e
Gerrit-Change-Number: 16417
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: tsaitgaist 
Gerrit-MessageType: newchange

Change in simtrace2[master]: minor: fix typo in comment

2018-09-07 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10822 )

Change subject: minor: fix typo in comment
..

minor: fix typo in comment

Change-Id: I3edb50abe93bc8574c9c1f25b34f75dab2e8f0ce
---
M firmware/apps/cardem/main.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/apps/cardem/main.c b/firmware/apps/cardem/main.c
index 0b5fbde..ef24c36 100644
--- a/firmware/apps/cardem/main.c
+++ b/firmware/apps/cardem/main.c
@@ -129,9 +129,8 @@
return;

ch = UART_GetChar();
-   /* We must echo the character to make python fdexpect happy, whcih we 
use in factory testing */
+   /* We must echo the character to make python fdexpect happy, which we 
use in factory testing */
fputc(ch, stdout);
-
board_exec_dbg_cmd(ch);
 }


--
To view, visit https://gerrit.osmocom.org/10822
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3edb50abe93bc8574c9c1f25b34f75dab2e8f0ce
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in simtrace2[master]: minor: fix typo in comment

2018-09-06 Thread Kévin Redon 
Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/10822


Change subject: minor: fix typo in comment
..

minor: fix typo in comment

Change-Id: I3edb50abe93bc8574c9c1f25b34f75dab2e8f0ce
---
M firmware/apps/cardem/main.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/22/10822/1

diff --git a/firmware/apps/cardem/main.c b/firmware/apps/cardem/main.c
index 0b5fbde..ef24c36 100644
--- a/firmware/apps/cardem/main.c
+++ b/firmware/apps/cardem/main.c
@@ -129,9 +129,8 @@
return;

ch = UART_GetChar();
-   /* We must echo the character to make python fdexpect happy, whcih we 
use in factory testing */
+   /* We must echo the character to make python fdexpect happy, which we 
use in factory testing */
fputc(ch, stdout);
-
board_exec_dbg_cmd(ch);
 }


--
To view, visit https://gerrit.osmocom.org/10822
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3edb50abe93bc8574c9c1f25b34f75dab2e8f0ce
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon