Change in simtrace2[master]: remsim: fix TPDU response size transmission
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/11362 )
Change subject: remsim: fix TPDU response size transmission
..
remsim: fix TPDU response size transmission
the TDPU response data size can be up to 256.
this length cannot be stored in a uint8_t, which would cause the
length to become 0, no data being send, and the reader reset the
card because of misbehaviour of the card (i.e. no/malformed
response leading to the timeout of the waiting time).
Change-Id: Iae7671085aaa3115a02d82530dd7a0e7e2d4155e
---
M host/simtrace2-remsim.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/host/simtrace2-remsim.c b/host/simtrace2-remsim.c
index d0bbb8c..73a7272 100644
--- a/host/simtrace2-remsim.c
+++ b/host/simtrace2-remsim.c
@@ -218,7 +218,7 @@
/*! \brief Request the SIMtrace2 to transmit a Procedure Byte, then Tx */
static int cardem_request_pb_and_tx(struct cardem_inst *ci, uint8_t pb,
- const uint8_t *data, uint8_t data_len_in)
+ const uint8_t *data, uint16_t data_len_in)
{
struct msgb *msg = st_msgb_alloc();
struct cardemu_usb_msg_tx_data *txd;
--
To view, visit https://gerrit.osmocom.org/11362
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae7671085aaa3115a02d82530dd7a0e7e2d4155e
Gerrit-Change-Number: 11362
Gerrit-PatchSet: 2
Gerrit-Owner: Kévin Redon
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Change in simtrace2[master]: remsim: fix TPDU response size transmission
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/11362
Change subject: remsim: fix TPDU response size transmission
..
remsim: fix TPDU response size transmission
the TDPU response data size can be up to 256.
this length cannot be stored in a uint8_t, which would cause the
length to become 0, no data being send, and the reader reset the
card because of misbehaviour of the card (i.e. no/malformed
response leading to the timeout of the waiting time).
Change-Id: Iae7671085aaa3115a02d82530dd7a0e7e2d4155e
---
M host/simtrace2-remsim.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/62/11362/1
diff --git a/host/simtrace2-remsim.c b/host/simtrace2-remsim.c
index d0bbb8c..73a7272 100644
--- a/host/simtrace2-remsim.c
+++ b/host/simtrace2-remsim.c
@@ -218,7 +218,7 @@
/*! \brief Request the SIMtrace2 to transmit a Procedure Byte, then Tx */
static int cardem_request_pb_and_tx(struct cardem_inst *ci, uint8_t pb,
- const uint8_t *data, uint8_t data_len_in)
+ const uint8_t *data, uint16_t data_len_in)
{
struct msgb *msg = st_msgb_alloc();
struct cardemu_usb_msg_tx_data *txd;
--
To view, visit https://gerrit.osmocom.org/11362
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae7671085aaa3115a02d82530dd7a0e7e2d4155e
Gerrit-Change-Number: 11362
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon
