Change in simtrace2[master]: rename PIN_PHONE_{CLK, IO} to PIN_USIM1_{CLK, IO}

2021-04-04 Thread laforge 
Hello Jenkins Builder, tsaitgaist,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/simtrace2/+/23614

to look at the new patch set (#2).

Change subject: rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO}
..

rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO}

While this differs from tha naming in the schematics ({CLK,IO}_PHONE),
this matches the naming scheme used for USIM2 and the naming on other
boards.

Change-Id: I486b14260faec897e8c8698c4b7987bf36492497
---
M firmware/libboard/simtrace/include/board.h
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/14/23614/2
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23614
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I486b14260faec897e8c8698c4b7987bf36492497
Gerrit-Change-Number: 23614
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tsaitgaist 
Gerrit-MessageType: newpatchset

Change in simtrace2[master]: rename PIN_PHONE_{CLK, IO} to PIN_USIM1_{CLK, IO}

2021-04-04 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/23614 )

Change subject: rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO}
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23614
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I486b14260faec897e8c8698c4b7987bf36492497
Gerrit-Change-Number: 23614
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: tsaitgaist 
Gerrit-Comment-Date: Sun, 04 Apr 2021 21:20:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in simtrace2[master]: rename PIN_PHONE_{CLK, IO} to PIN_USIM1_{CLK, IO}

2021-04-04 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/23614 )

Change subject: rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO}
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23614
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I486b14260faec897e8c8698c4b7987bf36492497
Gerrit-Change-Number: 23614
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: tsaitgaist 
Gerrit-Comment-Date: Sun, 04 Apr 2021 21:25:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in simtrace2[master]: rename PIN_PHONE_{CLK, IO} to PIN_USIM1_{CLK, IO}

2021-04-04 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/23614 )

Change subject: rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO}
..

rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO}

While this differs from tha naming in the schematics ({CLK,IO}_PHONE),
this matches the naming scheme used for USIM2 and the naming on other
boards.

Change-Id: I486b14260faec897e8c8698c4b7987bf36492497
---
M firmware/libboard/simtrace/include/board.h
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/firmware/libboard/simtrace/include/board.h 
b/firmware/libboard/simtrace/include/board.h
index 35c9426..ab1c019 100644
--- a/firmware/libboard/simtrace/include/board.h
+++ b/firmware/libboard/simtrace/include/board.h
@@ -78,11 +78,11 @@
 /* Phone USIM slot 1 RST pin (active low; RST_PHONE in schematic) */
 #define PIN_USIM1_nRST {PIO_PA24, PIOA, ID_PIOA, PIO_INPUT, 
PIO_IT_EDGE | PIO_DEGLITCH }
 /* Phone I/O data signal input/output (I/O_PHONE in schematic) */
-#define PIN_PHONE_IO   {PIO_PA22A_TXD1, PIOA, ID_PIOA, PIO_PERIPH_A, 
PIO_DEFAULT}
+#define PIN_USIM1_IO   {PIO_PA22A_TXD1, PIOA, ID_PIOA, PIO_PERIPH_A, 
PIO_DEFAULT}
 /* Phone CLK clock input (CLK_PHONE in schematic) */
-#define PIN_PHONE_CLK  {PIO_PA23A_SCK1, PIOA, ID_PIOA, PIO_PERIPH_A, 
PIO_DEFAULT}
+#define PIN_USIM1_CLK  {PIO_PA23A_SCK1, PIOA, ID_PIOA, PIO_PERIPH_A, 
PIO_DEFAULT}
 /* Pin used for phone USIM slot 1 communication */
-#define PINS_USIM1  PIN_PHONE_IO, PIN_PHONE_CLK, 
PIN_PHONE_CLK_INPUT, PIN_USIM1_VCC, PIN_PHONE_IO_INPUT, PIN_USIM1_nRST
+#define PINS_USIM1  PIN_USIM1_IO, PIN_USIM1_CLK, 
PIN_PHONE_CLK_INPUT, PIN_USIM1_VCC, PIN_PHONE_IO_INPUT, PIN_USIM1_nRST
 /* Phone I/O data signal input/output (unused USART RX input; connected to 
I/O_PHONE in schematic) */
 #define PIN_PHONE_IO_INPUT {PIO_PA21A_RXD1, PIOA, ID_PIOA, PIO_PERIPH_A, 
PIO_DEFAULT}
 /* Pin used as clock input (to measure the ETU duration; connected to 
CLK_PHONE in schematic) */

--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23614
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I486b14260faec897e8c8698c4b7987bf36492497
Gerrit-Change-Number: 23614
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: tsaitgaist 
Gerrit-MessageType: merged