[MERGED] libosmocore[master]: configure.ac: Enable -Wall by default

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: configure.ac: Enable -Wall by default
..


configure.ac: Enable -Wall by default

Change-Id: I70f917e05ad46049487710d1752aad2505c96696
---
M configure.ac
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index 1e258a4..64de4bf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -235,8 +235,8 @@
CPPFLAGS+=" -fsanitize=address -fsanitize=undefined"
 fi
 
-CFLAGS+=" -DBUILDING_LIBOSMOCORE"
-CPPFLAGS+=" -DBUILDING_LIBOSMOCORE"
+CFLAGS+=" -DBUILDING_LIBOSMOCORE -Wall"
+CPPFLAGS+=" -DBUILDING_LIBOSMOCORE -Wall"
 
 AC_ARG_ENABLE(simd,
[AS_HELP_STRING(

-- 
To view, visit https://gerrit.osmocom.org/2958
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I70f917e05ad46049487710d1752aad2505c96696
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

libosmocore[master]: configure.ac: Enable -Wall by default

[Pau Espin Pedrol]

Patch Set 4:

It's not th efirst because I was first fixing the ones I got without -Wall, 
then enabled -Wall and continued fixing. Should not be any issue, the important 
one is -Werror which needs to be the last one.

-- 
To view, visit https://gerrit.osmocom.org/2958
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70f917e05ad46049487710d1752aad2505c96696
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

libosmocore[master]: configure.ac: Enable -Wall by default

[Max]

Patch Set 4:

Shouldn't this be the 1st patch in the series? We enable all the warnings, fix 
them and than turn any future warning into error, no?

-- 
To view, visit https://gerrit.osmocom.org/2958
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70f917e05ad46049487710d1752aad2505c96696
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-HasComments: No

[PATCH] libosmocore[master]: configure.ac: Enable -Wall by default

[Pau Espin Pedrol]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/2958

to look at the new patch set (#3).

configure.ac: Enable -Wall by default

Change-Id: I70f917e05ad46049487710d1752aad2505c96696
---
M configure.ac
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/2958/3

diff --git a/configure.ac b/configure.ac
index 340a896..29b7b52 100644
--- a/configure.ac
+++ b/configure.ac
@@ -235,8 +235,8 @@
CPPFLAGS+=" -fsanitize=address -fsanitize=undefined"
 fi
 
-CFLAGS+=" -DBUILDING_LIBOSMOCORE"
-CPPFLAGS+=" -DBUILDING_LIBOSMOCORE"
+CFLAGS+=" -DBUILDING_LIBOSMOCORE -Wall"
+CPPFLAGS+=" -DBUILDING_LIBOSMOCORE -Wall"
 
 AC_ARG_ENABLE(simd,
[AS_HELP_STRING(

-- 
To view, visit https://gerrit.osmocom.org/2958
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70f917e05ad46049487710d1752aad2505c96696
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder

[PATCH] libosmocore[master]: configure.ac: Enable -Wall by default

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/2958

configure.ac: Enable -Wall by default

Change-Id: I70f917e05ad46049487710d1752aad2505c96696
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/2958/1

diff --git a/configure.ac b/configure.ac
index 531544a..59872f6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -236,7 +236,7 @@
 fi
 
 CFLAGS+=" -DBUILDING_LIBOSMOCORE -Werror"
-CPPFLAGS+=" -DBUILDING_LIBOSMOCORE -Werror"
+CPPFLAGS+=" -DBUILDING_LIBOSMOCORE -Werror -Wall"
 
 AC_ARG_ENABLE(simd,
[AS_HELP_STRING(

-- 
To view, visit https://gerrit.osmocom.org/2958
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I70f917e05ad46049487710d1752aad2505c96696
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol