libosmocore[master]: gsm/gsm48.c: drop useless assignment

2017-06-12 Thread Max

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/2881
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96c1ba70e332199a4ca95e827a7562f953975af4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-HasComments: No


libosmocore[master]: gsm/gsm48.c: drop useless assignment

2017-06-13 Thread Harald Welte

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/2881
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96c1ba70e332199a4ca95e827a7562f953975af4
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-HasComments: No


[PATCH] libosmocore[master]: gsm/gsm48.c: drop useless assignment

2017-06-11 Thread Vadim Yanitskiy

Review at  https://gerrit.osmocom.org/2881

gsm/gsm48.c: drop useless assignment

Change-Id: I96c1ba70e332199a4ca95e827a7562f953975af4
---
M src/gsm/gsm48.c
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/2881/1

diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 543c9c0..f7ad67c 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -410,7 +410,6 @@
bcd[1] = val % 10;
val = val / 10;
bcd[0] = val % 10;
-   val = val / 10;
 }
 
 /*! \brief Checks is particular message is cipherable in A/Gb mode according to

-- 
To view, visit https://gerrit.osmocom.org/2881
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96c1ba70e332199a4ca95e827a7562f953975af4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 


[MERGED] libosmocore[master]: gsm/gsm48.c: drop useless assignment

2017-06-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged.

Change subject: gsm/gsm48.c: drop useless assignment
..


gsm/gsm48.c: drop useless assignment

Change-Id: I96c1ba70e332199a4ca95e827a7562f953975af4
---
M src/gsm/gsm48.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 1b25538..405c904 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -421,7 +421,6 @@
bcd[1] = val % 10;
val = val / 10;
bcd[0] = val % 10;
-   val = val / 10;
 }
 
 /*! \brief Checks is particular message is cipherable in A/Gb mode according to

-- 
To view, visit https://gerrit.osmocom.org/2881
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96c1ba70e332199a4ca95e827a7562f953975af4
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max