libosmocore[master]: lapd_test.c: Convert compilation warning to level message

[Pau Espin Pedrol]

Patch Set 2:

As requested, I created an issue to track this: https://osmocom.org/issues/2336

-- 
To view, visit https://gerrit.osmocom.org/2953
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24c11226cd5bb5b6032f4ece7d1a0695dc82f0dd
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

libosmocore[master]: lapd_test.c: Convert compilation warning to level message

[Neels Hofmeyr]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/2953
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24c11226cd5bb5b6032f4ece7d1a0695dc82f0dd
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

libosmocore[master]: lapd_test.c: Convert compilation warning to level message

[Max]

Patch Set 1: Code-Review+1

Would be nice to also make a ticket and add reference to this ticket into 
message.

-- 
To view, visit https://gerrit.osmocom.org/2953
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24c11226cd5bb5b6032f4ece7d1a0695dc82f0dd
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-HasComments: No

[PATCH] libosmocore[master]: lapd_test.c: Convert compilation warning to level message

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/2953

lapd_test.c: Convert compilation warning to level message

This way we clean the build of warnings completely and we can enable
-Werror but we still see this FIXME message while compiling.

Change-Id: I24c11226cd5bb5b6032f4ece7d1a0695dc82f0dd
---
M tests/lapd/lapd_test.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/53/2953/1

diff --git a/tests/lapd/lapd_test.c b/tests/lapd/lapd_test.c
index e322314..0dccaa4 100644
--- a/tests/lapd/lapd_test.c
+++ b/tests/lapd/lapd_test.c
@@ -358,7 +358,7 @@
 
/* Verify the added RSL_IE_L3_INFO but we have a bug here */
OSMO_ASSERT(msg->data[6] == RSL_IE_L3_INFO);
-   #warning "RSL_IE_L3_INFO 16 bit length is wrong"
+   #pragma message ("RSL_IE_L3_INFO 16 bit length is wrong")
/* This should be okay but it is actually 0x0, 0x9c on ia-32 */
/* OSMO_ASSERT(msg->data[7] == 0x0 && msg->data[8] == 0x0); */
} else if (state->ms_read == 1) {

-- 
To view, visit https://gerrit.osmocom.org/2953
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I24c11226cd5bb5b6032f4ece7d1a0695dc82f0dd
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol