libosmocore[master]: logging vty: add 'logging set-log-mask' command to log node
Patch Set 1: I'm not sure we want this... The logmask is from a time when we didn't have the vty. Its syntax is awkward. I'd rather deprecate it all over the vty than introduce new users. -- To view, visit https://gerrit.osmocom.org/5254 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedd67750539b676271de0e0e9316d4e6f794406a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
libosmocore[master]: logging vty: add 'logging set-log-mask' command to log node
Patch Set 1: ah ok. I saw it as a convenient shorthand to set a couple of categories in a single line... -- To view, visit https://gerrit.osmocom.org/5254 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedd67750539b676271de0e0e9316d4e6f794406a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
[PATCH] libosmocore[master]: logging vty: add 'logging set-log-mask' command to log node
Review at https://gerrit.osmocom.org/5254 logging vty: add 'logging set-log-mask' command to log node So far the set-log-mask is only published on the VIEW and ENABLE nodes. It appears to have been forgotten from the actual log target node where it could be quite useful in config files. The command is like logging set-log-mask mm,1:cc,3:rsl,3 There also is a deprecated alias 'set log mask' without dashes, do not add that one, since it makes no sense to add a deprecated alias to a node where it was never present. Change-Id: Iedd67750539b676271de0e0e9316d4e6f794406a --- M src/vty/logging_vty.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/5254/1 diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index c39017b..fe5625c 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -799,6 +799,7 @@ install_element(CFG_LOG_NODE, &logging_prnt_timestamp_cmd); install_element(CFG_LOG_NODE, &logging_prnt_ext_timestamp_cmd); install_element(CFG_LOG_NODE, &logging_prnt_cat_cmd); + install_element(CFG_LOG_NODE, &logging_set_category_mask_cmd); install_element(CFG_LOG_NODE, &logging_level_cmd); install_element(CONFIG_NODE, &cfg_log_stderr_cmd); -- To view, visit https://gerrit.osmocom.org/5254 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iedd67750539b676271de0e0e9316d4e6f794406a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr
[ABANDON] libosmocore[master]: logging vty: add 'logging set-log-mask' command to log node
Neels Hofmeyr has abandoned this change. Change subject: logging vty: add 'logging set-log-mask' command to log node .. Abandoned -- To view, visit https://gerrit.osmocom.org/5254 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iedd67750539b676271de0e0e9316d4e6f794406a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr