meta-telephony[201705]: osmo-hlr: Introduce recipe

[Pau Espin Pedrol]

Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.osmocom.org/4097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[MERGED] meta-telephony[201705]: osmo-hlr: Introduce recipe

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: osmo-hlr: Introduce recipe
..


osmo-hlr: Introduce recipe

Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
---
A recipes-osmocom/osmo-hlr/osmo-hlr.inc
A recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
2 files changed, 33 insertions(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr.inc 
b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
new file mode 100644
index 000..8afe774
--- /dev/null
+++ b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
@@ -0,0 +1,26 @@
+DESCRIPTION = "Osmocom HLR implementation"
+HOMEPAGE = "https://osmocom.org/projects/osmo-hlr;
+LICENSE = "AGPLv3"
+LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"
+
+DEPENDS = "libtalloc libosmocore libosmo-abis sqlite3 sqlite3-native"
+
+INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+
+inherit autotools pkgconfig systemd
+
+do_compile_append() {
+   sqlite3 ${WORKDIR}/hlr.db < ${S}/sql/hlr.sql
+}
+
+do_install_append() {
+   install -d ${D}${systemd_system_unitdir}/
+   install -d ${D}${sysconfdir}/osmocom/
+   install -d ${D}${localstatedir}/lib/osmocom/
+
+   install -m 0644 ${S}/doc/examples/osmo-hlr.cfg 
${D}${sysconfdir}/osmocom/
+   install -m 0644 ${S}/contrib/systemd/osmo-hlr.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${WORKDIR}/hlr.db 
${D}${localstatedir}/lib/osmocom/hlr.db
+}
+
+SYSTEMD_SERVICE_${PN} = "${PN}.service"
diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb 
b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
new file mode 100644
index 000..8a08d94
--- /dev/null
+++ b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
@@ -0,0 +1,7 @@
+require ${PN}.inc
+
+S = "${WORKDIR}/git"
+SRCREV = "05c8b465ab2fe13edb67c95210a9b475f91ebeb3"
+SRC_URI = "git://git.osmocom.org/osmo-hlr.git;protocol=git"
+PV = "0.0.1+gitr${SRCPV}"
+PR = "${INC_PR}.0"

-- 
To view, visit https://gerrit.osmocom.org/4097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

meta-telephony[201705]: osmo-hlr: Introduce recipe

[Harald Welte]

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[PATCH] meta-telephony[201705]: osmo-hlr: Introduce recipe

[Pau Espin Pedrol]

Hello Neels Hofmeyr,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/4097

to look at the new patch set (#2).

osmo-hlr: Introduce recipe

Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
---
A recipes-osmocom/osmo-hlr/osmo-hlr.inc
A recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
2 files changed, 33 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/97/4097/2

diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr.inc 
b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
new file mode 100644
index 000..8afe774
--- /dev/null
+++ b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
@@ -0,0 +1,26 @@
+DESCRIPTION = "Osmocom HLR implementation"
+HOMEPAGE = "https://osmocom.org/projects/osmo-hlr;
+LICENSE = "AGPLv3"
+LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"
+
+DEPENDS = "libtalloc libosmocore libosmo-abis sqlite3 sqlite3-native"
+
+INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+
+inherit autotools pkgconfig systemd
+
+do_compile_append() {
+   sqlite3 ${WORKDIR}/hlr.db < ${S}/sql/hlr.sql
+}
+
+do_install_append() {
+   install -d ${D}${systemd_system_unitdir}/
+   install -d ${D}${sysconfdir}/osmocom/
+   install -d ${D}${localstatedir}/lib/osmocom/
+
+   install -m 0644 ${S}/doc/examples/osmo-hlr.cfg 
${D}${sysconfdir}/osmocom/
+   install -m 0644 ${S}/contrib/systemd/osmo-hlr.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${WORKDIR}/hlr.db 
${D}${localstatedir}/lib/osmocom/hlr.db
+}
+
+SYSTEMD_SERVICE_${PN} = "${PN}.service"
diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb 
b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
new file mode 100644
index 000..8a08d94
--- /dev/null
+++ b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
@@ -0,0 +1,7 @@
+require ${PN}.inc
+
+S = "${WORKDIR}/git"
+SRCREV = "05c8b465ab2fe13edb67c95210a9b475f91ebeb3"
+SRC_URI = "git://git.osmocom.org/osmo-hlr.git;protocol=git"
+PV = "0.0.1+gitr${SRCPV}"
+PR = "${INC_PR}.0"

-- 
To view, visit https://gerrit.osmocom.org/4097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

meta-telephony[201705]: osmo-hlr: Introduce recipe

[Pau Espin Pedrol]

Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4097/1/recipes-osmocom/osmo-hlr/osmo-hlr.inc
File recipes-osmocom/osmo-hlr/osmo-hlr.inc:

Line 12: RDEPENDS_${PN} = "libdbd-sqlite3"
> Ok good to know, then debian/control is wrong, I'll send a patch to fix it.
https://gerrit.osmocom.org/#/c/4107/


-- 
To view, visit https://gerrit.osmocom.org/4097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: Yes

meta-telephony[201705]: osmo-hlr: Introduce recipe

[Pau Espin Pedrol]

Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4097/1/recipes-osmocom/osmo-hlr/osmo-hlr.inc
File recipes-osmocom/osmo-hlr/osmo-hlr.inc:

Line 12: RDEPENDS_${PN} = "libdbd-sqlite3"
> we should not require libdbd-sqlite3, not using libdbi in osmo-hlr. Some pl
Ok good to know, then debian/control is wrong, I'll send a patch to fix it.


-- 
To view, visit https://gerrit.osmocom.org/4097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: Yes

meta-telephony[201705]: osmo-hlr: Introduce recipe

[Neels Hofmeyr]

Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/4097/1/recipes-osmocom/osmo-hlr/osmo-hlr.inc
File recipes-osmocom/osmo-hlr/osmo-hlr.inc:

Line 2: HOMEPAGE = "https://osmocom.org/;
link to OsmoHLR project page?


Line 12: RDEPENDS_${PN} = "libdbd-sqlite3"
we should not require libdbd-sqlite3, not using libdbi in osmo-hlr. Some plain 
libsqlite3 or something should suffice


-- 
To view, visit https://gerrit.osmocom.org/4097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: Yes

[PATCH] meta-telephony[201705]: osmo-hlr: Introduce recipe

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/4097

osmo-hlr: Introduce recipe

Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
---
A recipes-osmocom/osmo-hlr/osmo-hlr.inc
A recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
2 files changed, 35 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/97/4097/1

diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr.inc 
b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
new file mode 100644
index 000..c70b83d
--- /dev/null
+++ b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
@@ -0,0 +1,28 @@
+DESCRITOPN = "Osmocom HLR implementation"
+HOMEPAGE = "https://osmocom.org/;
+LICENSE = "AGPLv3"
+LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"
+
+DEPENDS = "libdbi libtalloc libosmocore libosmo-abis sqlite3 sqlite3-native"
+
+INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+
+inherit autotools pkgconfig systemd
+
+RDEPENDS_${PN} = "libdbd-sqlite3"
+
+do_compile_append() {
+   sqlite3 ${WORKDIR}/hlr.db < ${S}/sql/hlr.sql
+}
+
+do_install_append() {
+   install -d ${D}${systemd_system_unitdir}/
+   install -d ${D}${sysconfdir}/osmocom/
+   install -d ${D}${localstatedir}/lib/osmocom/
+
+   install -m 0644 ${S}/doc/examples/osmo-hlr.cfg 
${D}${sysconfdir}/osmocom/
+   install -m 0644 ${S}/contrib/systemd/osmo-hlr.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${WORKDIR}/hlr.db 
${D}${localstatedir}/lib/osmocom/hlr.db
+}
+
+SYSTEMD_SERVICE_${PN} = "${PN}.service"
diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb 
b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
new file mode 100644
index 000..8a08d94
--- /dev/null
+++ b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
@@ -0,0 +1,7 @@
+require ${PN}.inc
+
+S = "${WORKDIR}/git"
+SRCREV = "05c8b465ab2fe13edb67c95210a9b475f91ebeb3"
+SRC_URI = "git://git.osmocom.org/osmo-hlr.git;protocol=git"
+PV = "0.0.1+gitr${SRCPV}"
+PR = "${INC_PR}.0"

-- 
To view, visit https://gerrit.osmocom.org/4097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol