meta-telephony[201705]: osmo-msc: Avoid installed duplicated binaries in osmo-bsc
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/4101/1//COMMIT_MSG Commit Message: Line 7: osmo-msc: Avoid installed duplicated binaries in osmo-bsc please name the binaries that are removed -- To view, visit https://gerrit.osmocom.org/4101 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: Yes
meta-telephony[201705]: osmo-msc: Avoid installed duplicated binaries in osmo-bsc
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/4101/1/recipes-osmocom/osmo-msc/osmo-msc.inc File recipes-osmocom/osmo-msc/osmo-msc.inc: Line 2: HOMEPAGE = "https://osmocom.org/"; link to msc project page? -- To view, visit https://gerrit.osmocom.org/4101 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: Yes
meta-telephony[201705]: osmo-msc: Avoid installed duplicated binaries in osmo-bsc
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4101 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e Gerrit-PatchSet: 2 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
meta-telephony[201705]: osmo-msc: Avoid installed duplicated binaries in osmo-bsc
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/4101 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e Gerrit-PatchSet: 2 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-HasComments: No
[PATCH] meta-telephony[201705]: osmo-msc: Avoid installed duplicated binaries in osmo-bsc
Review at https://gerrit.osmocom.org/4101 osmo-msc: Avoid installed duplicated binaries in osmo-bsc Those two binaries are currently being installed by osmo-bsc too. Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e --- M recipes-osmocom/osmo-msc/osmo-msc.inc 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/01/4101/1 diff --git a/recipes-osmocom/osmo-msc/osmo-msc.inc b/recipes-osmocom/osmo-msc/osmo-msc.inc index 594d754..4c3125d 100644 --- a/recipes-osmocom/osmo-msc/osmo-msc.inc +++ b/recipes-osmocom/osmo-msc/osmo-msc.inc @@ -5,7 +5,7 @@ DEPENDS = "libdbi libasn1c osmo-iuh libosmocore libosmo-abis libosmo-sccp libosmo-netif libsmpp34 osmo-mgw" -INC_PR="r0.${META_TELEPHONY_OSMO_INC}" +INC_PR="r1.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd @@ -19,6 +19,10 @@ install -m 0644 ${S}/doc/examples/osmo-msc/osmo-msc.cfg ${D}${sysconfdir}/osmocom/ install -m 0644 ${S}/contrib/systemd/osmo-msc.service ${D}${systemd_system_unitdir}/ + + # osmo-bsc already provides these, see issue Osmocom #2522: + rm -f ${D}${bindir}/.debug/*meas* + rm -f ${D}${bindir}/*meas* } SYSTEMD_SERVICE_${PN} = "${PN}.service" -- To view, visit https://gerrit.osmocom.org/4101 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: Pau Espin Pedrol
[PATCH] meta-telephony[201705]: osmo-msc: Avoid installed duplicated binaries in osmo-bsc
Hello Neels Hofmeyr, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4101 to look at the new patch set (#2). osmo-msc: Avoid installed duplicated binaries in osmo-bsc Those two binaries are currently being installed by osmo-bsc too: - /usr/bin/osmo-meas-udp2db - /usr/bin/meas_json Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e --- M recipes-osmocom/osmo-msc/osmo-msc.inc 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/01/4101/2 diff --git a/recipes-osmocom/osmo-msc/osmo-msc.inc b/recipes-osmocom/osmo-msc/osmo-msc.inc index b4decf9..829f947 100644 --- a/recipes-osmocom/osmo-msc/osmo-msc.inc +++ b/recipes-osmocom/osmo-msc/osmo-msc.inc @@ -5,7 +5,7 @@ DEPENDS = "libdbi libasn1c osmo-iuh libosmocore libosmo-abis libosmo-sccp libosmo-netif libsmpp34 osmo-mgw" -INC_PR="r0.${META_TELEPHONY_OSMO_INC}" +INC_PR="r1.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd @@ -19,6 +19,10 @@ install -m 0644 ${S}/doc/examples/osmo-msc/osmo-msc.cfg ${D}${sysconfdir}/osmocom/ install -m 0644 ${S}/contrib/systemd/osmo-msc.service ${D}${systemd_system_unitdir}/ + + # osmo-bsc already provides these, see issue Osmocom #2522: + rm -f ${D}${bindir}/.debug/*meas* + rm -f ${D}${bindir}/*meas* } SYSTEMD_SERVICE_${PN} = "${PN}.service" -- To view, visit https://gerrit.osmocom.org/4101 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e Gerrit-PatchSet: 2 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Neels Hofmeyr
[MERGED] meta-telephony[201705]: osmo-msc: Avoid installed duplicated binaries in osmo-bsc
Pau Espin Pedrol has submitted this change and it was merged. Change subject: osmo-msc: Avoid installed duplicated binaries in osmo-bsc .. osmo-msc: Avoid installed duplicated binaries in osmo-bsc Those two binaries are currently being installed by osmo-bsc too: - /usr/bin/osmo-meas-udp2db - /usr/bin/meas_json Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e --- M recipes-osmocom/osmo-msc/osmo-msc.inc 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Pau Espin Pedrol: Verified Harald Welte: Looks good to me, approved diff --git a/recipes-osmocom/osmo-msc/osmo-msc.inc b/recipes-osmocom/osmo-msc/osmo-msc.inc index b4decf9..829f947 100644 --- a/recipes-osmocom/osmo-msc/osmo-msc.inc +++ b/recipes-osmocom/osmo-msc/osmo-msc.inc @@ -5,7 +5,7 @@ DEPENDS = "libdbi libasn1c osmo-iuh libosmocore libosmo-abis libosmo-sccp libosmo-netif libsmpp34 osmo-mgw" -INC_PR="r0.${META_TELEPHONY_OSMO_INC}" +INC_PR="r1.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd @@ -19,6 +19,10 @@ install -m 0644 ${S}/doc/examples/osmo-msc/osmo-msc.cfg ${D}${sysconfdir}/osmocom/ install -m 0644 ${S}/contrib/systemd/osmo-msc.service ${D}${systemd_system_unitdir}/ + + # osmo-bsc already provides these, see issue Osmocom #2522: + rm -f ${D}${bindir}/.debug/*meas* + rm -f ${D}${bindir}/*meas* } SYSTEMD_SERVICE_${PN} = "${PN}.service" -- To view, visit https://gerrit.osmocom.org/4101 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e Gerrit-PatchSet: 2 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol