[MERGED] osmo-bsc[master]: fix build: bssap test broke by undefined references

2017-11-07 Thread Neels Hofmeyr 
Neels Hofmeyr has submitted this change and it was merged.

Change subject: fix build: bssap test broke by undefined references
..


fix build: bssap test broke by undefined references

After the bssap test in Ie934c5d229140a89763bf2efff86d6a3766cd351, the
subsequent commit Ia2882b7ca31a3219c676986e85045fa08a425d7a was not tested
against the latest head, and its breaking bssap_test was not caught.

Fix current master of osmo-bsc's 'make check' target: add osmo_bsc_mgcp.c and
libosmo-mgcp-client dependencies to bssap_test linkage.

Change-Id: I28719d267452f66d65581c43433e24a9f46cf7dc
---
M tests/bssap/Makefile.am
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/bssap/Makefile.am b/tests/bssap/Makefile.am
index 80d655f..4bbe9ea 100644
--- a/tests/bssap/Makefile.am
+++ b/tests/bssap/Makefile.am
@@ -11,6 +11,7 @@
$(LIBOSMOABIS_CFLAGS) \
$(LIBOSMOSIGTRAN_CFLAGS) \
$(COVERAGE_CFLAGS) \
+   $(LIBOSMOMGCPCLIENT_CFLAGS) \
$(NULL)
 
 EXTRA_DIST = \
@@ -28,6 +29,7 @@
$(top_srcdir)/src/osmo-bsc/osmo_bsc_sigtran.c \
$(top_srcdir)/src/osmo-bsc/osmo_bsc_filter.c \
$(top_srcdir)/src/osmo-bsc/osmo_bsc_grace.c \
+   $(top_srcdir)/src/osmo-bsc/osmo_bsc_mgcp.c \
$(NULL)
 
 bssap_test_LDADD = \
@@ -39,6 +41,7 @@
$(LIBOSMOGSM_LIBS) \
$(LIBOSMOABIS_LIBS) \
$(LIBOSMOSIGTRAN_LIBS) \
+   $(LIBOSMOMGCPCLIENT_LIBS) \
$(NULL)
 
 bssap_test_LDFLAGS = \

-- 
To view, visit https://gerrit.osmocom.org/4721
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28719d267452f66d65581c43433e24a9f46cf7dc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr

osmo-bsc[master]: fix build: bssap test broke by undefined references

2017-11-07 Thread Neels Hofmeyr 

Patch Set 1: Code-Review+2

again fast tracking to prevent build fallout ... I hope I'm doing the right 
thing here, let me know if we need to revert some of these fast track merges.

-- 
To view, visit https://gerrit.osmocom.org/4721
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28719d267452f66d65581c43433e24a9f46cf7dc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[PATCH] osmo-bsc[master]: fix build: bssap test broke by undefined references

2017-11-07 Thread Neels Hofmeyr 

Review at  https://gerrit.osmocom.org/4721

fix build: bssap test broke by undefined references

After the bssap test in Ie934c5d229140a89763bf2efff86d6a3766cd351, the
subsequent commit Ia2882b7ca31a3219c676986e85045fa08a425d7a was not tested
against the latest head, and its breaking bssap_test was not caught.

Fix current master of osmo-bsc's 'make check' target: add osmo_bsc_mgcp.c and
libosmo-mgcp-client dependencies to bssap_test linkage.

Change-Id: I28719d267452f66d65581c43433e24a9f46cf7dc
---
M tests/bssap/Makefile.am
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/21/4721/1

diff --git a/tests/bssap/Makefile.am b/tests/bssap/Makefile.am
index 80d655f..4bbe9ea 100644
--- a/tests/bssap/Makefile.am
+++ b/tests/bssap/Makefile.am
@@ -11,6 +11,7 @@
$(LIBOSMOABIS_CFLAGS) \
$(LIBOSMOSIGTRAN_CFLAGS) \
$(COVERAGE_CFLAGS) \
+   $(LIBOSMOMGCPCLIENT_CFLAGS) \
$(NULL)
 
 EXTRA_DIST = \
@@ -28,6 +29,7 @@
$(top_srcdir)/src/osmo-bsc/osmo_bsc_sigtran.c \
$(top_srcdir)/src/osmo-bsc/osmo_bsc_filter.c \
$(top_srcdir)/src/osmo-bsc/osmo_bsc_grace.c \
+   $(top_srcdir)/src/osmo-bsc/osmo_bsc_mgcp.c \
$(NULL)
 
 bssap_test_LDADD = \
@@ -39,6 +41,7 @@
$(LIBOSMOGSM_LIBS) \
$(LIBOSMOABIS_LIBS) \
$(LIBOSMOSIGTRAN_LIBS) \
+   $(LIBOSMOMGCPCLIENT_LIBS) \
$(NULL)
 
 bssap_test_LDFLAGS = \

-- 
To view, visit https://gerrit.osmocom.org/4721
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28719d267452f66d65581c43433e24a9f46cf7dc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr