osmo-bsc[master]: fix handover_test link error

2018-02-20 Thread Neels Hofmeyr

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6606
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7e1d4815d72b8e0bbc6ccd68078a78de19d73b0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No


[PATCH] osmo-bsc[master]: fix handover_test link error

2018-02-20 Thread Stefan Sperling

Review at  https://gerrit.osmocom.org/6606

fix handover_test link error

Fix undefined references during link stage when building handover_test.
The archive libbsc.a needs to be listed before the various .so files.

Change-Id: Ie7e1d4815d72b8e0bbc6ccd68078a78de19d73b0
---
M tests/handover/Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/06/6606/1

diff --git a/tests/handover/Makefile.am b/tests/handover/Makefile.am
index 4dd5223..5cdc0b0 100644
--- a/tests/handover/Makefile.am
+++ b/tests/handover/Makefile.am
@@ -28,8 +28,8 @@
$(NULL)
 
 handover_test_LDADD = \
+   $(top_builddir)/src/libbsc/libbsc.a \
$(LIBOSMOCORE_LIBS) \
$(LIBOSMOGSM_LIBS) \
$(LIBOSMOABIS_LIBS) \
-   $(top_builddir)/src/libbsc/libbsc.a \
$(NULL)

-- 
To view, visit https://gerrit.osmocom.org/6606
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7e1d4815d72b8e0bbc6ccd68078a78de19d73b0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 


[MERGED] osmo-bsc[master]: fix handover_test link error

2018-02-20 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged.

Change subject: fix handover_test link error
..


fix handover_test link error

Fix undefined references during link stage when building handover_test.
The archive libbsc.a needs to be listed before the various .so files.

Change-Id: Ie7e1d4815d72b8e0bbc6ccd68078a78de19d73b0
---
M tests/handover/Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/handover/Makefile.am b/tests/handover/Makefile.am
index 4dd5223..5cdc0b0 100644
--- a/tests/handover/Makefile.am
+++ b/tests/handover/Makefile.am
@@ -28,8 +28,8 @@
$(NULL)
 
 handover_test_LDADD = \
+   $(top_builddir)/src/libbsc/libbsc.a \
$(LIBOSMOCORE_LIBS) \
$(LIBOSMOGSM_LIBS) \
$(LIBOSMOABIS_LIBS) \
-   $(top_builddir)/src/libbsc/libbsc.a \
$(NULL)

-- 
To view, visit https://gerrit.osmocom.org/6606
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7e1d4815d72b8e0bbc6ccd68078a78de19d73b0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr