[ABANDON] osmo-bts[master]: Name systemd service after the software
Pau Espin Pedrol has abandoned this change. Change subject: Name systemd service after the software .. Abandoned -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol
osmo-bts[master]: Name systemd service after the software
Patch Set 2: I think it was superseded by other merged patches. Pau? -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 2: What about these service file renames? -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 2: Maybe we could temporary copy service file instead of renaming and once meta-sysmocom-bsp adjustements are complete we can remove the old copy? -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 2: when Daniel is back, please see if he can help you out. -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 2: This needs to be coordinated with commits to OE layers to avoid breaking OE builds. I have patches available for OE repo pushed in a branch which should adapt the recipes to use new names. However, I don't have a setup available to test them. -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 2: could you summarize the current status? Why are we not merging yet? -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 2: Sorry I actually forgot to add the branch name in my previous e-mail: http://git.sysmocom.de/poky/meta-sysmocom-bsp/log/?h=sysmo2osmo -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 2: Fixes needed for meta-sysmocom-bsp are available in this branch (untested as I don't have the env setup here). Anyway, it seems osmo-bts_git.bb and osmo-pcu_git.bb recipes seem to pull from a specific git revision,so I guess the build should not break until those revisions are updated manually. I could not find anything to be changed in meta-telephony. If some other repo need to be upgraded please inform me. -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 2: Code-Review+2 I'm giving +2, but emphasizing Harald's remark: when submitting, stay alert for packaging failures from jenkins. (probably the sysmocom internal jenkins as well as the public jenkins.osmocom.org). Anyway, I think the only way to resolve this is to submit and clean up later in case of fallout. -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
[PATCH] osmo-bts[master]: Name systemd service after the software
Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2225
to look at the new patch set (#2).
Name systemd service after the software
Binary name was changed from sysmobts to osmo-bts but the service file
remained with the old name, which is confusing for newcomers.
Added an alias to the service file for users used to the old naming.
Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf
---
M Makefile.am
R contrib/osmo-bts-sysmo.service
M src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c
M src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c
4 files changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/2225/2
diff --git a/Makefile.am b/Makefile.am
index 9a5e26f..5598c4a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -5,7 +5,7 @@
# package the contrib and doc
EXTRA_DIST = \
- contrib/dump_docs.py contrib/screenrc-l1fwd contrib/sysmobts.service \
+ contrib/dump_docs.py contrib/screenrc-l1fwd
contrib/osmo-bts-sysmo.service \
contrib/l1fwd.init contrib/screenrc-sysmobts contrib/respawn.sh \
contrib/sysmobts.init contrib/sysmobts-calib/Makefile \
contrib/sysmobts-calib/sysmobts-calib.c \
diff --git a/contrib/sysmobts.service b/contrib/osmo-bts-sysmo.service
similarity index 96%
rename from contrib/sysmobts.service
rename to contrib/osmo-bts-sysmo.service
index e07a3db..bbb2bef 100644
--- a/contrib/sysmobts.service
+++ b/contrib/osmo-bts-sysmo.service
@@ -17,3 +17,4 @@
[Install]
WantedBy=multi-user.target
+Alias=sysmobts.service
diff --git a/src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c
b/src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c
index f01fd14..bdb8000 100644
--- a/src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c
+++ b/src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c
@@ -116,7 +116,7 @@
* and used SIGCHLD/waitpid to pick up the dead processes
* without invoking shell.
*/
- system("/bin/systemctl start sysmobts.service");
+ system("/bin/systemctl start osmo-bts-sysmo.service");
}
}
@@ -157,7 +157,7 @@
* and used SIGCHLD/waitpid to pick up the dead processes
* without invoking shell.
*/
- system("/bin/systemctl stop sysmobts.service");
+ system("/bin/systemctl stop osmo-bts-sysmo.service");
}
}
diff --git a/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c
b/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c
index 3020d90..b49f282 100644
--- a/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c
+++ b/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c
@@ -284,7 +284,7 @@
DEFUN(cfg_action_bts_srv_on, cfg_action_bts_srv_on_cmd,
"bts-service-on",
- "Start the systemd sysmobts.service\n")
+ "Start the systemd osmo-bts-sysmo.service\n")
{
int *action = vty->index;
*action |= TEMP_ACT_NORM_BTS_SRV_ON;
@@ -293,7 +293,7 @@
DEFUN(cfg_no_action_bts_srv_on, cfg_no_action_bts_srv_on_cmd,
"no bts-service-on",
- NO_STR "Start the systemd sysmobts.service\n")
+ NO_STR "Start the systemd osmo-bts-sysmo.service\n")
{
int *action = vty->index;
*action &= ~TEMP_ACT_NORM_BTS_SRV_ON;
@@ -338,7 +338,7 @@
DEFUN(cfg_action_bts_srv_off, cfg_action_bts_srv_off_cmd,
"bts-service-off",
- "Stop the systemd sysmobts.service\n")
+ "Stop the systemd osmo-bts-sysmo.service\n")
{
int *action = vty->index;
*action |= TEMP_ACT_BTS_SRV_OFF;
@@ -347,7 +347,7 @@
DEFUN(cfg_no_action_bts_srv_off, cfg_no_action_bts_srv_off_cmd,
"no bts-service-off",
- NO_STR "Stop the systemd sysmobts.service\n")
+ NO_STR "Stop the systemd osmo-bts-sysmo.service\n")
{
int *action = vty->index;
*action &= ~TEMP_ACT_BTS_SRV_OFF;
--
To view, visit https://gerrit.osmocom.org/2225
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
osmo-bts[master]: Name systemd service after the software
Patch Set 1: I wonder if it's worth it to merge common parts with debian/osmo-bts-trx.service? -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 1: Code-Review-1 The binary is called 'osmo-bts-sysmo', so let's have the service named 'osmo-bts-sysmo.service', right?? -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 1: Code-Review+1 sames as for the other change, we must make sure that the nightly builds won't break, or if they break manually fix up and build them again. -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No
osmo-bts[master]: Name systemd service after the software
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No
[PATCH] osmo-bts[master]: Name systemd service after the software
Review at https://gerrit.osmocom.org/2225
Name systemd service after the software
Binary name was changed from sysmopcu to osmo-pcu but the service file
remained with the old name, which is confusing for newcomers.
Added an alias to the service file for users used to the old naming.
Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf
---
M Makefile.am
R contrib/osmo-bts.service
M src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c
M src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c
4 files changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/2225/1
diff --git a/Makefile.am b/Makefile.am
index 9a5e26f..b83189c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -5,7 +5,7 @@
# package the contrib and doc
EXTRA_DIST = \
- contrib/dump_docs.py contrib/screenrc-l1fwd contrib/sysmobts.service \
+ contrib/dump_docs.py contrib/screenrc-l1fwd contrib/osmo-bts.service \
contrib/l1fwd.init contrib/screenrc-sysmobts contrib/respawn.sh \
contrib/sysmobts.init contrib/sysmobts-calib/Makefile \
contrib/sysmobts-calib/sysmobts-calib.c \
diff --git a/contrib/sysmobts.service b/contrib/osmo-bts.service
similarity index 96%
rename from contrib/sysmobts.service
rename to contrib/osmo-bts.service
index e07a3db..bbb2bef 100644
--- a/contrib/sysmobts.service
+++ b/contrib/osmo-bts.service
@@ -17,3 +17,4 @@
[Install]
WantedBy=multi-user.target
+Alias=sysmobts.service
diff --git a/src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c
b/src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c
index f01fd14..81e41f0 100644
--- a/src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c
+++ b/src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c
@@ -116,7 +116,7 @@
* and used SIGCHLD/waitpid to pick up the dead processes
* without invoking shell.
*/
- system("/bin/systemctl start sysmobts.service");
+ system("/bin/systemctl start osmo-bts.service");
}
}
@@ -157,7 +157,7 @@
* and used SIGCHLD/waitpid to pick up the dead processes
* without invoking shell.
*/
- system("/bin/systemctl stop sysmobts.service");
+ system("/bin/systemctl stop osmo-bts.service");
}
}
diff --git a/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c
b/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c
index 3020d90..85270de 100644
--- a/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c
+++ b/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c
@@ -284,7 +284,7 @@
DEFUN(cfg_action_bts_srv_on, cfg_action_bts_srv_on_cmd,
"bts-service-on",
- "Start the systemd sysmobts.service\n")
+ "Start the systemd osmo-bts.service\n")
{
int *action = vty->index;
*action |= TEMP_ACT_NORM_BTS_SRV_ON;
@@ -293,7 +293,7 @@
DEFUN(cfg_no_action_bts_srv_on, cfg_no_action_bts_srv_on_cmd,
"no bts-service-on",
- NO_STR "Start the systemd sysmobts.service\n")
+ NO_STR "Start the systemd osmo-bts.service\n")
{
int *action = vty->index;
*action &= ~TEMP_ACT_NORM_BTS_SRV_ON;
@@ -338,7 +338,7 @@
DEFUN(cfg_action_bts_srv_off, cfg_action_bts_srv_off_cmd,
"bts-service-off",
- "Stop the systemd sysmobts.service\n")
+ "Stop the systemd osmo-bts.service\n")
{
int *action = vty->index;
*action |= TEMP_ACT_BTS_SRV_OFF;
@@ -347,7 +347,7 @@
DEFUN(cfg_no_action_bts_srv_off, cfg_no_action_bts_srv_off_cmd,
"no bts-service-off",
- NO_STR "Stop the systemd sysmobts.service\n")
+ NO_STR "Stop the systemd osmo-bts.service\n")
{
int *action = vty->index;
*action &= ~TEMP_ACT_BTS_SRV_OFF;
--
To view, visit https://gerrit.osmocom.org/2225
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol
