osmo-bts[master]: vty.c: Remove warning message

2018-02-05 Thread Harald Welte

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6272
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie277dce00292c8f403b9a2b405efe4429e6af86a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No


[MERGED] osmo-bts[master]: vty.c: Remove warning message

2018-02-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged.

Change subject: vty.c: Remove warning message
..


vty.c: Remove warning message

This warning was included in commit
6d7b78bde165f39dcd9033f0c5386f5699801233 from 2011, and nowadays I only
see this command used in osmo-bts, so I think we most probably drop it
as it doesn't make sense anymore.

Change-Id: Ie277dce00292c8f403b9a2b405efe4429e6af86a
---
M src/common/vty.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/vty.c b/src/common/vty.c
index 050f922..498ab5a 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -391,7 +391,6 @@
return CMD_SUCCESS;
 }
 
-#warning merge with OpenBSC?
 DEFUN(cfg_bts_unit_id,
   cfg_bts_unit_id_cmd,
   "ipa unit-id <0-65534> <0-255>",

-- 
To view, visit https://gerrit.osmocom.org/6272
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie277dce00292c8f403b9a2b405efe4429e6af86a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


[PATCH] osmo-bts[master]: vty.c: Remove warning message

2018-02-05 Thread Pau Espin Pedrol

Review at  https://gerrit.osmocom.org/6272

vty.c: Remove warning message

This warning was included in commit
6d7b78bde165f39dcd9033f0c5386f5699801233 from 2011, and nowadays I only
see this command used in osmo-bts, so I think we most probably drop it
as it doesn't make sense anymore.

Change-Id: Ie277dce00292c8f403b9a2b405efe4429e6af86a
---
M src/common/vty.c
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/72/6272/1

diff --git a/src/common/vty.c b/src/common/vty.c
index 050f922..498ab5a 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -391,7 +391,6 @@
return CMD_SUCCESS;
 }
 
-#warning merge with OpenBSC?
 DEFUN(cfg_bts_unit_id,
   cfg_bts_unit_id_cmd,
   "ipa unit-id <0-65534> <0-255>",

-- 
To view, visit https://gerrit.osmocom.org/6272
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie277dce00292c8f403b9a2b405efe4429e6af86a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol