[MERGED] osmo-gsm-tester[master]: ofono_client: Improve log around Scan() failure

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: ofono_client: Improve log around Scan() failure
..


ofono_client: Improve log around Scan() failure

Change-Id: I8558d7fe41c155db2a9710e1eccf15b6499f24ef
---
M src/osmo_gsm_tester/ofono_client.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/ofono_client.py 
b/src/osmo_gsm_tester/ofono_client.py
index 45a4294..4deff9e 100644
--- a/src/osmo_gsm_tester/ofono_client.py
+++ b/src/osmo_gsm_tester/ofono_client.py
@@ -418,9 +418,11 @@
 # the registering succeeds while we are still waiting for Scan() to 
finsih.
 # So far the easiest seems to check if we are now registered and
 # otherwise schedule a scan again.
-self.err('Scan() failed:', e)
+self.err('Scan() failed, retrying if needed:', e)
 if not self.is_connected(mcc_mnc):
 self.schedule_scan_register(mcc_mnc)
+else:
+self.log('Already registered with network', mcc_mnc)
 
 def scan_cb_register_automatic(self, scanned_operators, mcc_mnc):
 self.dbg('scanned operators: ', scanned_operators);

-- 
To view, visit https://gerrit.osmocom.org/2904
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8558d7fe41c155db2a9710e1eccf15b6499f24ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 

osmo-gsm-tester[master]: ofono_client: Improve log around Scan() failure

[Neels Hofmeyr]

Patch Set 1: Code-Review+2

we could still improve, but whatever

-- 
To view, visit https://gerrit.osmocom.org/2904
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8558d7fe41c155db2a9710e1eccf15b6499f24ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[PATCH] osmo-gsm-tester[master]: ofono_client: Improve log around Scan() failure

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/2904

ofono_client: Improve log around Scan() failure

Change-Id: I8558d7fe41c155db2a9710e1eccf15b6499f24ef
---
M src/osmo_gsm_tester/ofono_client.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/04/2904/1

diff --git a/src/osmo_gsm_tester/ofono_client.py 
b/src/osmo_gsm_tester/ofono_client.py
index 45a4294..4deff9e 100644
--- a/src/osmo_gsm_tester/ofono_client.py
+++ b/src/osmo_gsm_tester/ofono_client.py
@@ -418,9 +418,11 @@
 # the registering succeeds while we are still waiting for Scan() to 
finsih.
 # So far the easiest seems to check if we are now registered and
 # otherwise schedule a scan again.
-self.err('Scan() failed:', e)
+self.err('Scan() failed, retrying if needed:', e)
 if not self.is_connected(mcc_mnc):
 self.schedule_scan_register(mcc_mnc)
+else:
+self.log('Already registered with network', mcc_mnc)
 
 def scan_cb_register_automatic(self, scanned_operators, mcc_mnc):
 self.dbg('scanned operators: ', scanned_operators);

-- 
To view, visit https://gerrit.osmocom.org/2904
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8558d7fe41c155db2a9710e1eccf15b6499f24ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol