[MERGED] osmo-pcu[master]: TBF: show assignment kind in vty
Harald Welte has submitted this change and it was merged. Change subject: TBF: show assignment kind in vty .. TBF: show assignment kind in vty Change-Id: Ic4e40d9c141ab7ee3f7c4dceec007dbe16359f93 Related: OS#1759 --- M src/pcu_vty_functions.cpp 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index eb15aa6..bb341f8 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -49,9 +49,11 @@ tbf->ta(), tbf->direction == GPRS_RLCMAC_UL_TBF ? "UL" : "DL", tbf->imsi(), VTY_NEWLINE); - vty_out(vty, " created=%lu state=%08x 1st_TS=%d 1st_cTS=%d ctrl_TS=%d " - "MS_CLASS=%d/%d%s", - tbf->created_ts(), tbf->state_flags, tbf->first_ts, + vty_out(vty, " created=%lu state=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s", + tbf->created_ts(), tbf->state_flags, + tbf->state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH), + tbf->state_flags & (1 << GPRS_RLCMAC_FLAG_PACCH), + tbf->first_ts, tbf->first_common_ts, tbf->control_ts, tbf->ms_class(), tbf->ms() ? tbf->ms()->egprs_ms_class() : -1, -- To view, visit https://gerrit.osmocom.org/6207 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4e40d9c141ab7ee3f7c4dceec007dbe16359f93 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
osmo-pcu[master]: TBF: show assignment kind in vty
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6207 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4e40d9c141ab7ee3f7c4dceec007dbe16359f93 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
[PATCH] osmo-pcu[master]: TBF: show assignment kind in vty
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6207 to look at the new patch set (#2). TBF: show assignment kind in vty Change-Id: Ic4e40d9c141ab7ee3f7c4dceec007dbe16359f93 Related: OS#1759 --- M src/pcu_vty_functions.cpp 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/6207/2 diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index eb15aa6..bb341f8 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -49,9 +49,11 @@ tbf->ta(), tbf->direction == GPRS_RLCMAC_UL_TBF ? "UL" : "DL", tbf->imsi(), VTY_NEWLINE); - vty_out(vty, " created=%lu state=%08x 1st_TS=%d 1st_cTS=%d ctrl_TS=%d " - "MS_CLASS=%d/%d%s", - tbf->created_ts(), tbf->state_flags, tbf->first_ts, + vty_out(vty, " created=%lu state=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s", + tbf->created_ts(), tbf->state_flags, + tbf->state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH), + tbf->state_flags & (1 << GPRS_RLCMAC_FLAG_PACCH), + tbf->first_ts, tbf->first_common_ts, tbf->control_ts, tbf->ms_class(), tbf->ms() ? tbf->ms()->egprs_ms_class() : -1, -- To view, visit https://gerrit.osmocom.org/6207 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic4e40d9c141ab7ee3f7c4dceec007dbe16359f93 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder
[PATCH] osmo-pcu[master]: TBF: show assignment kind in vty
Review at https://gerrit.osmocom.org/6207 TBF: show assignment kind in vty Change-Id: Ic4e40d9c141ab7ee3f7c4dceec007dbe16359f93 Related: OS#1759 --- M src/pcu_vty_functions.cpp 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/6207/1 diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index eb15aa6..31fffa9 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -49,9 +49,11 @@ tbf->ta(), tbf->direction == GPRS_RLCMAC_UL_TBF ? "UL" : "DL", tbf->imsi(), VTY_NEWLINE); - vty_out(vty, " created=%lu state=%08x 1st_TS=%d 1st_cTS=%d ctrl_TS=%d " - "MS_CLASS=%d/%d%s", - tbf->created_ts(), tbf->state_flags, tbf->first_ts, + vty_out(vty, " created=%lu state=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s", + tbf->created_ts(), tbf->state_flags, + state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH), + state_flags & (1 << GPRS_RLCMAC_FLAG_PACCH), + tbf->first_ts, tbf->first_common_ts, tbf->control_ts, tbf->ms_class(), tbf->ms() ? tbf->ms()->egprs_ms_class() : -1, -- To view, visit https://gerrit.osmocom.org/6207 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic4e40d9c141ab7ee3f7c4dceec007dbe16359f93 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max