osmo-sgsn[master]: configure.ac: Enable Wall in CFLAGS
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5673 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin PedrolGerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No
[MERGED] osmo-sgsn[master]: configure.ac: Enable Wall in CFLAGS
Harald Welte has submitted this change and it was merged. Change subject: configure.ac: Enable Wall in CFLAGS .. configure.ac: Enable Wall in CFLAGS Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 --- M configure.ac 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index b89c046..ba82eb1 100644 --- a/configure.ac +++ b/configure.ac @@ -104,6 +104,9 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) +CPPFLAGS="$CPPFLAGS -Wall" +CFLAGS="$CFLAGS -Wall" + AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -- To view, visit https://gerrit.osmocom.org/5673 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin PedrolGerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max
[PATCH] osmo-sgsn[master]: configure.ac: Enable Wall in CFLAGS
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5673 to look at the new patch set (#2). configure.ac: Enable Wall in CFLAGS Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 --- M configure.ac 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/73/5673/2 diff --git a/configure.ac b/configure.ac index b89c046..ba82eb1 100644 --- a/configure.ac +++ b/configure.ac @@ -104,6 +104,9 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) +CPPFLAGS="$CPPFLAGS -Wall" +CFLAGS="$CFLAGS -Wall" + AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -- To view, visit https://gerrit.osmocom.org/5673 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin PedrolGerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max
osmo-sgsn[master]: configure.ac: Enable Wall in CFLAGS
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5673 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin PedrolGerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No
osmo-sgsn[master]: configure.ac: Enable Wall in CFLAGS
Patch Set 1: I think this should come before Werror patch. -- To view, visit https://gerrit.osmocom.org/5673 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin PedrolGerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No
[PATCH] osmo-sgsn[master]: configure.ac: Enable Wall in CFLAGS
Review at https://gerrit.osmocom.org/5673 configure.ac: Enable Wall in CFLAGS Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/73/5673/1 diff --git a/configure.ac b/configure.ac index b89c046..bb4df57 100644 --- a/configure.ac +++ b/configure.ac @@ -104,6 +104,8 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) +CFLAGS="$CFLAGS -Wall" + AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -- To view, visit https://gerrit.osmocom.org/5673 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol