[ABANDON] osmo-trx[master]: build: check if libosmogsm is available

[roox]

roox has abandoned this change.

Change subject: build: check if libosmogsm is available
..


Abandoned

-- 
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: roox 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: roox 

osmo-trx[master]: build: check if libosmogsm is available

[Vadim Yanitskiy]

Patch Set 1:

> I just checked the dependencies of *all* osmocom-related
 > devel-packages a and also found (and fixed) issues in
 > libosmocoding-devel
 > libosmogb-devel
 > libosmoctrl-devel

Great. Now, I think it makes sense to abandon this change.

-- 
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: roox 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: roox 
Gerrit-HasComments: No

osmo-trx[master]: build: check if libosmogsm is available

[roox]

Patch Set 1:

I just checked the dependencies of *all* osmocom-related devel-packages a and 
also found (and fixed) issues in 
libosmocoding-devel
libosmogb-devel
libosmoctrl-devel

-- 
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: roox 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: roox 
Gerrit-HasComments: No

osmo-trx[master]: build: check if libosmogsm is available

[Vadim Yanitskiy]

Patch Set 1:

> You're right. It's package dependency issue on my side.
 > I just corrected the dependencies for the libosmoctrl-devel
 > package.

Please also have a look at the 'libosmoctrl.pc'.

-- 
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: roox 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: roox 
Gerrit-HasComments: No

osmo-trx[master]: build: check if libosmogsm is available

[roox]

Patch Set 1:

You're right. It's package dependency issue on my side.
I just corrected the dependencies for the libosmoctrl-devel package.

-- 
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: roox 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: roox 
Gerrit-HasComments: No

osmo-trx[master]: build: check if libosmogsm is available

[Vadim Yanitskiy]

Patch Set 1:

Hmm, seems this is a dependency of the libosmoctrl:

$ pkg-config --libs libosmoctrl

  -L/usr/local/lib -ltalloc -losmoctrl -losmogsm -losmocore

So, I guess libosmoctrl will not build without libosmogsm itself.

-- 
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: roox 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: roox 
Gerrit-HasComments: No

osmo-trx[master]: build: check if libosmogsm is available

[roox]

Patch Set 1:

[   29s] /bin/sh /home/abuild/rpmbuild/BUILD/osmo-trx-0.2.0.64/libtool  
--tag=CXX   --mode=link g++ -lpthread -I/usr/include/libosmocore/ 
-I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 
-grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong 
-funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g   -o 
osmo-trx osmo-trx.o libtransceiver.la 
/home/abuild/rpmbuild/BUILD/osmo-trx-0.2.0.64/Transceiver52M/x86/libarch.la 
/home/abuild/rpmbuild/BUILD/osmo-trx-0.2.0.64/GSM/libGSM.la 
/home/abuild/rpmbuild/BUILD/osmo-trx-0.2.0.64/CommonLibs/libcommon.la -lfftw3f 
-ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty 
-losmocore  -luhd
[   29s] libtool: link: g++ -I/usr/include/libosmocore/ 
-I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 
-grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong 
-funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g -o 
osmo-trx osmo-trx.o  ./.libs/libtransceiver.a 
/home/abuild/rpmbuild/BUILD/osmo-trx-0.2.0.64/Transceiver52M/x86/.libs/libarch.a
 /home/abuild/rpmbuild/BUILD/osmo-trx-0.2.0.64/GSM/.libs/libGSM.a 
/home/abuild/rpmbuild/BUILD/osmo-trx-0.2.0.64/CommonLibs/.libs/libcommon.a 
-lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -luhd
[   29s] 
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: cannot 
find -losmogsm

Full buildlogs:
https://pmtu.de/.dump/osmo-trx-openSUSE-Tumbleweed-buildlog-without-osmogsm.txt
https://pmtu.de/.dump/osmo-trx-openSUSE-Tumbleweed-buildlog-with-osmogsm.txt

-- 
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: roox 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: roox 
Gerrit-HasComments: No

osmo-trx[master]: build: check if libosmogsm is available

[Vadim Yanitskiy]

Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/7283/1/configure.ac
File configure.ac:

Line 80: PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.10.0)
Could you please clarify for what do we need libosmogsm?
I don't think it's used anywhere in code at the moment.


-- 
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: roox 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: Yes

[PATCH] osmo-trx[master]: build: check if libosmogsm is available

[roox]

Review at  https://gerrit.osmocom.org/7283

build: check if libosmogsm is available

Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
---
M configure.ac
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/83/7283/1

diff --git a/configure.ac b/configure.ac
index bade799..f9a6001 100644
--- a/configure.ac
+++ b/configure.ac
@@ -77,6 +77,7 @@
 PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.10.0)
 PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.3.0)
 PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 0.10.0)
+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.10.0)
 
 AC_ARG_WITH(usrp1, [
 AS_HELP_STRING([--with-usrp1],

-- 
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: roox