osmocom-bb[master]: l1ctl_proto.h: define burst indication messages

[Harald Welte]

Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6237
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Gerrit-PatchSet: 4
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: tnt 
Gerrit-HasComments: No

[MERGED] osmocom-bb[master]: l1ctl_proto.h: define burst indication messages

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: l1ctl_proto.h: define burst indication messages
..


l1ctl_proto.h: define burst indication messages

One burst indication message carries a single raw burst, forwarded
to the higher layers from DSP. The burst bits are hard-bits (0 or 1)
coming from demodulator, packed to 14.5 bytes. This is why we call
them 'raw' - no bit correction nor deciphering is performed.

Related: OS#1672
Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
---
M include/l1ctl_proto.h
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/l1ctl_proto.h b/include/l1ctl_proto.h
index 37d3d87..1706534 100644
--- a/include/l1ctl_proto.h
+++ b/include/l1ctl_proto.h
@@ -56,6 +56,7 @@
L1CTL_TRAFFIC_REQ,
L1CTL_TRAFFIC_CONF,
L1CTL_TRAFFIC_IND,
+   L1CTL_BURST_IND,
 
/* configure TBF for uplink/downlink */
L1CTL_TBF_CFG_REQ,
@@ -295,6 +296,19 @@
};
 } __attribute__((packed));
 
+#define BI_FLG_DUMMY (1 << 4)
+#define BI_FLG_SACCH (1 << 5)
+
+struct l1ctl_burst_ind {
+   uint32_t frame_nr;
+   uint16_t band_arfcn;/* ARFCN + band + ul indicator   */
+   uint8_t chan_nr;/* GSM 08.58 channel number (9.3.1)  */
+   uint8_t flags;  /* BI_FLG_xxx + burst_id = 2LSBs */
+   uint8_t rx_level;   /* 0 .. 63 in typical GSM notation (dBm+110) */
+   uint8_t snr;/* Reported SNR >> 8 (0-255) */
+   uint8_t bits[15];   /* 114 bits + 2 steal bits. Filled MSB first */
+} __attribute__((packed));
+
 /* a single L1CTL_PM response */
 struct l1ctl_pm_conf {
uint16_t band_arfcn;

-- 
To view, visit https://gerrit.osmocom.org/6237
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Gerrit-PatchSet: 4
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: tnt 

[PATCH] osmocom-bb[master]: l1ctl_proto.h: define burst indication messages

[Vadim Yanitskiy]

Hello Max, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/6237

to look at the new patch set (#4).

l1ctl_proto.h: define burst indication messages

One burst indication message carries a single raw burst, forwarded
to the higher layers from DSP. The burst bits are hard-bits (0 or 1)
coming from demodulator, packed to 14.5 bytes. This is why we call
them 'raw' - no bit correction nor deciphering is performed.

Related: OS#1672
Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
---
M include/l1ctl_proto.h
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/37/6237/4

diff --git a/include/l1ctl_proto.h b/include/l1ctl_proto.h
index 37d3d87..1706534 100644
--- a/include/l1ctl_proto.h
+++ b/include/l1ctl_proto.h
@@ -56,6 +56,7 @@
L1CTL_TRAFFIC_REQ,
L1CTL_TRAFFIC_CONF,
L1CTL_TRAFFIC_IND,
+   L1CTL_BURST_IND,
 
/* configure TBF for uplink/downlink */
L1CTL_TBF_CFG_REQ,
@@ -295,6 +296,19 @@
};
 } __attribute__((packed));
 
+#define BI_FLG_DUMMY (1 << 4)
+#define BI_FLG_SACCH (1 << 5)
+
+struct l1ctl_burst_ind {
+   uint32_t frame_nr;
+   uint16_t band_arfcn;/* ARFCN + band + ul indicator   */
+   uint8_t chan_nr;/* GSM 08.58 channel number (9.3.1)  */
+   uint8_t flags;  /* BI_FLG_xxx + burst_id = 2LSBs */
+   uint8_t rx_level;   /* 0 .. 63 in typical GSM notation (dBm+110) */
+   uint8_t snr;/* Reported SNR >> 8 (0-255) */
+   uint8_t bits[15];   /* 114 bits + 2 steal bits. Filled MSB first */
+} __attribute__((packed));
+
 /* a single L1CTL_PM response */
 struct l1ctl_pm_conf {
uint16_t band_arfcn;

-- 
To view, visit https://gerrit.osmocom.org/6237
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Gerrit-PatchSet: 4
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: tnt 

osmocom-bb[master]: l1ctl_proto.h: define burst indication messages

[Max]

Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/6237
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: tnt 
Gerrit-HasComments: No

[PATCH] osmocom-bb[master]: l1ctl_proto.h: define burst indication messages

[Vadim Yanitskiy]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/6237

to look at the new patch set (#3).

l1ctl_proto.h: define burst indication messages

One burst indication message carries a single raw burst, forwarded
to the higher layers from DSP. The burst bits are hard-bits (0 or 1)
coming from demodulator, packed to 14.5 bytes. This is why we call
them 'raw' - no bit correction nor deciphering is performed.

Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Related: OS#1672
---
M include/l1ctl_proto.h
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/37/6237/3

diff --git a/include/l1ctl_proto.h b/include/l1ctl_proto.h
index 37d3d87..1706534 100644
--- a/include/l1ctl_proto.h
+++ b/include/l1ctl_proto.h
@@ -56,6 +56,7 @@
L1CTL_TRAFFIC_REQ,
L1CTL_TRAFFIC_CONF,
L1CTL_TRAFFIC_IND,
+   L1CTL_BURST_IND,
 
/* configure TBF for uplink/downlink */
L1CTL_TBF_CFG_REQ,
@@ -295,6 +296,19 @@
};
 } __attribute__((packed));
 
+#define BI_FLG_DUMMY (1 << 4)
+#define BI_FLG_SACCH (1 << 5)
+
+struct l1ctl_burst_ind {
+   uint32_t frame_nr;
+   uint16_t band_arfcn;/* ARFCN + band + ul indicator   */
+   uint8_t chan_nr;/* GSM 08.58 channel number (9.3.1)  */
+   uint8_t flags;  /* BI_FLG_xxx + burst_id = 2LSBs */
+   uint8_t rx_level;   /* 0 .. 63 in typical GSM notation (dBm+110) */
+   uint8_t snr;/* Reported SNR >> 8 (0-255) */
+   uint8_t bits[15];   /* 114 bits + 2 steal bits. Filled MSB first */
+} __attribute__((packed));
+
 /* a single L1CTL_PM response */
 struct l1ctl_pm_conf {
uint16_t band_arfcn;

-- 
To view, visit https://gerrit.osmocom.org/6237
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: tnt 

osmocom-bb[master]: l1ctl_proto.h: define burst indication messages

[tnt]

Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/6237/2//COMMIT_MSG
Commit Message:

Line 10: to the higher layers from DSP. The burst bits are soft-bits (127..
They are hard-bits ... 116 bits = 14.5 bytes.


-- 
To view, visit https://gerrit.osmocom.org/6237
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Gerrit-PatchSet: 2
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: tnt 
Gerrit-HasComments: Yes

[PATCH] osmocom-bb[master]: l1ctl_proto.h: define burst indication messages

[Vadim Yanitskiy]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/6237

to look at the new patch set (#2).

l1ctl_proto.h: define burst indication messages

One burst indication message carries a single raw burst, forwarded
to the higher layers from DSP. The burst bits are soft-bits (127..
-127) from demodulator, packed to 15 bytes. This is why we call
them 'raw' - no bit correction nor deciphering is performed.

Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Related: OS#1672
---
M include/l1ctl_proto.h
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/37/6237/2

diff --git a/include/l1ctl_proto.h b/include/l1ctl_proto.h
index 37d3d87..1706534 100644
--- a/include/l1ctl_proto.h
+++ b/include/l1ctl_proto.h
@@ -56,6 +56,7 @@
L1CTL_TRAFFIC_REQ,
L1CTL_TRAFFIC_CONF,
L1CTL_TRAFFIC_IND,
+   L1CTL_BURST_IND,
 
/* configure TBF for uplink/downlink */
L1CTL_TBF_CFG_REQ,
@@ -295,6 +296,19 @@
};
 } __attribute__((packed));
 
+#define BI_FLG_DUMMY (1 << 4)
+#define BI_FLG_SACCH (1 << 5)
+
+struct l1ctl_burst_ind {
+   uint32_t frame_nr;
+   uint16_t band_arfcn;/* ARFCN + band + ul indicator   */
+   uint8_t chan_nr;/* GSM 08.58 channel number (9.3.1)  */
+   uint8_t flags;  /* BI_FLG_xxx + burst_id = 2LSBs */
+   uint8_t rx_level;   /* 0 .. 63 in typical GSM notation (dBm+110) */
+   uint8_t snr;/* Reported SNR >> 8 (0-255) */
+   uint8_t bits[15];   /* 114 bits + 2 steal bits. Filled MSB first */
+} __attribute__((packed));
+
 /* a single L1CTL_PM response */
 struct l1ctl_pm_conf {
uint16_t band_arfcn;

-- 
To view, visit https://gerrit.osmocom.org/6237
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Gerrit-PatchSet: 2
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: tnt