Re: Possible [PATCH] Add BBC Radio 4 Extra (was: Re: bit of a newbie but...)
On 2 April 2011 17:09, Jonathan Wiltshire wrote:
> On Fri, Apr 01, 2011 at 10:55:33PM +0100, Jon Davies wrote:
>> @@ -7109,6 +7109,7 @@ sub channels {
>> 'bbc_radio_two' => 'BBC Radio 2',
>> 'bbc_radio_three' => 'BBC Radio 3',
>> 'bbc_radio_four' => 'BBC Radio 4',
>> + 'bbc_radio_four_extra' => 'BBC Radio
>> 4 Extra',
>> 'bbc_radio_five_live' => 'BBC Radio 5 live',
>> 'bbc_radio_five_live_sports_extra' => 'BBC 5 live Sports
>> Extra',
>> 'bbc_6music' => 'BBC 6 Music',
>
> Is there any reason this hunk uses spaces at the beginning of the changed
> line instead of tabs?
No, there wasn't, consider it a typo.
Jon
___
get_iplayer mailing list
get_iplayer@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: Possible [PATCH] Add BBC Radio 4 Extra (was: Re: bit of a newbie but...)
On Fri, Apr 01, 2011 at 10:55:33PM +0100, Jon Davies wrote:
> @@ -7109,6 +7109,7 @@ sub channels {
> 'bbc_radio_two' => 'BBC Radio 2',
> 'bbc_radio_three' => 'BBC Radio 3',
> 'bbc_radio_four'=> 'BBC Radio 4',
> +'bbc_radio_four_extra' => 'BBC Radio 4
> Extra',
> 'bbc_radio_five_live' => 'BBC Radio 5 live',
> 'bbc_radio_five_live_sports_extra' => 'BBC 5 live Sports
> Extra',
> 'bbc_6music'=> 'BBC 6 Music',
Is there any reason this hunk uses spaces at the beginning of the changed
line instead of tabs?
I've applied the patch to the Debian package with no side effects, I'll
forward any bug reports. Thanks for your work!
--
Jonathan Wiltshire j...@debian.org
Debian Developer http://people.debian.org/~jmw
4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
signature.asc
Description: Digital signature
___
get_iplayer mailing list
get_iplayer@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: Possible [PATCH] Add BBC Radio 4 Extra (was: Re: bit of a newbie but...)
On Fri, 1 Apr 2011 22:55:33 +0100, you wrote: >That won't be quite enough. I've attached a patch which doesn't crash >get_iplayer, but I can't really test it until 4 extra content starts >appearing on iplayer, which won't be until at least tomorrow. Adn the >live streaming bit is a guess at what the URL will be. But it might >work... > >Cheers >Jon Ah, missed the "this_week" thing. Not sure what you meant by doesn't crash get_iplayer? As for testing, doesn't it work already? e.g. perl -I %incPath%/lib get_iplayer.pl --profiledir=. --type=radio "flywheel" --get --channel="BBC Radio 4 Extra" Not sure why content would have to appear on iplayer. JC ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: Possible [PATCH] Add BBC Radio 4 Extra (was: Re: bit of a newbie but...)
On 1 April 2011 22:55, Jon Davies wrote: > 've attached a patch which doesn't crash > get_iplayer, but I can't really test it until 4 extra content starts > appearing on iplayer, which won't be until at least tomorrow. Adn the > live streaming bit is a guess at what the URL will be. But it might > work... as Paul pointed out there /is/ some 4 Extra content on iplayer already (I must have blinked), and it appears my guess at a live radio URL is right, and as far as I can tell the patch works. It indexes, downloads and streams both recorded and live content for Radio 4 Extra fine from here. Enjoy Jon ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
Possible [PATCH] Add BBC Radio 4 Extra (was: Re: bit of a newbie but...)
On 1 April 2011 21:42, James Cook wrote:
> Try
>
> sub channels {
> return {
> 'bbc_1xtra' => 'BBC 1Xtra',
> 'bbc_radio_one' => 'BBC Radio 1',
> 'bbc_radio_two' => 'BBC Radio 2',
> 'bbc_radio_three' => 'BBC Radio 3',
> 'bbc_radio_four' => 'BBC Radio 4',
> 'bbc_radio_four_extra' => 'BBC Radio 4 Extra',
> 'bbc_radio_five_live' => 'BBC Radio 5 live',
That won't be quite enough. I've attached a patch which doesn't crash
get_iplayer, but I can't really test it until 4 extra content starts
appearing on iplayer, which won't be until at least tomorrow. Adn the
live streaming bit is a guess at what the URL will be. But it might
work...
Cheers
Jon
0004-Add-Radio-4-Extra.patch
Description: Binary data
___
get_iplayer mailing list
get_iplayer@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: bit of a newbie but...
On Fri, 1 Apr 2011 14:04:32 +0100, you wrote:
>On 1 April 2011 11:10, Paul wrote:
>> been using get_iplayer for a few weeks and just realised that the BBCs
>> change from Radio 7 to Radio 4 Extra looks like you can't use
>> get_iplayer to get this new material
>>
>> Am I right?
>
>As I understand it the channel names are hard-coded in get_iplayer, so
>an update to get_iplayer will be needed to get Radio 4 Extra from the
>iplayer site.
>
>It should be a pretty trivial patch, but I don't have access to the
>right systems here to write and test something.
>
>Jon
>
Try
sub channels {
return {
'bbc_1xtra'=> 'BBC 1Xtra',
'bbc_radio_one'=> 'BBC Radio 1',
'bbc_radio_two'=> 'BBC Radio 2',
'bbc_radio_three' => 'BBC Radio 3',
'bbc_radio_four' => 'BBC Radio 4',
'bbc_radio_four_extra' => 'BBC Radio 4 Extra',
'bbc_radio_five_live' => 'BBC Radio 5 live',
JC
___
get_iplayer mailing list
get_iplayer@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: bit of a newbie but...
On 1 April 2011 11:10, Paul wrote: > been using get_iplayer for a few weeks and just realised that the BBCs > change from Radio 7 to Radio 4 Extra looks like you can't use > get_iplayer to get this new material > > Am I right? As I understand it the channel names are hard-coded in get_iplayer, so an update to get_iplayer will be needed to get Radio 4 Extra from the iplayer site. It should be a pretty trivial patch, but I don't have access to the right systems here to write and test something. Jon ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: bit of a newbie but...
Hi Paul, Are you saying that Radio 4 Extra programmes won't be available on the iPlayer? Bit of a pain, if that's true! Cheers, Chris -Original Message- From: Paul Sent: Friday, April 01, 2011 11:10 AM To: get_iplayer@lists.infradead.org Subject: bit of a newbie but... been using get_iplayer for a few weeks and just realised that the BBCs change from Radio 7 to Radio 4 Extra looks like you can't use get_iplayer to get this new material Am I right? -- Paul Leman ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
bit of a newbie but...
been using get_iplayer for a few weeks and just realised that the BBCs change from Radio 7 to Radio 4 Extra looks like you can't use get_iplayer to get this new material Am I right? -- Paul Leman ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
