Dear Kostas
Thank you for your explanation.
BR
Tetsuo
2020年1月3日(金) 18:09 Konstantinos Poulios :
>
> Dear Tetsuo,
>
> Nice that you have found one more mistake.
>
> Actually I don't think that we have a policy for updating headers. I think
> Yves did it before making a new release, which is also a good option. If we
> are to make a policy for this I would suggest:
> - Update headers before a release
> - Update only headers of files that where created by the getfem project
> And the we have to decide for a policy on whether we update the header of all
> files or of the files that where touched since the latest release.
>
> BR
> Kostas
>
> On Fri, Jan 3, 2020 at 5:25 AM Tetsuo Koyama wrote:
>>
>> Dear Kostas and getfem project team
>>
>> I rechecked the commit and found a obvious mistake.
>> I pushed branch devel-tetsuo-fix-header.
>>
>> Kostas
>> Thank you for fix my mistake in your commit.
>>
>> Best regard Tetsuo.
>>
>> 2020年1月3日(金) 12:16 Tetsuo Koyama :
>> >
>> > Dear Kostas and happy 2020
>> >
>> > Thank you very much for your comment.
>> >
>> > > In general we shouldn't alter third-party license headers.
>> > Sorry for my mistake. I didn't notice that. I'm rechecking the
>> > modification now.
>> >
>> > > Then the other question is if we really want to change the license
>> > > headers of all files every year or only the license headers of the files
>> > > that have been modified during the past year. This would also exclude
>> > > many of the mistakes on third pary files that we never touch.
>> > The OSS project which I know updates the copyright of all the sources
>> > in the project. So I followed that way. But your way may be more
>> > appropriate to maintain the source code. Either way, I will follow the
>> > project policy and will recheck the changes. (Sorry I think I should
>> > have checked the project policy before the modification.)
>> >
>> > Best regards Tetsuo
>> >
>> > 2020年1月2日(木) 20:16 Konstantinos Poulios :
>> > >
>> > > Hi Tetsuo and happy 2020,
>> > >
>> > > I have found and fixed quite a few mistakes in this commit. But I would
>> > > like to ask you if you have time to recheck your changes in this commit
>> > > manually to make sure that we haven't broken any more headers. In
>> > > general we shouldn't alter third-party license headers.
>> > >
>> > > Then the other question is if we really want to change the license
>> > > headers of all files every year or only the license headers of the files
>> > > that have been modified during the past year. This would also exclude
>> > > many of the mistakes on third pary files that we never touch.
>> > >
>> > > Best regards
>> > > Kostas
>> > >
>> > > On Wed, Jan 1, 2020 at 11:55 PM Tetsuo Koyama
>> > > wrote:
>> > >>
>> > >> Dear Yves
>> > >>
>> > >> Thank you for your merge.
>> > >>
>> > >> Best regards,
>> > >>
>> > >> Tetsuo
>> > >>
>> > >> 2020年1月2日(木) 1:00 Yves Renard :
>> > >>>
>> > >>>
>> > >>> Dear Tetsuo,
>> > >>>
>> > >>> Thank for that ! And Happy new year 2020 too !
>> > >>>
>> > >>> Best regards,
>> > >>>
>> > >>> Yves
>> > >>>
>> > >>> - Mail original -
>> > >>> De: "Tetsuo Koyama"
>> > >>> À: "getfem-commits"
>> > >>> Envoyé: Mercredi 1 Janvier 2020 10:42:54
>> > >>> Objet: [Getfem-commits] Happy New Year 2020
>> > >>>
>> > >>> Dear getfem project
>> > >>>
>> > >>> Happy new year 2020 !
>> > >>> I updated the year of license.
>> > >>> Could you merge devel-tetsuo-happy-new-year-2020?
>> > >>>
>> > >>> Have a nice year.
>> > >>>
>> > >>> Best regards Tetsuo
