Re: Action Required: Status of Harbormaster for Differentials
Phyx writes: > Hi Ben, > > Out of curiosity which platforms will be getting harbormaster support? Is > this only Linux x86_64? > > Any plans to expand this in the future to all Tier 1 platforms? > Indeed I would like to get to this point. At the moment I am focusing on Linux x86_64 and Darwin x86_64. I may try to bring up an ARM as well. The other platforms would be subject to machine availability. Cheers, - Ben signature.asc Description: PGP signature ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Action Required: Status of Harbormaster for Differentials
Joachim Breitner writes: > [ Unknown signature status ] > Hi, > > Am Freitag, den 26.08.2016, 17:39 -0400 schrieb Ben Gamari: >> Indeed, it's available at [1]. > > it does not seem to be world-readable: > > $ git fetch phab > fatal: unable to access > 'http://phabricator.haskell.org/diffusion/GHCDIFF/GHC-Differentials.git/': > The requested URL returned error: 500 > Actually it looks like this was a configuration issue which broke Phabricator's HTTP git hosting. I believe I have fixed this but now seem to be fighting our CDN which I'll need help from the infrastructure guys for. Regardless, you should be able to clone the repo via ssh. >> The only thing you'll find in that repository currently is tags (not >> branches as I stated earlier; sorry!) with names of the form >> phabricator/base/1234 and phabricator/diff/1234. These contain the base >> and head commits of revision 1234, respectively. Note that 1234 does not >> identify a differential; rather it is a revision of a differential (e.g. >> the number that you see in the "ID" column of the history table fn a >> > ifferential in the web interface). > > Ok, I think I will have to add custom code to take care of DRs in > gipeda, but it is probably worth it. > This code won't strictly speaking be in gipeda, right? Rather, it would merely be a bit more logic in the build script, no? > Can I assume that phabricator/base/1234 is always (or at least usually) > a commit on master, or some other branch in the ghc repository? > Often it will be. However, I have in the past often opened "chains" of Differentials where the HEAD of one is the base commit of the next. Naturally in this case the base commit will not be in master. Cheers, - Ben signature.asc Description: PGP signature ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Action Required: Status of Harbormaster for Differentials
Hi, Am Montag, den 29.08.2016, 10:03 -0400 schrieb Ben Gamari: > > > it does not seem to be world-readable: > > > > $ git fetch phab > > fatal: unable to access 'http://phabricator.haskell.org/diffusion/G > > HCDIFF/GHC-Differentials.git/': The requested URL returned error: > > 500 > > > Actually it looks like this was a configuration issue which broke > Phabricator's HTTP git hosting. I believe I have fixed this but now > seem to be fighting our CDN which I'll need help from the > infrastructure > guys for. > > Regardless, you should be able to clone the repo via ssh. Permission denied (publickey,keyboard-interactive). fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. (This is without using an ssh key added to Phab – after all, I need a build service to poll that, and don’t want to hand out keys to that.) I’ll wait for the CDN to get working. > > > The only thing you'll find in that repository currently is tags (not > > > branches as I stated earlier; sorry!) with names of the form > > > phabricator/base/1234 and phabricator/diff/1234. These contain the base > > > and head commits of revision 1234, respectively. Note that 1234 does not > > > identify a differential; rather it is a revision of a differential (e.g. > > > the number that you see in the "ID" column of the history table fn a > > > > > > > > ifferential in the web interface). > > > > Ok, I think I will have to add custom code to take care of DRs in > > gipeda, but it is probably worth it. > > > This code won't strictly speaking be in gipeda, right? Rather, it would > merely be a bit more logic in the build script, no? Both. The build script needs to know that there are two repositories to poll from Gipeda needs to produce a section, like the one for branches, for DRs, which have slightly different semantics (in particular, they have an explicit base commit that comparisons should be made against, which is not the case for git branches). Hmm. Links to git diffs would also have to go to a different place. Annoying complexity there. Maybe a separate gipeda instance is simpler (but would get in the way of comparing commits on Phab with commits on the main repo, and duplicate building work). I’ll have to think more about how this can be done in a viable way. Greetings, Joachim -- -- Joachim “nomeata” Breitner m...@joachim-breitner.de • https://www.joachim-breitner.de/ XMPP: nome...@joachim-breitner.de • OpenPGP-Key: 0xF0FBF51F Debian Developer: nome...@debian.org signature.asc Description: This is a digitally signed message part ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Action Required: Status of Harbormaster for Differentials
Joachim Breitner writes: > Hi, > > Am Montag, den 29.08.2016, 10:03 -0400 schrieb Ben Gamari: >> >> Regardless, you should be able to clone the repo via ssh. > > Permission denied (publickey,keyboard-interactive). > fatal: Could not read from remote repository. > > Please make sure you have the correct access rights > and the repository exists. > > (This is without using an ssh key added to Phab – after all, I need a > build service to poll that, and don’t want to hand out keys to that.) > Ahh, sure. Right, it's expected that ssh requires a key. Indeed http is more fitting for your bot. > I’ll wait for the CDN to get working. > I'll let you know when things have been sorted. >> > Ok, I think I will have to add custom code to take care of DRs in >> > gipeda, but it is probably worth it. >> > >> This code won't strictly speaking be in gipeda, right? Rather, it would >> merely be a bit more logic in the build script, no? > > Both. > > The build script needs to know that there are two repositories to poll from > > Gipeda needs to produce a section, like the one for branches, for DRs, > which have slightly different semantics (in particular, they have an > explicit base commit that comparisons should be made against, which is > not the case for git branches). > Ahhh, I see. A nice point. Cheers, - Ben signature.asc Description: PGP signature ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Action Required: Status of Harbormaster for Differentials
Ben Gamari writes: > Joachim Breitner writes: > >> Hi, >> ... > Ahh, sure. Right, it's expected that ssh requires a key. Indeed http is > more fitting for your bot. > >> I’ll wait for the CDN to get working. >> > I'll let you know when things have been sorted. > Well this is unfortunate: it looks like GHC might be too big [1] for Phabricator's HTTP git hosting logic. Unfortunately it's hard to claim this with much confidence since the endpoint provides no error message beyond a 500 status code. I'm not really sure what to advise here; I'll try to raise a flag with the Phacility people but even if I could confirm that T4369 is the culprit, it's a bug that still unfixed after more than two years and I don't hold out much hope that there will be a fix in the near-term. They suggest that affected users instead use SSH. Sadly this would mean that you would need to provide a key to your bot. It is certainly not a very satisfying answer, but I'm afraid it is likely the best we'll be able to do for a while. Cheers, - Ben [1] https://secure.phabricator.com/T4369 signature.asc Description: PGP signature ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Last call for merge requests for 8.0.2
tl;dr. GHC 8.0.2 is coming. If you have a fix which you'd like to see merged into 8.0.2 and isn't already present in the tree, please speak up! Hello everyone, Over the last week I have been working down the (rather long) merge queue for the ghc-8.0 branch in preparation for a 8.0.2 release. At this point I think have merged nearly everything which will likely make it in to 8.0.2. If you have a patch which hasn't made it to the ghc-8.0 branch that you would like to see merged, please raise your concern on the appropriate Trac ticket. Thanks! - Ben signature.asc Description: PGP signature ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Action Required: Status of Harbormaster for Differentials
Ben Gamari writes: > tl;dr. I am working on restoring Harbormaster support for Differentials. >Towards this end, GHC's Phabricator instance will soon require >that you add an SSH public key to your account in order to upload >patches with `arc diff`. > For the record, I just flipped the switch on this and enabled building of Differentials with Harbormaster. So far things look good but please let me know if you encounter any problems. Thanks! Cheers, - Ben signature.asc Description: PGP signature ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Last call for merge requests for 8.0.2
Hello Ben, Could we have these patches added? http://git.haskell.org/ghc.git/commit/56f47d4a4e418235285d8b8cfe23bde6473f17fc http://git.haskell.org/ghc.git/commit/567dbd9bcb602accf3184b83050f2982cbb7758b These allow reify to reach local variables when used with addModFinalizer. Best, Facundo On Mon, Aug 29, 2016 at 4:00 PM, Ben Gamari wrote: > tl;dr. GHC 8.0.2 is coming. If you have a fix which you'd like to see >merged into 8.0.2 and isn't already present in the tree, please >speak up! > > > Hello everyone, > > Over the last week I have been working down the (rather long) merge > queue for the ghc-8.0 branch in preparation for a 8.0.2 release. At this > point I think have merged nearly everything which will likely make it in > to 8.0.2. > > If you have a patch which hasn't made it to the ghc-8.0 branch that you > would like to see merged, please raise your concern on the appropriate > Trac ticket. > > Thanks! > > - Ben > > > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs > ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Last call for merge requests for 8.0.2
Hello, I don't have a patch, but I think that #12433 is a really serious bug that deserves a timely fix, as compiling with `-dynamic` on Linux produces code that runs but produces incorrect results. Unfortunately, I don't have time to look into it, and the bug is not in a part of the compiler I have experience with. -Iavor On Mon, Aug 29, 2016 at 2:02 PM, Facundo Domínguez < facundo.doming...@tweag.io> wrote: > Hello Ben, > > Could we have these patches added? > > http://git.haskell.org/ghc.git/commit/56f47d4a4e418235285d8b8cfe23bd > e6473f17fc > http://git.haskell.org/ghc.git/commit/567dbd9bcb602accf3184b83050f29 > 82cbb7758b > > These allow reify to reach local variables when used with addModFinalizer. > > Best, > Facundo > > On Mon, Aug 29, 2016 at 4:00 PM, Ben Gamari wrote: > > tl;dr. GHC 8.0.2 is coming. If you have a fix which you'd like to see > >merged into 8.0.2 and isn't already present in the tree, please > >speak up! > > > > > > Hello everyone, > > > > Over the last week I have been working down the (rather long) merge > > queue for the ghc-8.0 branch in preparation for a 8.0.2 release. At this > > point I think have merged nearly everything which will likely make it in > > to 8.0.2. > > > > If you have a patch which hasn't made it to the ghc-8.0 branch that you > > would like to see merged, please raise your concern on the appropriate > > Trac ticket. > > > > Thanks! > > > > - Ben > > > > > > ___ > > ghc-devs mailing list > > ghc-devs@haskell.org > > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs > > > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs > ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
