Re: build fail with latest 8.1 sources

2016-11-12 Thread John Leo
I just pulled again and picked up a more recent patch by Ben Gamari:
https://github.com/ghc/ghc/commit/ca1b986074757efff755c33c7f9a62c7eae43c7f

This seems to have fixed the problem.  The commit says 8 hours ago but for
some reason I didn't pick it up 2 or 3 hours ago when I last pulled.

John

On Sat, Nov 12, 2016 at 3:19 PM, John Leo  wrote:

> That's exactly what I did--in fact clone a fresh GHC and try again, but no
> luck.  I attached the full logs in my second message, which have the
> details--let me know if the attachment is not readable.  Thanks very much
> for your help.
>
> John
>
> On Sat, Nov 12, 2016 at 3:16 PM, Simon Peyton Jones  > wrote:
>
>> I’ve seen a very recent commit that mentioned bumping a TH bound.  Maybe
>> pull, make clean and try again?
>>
>>
>>
>> Simon
>>
>>
>>
>> *From:* ghc-devs [mailto:ghc-devs-boun...@haskell.org] *On Behalf Of *John
>> Leo
>> *Sent:* 12 November 2016 22:48
>> *To:* ghc-devs 
>> *Subject:* build fail with latest 8.1 sources
>>
>>
>>
>> Hi everyone,
>>
>>
>>
>> I'm trying to build the latest 8.1 sources on a Mac running El Capitan.
>> I'm getting an error I'd never seen before and wonder if anyone has any
>> pointers of how I might fix things.  I blew away my GHC, re-cloned from
>> github, reconfigured and I still get the same error.
>>
>>
>>
>> The following are the relevant output lines; the problem is that the
>> template-haskell version doesn't seem to match.  I'm not sure whether this
>> is coming from the template-haskell in 8.1 or in 8.0.1 (which I'm using to
>> build 8.1), but checking the latter I have version 2.11.0.0 which I assume
>> should be sufficient.
>>
>>
>>
>> John
>>
>>
>>
>> 
>>
>>
>>
>> Configuring ghc-pkg-6.9...
>>
>> Configuring ghc-8.1...
>>
>> ghc-cabal: Encountered missing dependencies:
>>
>> template-haskell ==2.11.* && ==2.12.0.0
>>
>> make[1]: *** [compiler/stage1/package-data.mk
>> ]
>> Error 1
>>
>> make[1]: *** Waiting for unfinished jobs
>>
>> make: *** [all] Error 2
>>
>>
>>
>> 
>>
>>
>>
>> internal-229:~/haskell/ghc> cabal update
>>
>> (git)-[master]
>>
>> Downloading the latest package list from hackage.haskell.org
>> 
>>
>> Skipping download: local and remote files match.
>>
>> internal-229:~/haskell/ghc> cabal install template-haskell
>>
>> (git)-[master]
>>
>> Resolving dependencies...
>>
>> All the requested packages are already installed:
>>
>> template-haskell-2.11.0.0
>>
>> Use --reinstall if you want to reinstall anyway.
>>
>
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Windows build broken -- again

2016-11-12 Thread Erik de Castro Lopo
Simon Peyton Jones via ghc-devs wrote:

> In file included from rts\CheckUnload.c:16:0: error:
> 
> 
> 
> rts\LinkerInternals.h:284:15: error:
> 
>  error: unknown type name 'UChar'
> 
>  STATIC_INLINE UChar *

There's a patch up on Phab that should fix that:

https://phabricator.haskell.org/D2700

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: build fail with latest 8.1 sources

2016-11-12 Thread John Leo
That's exactly what I did--in fact clone a fresh GHC and try again, but no
luck.  I attached the full logs in my second message, which have the
details--let me know if the attachment is not readable.  Thanks very much
for your help.

John

On Sat, Nov 12, 2016 at 3:16 PM, Simon Peyton Jones 
wrote:

> I’ve seen a very recent commit that mentioned bumping a TH bound.  Maybe
> pull, make clean and try again?
>
>
>
> Simon
>
>
>
> *From:* ghc-devs [mailto:ghc-devs-boun...@haskell.org] *On Behalf Of *John
> Leo
> *Sent:* 12 November 2016 22:48
> *To:* ghc-devs 
> *Subject:* build fail with latest 8.1 sources
>
>
>
> Hi everyone,
>
>
>
> I'm trying to build the latest 8.1 sources on a Mac running El Capitan.
> I'm getting an error I'd never seen before and wonder if anyone has any
> pointers of how I might fix things.  I blew away my GHC, re-cloned from
> github, reconfigured and I still get the same error.
>
>
>
> The following are the relevant output lines; the problem is that the
> template-haskell version doesn't seem to match.  I'm not sure whether this
> is coming from the template-haskell in 8.1 or in 8.0.1 (which I'm using to
> build 8.1), but checking the latter I have version 2.11.0.0 which I assume
> should be sufficient.
>
>
>
> John
>
>
>
> 
>
>
>
> Configuring ghc-pkg-6.9...
>
> Configuring ghc-8.1...
>
> ghc-cabal: Encountered missing dependencies:
>
> template-haskell ==2.11.* && ==2.12.0.0
>
> make[1]: *** [compiler/stage1/package-data.mk
> ]
> Error 1
>
> make[1]: *** Waiting for unfinished jobs
>
> make: *** [all] Error 2
>
>
>
> 
>
>
>
> internal-229:~/haskell/ghc> cabal update
>
>   (git)-[master]
>
> Downloading the latest package list from hackage.haskell.org
> 
>
> Skipping download: local and remote files match.
>
> internal-229:~/haskell/ghc> cabal install template-haskell
>
>   (git)-[master]
>
> Resolving dependencies...
>
> All the requested packages are already installed:
>
> template-haskell-2.11.0.0
>
> Use --reinstall if you want to reinstall anyway.
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Windows build broken -- again

2016-11-12 Thread Simon Peyton Jones via ghc-devs
Sigh.  The Simon PJ Windows Buildbot reports


"inplace/bin/ghc-stage1.exe" -optc-fno-stack-protector -optc-Wall -optc-Werror 
-optc-Wall -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes 
-optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return 
-optc-Wpointer-arith -optc-Wmissing-noreturn -optc-Wnested-externs 
-optc-Wredundant-decls -optc-Iincludes -optc-Iincludes/dist 
-optc-Iincludes/dist-derivedconstants/header 
-optc-Iincludes/dist-ghcconstants/header -optc-Irts -optc-Irts/dist/build 
-optc-DCOMPILING_RTS -optc-fno-strict-aliasing -optc-fno-common 
-optc-Irts/dist/build/./autogen -optc-Wno-error=inline -optc-O2 
-optc-fomit-frame-pointer -optc-g -optc-DRtsWay=\"rts_v\" 
-optc-DWINVER=0x06000100 -static  -O0 -H64m -Wall 
-fllvm-fill-undef-with-garbage-Werror -Iincludes -Iincludes/dist 
-Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header 
-Irts -Irts/dist/build -DCOMPILING_RTS -this-unit-id rts -dcmm-lint  -i 
-irts -irts/dist/build -Irts/dist/build -irts/dist/build/./autogen 
-Irts/dist/build/./autogen   -O2-Wnoncanonical-monad-instances  -c 
rts/CheckUnload.c -o rts/dist/build/CheckUnload.o



In file included from rts\CheckUnload.c:16:0: error:



rts\LinkerInternals.h:284:15: error:

 error: unknown type name 'UChar'

 STATIC_INLINE UChar *

   ^

rts\LinkerInternals.h: In function 'myindex':



rts\LinkerInternals.h:288:11: error:

 error: 'UChar' undeclared (first use in this function)

 ((UChar*)base) + scale * index;

   ^



rts\LinkerInternals.h:288:11: error:

 note: each undeclared identifier is reported only once for each function 
it appears in



rts\LinkerInternals.h:288:17: error:

 error: expected expression before ')' token

 ((UChar*)base) + scale * index;

 ^



rts\LinkerInternals.h:285:28: error:

 error: unused parameter 'base' [-Werror=unused-parameter]

 myindex ( int scale, void* base, int index )

^

rts\LinkerInternals.h: At top level:



rts\LinkerInternals.h:292:5: error:

 error: unknown type name 'UChar'

 UChar* name,

 ^



rts\LinkerInternals.h:293:5: error:

 error: unknown type name 'UChar'

 UChar* strtab);

 ^

cc1.exe: all warnings being treated as errors

`gcc.exe' failed in phase `C Compiler'. (Exit code: 1)

make[1]: *** [rts/ghc.mk:255: rts/dist/build/CheckUnload.o] Error 1

make[1]: *** Waiting for unfinished jobs

make: *** [Makefile:127: all] Error 2

/c/code/HEAD-1$
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: build fail with latest 8.1 sources

2016-11-12 Thread Simon Peyton Jones via ghc-devs
I’ve seen a very recent commit that mentioned bumping a TH bound.  Maybe pull, 
make clean and try again?

Simon

From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of John Leo
Sent: 12 November 2016 22:48
To: ghc-devs 
Subject: build fail with latest 8.1 sources

Hi everyone,

I'm trying to build the latest 8.1 sources on a Mac running El Capitan.  I'm 
getting an error I'd never seen before and wonder if anyone has any pointers of 
how I might fix things.  I blew away my GHC, re-cloned from github, 
reconfigured and I still get the same error.

The following are the relevant output lines; the problem is that the 
template-haskell version doesn't seem to match.  I'm not sure whether this is 
coming from the template-haskell in 8.1 or in 8.0.1 (which I'm using to build 
8.1), but checking the latter I have version 2.11.0.0 which I assume should be 
sufficient.

John



Configuring ghc-pkg-6.9...
Configuring ghc-8.1...
ghc-cabal: Encountered missing dependencies:
template-haskell ==2.11.* && ==2.12.0.0
make[1]: *** 
[compiler/stage1/package-data.mk]
 Error 1
make[1]: *** Waiting for unfinished jobs
make: *** [all] Error 2



internal-229:~/haskell/ghc> cabal update

 (git)-[master]
Downloading the latest package list from 
hackage.haskell.org
Skipping download: local and remote files match.
internal-229:~/haskell/ghc> cabal install template-haskell  

 (git)-[master]
Resolving dependencies...
All the requested packages are already installed:
template-haskell-2.11.0.0
Use --reinstall if you want to reinstall anyway.
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: build fail with latest 8.1 sources

2016-11-12 Thread John Leo
Looking more closely at the log output it appears there were some errors or
at least warnings earlier in the output, including for template haskell, so
I've attached the full output.  I'll continue to investigate on my machine,
but again if anyone has pointers I'd appreciate it.  I've build 8.1 many
times and never seen this problem before.

John


On Sat, Nov 12, 2016 at 2:48 PM, John Leo  wrote:

> Hi everyone,
>
> I'm trying to build the latest 8.1 sources on a Mac running El Capitan.
> I'm getting an error I'd never seen before and wonder if anyone has any
> pointers of how I might fix things.  I blew away my GHC, re-cloned from
> github, reconfigured and I still get the same error.
>
> The following are the relevant output lines; the problem is that the
> template-haskell version doesn't seem to match.  I'm not sure whether this
> is coming from the template-haskell in 8.1 or in 8.0.1 (which I'm using to
> build 8.1), but checking the latter I have version 2.11.0.0 which I assume
> should be sufficient.
>
> John
>
> 
>
> Configuring ghc-pkg-6.9...
> Configuring ghc-8.1...
> ghc-cabal: Encountered missing dependencies:
> template-haskell ==2.11.* && ==2.12.0.0
> make[1]: *** [compiler/stage1/package-data.mk] Error 1
> make[1]: *** Waiting for unfinished jobs
> make: *** [all] Error 2
>
> 
>
> internal-229:~/haskell/ghc> cabal update
>
>   (git)-[master]
> Downloading the latest package list from hackage.haskell.org
> Skipping download: local and remote files match.
> internal-229:~/haskell/ghc> cabal install template-haskell
>
>   (git)-[master]
> Resolving dependencies...
> All the requested packages are already installed:
> template-haskell-2.11.0.0
> Use --reinstall if you want to reinstall anyway.
>


buildFailure20161112
Description: Binary data
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


build fail with latest 8.1 sources

2016-11-12 Thread John Leo
Hi everyone,

I'm trying to build the latest 8.1 sources on a Mac running El Capitan.
I'm getting an error I'd never seen before and wonder if anyone has any
pointers of how I might fix things.  I blew away my GHC, re-cloned from
github, reconfigured and I still get the same error.

The following are the relevant output lines; the problem is that the
template-haskell version doesn't seem to match.  I'm not sure whether this
is coming from the template-haskell in 8.1 or in 8.0.1 (which I'm using to
build 8.1), but checking the latter I have version 2.11.0.0 which I assume
should be sufficient.

John



Configuring ghc-pkg-6.9...
Configuring ghc-8.1...
ghc-cabal: Encountered missing dependencies:
template-haskell ==2.11.* && ==2.12.0.0
make[1]: *** [compiler/stage1/package-data.mk] Error 1
make[1]: *** Waiting for unfinished jobs
make: *** [all] Error 2



internal-229:~/haskell/ghc> cabal update

  (git)-[master]
Downloading the latest package list from hackage.haskell.org
Skipping download: local and remote files match.
internal-229:~/haskell/ghc> cabal install template-haskell

  (git)-[master]
Resolving dependencies...
All the requested packages are already installed:
template-haskell-2.11.0.0
Use --reinstall if you want to reinstall anyway.
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: GHC pretty printer philosophy

2016-11-12 Thread Richard Eisenberg
I'm afraid I've lost track of where this discussion took place (does someone 
else remember seeing it?), but I've advocated for faithful reproduction in the 
past. In particular, the pretty-printers for HsSyn should, in my opinion, never 
add or remove parentheses.

There is a problem here, though: sometimes HsSyn is produced within GHC (for 
example, in the implementation of `deriving`, or in splicing TH, among a few 
other spots). This HsSyn can get away with missing parentheses, because it's 
built as an unambiguous AST. But if the pretty-printer is always faithful, then 
pretty-printing such an AST will produce an unparsable string. Perhaps the 
answer is that the generated code should be generous with parentheses -- 
essentially moving the paren-adding code from today's pretty-printer to the 
generation sites.

Bottom line here: I fully support this direction of travel, but it's not 
without bumps in the road.

Richard

> On Nov 12, 2016, at 5:12 AM, Alan & Kim Zimmerman  wrote:
> 
> I am currently working on #3384, with the intent of ensuring that
> 
> parse (ppr (parse source)) == parse source
> 
> I have hit the issue where
> 
>foo :: (Int)
> 
> has the parens reflected in the original parsed AST, but the types pretty 
> printer goes to a lot of trouble to remove any parens not required to 
> interpret the meaning of the type.
> 
> So the question is, should the default ppr faithfully reproduce the source 
> that was parsed to generate the given AST, or simplify it?
> 
> From a round-tripping perspective I prefer the former, but there are other 
> use cases where the current behaviour is preferred.
> 
> If the original is preferred, it can perhaps be enabled via a flag to the 
> pretty printer, but before doing that I want to see if it actually matters.
> 
> Alan
> 
> 
> ___
> ghc-devs mailing list
> ghc-devs@haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


GHC pretty printer philosophy

2016-11-12 Thread Alan & Kim Zimmerman
I am currently working on #3384, with the intent of ensuring that

parse (ppr (parse source)) == parse source

I have hit the issue where

   foo :: (Int)

has the parens reflected in the original parsed AST, but the types pretty
printer goes to a lot of trouble to remove any parens not required to
interpret the meaning of the type.

So the question is, should the default ppr faithfully reproduce the source
that was parsed to generate the given AST, or simplify it?

>From a round-tripping perspective I prefer the former, but there are other
use cases where the current behaviour is preferred.

If the original is preferred, it can perhaps be enabled via a flag to the
pretty printer, but before doing that I want to see if it actually matters.

Alan
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs