Re: Validate on master broken.
This was also reported as #15900. Ömer Simon Peyton Jones via ghc-devs , 16 Kas 2018 Cum, 02:33 tarihinde şunu yazdı: > > Bother -- my fault. Sorry about that. I should have > thought of Haddock. > > Thanks for fixing. > > Simon > > | -Original Message- > | From: ghc-devs On Behalf Of Alec Theriault > | Sent: 15 November 2018 21:41 > | To: Andreas Klebinger > | Cc: ghc-devs@haskell.org > | Subject: Re: Validate on master broken. > | > | Thanks for noticing! > | > | I’m fixing this right now. The changes needed are really quite mundane… > | > | -Alec > | > | > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger > | wrote: > | > > | > Hello Devs, > | > > | > it seems Simons patch "Smarter HsType pretty-print for promoted > | datacons" broke ./validate. > | > > | > > | > > | >> I discovered that there were two copies of the PromotionFlag > | >>type (a boolean, with helpfully named data cons), one in > | >>IfaceType and one in HsType. So I combined into one, > | >>PromotionFlag, and moved it to BasicTypes. > | > > | > In particular haddock seems to have depended on the changed > | constructors. > | > If anyone with access and knowledge of haddock could fix this I would > | be grateful. > | > > | > > | > Cheers > | > Andreas > | > ___ > | > ghc-devs mailing list > | > ghc-devs@haskell.org > | > > | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske > | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- > | devs&data=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 > | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537&a > | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3D&reserved=0 > | > | ___ > | ghc-devs mailing list > | ghc-devs@haskell.org > | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske > | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- > | devs&data=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 > | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537&a > | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3D&reserved=0 > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
RE: Validate on master broken.
Bother -- my fault. Sorry about that. I should have thought of Haddock. Thanks for fixing. Simon | -Original Message- | From: ghc-devs On Behalf Of Alec Theriault | Sent: 15 November 2018 21:41 | To: Andreas Klebinger | Cc: ghc-devs@haskell.org | Subject: Re: Validate on master broken. | | Thanks for noticing! | | I’m fixing this right now. The changes needed are really quite mundane… | | -Alec | | > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger | wrote: | > | > Hello Devs, | > | > it seems Simons patch "Smarter HsType pretty-print for promoted | datacons" broke ./validate. | > | > | > | >> I discovered that there were two copies of the PromotionFlag | >>type (a boolean, with helpfully named data cons), one in | >>IfaceType and one in HsType. So I combined into one, | >>PromotionFlag, and moved it to BasicTypes. | > | > In particular haddock seems to have depended on the changed | constructors. | > If anyone with access and knowledge of haddock could fix this I would | be grateful. | > | > | > Cheers | > Andreas | > ___ | > ghc-devs mailing list | > ghc-devs@haskell.org | > | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | devs&data=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537&a | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3D&reserved=0 | | ___ | ghc-devs mailing list | ghc-devs@haskell.org | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | devs&data=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537&a | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3D&reserved=0 ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Validate on master broken.
Thanks for noticing! I’m fixing this right now. The changes needed are really quite mundane… -Alec > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger > wrote: > > Hello Devs, > > it seems Simons patch "Smarter HsType pretty-print for promoted datacons" > broke ./validate. > > > >> I discovered that there were two copies of the PromotionFlag >>type (a boolean, with helpfully named data cons), one in >>IfaceType and one in HsType. So I combined into one, >>PromotionFlag, and moved it to BasicTypes. > > In particular haddock seems to have depended on the changed constructors. > If anyone with access and knowledge of haddock could fix this I would be > grateful. > > > Cheers > Andreas > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Validate on master broken.
Hello Devs, it seems Simons patch "Smarter HsType pretty-print for promoted datacons" broke ./validate. I discovered that there were two copies of the PromotionFlag type (a boolean, with helpfully named data cons), one in IfaceType and one in HsType. So I combined into one, PromotionFlag, and moved it to BasicTypes. In particular haddock seems to have depended on the changed constructors. If anyone with access and knowledge of haddock could fix this I would be grateful. Cheers Andreas ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
RE: perf stats
Moreover it takes more than 50% of the time when doing make TEST=T1535 which I do a lot Simon From: Simon Peyton Jones Sent: 15 November 2018 11:43 To: 'ghc-devs@haskell.org' Subject: perf stats This has just started happening in my local build tree Appending 0 stats to git notes. fatal: Not a git repository (or any parent up to mount point /5playpen) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). fatal: Not a git repository (or any parent up to mount point /5playpen) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). fatal: Not a git repository (or any parent up to mount point /5playpen) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). fatal: Not a git repository (or any parent up to mount point /5playpen) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). fatal: Not a git repository (or any parent up to mount point /5playpen) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). An error occured while writing the performance metrics to git notes. This is usually due to a lock-file existing somewhere in the git repo. ../../mk/test.mk:344: recipe for target 'test' failed make: *** [test] Error 1 Should I worry? it looks bad. I definitely don’t want to monkey with git notes when I’m just developing/testing/validating, which I do endlessly Simon ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
perf stats
This has just started happening in my local build tree Appending 0 stats to git notes. fatal: Not a git repository (or any parent up to mount point /5playpen) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). fatal: Not a git repository (or any parent up to mount point /5playpen) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). fatal: Not a git repository (or any parent up to mount point /5playpen) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). fatal: Not a git repository (or any parent up to mount point /5playpen) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). fatal: Not a git repository (or any parent up to mount point /5playpen) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). An error occured while writing the performance metrics to git notes. This is usually due to a lock-file existing somewhere in the git repo. ../../mk/test.mk:344: recipe for target 'test' failed make: *** [test] Error 1 Should I worry? it looks bad. I definitely don’t want to monkey with git notes when I’m just developing/testing/validating, which I do endlessly Simon ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
