Re: Processing MRs very slow?

2019-05-22 Thread Iavor Diatchki
Great thanks!  How can I have a look at Marge-bot's queue?

Perhaps it is worth updating Step 7 or 8 of
https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/fixing-bugs
to indicate that the reviewers should assign the MR to Marge-bot when
it is approved, and how one can check if that has happened.


On Wed, May 22, 2019 at 9:53 AM David Eichmann  wrote:
>
> Recently there have been some issues with CI that has slowed down
> merging. In particular a performance test (T9630) was failing on CI.
> That is fixed now and as of today Marge-Bot seems to be merging MRs
> again. I'll continue to monitor this in the coming days.
>
> Iavor, your MR was approved but not assigned to Marge-bot, and so was
> not in the merge queue. I'm not sure who has permission to do this, but
> you can always ping the approvers. In this case I've assigned to
> Marge-bot for you, and it will hopefully be merge soon.
>
> David Eichmann
>
> On 5/22/19 5:09 PM, Iavor Diatchki wrote:
> > Hello,
> >
> > I made a gitlab MR that adds two NOINLINE pragmas and some comments.
> > It's been about a week since my last push to the MR, and nothing has
> > happened since.
> >
> > Is there a way to check on what is its status:
> >- Is it stuck because I need to do something?
> >- Is it stuck because someone else needs to do something?
> >- Or is it just in the queue to be merged, in which case it would be
> > nice to know where in line it is, so I can see that there is progress,
> > and it is not just stuck.
> >
> > Given that this is such a simple MR, I am not too worried about
> > conflicts but a week long lag seems less than ideal for anything even
> > mildly complex.
> >
> > -Iavor
> >
> > PS: I just clicked on all the little check boxes from the
> > template---perhaps that's why things weren't progressing?
> > ___
> > ghc-devs mailing list
> > ghc-devs@haskell.org
> > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
> --
> David Eichmann, Haskell Consultant
> Well-Typed LLP, http://www.well-typed.com
>
> Registered in England & Wales, OC335890
> 118 Wymering Mansions, Wymering Road, London W9 2NF, England
>
> ___
> ghc-devs mailing list
> ghc-devs@haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: [hadrian/macos] build broken

2019-05-22 Thread Alp Mestanogullari

I @'d the author of that patch on your ticket.

On 22/05/2019 21:15, Shayne Fletcher wrote:

Hi Alp,

Just confirming now but it seems its 
https://gitlab.haskell.org/ghc/ghc/commit/e529c65eacf595006dd5358491d28c202d673732 where 
the breakage came in ("Remove all target specific portions of 
Config.hs" @John Ericson).


On Wed, May 22, 2019 at 1:56 PM Shayne Fletcher 
mailto:shayne.fletc...@daml.com>> wrote:


Here you go Alp https://gitlab.haskell.org/ghc/ghc/issues/16685.
Hope this helps!

On Wed, May 22, 2019 at 1:41 PM Alp Mestanogullari
mailto:a...@well-typed.com>> wrote:

Hello!

Could you create a ticket about this with all the relevant
details (OS X version, boot ghc version, commit, hadrian
command, etc), and the 'hadrian' label? You should even feel
free to mention @snowleopard and @alp there.

Cheers

On 22/05/2019 19:37, Shayne Fletcher via ghc-devs wrote:

I'm trying to isolate the commit that's causing this, but the
deal is on MacOS I'm seeing stage1 `ld` crashes linking `HStime`:
```

00x1052e2748__assert_rtn + 129

10x1052be30fld::Fixup::Fixup(unsigned int,
ld::Fixup::Cluster, ld::Fixup::Kind, bool, char const*) + 95


20x1052e8736mach_o::relocatable::Parser::addFixup(mach_o::relocatable::Parser::SourceLocation
const&, ld::Fixup::Cluster, ld::Fixup::Kind, bool, char
const*) + 34


30x1052eaa9cmach_o::relocatable::Section::addRelocFixup(mach_o::relocatable::Parser&,
macho_relocation_info > const*) + 1722


40x1052ff61bmach_o::relocatable::Section::makeFixups(mach_o::relocatable::Parser&,
mach_o::relocatable::Parser::CFI_CU_InfoArrays
const&) + 105


50x1052faa66mach_o::relocatable::Parser::parse(mach_o::relocatable::ParserOptions
const&) + 2120

60x1052f1250mach_o::relocatable::Parser::parse(unsigned
char const*, unsigned long long, char const*, long,
ld::File::Ordinal, mach_o::relocatable::ParserOptions const&)
+ 282

70x10534352ald::tool::InputFiles::makeFile(Options::FileInfo
const&, bool) + 808

80x105345f22ld::tool::InputFiles::parseWorkerThread() + 530

90x7fff70a6b2eb_pthread_body + 126

100x7fff70a6e249_pthread_start + 66

A linker snapshot was created at:

/tmp/HStime-1.9.2.o-2019-04-22-132113.ld-snapshot

ld: Assertion failed: (name != NULL), function Fixup, file
/Library/Caches/com.apple.xbs/Sources/ld64/ld64-450.3/src/ld/ld.hpp,
line 724.
```
I can replicate this on multiple machines and different
versions of xcode command line tools.

Any ideas?


-- 
Shayne Fletcher

Language Engineer
c: +1 917 699 7763
e: shayne.fletc...@daml.com 
Digital Asset Holdings, LLC
4 World Trade Center 150 Greenwich Street, 47th Floor


New York, NY 10007, USA


digitalasset.com 


This message, and any attachments, is for the intended
recipient(s) only, may contain information that is
privileged, confidential and/or proprietary and subject to
important terms and conditions available at
http://www.digitalasset.com/emaildisclaimer.html. If you are
not the intended recipient, please delete this message.

___
ghc-devs mailing list
ghc-devs@haskell.org  
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


-- 
Alp Mestanogullari, Haskell Consultant

Well-Typed LLP,https://www.well-typed.com/

Registered in England and Wales, OC335890
118 Wymering Mansions, Wymering Road, London, W9 2NF, England

___
ghc-devs mailing list
ghc-devs@haskell.org 
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs



-- 
Shayne Fletcher

Language Engineer
c: +1 917 699 7763
e: shayne.fletc...@daml.com 
Digital Asset Holdings, LLC
4 World Trade Center 150 Greenwich Street, 47th Floor


New York, NY 10007, USA


  

Re: [hadrian/macos] build broken

2019-05-22 Thread Shayne Fletcher via ghc-devs
Hi Alp,

Just confirming now but it seems its
https://gitlab.haskell.org/ghc/ghc/commit/e529c65eacf595006dd5358491d28c202d673732
where
the breakage came in ("Remove all target specific portions of Config.hs"
@John Ericson).

On Wed, May 22, 2019 at 1:56 PM Shayne Fletcher 
wrote:

> Here you go Alp https://gitlab.haskell.org/ghc/ghc/issues/16685. Hope
> this helps!
>
> On Wed, May 22, 2019 at 1:41 PM Alp Mestanogullari 
> wrote:
>
>> Hello!
>>
>> Could you create a ticket about this with all the relevant details (OS X
>> version, boot ghc version, commit, hadrian command, etc), and the 'hadrian'
>> label? You should even feel free to mention @snowleopard and @alp there.
>>
>> Cheers
>> On 22/05/2019 19:37, Shayne Fletcher via ghc-devs wrote:
>>
>> I'm trying to isolate the commit that's causing this, but the deal is on
>> MacOS I'm seeing stage1 `ld` crashes linking `HStime`:
>> ```
>>
>> 0  0x1052e2748  __assert_rtn + 129
>>
>> 1  0x1052be30f  ld::Fixup::Fixup(unsigned int, ld::Fixup::Cluster,
>> ld::Fixup::Kind, bool, char const*) + 95
>>
>> 2  0x1052e8736  
>> mach_o::relocatable::Parser::addFixup(mach_o::relocatable::Parser::SourceLocation
>> const&, ld::Fixup::Cluster, ld::Fixup::Kind, bool, char const*) + 34
>>
>> 3  0x1052eaa9c  
>> mach_o::relocatable::Section::addRelocFixup(mach_o::relocatable::Parser&,
>> macho_relocation_info > const*) + 1722
>>
>> 4  0x1052ff61b  
>> mach_o::relocatable::Section::makeFixups(mach_o::relocatable::Parser&,
>> mach_o::relocatable::Parser::CFI_CU_InfoArrays const&) + 105
>>
>> 5  0x1052faa66  
>> mach_o::relocatable::Parser::parse(mach_o::relocatable::ParserOptions
>> const&) + 2120
>>
>> 6  0x1052f1250  mach_o::relocatable::Parser::parse(unsigned char
>> const*, unsigned long long, char const*, long, ld::File::Ordinal,
>> mach_o::relocatable::ParserOptions const&) + 282
>>
>> 7  0x10534352a  ld::tool::InputFiles::makeFile(Options::FileInfo const&,
>> bool) + 808
>>
>> 8  0x105345f22  ld::tool::InputFiles::parseWorkerThread() + 530
>>
>> 9  0x7fff70a6b2eb  _pthread_body + 126
>>
>> 10  0x7fff70a6e249  _pthread_start + 66
>>
>> A linker snapshot was created at:
>>
>> /tmp/HStime-1.9.2.o-2019-04-22-132113.ld-snapshot
>>
>> ld: Assertion failed: (name != NULL), function Fixup, file
>> /Library/Caches/com.apple.xbs/Sources/ld64/ld64-450.3/src/ld/ld.hpp, line
>> 724.
>> ```
>> I can replicate this on multiple machines and different versions of xcode
>> command line tools.
>>
>> Any ideas?
>>
>> --
>> Shayne Fletcher
>> Language Engineer
>> c: +1 917 699 7763
>> e: shayne.fletc...@daml.com
>> Digital Asset Holdings, LLC
>> 4 World Trade Center150
>> Greenwich Street, 47th Floor
>> 
>> New York, NY 10007, USA
>> 
>> digitalasset.com 
>>
>>
>> This message, and any attachments, is for the intended recipient(s) only,
>> may contain information that is privileged, confidential and/or proprietary
>> and subject to important terms and conditions available at
>> http://www.digitalasset.com/emaildisclaimer.html. If you are not the
>> intended recipient, please delete this message.
>>
>> ___
>> ghc-devs mailing 
>> listghc-devs@haskell.orghttp://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>>
>> --
>> Alp Mestanogullari, Haskell Consultant
>> Well-Typed LLP, https://www.well-typed.com/
>>
>> Registered in England and Wales, OC335890
>> 118 Wymering Mansions, Wymering Road, London, W9 2NF, England
>>
>> ___
>> ghc-devs mailing list
>> ghc-devs@haskell.org
>> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>>
>
>
> --
> Shayne Fletcher
> Language Engineer
> c: +1 917 699 7763
> e: shayne.fletc...@daml.com
> Digital Asset Holdings, LLC
> 4 World Trade Center150 Greenwich
> Street, 47th Floor
> 
> New York, NY 10007, USA
> 
> digitalasset.com 
>
>

-- 
Shayne Fletcher
Language Engineer
c: +1 917 699 7763
e: shayne.fletc...@daml.com
Digital Asset Holdings, LLC
4 World Trade Center150 Greenwich
Street, 47th Floor

New York, NY 10007, USA


Re: [hadrian/macos] build broken

2019-05-22 Thread Shayne Fletcher via ghc-devs
Here you go Alp https://gitlab.haskell.org/ghc/ghc/issues/16685. Hope this
helps!

On Wed, May 22, 2019 at 1:41 PM Alp Mestanogullari 
wrote:

> Hello!
>
> Could you create a ticket about this with all the relevant details (OS X
> version, boot ghc version, commit, hadrian command, etc), and the 'hadrian'
> label? You should even feel free to mention @snowleopard and @alp there.
>
> Cheers
> On 22/05/2019 19:37, Shayne Fletcher via ghc-devs wrote:
>
> I'm trying to isolate the commit that's causing this, but the deal is on
> MacOS I'm seeing stage1 `ld` crashes linking `HStime`:
> ```
>
> 0  0x1052e2748  __assert_rtn + 129
>
> 1  0x1052be30f  ld::Fixup::Fixup(unsigned int, ld::Fixup::Cluster,
> ld::Fixup::Kind, bool, char const*) + 95
>
> 2  0x1052e8736  
> mach_o::relocatable::Parser::addFixup(mach_o::relocatable::Parser::SourceLocation
> const&, ld::Fixup::Cluster, ld::Fixup::Kind, bool, char const*) + 34
>
> 3  0x1052eaa9c  
> mach_o::relocatable::Section::addRelocFixup(mach_o::relocatable::Parser&,
> macho_relocation_info > const*) + 1722
>
> 4  0x1052ff61b  
> mach_o::relocatable::Section::makeFixups(mach_o::relocatable::Parser&,
> mach_o::relocatable::Parser::CFI_CU_InfoArrays const&) + 105
>
> 5  0x1052faa66  
> mach_o::relocatable::Parser::parse(mach_o::relocatable::ParserOptions
> const&) + 2120
>
> 6  0x1052f1250  mach_o::relocatable::Parser::parse(unsigned char
> const*, unsigned long long, char const*, long, ld::File::Ordinal,
> mach_o::relocatable::ParserOptions const&) + 282
>
> 7  0x10534352a  ld::tool::InputFiles::makeFile(Options::FileInfo const&,
> bool) + 808
>
> 8  0x105345f22  ld::tool::InputFiles::parseWorkerThread() + 530
>
> 9  0x7fff70a6b2eb  _pthread_body + 126
>
> 10  0x7fff70a6e249  _pthread_start + 66
>
> A linker snapshot was created at:
>
> /tmp/HStime-1.9.2.o-2019-04-22-132113.ld-snapshot
>
> ld: Assertion failed: (name != NULL), function Fixup, file
> /Library/Caches/com.apple.xbs/Sources/ld64/ld64-450.3/src/ld/ld.hpp, line
> 724.
> ```
> I can replicate this on multiple machines and different versions of xcode
> command line tools.
>
> Any ideas?
>
> --
> Shayne Fletcher
> Language Engineer
> c: +1 917 699 7763
> e: shayne.fletc...@daml.com
> Digital Asset Holdings, LLC
> 4 World Trade Center150 Greenwich
> Street, 47th Floor
> 
> New York, NY 10007, USA
> 
> digitalasset.com 
>
>
> This message, and any attachments, is for the intended recipient(s) only,
> may contain information that is privileged, confidential and/or proprietary
> and subject to important terms and conditions available at
> http://www.digitalasset.com/emaildisclaimer.html. If you are not the
> intended recipient, please delete this message.
>
> ___
> ghc-devs mailing 
> listghc-devs@haskell.orghttp://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
> --
> Alp Mestanogullari, Haskell Consultant
> Well-Typed LLP, https://www.well-typed.com/
>
> Registered in England and Wales, OC335890
> 118 Wymering Mansions, Wymering Road, London, W9 2NF, England
>
> ___
> ghc-devs mailing list
> ghc-devs@haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>


-- 
Shayne Fletcher
Language Engineer
c: +1 917 699 7763
e: shayne.fletc...@daml.com
Digital Asset Holdings, LLC
4 World Trade Center150 Greenwich
Street, 47th Floor

New York, NY 10007, USA

digitalasset.com 

-- 
This message, and any attachments, is for the intended recipient(s) only, 
may contain information that is privileged, confidential and/or proprietary 
and subject to important terms and conditions available at 
http://www.digitalasset.com/emaildisclaimer.html 
. If you are not the 
intended recipient, please delete this message.
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: [hadrian/windows] build broken

2019-05-22 Thread Alp Mestanogullari
Yes, I suspect so, even though I'll let David (cc'd) talk about this, as 
he's the one who's been working on this.


On 22/05/2019 19:03, Shayne Fletcher via ghc-devs wrote:

I guess,

On Wed, May 22, 2019 at 12:27 PM Shayne Fletcher 
mailto:shayne.fletc...@daml.com>> wrote:


Windows builds with hadrian are currently failing with "file does
not exist and no build rule available"
`_build/stage1/libffi/build/inst/bin/libffi-6.dll`. Anybody have
an ideas on how to overcome that?


relates to 0af519ac583c3544b1c4b1315b38ba0174d3ccb1, "Refactor libffi 
and RTS rules" (@DavidEichmann).


I get the feeling that the current state of affairs is known and there 
are MRs working their way through the system to restore things already?

--
Shayne Fletcher
Language Engineer
c: +1 917 699 7763
e: shayne.fletc...@daml.com 
Digital Asset Holdings, LLC
4 World Trade Center 150 Greenwich Street, 47th Floor 

New York, NY 10007, USA 


digitalasset.com 


This message, and any attachments, is for the intended recipient(s) 
only, may contain information that is privileged, confidential and/or 
proprietary and subject to important terms and conditions available at 
http://www.digitalasset.com/emaildisclaimer.html 
. If you are not the 
intended recipient, please delete this message.


___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


--
Alp Mestanogullari, Haskell Consultant
Well-Typed LLP, https://www.well-typed.com/

Registered in England and Wales, OC335890
118 Wymering Mansions, Wymering Road, London, W9 2NF, England

___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: [hadrian/macos] build broken

2019-05-22 Thread Alp Mestanogullari

Hello!

Could you create a ticket about this with all the relevant details (OS X 
version, boot ghc version, commit, hadrian command, etc), and the 
'hadrian' label? You should even feel free to mention @snowleopard and 
@alp there.


Cheers

On 22/05/2019 19:37, Shayne Fletcher via ghc-devs wrote:
I'm trying to isolate the commit that's causing this, but the deal is 
on MacOS I'm seeing stage1 `ld` crashes linking `HStime`:

```

00x1052e2748__assert_rtn + 129

10x1052be30fld::Fixup::Fixup(unsigned int, ld::Fixup::Cluster, 
ld::Fixup::Kind, bool, char const*) + 95


20x1052e8736mach_o::relocatable::Parser::addFixup(mach_o::relocatable::Parser::SourceLocation 
const&, ld::Fixup::Cluster, ld::Fixup::Kind, bool, char const*) + 34


30x1052eaa9cmach_o::relocatable::Section::addRelocFixup(mach_o::relocatable::Parser&, 
macho_relocation_info > const*) + 1722


40x1052ff61bmach_o::relocatable::Section::makeFixups(mach_o::relocatable::Parser&, 
mach_o::relocatable::Parser::CFI_CU_InfoArrays const&) + 105


50x1052faa66mach_o::relocatable::Parser::parse(mach_o::relocatable::ParserOptions 
const&) + 2120


60x1052f1250mach_o::relocatable::Parser::parse(unsigned char 
const*, unsigned long long, char const*, long, ld::File::Ordinal, 
mach_o::relocatable::ParserOptions const&) + 282


70x10534352ald::tool::InputFiles::makeFile(Options::FileInfo const&, 
bool) + 808


80x105345f22ld::tool::InputFiles::parseWorkerThread() + 530

90x7fff70a6b2eb_pthread_body + 126

100x7fff70a6e249_pthread_start + 66

A linker snapshot was created at:

/tmp/HStime-1.9.2.o-2019-04-22-132113.ld-snapshot

ld: Assertion failed: (name != NULL), function Fixup, file 
/Library/Caches/com.apple.xbs/Sources/ld64/ld64-450.3/src/ld/ld.hpp, 
line 724.

```
I can replicate this on multiple machines and different versions of 
xcode command line tools.


Any ideas?


--
Shayne Fletcher
Language Engineer
c: +1 917 699 7763
e: shayne.fletc...@daml.com 
Digital Asset Holdings, LLC
4 World Trade Center 150 Greenwich Street, 47th Floor 

New York, NY 10007, USA 


digitalasset.com 


This message, and any attachments, is for the intended recipient(s) 
only, may contain information that is privileged, confidential and/or 
proprietary and subject to important terms and conditions available at 
http://www.digitalasset.com/emaildisclaimer.html 
. If you are not the 
intended recipient, please delete this message.


___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


--
Alp Mestanogullari, Haskell Consultant
Well-Typed LLP, https://www.well-typed.com/

Registered in England and Wales, OC335890
118 Wymering Mansions, Wymering Road, London, W9 2NF, England

___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


[hadrian/macos] build broken

2019-05-22 Thread Shayne Fletcher via ghc-devs
I'm trying to isolate the commit that's causing this, but the deal is on
MacOS I'm seeing stage1 `ld` crashes linking `HStime`:
```

0  0x1052e2748  __assert_rtn + 129

1  0x1052be30f  ld::Fixup::Fixup(unsigned int, ld::Fixup::Cluster,
ld::Fixup::Kind, bool, char const*) + 95

2  0x1052e8736
mach_o::relocatable::Parser::addFixup(mach_o::relocatable::Parser::SourceLocation
const&, ld::Fixup::Cluster, ld::Fixup::Kind, bool, char const*) + 34

3  0x1052eaa9c
mach_o::relocatable::Section::addRelocFixup(mach_o::relocatable::Parser&,
macho_relocation_info > const*) + 1722

4  0x1052ff61b
mach_o::relocatable::Section::makeFixups(mach_o::relocatable::Parser&,
mach_o::relocatable::Parser::CFI_CU_InfoArrays const&) + 105

5  0x1052faa66
mach_o::relocatable::Parser::parse(mach_o::relocatable::ParserOptions
const&) + 2120

6  0x1052f1250  mach_o::relocatable::Parser::parse(unsigned char
const*, unsigned long long, char const*, long, ld::File::Ordinal,
mach_o::relocatable::ParserOptions const&) + 282

7  0x10534352a  ld::tool::InputFiles::makeFile(Options::FileInfo const&,
bool) + 808

8  0x105345f22  ld::tool::InputFiles::parseWorkerThread() + 530

9  0x7fff70a6b2eb  _pthread_body + 126

10  0x7fff70a6e249  _pthread_start + 66

A linker snapshot was created at:

/tmp/HStime-1.9.2.o-2019-04-22-132113.ld-snapshot

ld: Assertion failed: (name != NULL), function Fixup, file
/Library/Caches/com.apple.xbs/Sources/ld64/ld64-450.3/src/ld/ld.hpp, line
724.
```
I can replicate this on multiple machines and different versions of xcode
command line tools.

Any ideas?

-- 
Shayne Fletcher
Language Engineer
c: +1 917 699 7763
e: shayne.fletc...@daml.com
Digital Asset Holdings, LLC
4 World Trade Center150 Greenwich
Street, 47th Floor

New York, NY 10007, USA

digitalasset.com 

-- 
This message, and any attachments, is for the intended recipient(s) only, 
may contain information that is privileged, confidential and/or proprietary 
and subject to important terms and conditions available at 
http://www.digitalasset.com/emaildisclaimer.html 
. If you are not the 
intended recipient, please delete this message.
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: [hadrian/windows] build broken

2019-05-22 Thread Shayne Fletcher via ghc-devs
I guess,

On Wed, May 22, 2019 at 12:27 PM Shayne Fletcher 
wrote:

> Windows builds with hadrian are currently failing with "file does not
> exist and no build rule available"
> `_build/stage1/libffi/build/inst/bin/libffi-6.dll`. Anybody have an ideas
> on how to overcome that?
>
>
relates to 0af519ac583c3544b1c4b1315b38ba0174d3ccb1, "Refactor libffi and
RTS rules" (@DavidEichmann).

I get the feeling that the current state of affairs is known and there are
MRs working their way through the system to restore things already?

-- 
Shayne Fletcher
Language Engineer
c: +1 917 699 7763
e: shayne.fletc...@daml.com
Digital Asset Holdings, LLC
4 World Trade Center150 Greenwich
Street, 47th Floor

New York, NY 10007, USA

digitalasset.com 

-- 
This message, and any attachments, is for the intended recipient(s) only, 
may contain information that is privileged, confidential and/or proprietary 
and subject to important terms and conditions available at 
http://www.digitalasset.com/emaildisclaimer.html 
. If you are not the 
intended recipient, please delete this message.
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Bug or feature?

2019-05-22 Thread Iavor Diatchki
OK, I made #16684 to track the issue:
https://gitlab.haskell.org/ghc/ghc/issues/16684

Perhaps we should continue the discussion over there.

-Iavor

On Tue, May 21, 2019 at 10:18 PM Nicolas Frisby
 wrote:
>
> I'd be happy to raise a ticket, but it might take a few days -- work trip.
>
> On Tue, May 21, 2019, 01:55 Simon Peyton Jones  wrote:
>>
>> We have to be careful in how we define "equality" in the above sentence, 
>> including class constraints that (may) have superclass equality constraints.
>>
>>
>>
>> Indeed. That’s what happens now.
>>
>>
>>
>> I do think this would work.
>>
>>
>>
>> Cool.  Nick or Iavor: would you like to turn this conversation into a ticket?
>>
>>
>>
>> (Although it is technically user-facing, it is a very small corner and I’m 
>> not sure it would need a GHC proposal – others may want to comment.)
>>
>>
>>
>> Simon
>>
>>
>>
>> From: Richard Eisenberg 
>> Sent: 21 May 2019 09:43
>> To: Simon Peyton Jones 
>> Cc: Nicolas Frisby ; Iavor Diatchki 
>> ; ghc-devs@haskell.org; Ryan Scott 
>> 
>> Subject: Re: Bug or feature?
>>
>>
>>
>>
>>
>>
>>
>> On May 21, 2019, at 10:23 AM, Simon Peyton Jones via ghc-devs 
>>  wrote:
>>
>>
>>
>> But (A) looks sound to me.
>>
>>
>>
>> I like (A). (B) makes me nervous, too.
>>
>>
>>
>> > A. An implication is considered to “bind local equalities” iff it has at 
>> > least one given equality whose free variables are not all bound by the 
>> > same implication.
>>
>>
>>
>> We have to be careful in how we define "equality" in the above sentence, 
>> including class constraints that (may) have superclass equality constraints. 
>> I do think this would work.
>>
>>
>>
>> Richard
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Processing MRs very slow?

2019-05-22 Thread David Eichmann
Recently there have been some issues with CI that has slowed down 
merging. In particular a performance test (T9630) was failing on CI. 
That is fixed now and as of today Marge-Bot seems to be merging MRs 
again. I'll continue to monitor this in the coming days.


Iavor, your MR was approved but not assigned to Marge-bot, and so was 
not in the merge queue. I'm not sure who has permission to do this, but 
you can always ping the approvers. In this case I've assigned to 
Marge-bot for you, and it will hopefully be merge soon.


David Eichmann

On 5/22/19 5:09 PM, Iavor Diatchki wrote:

Hello,

I made a gitlab MR that adds two NOINLINE pragmas and some comments.
It's been about a week since my last push to the MR, and nothing has
happened since.

Is there a way to check on what is its status:
   - Is it stuck because I need to do something?
   - Is it stuck because someone else needs to do something?
   - Or is it just in the queue to be merged, in which case it would be
nice to know where in line it is, so I can see that there is progress,
and it is not just stuck.

Given that this is such a simple MR, I am not too worried about
conflicts but a week long lag seems less than ideal for anything even
mildly complex.

-Iavor

PS: I just clicked on all the little check boxes from the
template---perhaps that's why things weren't progressing?
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


--
David Eichmann, Haskell Consultant
Well-Typed LLP, http://www.well-typed.com

Registered in England & Wales, OC335890
118 Wymering Mansions, Wymering Road, London W9 2NF, England

___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


[hadrian/windows] build broken

2019-05-22 Thread Shayne Fletcher via ghc-devs
Windows builds with hadrian are currently failing with "file does not exist
and no build rule available"
`_build/stage1/libffi/build/inst/bin/libffi-6.dll`. Anybody have an ideas
on how to overcome that?

-- 
Shayne Fletcher
Language Engineer
c: +1 917 699 7763
e: shayne.fletc...@daml.com
Digital Asset Holdings, LLC
4 World Trade Center150 Greenwich
Street, 47th Floor

New York, NY 10007, USA

digitalasset.com 

-- 
This message, and any attachments, is for the intended recipient(s) only, 
may contain information that is privileged, confidential and/or proprietary 
and subject to important terms and conditions available at 
http://www.digitalasset.com/emaildisclaimer.html 
. If you are not the 
intended recipient, please delete this message.
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: Processing MRs very slow?

2019-05-22 Thread Alexandre Rodrigues
The same has happened to an MR I submitted, 713. I believe it is because this 
kind of contributions have low priority, and maintainers already have their 
hands full.






From: ghc-devs  on behalf of Iavor Diatchki 

Sent: Wednesday, May 22, 2019 5:09:13 PM
To: ghc-devs
Subject: Processing MRs very slow?

Hello,

I made a gitlab MR that adds two NOINLINE pragmas and some comments.
It's been about a week since my last push to the MR, and nothing has
happened since.

Is there a way to check on what is its status:
  - Is it stuck because I need to do something?
  - Is it stuck because someone else needs to do something?
  - Or is it just in the queue to be merged, in which case it would be
nice to know where in line it is, so I can see that there is progress,
and it is not just stuck.

Given that this is such a simple MR, I am not too worried about
conflicts but a week long lag seems less than ideal for anything even
mildly complex.

-Iavor

PS: I just clicked on all the little check boxes from the
template---perhaps that's why things weren't progressing?
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Processing MRs very slow?

2019-05-22 Thread Iavor Diatchki
Hello,

I made a gitlab MR that adds two NOINLINE pragmas and some comments.
It's been about a week since my last push to the MR, and nothing has
happened since.

Is there a way to check on what is its status:
  - Is it stuck because I need to do something?
  - Is it stuck because someone else needs to do something?
  - Or is it just in the queue to be merged, in which case it would be
nice to know where in line it is, so I can see that there is progress,
and it is not just stuck.

Given that this is such a simple MR, I am not too worried about
conflicts but a week long lag seems less than ideal for anything even
mildly complex.

-Iavor

PS: I just clicked on all the little check boxes from the
template---perhaps that's why things weren't progressing?
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs