RE: FW: [commit: ghc] tc-arrows: Rearrange the typechecking of arrows, especially arrow forms (49badc9)

2013-03-04 Thread Simon Peyton-Jones
Ross

Excellent.  We have moved forward nicely on the arrows front.

I have pushed the refactoring to typechecking arrows that we did together.  
Remaining:

* You missed one test failure: 
   ghci/scripts   T5045 [bad stderr] (ghci)
  I'm sure that just looking at the source code will tell you why
  it no longer typechecks, and the fix will be simple.  

  Could you spare a moment to fix this soon?  At the moment it'll make
  validate fail. I could open a ticket and make it expect_broken, but
  it'd be less of a hassle to fix it immediately.  5 min job.

The remaining open tickets I know about are:
 * #5267
 * #5777
 * #5333
 * #344

Might you look at them?

Thanks

Simon

| -Original Message-
| From: Ross Paterson [mailto:r...@soi.city.ac.uk]
| Sent: 19 February 2013 13:41
| To: Simon Peyton-Jones
| Cc: ghc-devs@haskell.org
| Subject: Re: FW: [commit: ghc] tc-arrows: Rearrange the typechecking of
| arrows, especially arrow forms (49badc9)
| 
| On Thu, Feb 14, 2013 at 05:40:51PM +, Simon Peyton-Jones wrote:
|  I've pushed a new branch, tc-arrows, for the new typechecking of
| arrows, based on the discussion we had last week.
| 
|  It all compiles, but won't work because I have done nothing to the
| desugaring.
| 
|  It uses our new representation with (env,
|  nested-tuple-with-unit-at-end) rather than (nested-tuple-with-env-at-
| the-end), so desugaring needs significant attention.
| 
| I think it's done.  All but 4 of the tests pass:
| - I have new versions of arrowform1 and T5283 that pass.
| - The type error message for T5380 has changed.
| - The gimmick used by arrowapply4 is incompatible with the new
| representation,
|   so this test should be dropped.

___
ghc-devs mailing list
ghc-devs@haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs


Re: FW: [commit: ghc] tc-arrows: Rearrange the typechecking of arrows, especially arrow forms (49badc9)

2013-02-19 Thread Ross Paterson
On Thu, Feb 14, 2013 at 05:40:51PM +, Simon Peyton-Jones wrote:
 I've pushed a new branch, tc-arrows, for the new typechecking of arrows, 
 based on the discussion we had last week.
 
 It all compiles, but won't work because I have done nothing to the 
 desugaring.  
 
 It uses our new representation with (env, nested-tuple-with-unit-at-end)
 rather than (nested-tuple-with-env-at-the-end), so desugaring needs 
 significant attention.

I think it's done.  All but 4 of the tests pass:
- I have new versions of arrowform1 and T5283 that pass.
- The type error message for T5380 has changed.
- The gimmick used by arrowapply4 is incompatible with the new representation,
  so this test should be dropped.

___
ghc-devs mailing list
ghc-devs@haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs