Re: Phabricator diffs not viewable by non-logged in users

[Austin Seipp]

The error message was fairly self explanatory: it mentions the restriction
was on the Build Plan object, not the Differential revision (if you view it
in private/incognito mode). In Phabricator, various objects can have their
own policies. Objects can be attached to others, like builds to diffs.
Diffs had been set to be public on creation, but for some reason, all the
Harbormaster build plans required 'All Users' to view them, which requires
a login.

I've fixed this by changing all the build plans to be public, which they
should have been in the first place.

On Thu, Sep 1, 2016 at 12:30 AM, Ben Gamari  wrote:

> "Edward Z. Yang"  writes:
>
> > For example, if I am not logged in (try an incognito/private
> > browsing session), https://phabricator.haskell.org/D2501 reports
> > an error.
> >
> Indeed I had noticed this as well and it has been on my list of things
> to look in to. I agree that you shouldn't need to be logged in to view
> differentials.
>
> Austin, do you have any idea why this is the case?
>
> Cheers,
>
> - Ben
>
>


-- 
Regards,

Austin Seipp, Haskell Consultant
Well-Typed LLP, http://www.well-typed.com/
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Re: Phabricator diffs not viewable by non-logged in users

[Ben Gamari]

"Edward Z. Yang"  writes:

> For example, if I am not logged in (try an incognito/private
> browsing session), https://phabricator.haskell.org/D2501 reports
> an error.
>
Indeed I had noticed this as well and it has been on my list of things
to look in to. I agree that you shouldn't need to be logged in to view
differentials.

Austin, do you have any idea why this is the case?

Cheers,

- Ben



signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Phabricator diffs not viewable by non-logged in users

[Edward Z. Yang]

For example, if I am not logged in (try an incognito/private
browsing session), https://phabricator.haskell.org/D2501 reports
an error.

Is this intentional? Seems poor, and also the diff is labeled as Public
in the UI. I found this quite surprising.

Edward
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs