Re: Validate on master broken.
I reported the exact error in https://ghc.haskell.org/trac/ghc/ticket/15898#comment:3. On 16/11/2018 11:28, Ömer Sinan Ağacan wrote: 4efd1b487e fixed the build but the test T15898 now fails when run in ghci way. Ömer Ömer Sinan Ağacan , 16 Kas 2018 Cum, 07:39 tarihinde şunu yazdı: This was also reported as #15900. Ömer Simon Peyton Jones via ghc-devs , 16 Kas 2018 Cum, 02:33 tarihinde şunu yazdı: Bother -- my fault. Sorry about that. I should have thought of Haddock. Thanks for fixing. Simon | -Original Message- | From: ghc-devs On Behalf Of Alec Theriault | Sent: 15 November 2018 21:41 | To: Andreas Klebinger | Cc: ghc-devs@haskell.org | Subject: Re: Validate on master broken. | | Thanks for noticing! | | I’m fixing this right now. The changes needed are really quite mundane… | | -Alec | | > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger | wrote: | > | > Hello Devs, | > | > it seems Simons patch "Smarter HsType pretty-print for promoted | datacons" broke ./validate. | > | > | > | >> I discovered that there were two copies of the PromotionFlag | >>type (a boolean, with helpfully named data cons), one in | >>IfaceType and one in HsType. So I combined into one, | >>PromotionFlag, and moved it to BasicTypes. | > | > In particular haddock seems to have depended on the changed | constructors. | > If anyone with access and knowledge of haddock could fix this I would | be grateful. | > | > | > Cheers | > Andreas | > ___ | > ghc-devs mailing list | > ghc-devs@haskell.org | > | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | devsdata=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537 | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3Dreserved=0 | | ___ | ghc-devs mailing list | ghc-devs@haskell.org | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | devsdata=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537 | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3Dreserved=0 ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs -- Alp Mestanogullari, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/ Registered in England and Wales, OC335890 118 Wymering Mansions, Wymering Road, London, W9 2NF, England ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Validate on master broken.
4efd1b487e fixed the build but the test T15898 now fails when run in ghci way. Ömer Ömer Sinan Ağacan , 16 Kas 2018 Cum, 07:39 tarihinde şunu yazdı: > > This was also reported as #15900. > > Ömer > > Simon Peyton Jones via ghc-devs , 16 Kas 2018 > Cum, 02:33 tarihinde şunu yazdı: > > > > Bother -- my fault. Sorry about that. I should have > > thought of Haddock. > > > > Thanks for fixing. > > > > Simon > > > > | -Original Message- > > | From: ghc-devs On Behalf Of Alec Theriault > > | Sent: 15 November 2018 21:41 > > | To: Andreas Klebinger > > | Cc: ghc-devs@haskell.org > > | Subject: Re: Validate on master broken. > > | > > | Thanks for noticing! > > | > > | I’m fixing this right now. The changes needed are really quite mundane… > > | > > | -Alec > > | > > | > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger > > | wrote: > > | > > > | > Hello Devs, > > | > > > | > it seems Simons patch "Smarter HsType pretty-print for promoted > > | datacons" broke ./validate. > > | > > > | > > > | > > > | >> I discovered that there were two copies of the PromotionFlag > > | >>type (a boolean, with helpfully named data cons), one in > > | >>IfaceType and one in HsType. So I combined into one, > > | >>PromotionFlag, and moved it to BasicTypes. > > | > > > | > In particular haddock seems to have depended on the changed > > | constructors. > > | > If anyone with access and knowledge of haddock could fix this I would > > | be grateful. > > | > > > | > > > | > Cheers > > | > Andreas > > | > ___ > > | > ghc-devs mailing list > > | > ghc-devs@haskell.org > > | > > > | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske > > | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- > > | devsdata=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 > > | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537 > > | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3Dreserved=0 > > | > > | ___ > > | ghc-devs mailing list > > | ghc-devs@haskell.org > > | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske > > | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- > > | devsdata=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 > > | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537 > > | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3Dreserved=0 > > ___ > > ghc-devs mailing list > > ghc-devs@haskell.org > > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Validate on master broken.
This was also reported as #15900. Ömer Simon Peyton Jones via ghc-devs , 16 Kas 2018 Cum, 02:33 tarihinde şunu yazdı: > > Bother -- my fault. Sorry about that. I should have > thought of Haddock. > > Thanks for fixing. > > Simon > > | -Original Message- > | From: ghc-devs On Behalf Of Alec Theriault > | Sent: 15 November 2018 21:41 > | To: Andreas Klebinger > | Cc: ghc-devs@haskell.org > | Subject: Re: Validate on master broken. > | > | Thanks for noticing! > | > | I’m fixing this right now. The changes needed are really quite mundane… > | > | -Alec > | > | > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger > | wrote: > | > > | > Hello Devs, > | > > | > it seems Simons patch "Smarter HsType pretty-print for promoted > | datacons" broke ./validate. > | > > | > > | > > | >> I discovered that there were two copies of the PromotionFlag > | >>type (a boolean, with helpfully named data cons), one in > | >>IfaceType and one in HsType. So I combined into one, > | >>PromotionFlag, and moved it to BasicTypes. > | > > | > In particular haddock seems to have depended on the changed > | constructors. > | > If anyone with access and knowledge of haddock could fix this I would > | be grateful. > | > > | > > | > Cheers > | > Andreas > | > ___ > | > ghc-devs mailing list > | > ghc-devs@haskell.org > | > > | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske > | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- > | devsdata=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 > | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537 > | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3Dreserved=0 > | > | ___ > | ghc-devs mailing list > | ghc-devs@haskell.org > | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske > | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- > | devsdata=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 > | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537 > | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3Dreserved=0 > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
RE: Validate on master broken.
Bother -- my fault. Sorry about that. I should have thought of Haddock. Thanks for fixing. Simon | -Original Message- | From: ghc-devs On Behalf Of Alec Theriault | Sent: 15 November 2018 21:41 | To: Andreas Klebinger | Cc: ghc-devs@haskell.org | Subject: Re: Validate on master broken. | | Thanks for noticing! | | I’m fixing this right now. The changes needed are really quite mundane… | | -Alec | | > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger | wrote: | > | > Hello Devs, | > | > it seems Simons patch "Smarter HsType pretty-print for promoted | datacons" broke ./validate. | > | > | > | >> I discovered that there were two copies of the PromotionFlag | >>type (a boolean, with helpfully named data cons), one in | >>IfaceType and one in HsType. So I combined into one, | >>PromotionFlag, and moved it to BasicTypes. | > | > In particular haddock seems to have depended on the changed | constructors. | > If anyone with access and knowledge of haddock could fix this I would | be grateful. | > | > | > Cheers | > Andreas | > ___ | > ghc-devs mailing list | > ghc-devs@haskell.org | > | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | devsdata=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537 | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3Dreserved=0 | | ___ | ghc-devs mailing list | ghc-devs@haskell.org | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | devsdata=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6 | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537 | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3Dreserved=0 ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: Validate on master broken.
Thanks for noticing! I’m fixing this right now. The changes needed are really quite mundane… -Alec > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger > wrote: > > Hello Devs, > > it seems Simons patch "Smarter HsType pretty-print for promoted datacons" > broke ./validate. > > > >> I discovered that there were two copies of the PromotionFlag >>type (a boolean, with helpfully named data cons), one in >>IfaceType and one in HsType. So I combined into one, >>PromotionFlag, and moved it to BasicTypes. > > In particular haddock seems to have depended on the changed constructors. > If anyone with access and knowledge of haddock could fix this I would be > grateful. > > > Cheers > Andreas > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Validate on master broken.
Hello Devs, it seems Simons patch "Smarter HsType pretty-print for promoted datacons" broke ./validate. I discovered that there were two copies of the PromotionFlag type (a boolean, with helpfully named data cons), one in IfaceType and one in HsType. So I combined into one, PromotionFlag, and moved it to BasicTypes. In particular haddock seems to have depended on the changed constructors. If anyone with access and knowledge of haddock could fix this I would be grateful. Cheers Andreas ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
