Re: Warning about glomming

2022-04-07 Thread ÉRDI Gergő

On Thu, 7 Apr 2022, Simon Peyton Jones wrote:


Gergo might you offer a patch?


https://gitlab.haskell.org/ghc/ghc/-/merge_requests/7964
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Warning about glomming

2022-04-07 Thread Simon Peyton Jones
It's a warning directed solely at compiler authors (hence -DDEBUG).  If a
lot of glomming is happening, it might be due to some scoping or dependency
analysis bug -- e.g. perhaps OccAnal isn't putting bindings in proper
dependency order, or perhaps some plugin is gratuitously scrambling the
order of the top level definitions.   Or it might be legitimate, as in your
case.

Perhaps adding a Note with the code that generates the warning (or wherever
you looked -- where was that?) would be better.  I always like to look for
ways to reply not just to Gergo but to all the future Gergos who stumble
over this.

Gergo might you offer a patch?

Simon

On Thu, 7 Apr 2022 at 07:47, Gergő Érdi  wrote:

> Using -DDEBUG, I see a warning about glomming from OccurAnal. Having
> read the relevant Note, the situation is exactly what's described
> here: since I'm using cross-module specializations, the specializer
> will generate rewrite rules that replace external references with
> local forward references.
>
> But the one thing the Note doesn't explicitly state is why this is
> reported as a warning. It sounds like OccurAnal is well equipped to
> fix this problem. So is glomming a sign of a problem or is it not? If
> I see that warning, does that point to a problem in how I use the GHC
> API, a problem in the code that I'm trying to compile, or neither?
> ___
> ghc-devs mailing list
> ghc-devs@haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Warning about glomming

2022-04-07 Thread Gergő Érdi
Using -DDEBUG, I see a warning about glomming from OccurAnal. Having
read the relevant Note, the situation is exactly what's described
here: since I'm using cross-module specializations, the specializer
will generate rewrite rules that replace external references with
local forward references.

But the one thing the Note doesn't explicitly state is why this is
reported as a warning. It sounds like OccurAnal is well equipped to
fix this problem. So is glomming a sign of a problem or is it not? If
I see that warning, does that point to a problem in how I use the GHC
API, a problem in the code that I'm trying to compile, or neither?
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs