Re: any luck using "retrie" refactoring tool on GHC sources?

2022-01-24 Thread Norman Ramsey
 > > I'm trying to use the retrie refactoring tool..
 > >
 > For what it's worth, Norman has reported this issue upstream as
 > https://github.com/facebookincubator/retrie/issues/41

Turns out the tool wants `=` in the rule, not `==`.

And if you have a ' in your function name, the tool barfs because it
launches a `grep` command without escaping the ' properly to the
shell.  I have pushed a fix at
https://github.com/facebookincubator/retrie/pull/43.


Norman

___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: any luck using "retrie" refactoring tool on GHC sources?

2022-01-24 Thread Ben Gamari
Norman Ramsey  writes:

> I'm trying to use the retrie refactoring tool, but I'm getting a
> mysterious error message: 
>
> nr@homedog ~/a/g/compiler [1]> retrie --adhoc "forall x . not 
> (backendNeedn'tLink x) == backendNeedsLink x"
>
> parseAdhocs:1:80: error: parse error on input ‘#-}’
> retrie: user error (parse failed)
>
> The Tool was installed using cabal install; its github page is
> https://github.com/facebookincubator/retrie/#readme.  
>
> Has anybody had any success using this tool on the GHC sources?
> I'd love a workaround, or just advice.
>
For what it's worth, Norman has reported this issue upstream as
https://github.com/facebookincubator/retrie/issues/41

Cheers,

- Ben


signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


any luck using "retrie" refactoring tool on GHC sources?

2022-01-23 Thread Norman Ramsey
I'm trying to use the retrie refactoring tool, but I'm getting a
mysterious error message: 

nr@homedog ~/a/g/compiler [1]> retrie --adhoc "forall x . not 
(backendNeedn'tLink x) == backendNeedsLink x"

parseAdhocs:1:80: error: parse error on input ‘#-}’
retrie: user error (parse failed)

The Tool was installed using cabal install; its github page is
https://github.com/facebookincubator/retrie/#readme.  

Has anybody had any success using this tool on the GHC sources?
I'd love a workaround, or just advice.


Norman

___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs