Re: [Gimp-developer] ACO and CSS palette importing (patch attached)
Thanks, that patch looks generally fine, also coding style wise, however: gimppalette-load.c: In function ‘gimp_palette_load_aco’: gimppalette-load.c:440: warning: unused variable ‘color_bytes’ gimppalette-load.c:598:28: warning: unknown escape sequence '\)' gimppalette-load.c: In function ‘gimp_palette_load_css’: gimppalette-load.c:593: warning: unused variable ‘status’ gimppalette-load.c:592: warning: unused variable ‘format2_preamble’ gimppalette-load.c:591: warning: unused variable ‘color_info’ gimppalette-load.c:590: warning: unused variable ‘header’ gimppalette-load.c:589: warning: unused variable ‘i’ gimppalette-load.c:588: warning: unused variable ‘number_of_colors’ gimppalette-load.c:587: warning: unused variable ‘format_version’ gimppalette-load.c:586: warning: unused variable ‘color_bytes’ gimppalette-load.c: In function ‘gimp_palette_load_detect_format’: gimppalette-load.c:679: warning: ISO C90 forbids mixed declarations and code Please fix these warnings and attach the updated patch to bugzilla. This way it won't get lost. The patch can unfortunately not be included in 2.4 because we are too close to a release, and we don't depend on a glib version that has GRegex yet. I'll look into applying it after the 2.4 release so it will be in 2.6. thanks, --mitch On Sat, 2007-08-04 at 19:45 +0100, Nicola Archibald wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi All, > > Attached is a patch, against svn, which adds ACO importing, and CSS > color extraction, for the palette system. > > The ACO code only reads the version 1 section at the moment, I plan on > finishing the version 2 support to extract color names a little later. > Color spaces supported are RGB, CMYK, HSV and greyscale, but not Lab. > > The CSS import extracts colors defined in a .css file. > > > If this patch meets the standards, perhaps someone would like to > incorporate it into the repository. > > This patch would, I believe, enable the closing of Bug #316618 ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] ANNOUNCE: GIMP 2.3.19 development release
On Thursday 26 July 2007, Nemes Ioan Sorin wrote: > > It took us long enough to get 2.4 done. I don't worry too much about > > adoption at this point. Sooner or later everyone will update. > > Btw, about adoption > > Gimp became more and more important - 2.4 is long awaited - interested > peoples will upgrade to 7.10 even only for Gimp 2.4 (if is a library > problem) - I AM USING GUTSY FOR Gimp 2.3.18 (and 2.3.19 now). > > > Feisty is not going to include GIMP 2.4 anyway. If we manage to release > > soon, then 2.4 will be in the next Ubuntu release though. And that > > release is likely going to use GTK+ 2.12 anyway. > > Gutsy already use GTK 2.11.6 and 2.3.18 work very well on Gutsy - not a > single crash (and I use Gimp very intensive). Quick starting point for 2.3.19 on Feisty: 1.) download gtk latest 2.) Compile it, with a prefix of something out of the way, like --prefix=/opt/gtk, make, make install 3.) export your PKG_INSTALL_PATH (wrong spelling) to find the .pc file under /opt/gtk/bin something 4.) configure gimp 2.3.19 and it will find it. I had no idea how to do this, and I figured it out. Not rocket science. ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] ACO and CSS palette importing (patch attached)
[resending, apparently the firts try didn't make it...] Thanks, that patch looks generally fine, also coding style wise, however: gimppalette-load.c: In function ‘gimp_palette_load_aco’: gimppalette-load.c:440: warning: unused variable ‘color_bytes’ gimppalette-load.c:598:28: warning: unknown escape sequence '\)' gimppalette-load.c: In function ‘gimp_palette_load_css’: gimppalette-load.c:593: warning: unused variable ‘status’ gimppalette-load.c:592: warning: unused variable ‘format2_preamble’ gimppalette-load.c:591: warning: unused variable ‘color_info’ gimppalette-load.c:590: warning: unused variable ‘header’ gimppalette-load.c:589: warning: unused variable ‘i’ gimppalette-load.c:588: warning: unused variable ‘number_of_colors’ gimppalette-load.c:587: warning: unused variable ‘format_version’ gimppalette-load.c:586: warning: unused variable ‘color_bytes’ gimppalette-load.c: In function ‘gimp_palette_load_detect_format’: gimppalette-load.c:679: warning: ISO C90 forbids mixed declarations and code Please fix these warnings and attach the updated patch to bugzilla. This way it won't get lost. The patch can unfortunately not be included in 2.4 because we are too close to a release, and we don't depend on a glib version that has GRegex yet. I'll look into applying it after the 2.4 release so it will be in 2.6. thanks, --mitch On Sat, 2007-08-04 at 19:45 +0100, Nicola Archibald wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi All, > > Attached is a patch, against svn, which adds ACO importing, and CSS > color extraction, for the palette system. > > The ACO code only reads the version 1 section at the moment, I plan on > finishing the version 2 support to extract color names a little later. > Color spaces supported are RGB, CMYK, HSV and greyscale, but not Lab. > > The CSS import extracts colors defined in a .css file. > > > If this patch meets the standards, perhaps someone would like to > incorporate it into the repository. > > This patch would, I believe, enable the closing of Bug #316618 ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Downscaling quality.
Sven Neumann wrote: > Hi, > > On Mon, 2007-08-06 at 13:27 -0300, Guillermo Espertino wrote: > > >> You're absolutely right. This discussion is pointless. If you suggest >> that a script for scaling down in several steps is a valid solution you >> know as much about image manipulation as I do about coding. So don't >> waste each other's time. >> I'd be happy if you choose to listen to the users, even if they can't >> make a patch. But since the first time I was here, I see the same: every >> suggestion a user makes, you almost call him stupid. >> > > First of all, I didn't call you or anyone else stupid. Second, this is a > developer list. If you want to make a user suggestion without going into > implementation details, then please use the gimp-user mailing-list for > that. > > The point you raised is handled in our bug-tracker and it was high on > the priority list for 2.4. Unfortunately it has not been resolved yet. > As a member of the gimp-developer list, I expect you to know that. > There is not much point in bringing it up again since that is not likely > going to help. That's why I call this a pointless discussion for the > developer list. > > > Sven > > > ___ > Gimp-developer mailing list > Gimp-developer@lists.XCF.Berkeley.EDU > https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer > > > I can't seem to find the associated bug. Does anybody know which is the bug report? I've got a test version (for scale-funcs.c) that scales down in reducing the image 1/4 each step. Between each step a the image is blurred before starting the next reduce cycle. The final step performs a bilinear interpolation. 1000 x 1000 => blur (3x3 gauss) => 500 x 500 => blur (3x3 gauss) => 250x250 => bilinear interpolation => 200x200 Geert ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] 2.4 showstoppers
Hi gimp developers, I am using 2.3.x for quite some time now and it was wonderful to see how things were getting better with each release. Thank you very much and keep on the good work. Laurenz Gamper ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] 2.4 showstoppers
Sven Neumann ([EMAIL PROTECTED]) wrote: > 374854 possible optimizations in Script-Fu > > This one can possibly be closed or moved from the milestone. Waiting > for a comment from Kevin. [...] > 438997 Output on stdout when using script-fu console > > Looks like a low-hanging fruit. Some help from Kevin would be > appreciated. I'll look into these when at the camp. Bye, Simon -- [EMAIL PROTECTED] http://simon.budig.de/ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] 2.4 showstoppers
On Tuesday 07 August 2007 07:43, Sven Neumann wrote: > 349340 Alt behaves incorrectly for new rectangle/ellipse selecti... > > Should probably be looked at. We should get the interaction right > for the 2.4 release and not change it later unless absolutely needed. I just stumbled across a similar issue with the latest version (at most a few days old, I'll update to the head later tonight (GMT) : If I select the whole image (pressing CTRL-A) and then I select a rectangle area out of that image with the rect selection tool the area does not replace the previous selection as it did previously - so that cropping to selection doesn't work. Only after trying to crop to selection you see what has happned: the selection seems to be both the whole image and the selected rectangle! -- mfg Karl Günter ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] 2.4 showstoppers
Moin, there are still some bugs left on the 2.4 milestone and I would like to comment on them, perhaps raising some interest here: 78265 Add support for ICC color profiles I am currently finishing the remaining bits. Since last night the color-managed display actually does the right thing. There are still some things left to be done in the lcms plug-in though. 156905 GimpAspectPreview doesn't respect the layer offset and ca... I believe that this one can be fixed using the existing API. We should definitely try to fix it in 2.4 but it doesn't need to block the release. 349340 Alt behaves incorrectly for new rectangle/ellipse selecti... Should probably be looked at. We should get the interaction right for the 2.4 release and not change it later unless absolutely needed. 355545 fixing the aspect ratio for crop tool As fas as I know Martin is working on this and expects to have it ready soon. 356716 GimpZoomPreview is broken in some plug-ins There are two more plug-ins that need to be fixed. Probably some low hanging fruits... 360106 GimpPdbDialog appears behind plug-in dialogs I still don't know how to best address this one. Perhaps set the stay-on-top flag on the PDB dialogs. That would be ugly though. 374854 possible optimizations in Script-Fu This one can possibly be closed or moved from the milestone. Waiting for a comment from Kevin. 387604 print plug-in needs more work We have come a good deal further here and I think that the remaining issue is actually a GTK+ bug. 417166 Default ratio for crop tool is 1:1 instead of http://events.ccc.de/camp/2007). If we don't manage to make the release candidate this weekend, then 2.4 will probably have to wait a little longer. I will be completely off-line for three weeks starting from the 18th of August. This will be my honeymoon and you guys would make me the best of all wedding presents if we could get 2.4rc1 out before I leave. And perhaps 2.4.0 released before I return... Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer