[Gimp-developer] Uncomitted patches
Hello, I have posted several patches for GIMP which only need to be applied, However I see that they haven't recieved a response for about 2 months. I know that the developers are busy, but I at least want to know that someone noticed these and that they are somewhere on the list of things to be done. A palettte export script to close a four year old feature request (Souce is attached) - http://bugzilla.gnome.org/show_bug.cgi?id=304399 A fix for the bug in the sphere designer plugin (patch is attached) - http://bugzilla.gnome.org/show_bug.cgi?id=582821 Note that for the sphere designer, the patch is in gnu diff since I couldn't create a working git repository of gimp (I had issues with git) If any changes need to be done for the patches and this is the cause for the delay, or if there is any way I can apply the patches myself to the source please tell me and I'll do so. Thanks, ~LightningIsMyName ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Uncomitted patches
On 07/15/2009 11:04 AM, LightningIsMyName wrote: Hello, I have posted several patches for GIMP which only need to be applied, However I see that they haven't recieved a response for about 2 months. I know that the developers are busy, but I at least want to know that someone noticed these and that they are somewhere on the list of things to be done. A palettte export script to close a four year old feature request (Souce is attached) - http://bugzilla.gnome.org/show_bug.cgi?id=304399 A fix for the bug in the sphere designer plugin (patch is attached) - http://bugzilla.gnome.org/show_bug.cgi?id=582821 Note that for the sphere designer, the patch is in gnu diff since I couldn't create a working git repository of gimp (I had issues with git) If any changes need to be done for the patches and this is the cause for the delay, or if there is any way I can apply the patches myself to the source please tell me and I'll do so. Hi, The sphere designer patch looks trivial. With risk of coming across as lazy, could you reattach that patch as a git commit with git-format-patch please? Having patches as git commits makes them about twice as convenient for maintainers to apply. The same goes for the palette export script. The palette export script looks like good code to me after a quick look. I just wonder if that script shouldn't be offered as a third-party plug-in. BR, Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] API proposal for libgimp export dialog
On 07/15/2009 12:20 AM, Sven Neumann wrote: Hi, On Tue, 2009-07-14 at 22:59 +0200, Martin Nordholts wrote: Exactly how will it break existing plug-ins? It will just be changed to act as if the user clicked the Export button. Take a look at the code on the branch and you'll see what I mean There are questions to ask the user and we can't just start to skip these questions. Third-party plug-ins that use the gimp_export_image() function should continue to behave exactly as they behave now. Hi, Let us then add the following function to libgimp GimpExportReturn gimp_export_prepare_image (gint32 *image_ID, gint32 *drawable_ID, GimpExportCapabilities capabilities); that shares the implementation and semantics with gimp_export_image() except that it doesn't show any dialogs, it just goes ahead and creates a merged copy of the image if needed. By sharing the implementation with gimp_export_image() we can use well-tested code and it becomes easy to port plug-ins to the new API. Regarding changing gimp_export_dialog_get_container() into having semantics similar to gtk_container_add(), I fear that we will have to duplicate too much of the API. If we provide _add() we need to wrap _remove() and so on. Instead of doing that I propose a name change to GtkWidget * gimp_export_dialog_get_vbox (GtkWidget *dialog); Again, this API has the benefit of making porting plug-ins easy. For completeness, here is the third function in the new export API, unchanged from before: GtkWidget * gimp_export_dialog_new (const gchar *format_name, const gchar *role, const gchar *help_id); For people with time to look at code, the git branch is updated (rewritten): http://git.gnome.org/cgit/gimp/log/?h=export-dialog-cleanup-tmp BR, Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] API proposal for libgimp export dialog
On Tue, 2009-07-14 at 22:50 +0200, Martin Nordholts wrote: On 07/14/2009 10:44 PM, Sven Neumann wrote: This function creates a new dialog, and plug-ins then use GtkWidget * gimp_export_dialog_get_container (GtkWidget *dialog); to get a vbox that the file-format specific widgets with export options are put it. I'd suggest to have gimp_export_dialog_add() instead with semantics similar to gtk_container_add(). That's a good idea, I'll change that. I don't think it's such a good idea. What about the difference between gtk_container_add() and gtk_box_pack_start()/end() with all their options. We should not restrict the ways plugins are able to construct their GUI, at least definitely not in a way that forces them to pack everything either expanding of shrinking. gimp_export_dialog_get_container() was not such a bad idea imho, but I would call it gimp_export_dialog_get_content_area(), because we have precedence of this API in GtkDialog. Also, it should probably return a completely empty vbox, not the same vbox where the export options got packed into. ciao, --mitch ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] API proposal for libgimp export dialog
On 07/15/2009 03:24 PM, Michael Natterer wrote: On Tue, 2009-07-14 at 22:50 +0200, Martin Nordholts wrote: gimp_export_dialog_get_container() was not such a bad idea imho, but I would call it gimp_export_dialog_get_content_area(), because we have precedence of this API in GtkDialog. Consistency with GTK+ is nice, but now that we mention it, we don't need gimp_export_dialog_get_content_area() at all, we can just use gtk_dialog_get_content_area() / Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] API proposal for libgimp export dialog
Hi, On Wed, 2009-07-15 at 15:24 +0200, Michael Natterer wrote: I don't think it's such a good idea. What about the difference between gtk_container_add() and gtk_box_pack_start()/end() with all their options. We should not restrict the ways plugins are able to construct their GUI, at least definitely not in a way that forces them to pack everything either expanding of shrinking. That could easily be achieved by packing a vbox into the export dialog container. But still I like your proposal better. gimp_export_dialog_get_container() was not such a bad idea imho, but I would call it gimp_export_dialog_get_content_area(), because we have precedence of this API in GtkDialog. +1 from me Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] API proposal for libgimp export dialog
On 07/15/2009 09:06 PM, Martin Nordholts wrote: On 07/15/2009 03:24 PM, Michael Natterer wrote: On Tue, 2009-07-14 at 22:50 +0200, Martin Nordholts wrote: gimp_export_dialog_get_container() was not such a bad idea imho, but I would call it gimp_export_dialog_get_content_area(), because we have precedence of this API in GtkDialog. Consistency with GTK+ is nice, but now that we mention it, we don't need gimp_export_dialog_get_content_area() at all, we can just use gtk_dialog_get_content_area() That depends of course on if we need to put common widgets within the content area. Hmm we should perhaps add gimp_export_dialog_get_content_area() so that we in the future can do that. Until we do, it would just be a wrapper around gtk_dialog_get_content_area() / Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Uncomitted patches
Hi Martin, Thanks for your response. I'll be on a computer with git somewhere in the next week, and then I'll resubmit the patches. And about the palette script, I do believe it should be included since if we have a palette import built in (for CSS, and for adobe .aco files) there is nothing wrong in having the palette export script included as well. Thanks for your help, On Wed, Jul 15, 2009 at 12:25 PM, Martin Nordholtsense...@gmail.com wrote: On 07/15/2009 11:04 AM, LightningIsMyName wrote: Hello, I have posted several patches for GIMP which only need to be applied, However I see that they haven't recieved a response for about 2 months. I know that the developers are busy, but I at least want to know that someone noticed these and that they are somewhere on the list of things to be done. A palettte export script to close a four year old feature request (Souce is attached) - http://bugzilla.gnome.org/show_bug.cgi?id=304399 A fix for the bug in the sphere designer plugin (patch is attached) - http://bugzilla.gnome.org/show_bug.cgi?id=582821 Note that for the sphere designer, the patch is in gnu diff since I couldn't create a working git repository of gimp (I had issues with git) If any changes need to be done for the patches and this is the cause for the delay, or if there is any way I can apply the patches myself to the source please tell me and I'll do so. Hi, The sphere designer patch looks trivial. With risk of coming across as lazy, could you reattach that patch as a git commit with git-format-patch please? Having patches as git commits makes them about twice as convenient for maintainers to apply. The same goes for the palette export script. The palette export script looks like good code to me after a quick look. I just wonder if that script shouldn't be offered as a third-party plug-in. BR, Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] Applying GIT patch
Hello, I have uploaded a couple patches (tarballs containing multiple commits) to bugzilla. What is the correct method to apply these patches so that others can see my work? Thank you, Eric ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Applying GIT patch
On 07/15/2009 09:59 PM, Eric Daoust wrote: Hello, I have uploaded a couple patches (tarballs containing multiple commits) to bugzilla. What is the correct method to apply these patches so that others can see my work? Hi, To apply patches created with git-format-patch, use git-am, like this: git am 0001-single-file.patch or for multi-file commits: tar -zxvf lots-of-commits.tar.gz git am lots-of-commits/* where lots-of-commits contains the files 0001-foo.patch 0002-bar.patch 0003-foo-bar.patch Often, you might want to create a new branch before you apply them git checkout -b lots-of-commits origin/master HTH, Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] Switch language via menu
Hello list members, I just want to ask one question on how to switch langugage in Gimp via menu, It will be good if Gimp can switch language via menu like VLC, Pidgin. Any one know, will Gimp have this feature in the future? Thank in advance for your respone. Sokhem ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
