Re: [Gimp-developer] Re: Redo shortcut

2003-09-30 Thread David Neary
Guillermo S. Romero / Familia Romero wrote:
> [EMAIL PROTECTED] (2003-09-26 at 1933.11 +):
> > >I'd suggest to leave the C-R as default keybinding and hardcode the C-S-Z. 
> > sounds like a good option, of course, it would confuse things if a user 
> > wants to apply SH+CT+Z to some other function(not sure why they'd want to, 
> > but it's possible).
> 
> Grouped undo, or call undo history, ie. Hardcoding would be more
> problem than harm, btw.

Just to clarify what I meant when I said "hard-coding a value" -
since it seems to have caught on as a phrase.

The default value is hard-coded for any given menu item. When
registering the menu item, there is a C function call that
basically does this...
register menu item (name, menu placement, default shortcut);

A registered menu item corresponds to a function being called.

I seem to recall that it was possible to say 

register menu item (name, menu placement, default shortcut 1);
register menu item (name, menu placement, default shortcut 2);

and have 2 shortcuts to the same menu item. This is not possible
in gtk+ 2 (the second shortcut over-writes the first one), so 
talking about hardcoding several shortcuts is probably useless :)

Note also that the hard-coded shortcut is the default shortcut...
it seems that there was some confusion about this above.

There may be hacky ways around this, such as creating "phantom"
menu items with one shortcut which are nothing but wrappers
around another menu item, but that way leads madness when you
throw dynamic shortcuts into the mix.

> They did not have any problem about changing button order from the
> most used one (important button on left side, for LTR languages) to
> the easier to use one (imporant on right side), OTOH, so logic behind
> when to change and when not is fuzzy for me.

The button order is used elsewhere (Mac). It should be used in
conjunction with better dialogs (action verbs such as "Save",
"Revert", "Don't save" rather than "Yes", "No", "Cancel"). And
the logic behind it is simply that humans using LTR languages
read dialogs from the top left to the bottom right, so the
default action should be on the bottom right.

Cheers,
Dave.

-- 
   David Neary,
   Lyon, France
  E-Mail: [EMAIL PROTECTED]
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Re: Redo shortcut

2003-09-28 Thread Øyvind Kolås
* Tom Mraz <[EMAIL PROTECTED]> [030928 15:59]:
> Guillermo S. Romero / Familia Romero wrote:
> >[EMAIL PROTECTED] (2003-09-26 at 1933.11 +):
> >
> >>>I'd suggest to leave the C-R as default keybinding and hardcode the 
> >>>C-S-Z. 
> >>
> >>sounds like a good option, of course, it would confuse things if a user 
> >>wants to apply SH+CT+Z to some other function(not sure why they'd want 
> >>to, but it's possible).
> >
> >
> >Grouped undo, or call undo history, ie. Hardcoding would be more
> >problem than help, btw.
> 
> I meant to hardcode it in such a way, that it could be reassigned by 
> user  keybinding preference to other function. Not that I think it's 
> probable that anyone would reassign it to anything.

Not having time to really pay attention,.. sometimes you feel like
making some noise anyways.

Since gtk doesn't allow multiple keybindings/action,. why not create a
duplicate menu entry that is somehow hidden? By default both bindings
would work,.. if the user reassigns the hidden binding, the biggest
problem would be presenting an opportunity to re set it.

/Øyvind K.
-- 
  .^.
  /V\Øyvind Kolås,  Gjøvik University College, Norway 
 /(_)\   <[EMAIL PROTECTED]>,<[EMAIL PROTECTED]>
  ^ ^
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Re: Redo shortcut

2003-09-26 Thread Tom Mraz
Guillermo S. Romero / Familia Romero wrote:
[EMAIL PROTECTED] (2003-09-26 at 1933.11 +):

I'd suggest to leave the C-R as default keybinding and hardcode the C-S-Z. 
sounds like a good option, of course, it would confuse things if a user 
wants to apply SH+CT+Z to some other function(not sure why they'd want to, 
but it's possible).


Grouped undo, or call undo history, ie. Hardcoding would be more
problem than help, btw.
I meant to hardcode it in such a way, that it could be reassigned by 
user  keybinding preference to other function. Not that I think it's 
probable that anyone would reassign it to anything.

Tom Mraz

___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


[Gimp-developer] Re: Redo shortcut

2003-09-26 Thread Guillermo S. Romero / Familia Romero
[EMAIL PROTECTED] (2003-09-26 at 1933.11 +):
> >I'd suggest to leave the C-R as default keybinding and hardcode the C-S-Z. 
> sounds like a good option, of course, it would confuse things if a user 
> wants to apply SH+CT+Z to some other function(not sure why they'd want to, 
> but it's possible).

Grouped undo, or call undo history, ie. Hardcoding would be more
problem than harm, btw.

> just out of interest, what on earth made the GNOME HIG people think that 
> SH+CT+Z was a good combo for anything? and is there a good reason (HIG rules 
> wise) for not allowing use of CT+R? it's not like there's a refresh of 
> reload funciton in GIMP(although it could be handy, i still wouldn't want it 
> attached to CT+R)

Probably a mix of "related to undo" with "used in other places"
reasonings. If you want a real answer, ask them.

They did not have any problem about changing button order from the
most used one (important button on left side, for LTR languages) to
the easier to use one (imporant on right side), OTOH, so logic behind
when to change and when not is fuzzy for me. And they proposed
shortcuts seem to be text editor / browser oriented, while other kinds
of apps seems to be ignored.

GSR
 
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


[Gimp-developer] Re: Redo shortcut (was: Undo shortcut)

2003-09-25 Thread Guillermo S. Romero / Familia Romero
[EMAIL PROTECTED] (2003-09-25 at 2008.02 +0200):
> You have a point here. I think that what was chosen was the
> consistency of Shift as negation. I think that's probably a goal

Relation, not just plain negation. So that is why using shift for
grouping would be fine.

> we could work towards. It certainly makes a lot of logical sense.
> But then, so does having + to zoom in instead of =, and look how
> many bug reports that's got us :)

I thought the logic behind = for zoom is that it is in the same key
than + (in USA kbds, at least) but people wanted to avoid using
Shift. I guess people's logic includes comfort. :]

GSR
 
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer