Re: [Gimp-developer] Should the checkerboard be linked to the window or to the image?

2004-09-02 Thread Sven Neumann
Hi,

Carol Spears [EMAIL PROTECTED] writes:

 the same way you can change the padding color now.  i would not have
 been able to imagine such an interface to the previews without all those
 new options for customizing your sessions.  all this stuff is sane?

You might not have noticed that we have started to remove options from
the user interface. However you should be aware of the fact that we
try not to add new options unless there's a very good reason for it.

Actually the plan was to let the plug-in previews respect the settings
from gimprc that already exist:

  (transparency-size medium-checks)

 Sets the size of the checkerboard used to display  transparency.
 Possible  values  are  small-checks,  medium-checks  and  large-
 checks.

  (transparency-type gray-checks)

 Sets the manner in which transparency is  displayed  in  images.
 Possible  values  are  light-checks,  gray-checks,  dark-checks,
 white-only, gray-only and black-only.

That would of course mean that the same settings apply to plug-in
previews and to image windows.


Sven


___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Should the checkerboard be linked to the window or to the image?

2004-09-02 Thread David Odin
On Thu, Sep 02, 2004 at 12:36:43PM +0200, Sven Neumann wrote:
 Hi,
 
 Carol Spears [EMAIL PROTECTED] writes:
 
  the same way you can change the padding color now.  i would not have
  been able to imagine such an interface to the previews without all those
  new options for customizing your sessions.  all this stuff is sane?
 
 You might not have noticed that we have started to remove options from
 the user interface. However you should be aware of the fact that we
 try not to add new options unless there's a very good reason for it.
 
 Actually the plan was to let the plug-in previews respect the settings
 from gimprc that already exist:
 
   (transparency-size medium-checks)
 
  Sets the size of the checkerboard used to display  transparency.
  Possible  values  are  small-checks,  medium-checks  and  large-
  checks.
 
   (transparency-type gray-checks)
 
  Sets the manner in which transparency is  displayed  in  images.
  Possible  values  are  light-checks,  gray-checks,  dark-checks,
  white-only, gray-only and black-only.


  How hard would this be to implement?

 That would of course mean that the same settings apply to plug-in
 previews and to image windows.

  Which is the way it should be if we want to be consistant.

-- 
[EMAIL PROTECTED]
Friends help you move. Real friends help you move bodies.
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Should the checkerboard be linked to the window or to the image?

2004-09-02 Thread Sven Neumann
Hi,

David Odin [EMAIL PROTECTED] writes:

  Actually the plan was to let the plug-in previews respect the settings
  from gimprc that already exist:
  
(transparency-size medium-checks)
  
   Sets the size of the checkerboard used to display  transparency.
   Possible  values  are  small-checks,  medium-checks  and  large-
   checks.
  
(transparency-type gray-checks)
  
   Sets the manner in which transparency is  displayed  in  images.
   Possible  values  are  light-checks,  gray-checks,  dark-checks,
   white-only, gray-only and black-only.
 
 
   How hard would this be to implement?

It would involve two changes:

(1) Add transparency-size and transparency-type properties to
GimpPreviewArea and use them when drawing the checkerboard.
(2) Somehow get the preferences to the plug-in.

Step 1 should be pretty much straight-forward. The properties can be
copied more or less directly from GimpDisplayConfig (app/config).
Checkerboard rendering will become slightly more complex but I don't
expect any noticeable slowdown. The code has still some room for
optimizations anyway.

There are two possibilities to implement step 2. Either we add a PDB
API to access the checkerboard settings:

  gimp_gimprc_get_transparency_type()  ??
  gimp_gimprc_get_transparency_size()  ??

or (and I'd prefer that), we pass these settings to the plug-in in the
GPConfig message. This is a message that is sent to each plug-in when
it is started. We handle this in libgimp and allow the plug-in to
access the settings using a simple API. See for example
gimp_show_tool_tips() or gimp_display_name().

Using the config message is definitely the prefered way of doing this
but unfortunately we are completely braindead and didn't add any
padding to the GPConfig struct :( However, there's still hope but
things are becoming ugly now. Readers with a weak stomach, please
leave now...

The GPConfig struct contains an unused member which is gamma. This
is a double and IIRC a double is guaranteed to be always 8 bytes. So
we could remove gamma and replace it with two 32bit integers and use
those for the transparency settings. We could even squeeze the
transparency settings into less than 8 bytes and keep the remaining
bytes for future use. Might become useful pretty soon, for example as
a way to pass whether color management should be enabled or disabled.

Can anyone think of better ways to do this? Are there any strong
objections against the ugly hack I outlined above? Did I overlook
something (like for example platforms where a gdouble is not 8 bytes)?


Sven
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Should the checkerboard be linked to the window or to the image?

2004-09-02 Thread Sven Neumann
Hi,

a short followup to myself...

As outlined in my previous mail, the checkerboard settings for the
preview should be taken from the gimprc when the preview widget is
created. It would be nice though to have a way to change the
checkerboard settings for the individual preview widget. I think a
right-click menu in the GimpPreviewArea is the way to go
here. Somewhat hidden but it would be an expert feature anway. Such a
right-click menu would allow users to quickly change to a
solid-colored background. As Carol outlined this can be useful if for
example you are trying to find the best radius to blur a text layer.


Sven
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Should the checkerboard be linked to the window or to the image?

2004-09-02 Thread Carol Spears
On Thu, Sep 02, 2004 at 12:36:43PM +0200, Sven Neumann wrote:
 
 You might not have noticed that we have started to remove options from
 the user interface. However you should be aware of the fact that we
 try not to add new options unless there's a very good reason for it.
 
well, no.  i did not notice that options have been being removed.  i
guess i have been so bedazzled by the changes that i have only seen the
2.1 branch improving.

also, i did not use many of those new customizable options (new for
gimp-2.0) -- i found them when trying to document it.  (i used gimp far
too long without padding, for instance)

thank you for considering that there might be different needs for
previews and images.

carol

___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Should the checkerboard be linked to the window or to the image?

2004-09-01 Thread Sven Neumann
Hi,

Carol Spears [EMAIL PROTECTED] writes:

 perhaps no checkerboard could also be considered?

It would have to be optional and I cannot imagine a sane user
interface for this. Can you?


Sven
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Should the checkerboard be linked to the window or to the image?

2004-09-01 Thread Carol Spears
On Thu, Sep 02, 2004 at 03:37:29AM +0200, Sven Neumann wrote:
 Hi,
 
 Carol Spears [EMAIL PROTECTED] writes:
 
  perhaps no checkerboard could also be considered?
 
 It would have to be optional and I cannot imagine a sane user
 interface for this. Can you?
 
scanners?  what does this have to do with scanners?

heck, sometimes you cannot see the image on the image even 

carol

___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Should the checkerboard be linked to the window or to the image?

2004-09-01 Thread Carol Spears
On Wed, Sep 01, 2004 at 06:51:46PM -0700, Carol Spears wrote:
 On Thu, Sep 02, 2004 at 03:37:29AM +0200, Sven Neumann wrote:
  Hi,
  
  Carol Spears [EMAIL PROTECTED] writes:
  
   perhaps no checkerboard could also be considered?
  
  It would have to be optional and I cannot imagine a sane user
  interface for this. Can you?
  
 scanners?  what does this have to do with scanners?
 
 heck, sometimes you cannot see the image on the image even 
 
i read this wrong the first time and thought you were talking about
something else (not even scanners).

user interface.  you can set in preferences that previews dont show the
checkerboard for transparency.  

this new gimp is so full of interface options -- padding color and
window stuff.  that is why your comment was confusing to me.

the same way you can change the padding color now.  i would not have
been able to imagine such an interface to the previews without all those
new options for customizing your sessions.  all this stuff is sane?

carol

___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer