[Gimp-developer] gegl and spiro
What benefits are there from installing the spiro libraries for gegl to use? According to the spiro website: http://libspiro.sourceforge.net/ Using bézier splines an artist can easily draw curves with the same slope on either side of an on-curve point. Spiros, on the other hand, are based on clothoid splines which make it easy to maintain constant curvature as well as constant slope. Such curves will simply look nicer. I've never had the spiro libraries installed on my computer. They can be downloaded from sourceforge. What would be the benefits? What part of Gimp would draw nicer curves? Elle -- http://ninedegreesbelow.com - articles on open source digital photography ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
Re: [Gimp-developer] gegl and spiro
Currently, there is (almost) no benefit. Building gegl with spiro support allows XML compositions to use spiro curves when input on the gegl command line. I'm not entirely sure that works as I've never used it, and I have a feeling nobody else has used it in a long time. The spiro curves support used to be part of the old gegl editor, but now that editor is gone. So, building with spiro won't change gimp at all. On Sat, Jul 27, 2013 at 6:21 PM, Elle Stone l.elle.st...@gmail.com wrote: What benefits are there from installing the spiro libraries for gegl to use? According to the spiro website: http://libspiro.sourceforge.net/ Using bézier splines an artist can easily draw curves with the same slope on either side of an on-curve point. Spiros, on the other hand, are based on clothoid splines which make it easy to maintain constant curvature as well as constant slope. Such curves will simply look nicer. I've never had the spiro libraries installed on my computer. They can be downloaded from sourceforge. What would be the benefits? What part of Gimp would draw nicer curves? Elle -- http://ninedegreesbelow.com - articles on open source digital photography ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
Re: [Gimp-developer] Gimp git on Mac Segfault
Should have mentioned the segfault is related to gimp_language_store_parser_init () __ ./gimp-2.9 --verbose Cannot spawn a message bus without a machine-id: Unable to load /var/lib/dbus/machine-id or /etc/machine-id: Failed to open file '/var/lib/dbus/machine-id': No such file or directory This is a development version of GIMP. Debug messages may appear here. INIT: gimp_load_config Parsing '/Users/partha/Library/Application Support/GIMP/2.9/unitrc' Parsing '/Users/partha/projects/src/gimp/Gimp-2.9.app/Contents/Resources/etc/gimp/2.0/gimprc' Parsing '/Users/partha/Library/Application Support/GIMP/2.9/gimprc' ./gimp-2.9: fatal error: Segmentation fault: 11 ./gimp-2.9 (pid:63964): [E]xit, [H]alt, show [S]tack trace or [P]roceed: S #0 0x7fff8b970698 in __wait4 () #1 0x000101868353 in g_on_error_stack_trace () #2 0x0001018687f2 in g_on_error_query () #3 0x0001dee4 in gimp_eek () #4 0x0001df58 in gimp_fatal_error () #5 0x0001e7b6 in gimp_sigfatal_handler () #6 signal handler called #7 0x7fff8cb0a60b in strchr () #8 0x000100167614 in gimp_language_store_parser_init () #9 0x000100012c75 in gui_init () #10 0x0001d890 in app_run () #11 0x0001fe24 in main () __ Thanks, Partha On Sat, Jul 27, 2013 at 3:01 PM, Partha Bagchi parth...@gmail.com wrote: Jehan, Looks like the segfault is back? Thanks, Partha On Fri, Jul 19, 2013 at 7:12 AM, Partha Bagchi parth...@gmail.com wrote: Jehan, Thumbs up! All good now. It didn't crash and I was able to open images etc. Thanks again, Partha On Thu, Jul 18, 2013 at 10:56 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hey Partha, you can pull and test now. I made a simple commit where I only take care of the unset env variable issue. Hopefully this will fix the OSX crash. I'll handle the other issue I discovered about not being thread-safe later. Tell me how it goes. :-) Jehan On Fri, Jul 19, 2013 at 11:26 AM, Jehan Pagès jehan.marmott...@gmail.com wrote: Partha, nothing pushed yet. I'll do this and send a message. :-) Jehan On Fri, Jul 19, 2013 at 11:21 AM, Partha Bagchi parth...@gmail.com wrote: Jehan, Do you want me to go ahead test the current code or wait for you to add additional logic? Thanks! Partha On Thu, Jul 18, 2013 at 10:04 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hi, I searched a little more though, and it seems on BSDs, hence on OSX, indeed setenv with a NULL value could crash the program. The setenv in GNU libc on the other hand perfectly handles the case explicitly. So obviously when I see this kind of code (note I am not 100% sure this is the code for Darwin on Mountain Lion but I can't find a reference linking the libc numbers there and the Darwin version 10.8, but I assume that should be a similar code): http://www.opensource.apple.com/source/Libc/Libc-825.26/stdlib/FreeBSD/setenv.c Before any test on the value pointer, it dereferences it (which is undefined!), and read the content of the non-existing first character of the NULL string (which I assume would crash!): if (*value == '=') /* no `=' in value */ ++value; I don't know what is the policy on BSD but I thought they were very keen on security, but this code does not look very sane to me. So yeah anyway that's a problem too in the end. I'll deal with it. Jehan On Fri, Jul 19, 2013 at 7:14 AM, Partha Bagchi parth...@gmail.com wrote: Jehan, I will test it tomorrow. I will get back to you with the results. Thanks for your prompt response! Partha On Thu, Jul 18, 2013 at 11:42 AM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hi again, I have some working code in my working branch now where I applied the concepts I wrote about (basically initializing the language store only once and at the very start of the program, before any threading would occur hopefully). Don't know if that will be the finale code, but should be at least good enough to test on OSX (I don't have access to a OSX machine to reproduce the bug myself and see if this indeed fixes the issue). As soon as the report is up, I'll upload the patch there so that someone with OSX can test it and tell me if that fixes it. :-) Thanks. Jehan On Thu, Jul 18, 2013 at 9:47 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hey all, it seems I am the culprit for this bug. I don't have this crash on Linux though. It looks like the implementation of setenv/getenv is different on OSX. According to glib doc, the problem may be that on some implementations, successive calls may use the same buffer. I guess that's the case on OSX. And also these calls
Re: [Gimp-developer] gegl and spiro
Michael, So, building with spiro won't change gimp at all. Thanks! for answering. I won't install spiro. Elle -- http://ninedegreesbelow.com - articles on open source digital photography ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
Re: [Gimp-developer] Gimp git on Mac Segfault
Hey Partha, su_v, could you test the following patch: - copy it in your GIMP directory; - apply it with this command from the GIMP directory: patch -p0 osx_crash.diff - compile and try again. I believe it would not fix your crash, because I did not change the calls where your traces say it happens. Problem is that it apparently crashes at strchr() but there are 5 of them in this function. Looking at what seems to be the code in MacOSX of strchr(), looks like it may be when the string is NULL, but in my code, I don't see anywhere where this is supposed to be possible. So unless you can run a debugger to know which exact strchr() line it happens at, I added some debug output in the code. Just copy paste anything which may be outputted before crash. You will most likely have a whole bunch of lines on screen because I want to cover as much ground as possible, so you can run like this: $ ./gimp-2.9 --verbose output.txt Then send me the output.txt after the crash occurs. Thanks. Jehan On Sun, Jul 28, 2013 at 1:47 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Argh! I should nearly have a Mac just to test code there! uhuh Let me have a look. :-) Jehan On Sun, Jul 28, 2013 at 10:39 AM, Partha Bagchi parth...@gmail.com wrote: Should have mentioned the segfault is related to gimp_language_store_parser_init () __ ./gimp-2.9 --verbose Cannot spawn a message bus without a machine-id: Unable to load /var/lib/dbus/machine-id or /etc/machine-id: Failed to open file '/var/lib/dbus/machine-id': No such file or directory This is a development version of GIMP. Debug messages may appear here. INIT: gimp_load_config Parsing '/Users/partha/Library/Application Support/GIMP/2.9/unitrc' Parsing '/Users/partha/projects/src/gimp/Gimp-2.9.app/Contents/Resources/etc/gimp/2.0/gimprc' Parsing '/Users/partha/Library/Application Support/GIMP/2.9/gimprc' ./gimp-2.9: fatal error: Segmentation fault: 11 ./gimp-2.9 (pid:63964): [E]xit, [H]alt, show [S]tack trace or [P]roceed: S #0 0x7fff8b970698 in __wait4 () #1 0x000101868353 in g_on_error_stack_trace () #2 0x0001018687f2 in g_on_error_query () #3 0x0001dee4 in gimp_eek () #4 0x0001df58 in gimp_fatal_error () #5 0x0001e7b6 in gimp_sigfatal_handler () #6 signal handler called #7 0x7fff8cb0a60b in strchr () #8 0x000100167614 in gimp_language_store_parser_init () #9 0x000100012c75 in gui_init () #10 0x0001d890 in app_run () #11 0x0001fe24 in main () __ Thanks, Partha On Sat, Jul 27, 2013 at 3:01 PM, Partha Bagchi parth...@gmail.com wrote: Jehan, Looks like the segfault is back? Thanks, Partha On Fri, Jul 19, 2013 at 7:12 AM, Partha Bagchi parth...@gmail.com wrote: Jehan, Thumbs up! All good now. It didn't crash and I was able to open images etc. Thanks again, Partha On Thu, Jul 18, 2013 at 10:56 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hey Partha, you can pull and test now. I made a simple commit where I only take care of the unset env variable issue. Hopefully this will fix the OSX crash. I'll handle the other issue I discovered about not being thread-safe later. Tell me how it goes. :-) Jehan On Fri, Jul 19, 2013 at 11:26 AM, Jehan Pagès jehan.marmott...@gmail.com wrote: Partha, nothing pushed yet. I'll do this and send a message. :-) Jehan On Fri, Jul 19, 2013 at 11:21 AM, Partha Bagchi parth...@gmail.com wrote: Jehan, Do you want me to go ahead test the current code or wait for you to add additional logic? Thanks! Partha On Thu, Jul 18, 2013 at 10:04 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hi, I searched a little more though, and it seems on BSDs, hence on OSX, indeed setenv with a NULL value could crash the program. The setenv in GNU libc on the other hand perfectly handles the case explicitly. So obviously when I see this kind of code (note I am not 100% sure this is the code for Darwin on Mountain Lion but I can't find a reference linking the libc numbers there and the Darwin version 10.8, but I assume that should be a similar code): http://www.opensource.apple.com/source/Libc/Libc-825.26/stdlib/FreeBSD/setenv.c Before any test on the value pointer, it dereferences it (which is undefined!), and read the content of the non-existing first character of the NULL string (which I assume would crash!): if (*value == '=') /* no `=' in value */ ++value; I don't know what is the policy on BSD but I thought they were very keen on security, but this code does not look very sane to me. So yeah anyway that's a problem too in the end. I'll deal with it. Jehan On Fri, Jul 19, 2013 at 7:14 AM, Partha Bagchi parth...@gmail.com wrote: Jehan, I will test it tomorrow. I
Re: [Gimp-developer] Gimp git on Mac Segfault
Just to try into another direction: if you comment out the line: parse_iso_codes (base_lang_list, NULL); (line 173 in app/widgets/gimplanguagestore-parser.c) Do you still have the crash? And if yes, the same trace? Jehan On Sun, Jul 28, 2013 at 4:22 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hmmm... NULL nowhere, no strange values, nothing. Did the trace still say it happened at strchr() inside gimp_language_store_parser_init ()? Jehan On Sun, Jul 28, 2013 at 4:16 PM, Partha Bagchi parth...@gmail.com wrote: Hi Jehan, Here is the output from the crash. Hope it's helpful. I don't see anything myself. :( Thanks! Partha On Sat, Jul 27, 2013 at 11:47 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hey Partha, su_v, could you test the following patch: - copy it in your GIMP directory; - apply it with this command from the GIMP directory: patch -p0 osx_crash.diff - compile and try again. I believe it would not fix your crash, because I did not change the calls where your traces say it happens. Problem is that it apparently crashes at strchr() but there are 5 of them in this function. Looking at what seems to be the code in MacOSX of strchr(), looks like it may be when the string is NULL, but in my code, I don't see anywhere where this is supposed to be possible. So unless you can run a debugger to know which exact strchr() line it happens at, I added some debug output in the code. Just copy paste anything which may be outputted before crash. You will most likely have a whole bunch of lines on screen because I want to cover as much ground as possible, so you can run like this: $ ./gimp-2.9 --verbose output.txt Then send me the output.txt after the crash occurs. Thanks. Jehan On Sun, Jul 28, 2013 at 1:47 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Argh! I should nearly have a Mac just to test code there! uhuh Let me have a look. :-) Jehan On Sun, Jul 28, 2013 at 10:39 AM, Partha Bagchi parth...@gmail.com wrote: Should have mentioned the segfault is related to gimp_language_store_parser_init () __ ./gimp-2.9 --verbose Cannot spawn a message bus without a machine-id: Unable to load /var/lib/dbus/machine-id or /etc/machine-id: Failed to open file '/var/lib/dbus/machine-id': No such file or directory This is a development version of GIMP. Debug messages may appear here. INIT: gimp_load_config Parsing '/Users/partha/Library/Application Support/GIMP/2.9/unitrc' Parsing '/Users/partha/projects/src/gimp/Gimp-2.9.app/Contents/Resources/etc/gimp/2.0/gimprc' Parsing '/Users/partha/Library/Application Support/GIMP/2.9/gimprc' ./gimp-2.9: fatal error: Segmentation fault: 11 ./gimp-2.9 (pid:63964): [E]xit, [H]alt, show [S]tack trace or [P]roceed: S #0 0x7fff8b970698 in __wait4 () #1 0x000101868353 in g_on_error_stack_trace () #2 0x0001018687f2 in g_on_error_query () #3 0x0001dee4 in gimp_eek () #4 0x0001df58 in gimp_fatal_error () #5 0x0001e7b6 in gimp_sigfatal_handler () #6 signal handler called #7 0x7fff8cb0a60b in strchr () #8 0x000100167614 in gimp_language_store_parser_init () #9 0x000100012c75 in gui_init () #10 0x0001d890 in app_run () #11 0x0001fe24 in main () __ Thanks, Partha On Sat, Jul 27, 2013 at 3:01 PM, Partha Bagchi parth...@gmail.com wrote: Jehan, Looks like the segfault is back? Thanks, Partha On Fri, Jul 19, 2013 at 7:12 AM, Partha Bagchi parth...@gmail.com wrote: Jehan, Thumbs up! All good now. It didn't crash and I was able to open images etc. Thanks again, Partha On Thu, Jul 18, 2013 at 10:56 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hey Partha, you can pull and test now. I made a simple commit where I only take care of the unset env variable issue. Hopefully this will fix the OSX crash. I'll handle the other issue I discovered about not being thread-safe later. Tell me how it goes. :-) Jehan On Fri, Jul 19, 2013 at 11:26 AM, Jehan Pagès jehan.marmott...@gmail.com wrote: Partha, nothing pushed yet. I'll do this and send a message. :-) Jehan On Fri, Jul 19, 2013 at 11:21 AM, Partha Bagchi parth...@gmail.com wrote: Jehan, Do you want me to go ahead test the current code or wait for you to add additional logic? Thanks! Partha On Thu, Jul 18, 2013 at 10:04 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hi, I searched a little more though, and it seems on BSDs, hence on OSX, indeed setenv with a NULL value could crash the program. The setenv in GNU libc on the other hand perfectly handles the case explicitly. So obviously when I see this kind
Re: [Gimp-developer] Gimp git on Mac Segfault
[ reposting to the list, with trimmed fullquote ] On my system (10.7.5), GIMP launches ok, but crashes when opening the preferences. See stack trace in https://bugzilla.gnome.org/show_bug.cgi?id=704592#c6 With your patch applied (and no other local changes), GIMP still launches ok, and now no longer crashes when opening the preferences dialog (see attached log). On 2013-07-28 05:47 +0100, Jehan Pagès wrote: Hey Partha, su_v, could you test the following patch: - copy it in your GIMP directory; - apply it with this command from the GIMP directory: patch -p0 osx_crash.diff - compile and try again. I believe it would not fix your crash, because I did not change the calls where your traces say it happens. Problem is that it apparently crashes at strchr() but there are 5 of them in this function. Looking at what seems to be the code in MacOSX of strchr(), looks like it may be when the string is NULL, but in my code, I don't see anywhere where this is supposed to be possible. So unless you can run a debugger to know which exact strchr() line it happens at, I added some debug output in the code. Just copy paste anything which may be outputted before crash. You will most likely have a whole bunch of lines on screen because I want to cover as much ground as possible, so you can run like this: $ ./gimp-2.9 --verbose output.txt Then send me the output.txt after the crash occurs. Thanks. Jehan On Sun, Jul 28, 2013 at 1:47 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Argh! I should nearly have a Mac just to test code there! uhuh Let me have a look. :-) Jehan On Sun, Jul 28, 2013 at 10:39 AM, Partha Bagchi parth...@gmail.com wrote: Should have mentioned the segfault is related to gimp_language_store_parser_init () __ ./gimp-2.9 --verbose Cannot spawn a message bus without a machine-id: Unable to load /var/lib/dbus/machine-id or /etc/machine-id: Failed to open file '/var/lib/dbus/machine-id': No such file or directory This is a development version of GIMP. Debug messages may appear here. INIT: gimp_load_config Parsing '/Users/partha/Library/Application Support/GIMP/2.9/unitrc' Parsing '/Users/partha/projects/src/gimp/Gimp-2.9.app/Contents/Resources/etc/gimp/2.0/gimprc' Parsing '/Users/partha/Library/Application Support/GIMP/2.9/gimprc' ./gimp-2.9: fatal error: Segmentation fault: 11 ./gimp-2.9 (pid:63964): [E]xit, [H]alt, show [S]tack trace or [P]roceed: S #0 0x7fff8b970698 in __wait4 () #1 0x000101868353 in g_on_error_stack_trace () #2 0x0001018687f2 in g_on_error_query () #3 0x0001dee4 in gimp_eek () #4 0x0001df58 in gimp_fatal_error () #5 0x0001e7b6 in gimp_sigfatal_handler () #6 signal handler called #7 0x7fff8cb0a60b in strchr () #8 0x000100167614 in gimp_language_store_parser_init () #9 0x000100012c75 in gui_init () #10 0x0001d890 in app_run () #11 0x0001fe24 in main () __ Thanks, Partha On Sat, Jul 27, 2013 at 3:01 PM, Partha Bagchi parth...@gmail.com wrote: Jehan, Looks like the segfault is back? Thanks, Partha INIT: gimp_load_config Parsing '/Users/su_v/Library/Application Support/GIMP/2.9/unitrc' Parsing '/Volumes/magenta/mp-trunk/src/gimp/local/etc/gimp/2.0/gimprc' Parsing '/Users/su_v/Library/Application Support/GIMP/2.9/gimprc' locale when checking mo files: am base_code when checking mo files: am locale when checking mo files: ar base_code when checking mo files: ar locale when checking mo files: ast base_code when checking mo files: ast locale when checking mo files: az base_code when checking mo files: az locale when checking mo files: be base_code when checking mo files: be locale when checking mo files: bg base_code when checking mo files: bg locale when checking mo files: br base_code when checking mo files: br locale when checking mo files: ca base_code when checking mo files: ca locale when checking mo files: ca@valencia base_code when checking mo files: ca@valencia locale when checking mo files: cs base_code when checking mo files: cs locale when checking mo files: csb base_code when checking mo files: csb locale when checking mo files: da base_code when checking mo files: da locale when checking mo files: de base_code when checking mo files: de locale when checking mo files: dz base_code when checking mo files: dz locale when checking mo files: el base_code when checking mo files: el locale when checking mo files: en_CA base_code when checking mo files: en locale when checking mo files: en_GB base_code when checking mo files: en locale when checking mo files: eo base_code when checking mo files: eo locale when checking mo files: es base_code when checking mo files: es locale when checking mo files: et base_code when checking mo files: et locale when checking mo files: eu base_code
Re: [Gimp-developer] Gimp git on Mac Segfault
Hi su_v, yes I saw your message in the report too. Actually I was feeling this would work your crash around when I wrote this patch. But that is still not a fix. When you open the preferences and check the Interface tab, then the language list, this list is empty now, right? Jehan On Sun, Jul 28, 2013 at 5:19 PM, su_v suv...@users.sourceforge.net wrote: On my system (10.7.5), GIMP launches ok, but crashes when opening the preferences. See stack trace in https://bugzilla.gnome.org/show_bug.cgi?id=704592#c6 With your patch applied (and no other local changes), GIMP still launches ok, and now no longer crashes when opening the preferences dialog (see attached log). On 2013-07-28 05:47 +0100, Jehan Pagès wrote: Hey Partha, su_v, could you test the following patch: - copy it in your GIMP directory; - apply it with this command from the GIMP directory: patch -p0 osx_crash.diff - compile and try again. I believe it would not fix your crash, because I did not change the calls where your traces say it happens. Problem is that it apparently crashes at strchr() but there are 5 of them in this function. Looking at what seems to be the code in MacOSX of strchr(), looks like it may be when the string is NULL, but in my code, I don't see anywhere where this is supposed to be possible. So unless you can run a debugger to know which exact strchr() line it happens at, I added some debug output in the code. Just copy paste anything which may be outputted before crash. You will most likely have a whole bunch of lines on screen because I want to cover as much ground as possible, so you can run like this: $ ./gimp-2.9 --verbose output.txt Then send me the output.txt after the crash occurs. Thanks. Jehan On Sun, Jul 28, 2013 at 1:47 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Argh! I should nearly have a Mac just to test code there! uhuh Let me have a look. :-) Jehan On Sun, Jul 28, 2013 at 10:39 AM, Partha Bagchi parth...@gmail.com wrote: Should have mentioned the segfault is related to gimp_language_store_parser_init () __ ./gimp-2.9 --verbose Cannot spawn a message bus without a machine-id: Unable to load /var/lib/dbus/machine-id or /etc/machine-id: Failed to open file '/var/lib/dbus/machine-id': No such file or directory This is a development version of GIMP. Debug messages may appear here. INIT: gimp_load_config Parsing '/Users/partha/Library/Application Support/GIMP/2.9/unitrc' Parsing '/Users/partha/projects/src/gimp/Gimp-2.9.app/Contents/Resources/etc/gimp/2.0/gimprc' Parsing '/Users/partha/Library/Application Support/GIMP/2.9/gimprc' ./gimp-2.9: fatal error: Segmentation fault: 11 ./gimp-2.9 (pid:63964): [E]xit, [H]alt, show [S]tack trace or [P]roceed: S #0 0x7fff8b970698 in __wait4 () #1 0x000101868353 in g_on_error_stack_trace () #2 0x0001018687f2 in g_on_error_query () #3 0x0001dee4 in gimp_eek () #4 0x0001df58 in gimp_fatal_error () #5 0x0001e7b6 in gimp_sigfatal_handler () #6 signal handler called #7 0x7fff8cb0a60b in strchr () #8 0x000100167614 in gimp_language_store_parser_init () #9 0x000100012c75 in gui_init () #10 0x0001d890 in app_run () #11 0x0001fe24 in main () __ Thanks, Partha On Sat, Jul 27, 2013 at 3:01 PM, Partha Bagchi parth...@gmail.com wrote: Jehan, Looks like the segfault is back? Thanks, Partha On Fri, Jul 19, 2013 at 7:12 AM, Partha Bagchi parth...@gmail.com wrote: Jehan, Thumbs up! All good now. It didn't crash and I was able to open images etc. Thanks again, Partha On Thu, Jul 18, 2013 at 10:56 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hey Partha, you can pull and test now. I made a simple commit where I only take care of the unset env variable issue. Hopefully this will fix the OSX crash. I'll handle the other issue I discovered about not being thread-safe later. Tell me how it goes. :-) Jehan On Fri, Jul 19, 2013 at 11:26 AM, Jehan Pagès jehan.marmott...@gmail.com wrote: Partha, nothing pushed yet. I'll do this and send a message. :-) Jehan On Fri, Jul 19, 2013 at 11:21 AM, Partha Bagchi parth...@gmail.com wrote: Jehan, Do you want me to go ahead test the current code or wait for you to add additional logic? Thanks! Partha On Thu, Jul 18, 2013 at 10:04 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: Hi, I searched a little more though, and it seems on BSDs, hence on OSX, indeed setenv with a NULL value could crash the program. The setenv in GNU libc on the other hand perfectly handles the case explicitly. So obviously when I see this kind of code (note I am not 100% sure this is the code for Darwin on Mountain Lion but I can't find a reference linking the libc numbers there and the Darwin version 10.8, but
Re: [Gimp-developer] Gimp git on Mac Segfault
On 2013-07-28 07:32 +0100, Jehan Pagès wrote: yes I saw your message in the report too. Actually I was feeling this would work your crash around when I wrote this patch. But that is still not a fix. When you open the preferences and check the Interface tab, then the language list, this list is empty now, right? No, it lists all languages. On 2013-07-28 07:31 +0100, Partha Bagchi wrote: Are you using Macport? I don't use Macport and build all my dependencies from scratch. Yes, I use MacPorts for the dependencies. [ fullquote below trimmed to avoid moderation ] On Sun, Jul 28, 2013 at 5:19 PM, su_v suv...@users.sourceforge.net wrote: On my system (10.7.5), GIMP launches ok, but crashes when opening the preferences. See stack trace in https://bugzilla.gnome.org/show_bug.cgi?id=704592#c6 With your patch applied (and no other local changes), GIMP still launches ok, and now no longer crashes when opening the preferences dialog (see attached log). On 2013-07-28 05:47 +0100, Jehan Pagès wrote: Hey Partha, su_v, could you test the following patch: - copy it in your GIMP directory; - apply it with this command from the GIMP directory: patch -p0 osx_crash.diff - compile and try again. I believe it would not fix your crash, because I did not change the calls where your traces say it happens. Problem is that it apparently crashes at strchr() but there are 5 of them in this function. Looking at what seems to be the code in MacOSX of strchr(), looks like it may be when the string is NULL, but in my code, I don't see anywhere where this is supposed to be possible. So unless you can run a debugger to know which exact strchr() line it happens at, I added some debug output in the code. Just copy paste anything which may be outputted before crash. You will most likely have a whole bunch of lines on screen because I want to cover as much ground as possible, so you can run like this: $ ./gimp-2.9 --verbose output.txt Then send me the output.txt after the crash occurs. Thanks. Jehan ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
