[Gimp-developer] Making enabling dynamics a checkbox (Issue #4333)

2021-12-29 Thread Asalle via gimp-developer-list
Hi all,

I'm fairly new to gimp, so any advice is welcome. I'm attempting to
implement this feature request:
https://gitlab.gnome.org/GNOME/gimp/-/issues/4333#note_1211607.
In short: instead of changing from e. g. "Basic dynamics" to "Dynamics Off"
and vice versa, there should be just a checkbox that allows to turn the
dynamics off and on.

So far I've implemented the checkbox and a "use-dynamics" property in
PaintOptions. But I'm not sure how to actually enable it when drawing. I'm
also not sure if I'm on the right path, so if you could nudge me in the
right direction, I would appreciate it!

Here is my patch:
https://gitlab.gnome.org/Asalle/gimp/-/commit/1928d1edd71286ce7b185fbf24eda91aa5b504b3.


-- 
Best regards,
Asa
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list


Re: [Gimp-developer] Making enabling dynamics a checkbox (Issue #4333)

2021-12-29 Thread Joao S. O. Bueno via gimp-developer-list
Maybe, instead of a redundant control to the already cluttered tool options,
we could step back and try to get an easier way to find and select a desired
dynamics (including the "Dynamics Off"). meanwhile, maybe just
making it special so that it shows first on the dynamics list would
be a nicer workaround than adding still another control there.

On Wed, 29 Dec 2021 at 12:42, Asalle via gimp-developer-list <
gimp-developer-list@gnome.org> wrote:

> Hi all,
>
> I'm fairly new to gimp, so any advice is welcome. I'm attempting to
> implement this feature request:
> https://gitlab.gnome.org/GNOME/gimp/-/issues/4333#note_1211607.
> In short: instead of changing from e. g. "Basic dynamics" to "Dynamics Off"
> and vice versa, there should be just a checkbox that allows to turn the
> dynamics off and on.
>
> So far I've implemented the checkbox and a "use-dynamics" property in
> PaintOptions. But I'm not sure how to actually enable it when drawing. I'm
> also not sure if I'm on the right path, so if you could nudge me in the
> right direction, I would appreciate it!
>
> Here is my patch:
>
> https://gitlab.gnome.org/Asalle/gimp/-/commit/1928d1edd71286ce7b185fbf24eda91aa5b504b3
> .
>
>
> --
> Best regards,
> Asa
> ___
> gimp-developer-list mailing list
> List address:gimp-developer-list@gnome.org
> List membership:
> https://mail.gnome.org/mailman/listinfo/gimp-developer-list
> List archives:   https://mail.gnome.org/archives/gimp-developer-list
>
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list