Re: [Gimp-developer] Fwd: GIMP Icons

2013-11-17 Thread Jehan Pagès
Hi,

On Fri, Nov 15, 2013 at 9:41 AM, Michael Henning
 wrote:
> This was replied to just me, so I'm forwarding it to the entire list.

Thanks Michael.

>
> -- Forwarded message --
> From: Andrew Pullins 
> Date: Thu, Nov 14, 2013 at 2:15 AM
> Subject: Re: [Gimp-developer] GIMP Icons
> To: Michael Henning 
>
>
>
>> > You have not answered to the question. What version is it *exactly*?
>> > The last is 2.8.8. Just "2.8" is not enough, there has been 4 minor
>> > versions in 2.8. Please check the About of the program.
>
>
> here are some comments form my DeviantArt
>
> Linux
>
> Works fine on Debian Wheezy / Gimp 2.8.x
>
> Dark theme crashes on Ubuntu 12.04, but Light works fine.

I just tested on my Linux Mint. The dark theme crashes too.
So I tracked the bug. As I thought, the issue is in GTK+. I have fixed
it on my locale development and will upload the patch tomorrow on
Bugzilla (I want first to do a few more tests and see if it affects
GTK+ 3 as well. But for now, I must sleep).

> [...]

>> > There seems to be a lot of missing icons in your set, and more
>> > problematic, several errors in the gtkrc.
>> > So that may explain why it does not work well (or at all) for some
>> > people (maybe it depends on the version of GTK+ installed). The best
>> > on your side would be to fix at least the gtkrc.
>
>
>  well I can see how I messed some icons, there are a lot. as for the
> gtkrc I kinda just took a bunch of different themes mashed them
> together and ctrl found colors till switching them out got the look I
> wanted. I honestly have no idea what I'm doing with these themes. I
> did not know there was anything wrong with the gtkrc and have no idea
> where to start. I really wanted this to be a GMIP only theme, there
> seems to be a lot of GIMIP themes out there that can be used for many
> applications and there for have a lot of extra stuff that GIMP dose
> not need.

I see. Well if you just follow all the warning output in a terminal,
you can at least track all the non-existent images and get rid of the
references in the gtkrc.
That would be already a good start. :-)

>> > In any case, if really GIMP crashes because of this, that's not
>> > normal. It should not crash on wrong input. Could you please open a
>> > bug report: https://bugzilla.gnome.org/enter_bug.cgi?product=GIMP
>
>
>>
>> > Then a developer (maybe me) will look into it when we have some time,
>> > and we'll try to reproduce the crash.
>
>
>  I will do so.

Well, now that I have fixed the bug, I may as well take care of the
bug ticket too, I guess.
Thanks for the report anyway.

Jehan
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list


Re: [Gimp-developer] Fwd: GIMP Icons

2013-11-17 Thread Jehan Pagès
Hi again,

On Mon, Nov 18, 2013 at 12:25 AM, Jehan Pagès
 wrote:
> Hi,
>
> On Fri, Nov 15, 2013 at 9:41 AM, Michael Henning
>  wrote:
>> This was replied to just me, so I'm forwarding it to the entire list.
>
> Thanks Michael.
>
>>
>> -- Forwarded message --
>> From: Andrew Pullins 
>> Date: Thu, Nov 14, 2013 at 2:15 AM
>> Subject: Re: [Gimp-developer] GIMP Icons
>> To: Michael Henning 
>>
>>
>>
>>> > You have not answered to the question. What version is it *exactly*?
>>> > The last is 2.8.8. Just "2.8" is not enough, there has been 4 minor
>>> > versions in 2.8. Please check the About of the program.
>>
>>
>> here are some comments form my DeviantArt
>>
>> Linux
>>
>> Works fine on Debian Wheezy / Gimp 2.8.x
>>
>> Dark theme crashes on Ubuntu 12.04, but Light works fine.
>
> I just tested on my Linux Mint. The dark theme crashes too.
> So I tracked the bug. As I thought, the issue is in GTK+. I have fixed
> it on my locale development and will upload the patch tomorrow on
> Bugzilla (I want first to do a few more tests and see if it affects
> GTK+ 3 as well. But for now, I must sleep).

Well in the end, I did not want to push it to tomorrow. So I just
tested and made the ticket now.
See https://bugzilla.gnome.org/show_bug.cgi?id=712536

With this patch, we will handle better broken themes.

In the meantime, you should fix your theme if you want it to work with
current GTK+.
In particular, just remove all the gap_file, gap_start_file and
gap_end_file in your gtkrc which do not correspond to an existing
image. These were the pieces of the gtkrc which was making GTK+ crash.
Regards,

Jehan

>
>> [...]
>
>>> > There seems to be a lot of missing icons in your set, and more
>>> > problematic, several errors in the gtkrc.
>>> > So that may explain why it does not work well (or at all) for some
>>> > people (maybe it depends on the version of GTK+ installed). The best
>>> > on your side would be to fix at least the gtkrc.
>>
>>
>>  well I can see how I messed some icons, there are a lot. as for the
>> gtkrc I kinda just took a bunch of different themes mashed them
>> together and ctrl found colors till switching them out got the look I
>> wanted. I honestly have no idea what I'm doing with these themes. I
>> did not know there was anything wrong with the gtkrc and have no idea
>> where to start. I really wanted this to be a GMIP only theme, there
>> seems to be a lot of GIMIP themes out there that can be used for many
>> applications and there for have a lot of extra stuff that GIMP dose
>> not need.
>
> I see. Well if you just follow all the warning output in a terminal,
> you can at least track all the non-existent images and get rid of the
> references in the gtkrc.
> That would be already a good start. :-)
>
>>> > In any case, if really GIMP crashes because of this, that's not
>>> > normal. It should not crash on wrong input. Could you please open a
>>> > bug report: https://bugzilla.gnome.org/enter_bug.cgi?product=GIMP
>>
>>
>>>
>>> > Then a developer (maybe me) will look into it when we have some time,
>>> > and we'll try to reproduce the crash.
>>
>>
>>  I will do so.
>
> Well, now that I have fixed the bug, I may as well take care of the
> bug ticket too, I guess.
> Thanks for the report anyway.
>
> Jehan
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list


Re: [Gimp-developer] Fwd: GIMP Icons

2013-11-26 Thread Jehan Pagès
Hi,

On Wed, Nov 27, 2013 at 8:23 AM, Andrew Pullins  wrote:
> I was wondering why are there so many different sized icons? I mean I
> understand that GIMP has different sized icons, but sometimes it does not
> care what size the icon is it will insert it anyway. I noticed that my color
> switcher icon (aka "stock-swap-colors-12") was not working,  and I found
> that it was because I made it a 24x24 icon. once I resized it back down to
> 12 it was find. but on the other hand, my stock-join-miter-16 is not 16x16
> but in-facet 24x24. So why are there some many different icons? there are
> 16x16, 24x24, 32x32, 48x42, and 64x64. GIMP does not care what file format
> it is in, or at least it does not care that my themes are all .SVG. what
> makes it even more confusing is when there are four red Channel icons.

Well I don't know the answer to this. :-)
If you want better chances of answers, you better send your questions
to the mailing list, not to me only. I forward it for you.

Jehan

>
> On Sun, Nov 17, 2013 at 8:47 PM, Andrew Pullins 
> wrote:
>>
>> I have GIMP 2.8.8 installed on Ubuntu 13.10
>>
>>
>> On Sun, Nov 17, 2013 at 7:22 PM, Andrew Pullins 
>> wrote:
>>>
>>> My GIMP has not crashed in some time. Thats what makes this bug so
>>> strange, it seems to depend on your OS and GIMP build. I'm not in front of
>>> my computer but I'll tell you what my GIMP version is.
>>>
>>> On Nov 17, 2013 4:55 PM, "Jehan Pagès" 
>>> wrote:

 Hi,

 On Mon, Nov 18, 2013 at 10:39 AM, Andrew Pullins 
 wrote:
 > And here are the errors I get when I load the light theme
 >
 > ~$ gimp
 > /home/andrew/.gimp-2.8/themes/Flat-Light/gtkrc:3: error: unexpected
 > character ':', expected character '='
 > GIMP-Error: Failed to load data:
 >
 > Couldn't recognize the image file format for file
 > '/home/andrew/.gimp-2.8/patterns/GPS-Pat/Canvas-Covered.xcf'
 >
 > GIMP-Error: Failed to load data:
 >
 > Fatal parse error in gradient file
 > '/home/andrew/.gimp-2.8/gradients/Untitled.ggr': Read error in line 1.

 Hmmm. I had more than that, even for the light theme.
 In any case, after fixing all the "gap" files, did the crash stop at
 least?

 Jehan
>>
>>
>
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list


Re: [Gimp-developer] Fwd: GIMP Icons

2013-11-26 Thread jEsuSdA 8)

El 26/11/13 22:42, Jehan Pagès escribió:

I was wondering why are there so many different sized icons? I mean I

understand that GIMP has different sized icons, but sometimes it does not
care what size the icon is it will insert it anyway. I noticed that my color
switcher icon (aka "stock-swap-colors-12") was not working,  and I found
that it was because I made it a 24x24 icon. once I resized it back down to
12 it was find. but on the other hand, my stock-join-miter-16 is not 16x16
but in-facet 24x24. So why are there some many different icons? there are
16x16, 24x24, 32x32, 48x42, and 64x64. GIMP does not care what file format
it is in, or at least it does not care that my themes are all .SVG. what
makes it even more confusing is when there are four red Channel icons.


Hi Jehan,

The sizes are selected bye the gtkrc file. If you open it, you can view 
what icon sizes are neccesary and, of course, you can force some of them 
to a size you consider.


Instead to make several resized versions of all icons, I suggest you 
make only the needed ones using the gtkrc file of your theme. ;)


Good luck!
jEsuSdA 8)

___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list


Re: [Gimp-developer] Fwd: GIMP Icons

2013-12-04 Thread Jehan Pagès
Hi,

On Mon, Nov 18, 2013 at 1:06 AM, Jehan Pagès  wrote:
> Hi again,
>
> On Mon, Nov 18, 2013 at 12:25 AM, Jehan Pagès
>  wrote:
>> Hi,
>>
>> On Fri, Nov 15, 2013 at 9:41 AM, Michael Henning
>>  wrote:
>>> This was replied to just me, so I'm forwarding it to the entire list.
>>
>> Thanks Michael.
>>
>>>
>>> -- Forwarded message --
>>> From: Andrew Pullins 
>>> Date: Thu, Nov 14, 2013 at 2:15 AM
>>> Subject: Re: [Gimp-developer] GIMP Icons
>>> To: Michael Henning 
>>>
>>>
>>>
 > You have not answered to the question. What version is it *exactly*?
 > The last is 2.8.8. Just "2.8" is not enough, there has been 4 minor
 > versions in 2.8. Please check the About of the program.
>>>
>>>
>>> here are some comments form my DeviantArt
>>>
>>> Linux
>>>
>>> Works fine on Debian Wheezy / Gimp 2.8.x
>>>
>>> Dark theme crashes on Ubuntu 12.04, but Light works fine.
>>
>> I just tested on my Linux Mint. The dark theme crashes too.
>> So I tracked the bug. As I thought, the issue is in GTK+. I have fixed
>> it on my locale development and will upload the patch tomorrow on
>> Bugzilla (I want first to do a few more tests and see if it affects
>> GTK+ 3 as well. But for now, I must sleep).
>
> Well in the end, I did not want to push it to tomorrow. So I just
> tested and made the ticket now.
> See https://bugzilla.gnome.org/show_bug.cgi?id=712536
>
> With this patch, we will handle better broken themes.

Just for your information, the patch has made it upstream and new
stables releases of GTK+ are planned for this week. Not sure when it
would make it to your distribution but when it will, the particular
crashes you experienced will be fixed (unless there were other issues
I could not discover) with GTK+ 2.24.23.

This being said, even though GTK+ will be now robuster on a faulty
theme, I would still suggest you to fix your theme with the
indications I gave you earlier. Then you don't have to ask your users
to wait for an updated GTK+. :-)
Bye!

Jehan

>
> In the meantime, you should fix your theme if you want it to work with
> current GTK+.
> In particular, just remove all the gap_file, gap_start_file and
> gap_end_file in your gtkrc which do not correspond to an existing
> image. These were the pieces of the gtkrc which was making GTK+ crash.
> Regards,
>
> Jehan
>
>>
>>> [...]
>>
 > There seems to be a lot of missing icons in your set, and more
 > problematic, several errors in the gtkrc.
 > So that may explain why it does not work well (or at all) for some
 > people (maybe it depends on the version of GTK+ installed). The best
 > on your side would be to fix at least the gtkrc.
>>>
>>>
>>>  well I can see how I messed some icons, there are a lot. as for the
>>> gtkrc I kinda just took a bunch of different themes mashed them
>>> together and ctrl found colors till switching them out got the look I
>>> wanted. I honestly have no idea what I'm doing with these themes. I
>>> did not know there was anything wrong with the gtkrc and have no idea
>>> where to start. I really wanted this to be a GMIP only theme, there
>>> seems to be a lot of GIMIP themes out there that can be used for many
>>> applications and there for have a lot of extra stuff that GIMP dose
>>> not need.
>>
>> I see. Well if you just follow all the warning output in a terminal,
>> you can at least track all the non-existent images and get rid of the
>> references in the gtkrc.
>> That would be already a good start. :-)
>>
 > In any case, if really GIMP crashes because of this, that's not
 > normal. It should not crash on wrong input. Could you please open a
 > bug report: https://bugzilla.gnome.org/enter_bug.cgi?product=GIMP
>>>
>>>

 > Then a developer (maybe me) will look into it when we have some time,
 > and we'll try to reproduce the crash.
>>>
>>>
>>>  I will do so.
>>
>> Well, now that I have fixed the bug, I may as well take care of the
>> bug ticket too, I guess.
>> Thanks for the report anyway.
>>
>> Jehan
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list


Re: [Gimp-developer] Fwd: GIMP Icons

2014-01-13 Thread Andrew Pullins
So I was wondering how do I specify icon sizes in the imagerc file?  so for
example their are four channel icons.  A 16x16, 24x24, 32x32, and 48x48
icon. Here is code from my imagerc file that likes to my center icon.

  stock["gimp-channel"] =
{
  { "images/stock-channel-24.svg", *, *, "gtk-button" },
  { "images/stock-channel-24.svg", *, ACTIVE, "gtk-button" },
  { "images/stock-channel-24.svg", *, PRELIGHT, "gtk-button" },
  { "images/stock-channel-24.svg", *, *, *}
}

would I copy this and have two sets linking to the different icons like
this?

  stock["gimp-channel-16"] =
{
  { "images/stock-channel-16.svg", *, *, "gtk-button" },
  { "images/stock-channel-16.svg", *, ACTIVE, "gtk-button" },
  { "images/stock-channel-16.svg", *, PRELIGHT, "gtk-button" },
  { "images/stock-channel-16.svg", *, *, *}
}
  stock["gimp-channel-24"] =
{
  { "images/stock-channel-24.svg", *, *, "gtk-button" },
  { "images/stock-channel-24.svg", *, ACTIVE, "gtk-button" },
  { "images/stock-channel-24.svg", *, PRELIGHT, "gtk-button" },
  { "images/stock-channel-24.svg", *, *, *}
}
etc.


On Wed, Dec 4, 2013 at 7:09 AM, Jehan Pagès wrote:

> Hi,
>
> On Mon, Nov 18, 2013 at 1:06 AM, Jehan Pagès 
> wrote:
> > Hi again,
> >
> > On Mon, Nov 18, 2013 at 12:25 AM, Jehan Pagès
> >  wrote:
> >> Hi,
> >>
> >> On Fri, Nov 15, 2013 at 9:41 AM, Michael Henning
> >>  wrote:
> >>> This was replied to just me, so I'm forwarding it to the entire list.
> >>
> >> Thanks Michael.
> >>
> >>>
> >>> -- Forwarded message --
> >>> From: Andrew Pullins 
> >>> Date: Thu, Nov 14, 2013 at 2:15 AM
> >>> Subject: Re: [Gimp-developer] GIMP Icons
> >>> To: Michael Henning 
> >>>
> >>>
> >>>
>  > You have not answered to the question. What version is it *exactly*?
>  > The last is 2.8.8. Just "2.8" is not enough, there has been 4 minor
>  > versions in 2.8. Please check the About of the program.
> >>>
> >>>
> >>> here are some comments form my DeviantArt
> >>>
> >>> Linux
> >>>
> >>> Works fine on Debian Wheezy / Gimp 2.8.x
> >>>
> >>> Dark theme crashes on Ubuntu 12.04, but Light works fine.
> >>
> >> I just tested on my Linux Mint. The dark theme crashes too.
> >> So I tracked the bug. As I thought, the issue is in GTK+. I have fixed
> >> it on my locale development and will upload the patch tomorrow on
> >> Bugzilla (I want first to do a few more tests and see if it affects
> >> GTK+ 3 as well. But for now, I must sleep).
> >
> > Well in the end, I did not want to push it to tomorrow. So I just
> > tested and made the ticket now.
> > See https://bugzilla.gnome.org/show_bug.cgi?id=712536
> >
> > With this patch, we will handle better broken themes.
>
> Just for your information, the patch has made it upstream and new
> stables releases of GTK+ are planned for this week. Not sure when it
> would make it to your distribution but when it will, the particular
> crashes you experienced will be fixed (unless there were other issues
> I could not discover) with GTK+ 2.24.23.
>
> This being said, even though GTK+ will be now robuster on a faulty
> theme, I would still suggest you to fix your theme with the
> indications I gave you earlier. Then you don't have to ask your users
> to wait for an updated GTK+. :-)
> Bye!
>
> Jehan
>
> >
> > In the meantime, you should fix your theme if you want it to work with
> > current GTK+.
> > In particular, just remove all the gap_file, gap_start_file and
> > gap_end_file in your gtkrc which do not correspond to an existing
> > image. These were the pieces of the gtkrc which was making GTK+ crash.
> > Regards,
> >
> > Jehan
> >
> >>
> >>> [...]
> >>
>  > There seems to be a lot of missing icons in your set, and more
>  > problematic, several errors in the gtkrc.
>  > So that may explain why it does not work well (or at all) for some
>  > people (maybe it depends on the version of GTK+ installed). The best
>  > on your side would be to fix at least the gtkrc.
> >>>
> >>>
> >>>  well I can see how I messed some icons, there are a lot. as for the
> >>> gtkrc I kinda just took a bunch of different themes mashed them
> >>> together and ctrl found colors till switching them out got the look I
> >>> wanted. I honestly have no idea what I'm doing with these themes. I
> >>> did not know there was anything wrong with the gtkrc and have no idea
> >>> where to start. I really wanted this to be a GMIP only theme, there
> >>> seems to be a lot of GIMIP themes out there that can be used for many
> >>> applications and there for have a lot of extra stuff that GIMP dose
> >>> not need.
> >>
> >> I see. Well if you just follow all the warning output in a terminal,
> >> you can at least track all the non-existent images and get rid of the
> >> references in the gtkrc.
> >> That would be already a good start. :-)
> >>
>  > In any case, if really GIMP crashes because of this, that's not
>