[jira] [Commented] (GIRAPH-64) Create VertexRunner to make it easier to run users' computations

[Hyunsik Choi (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146023#comment-13146023
 ] 

Hyunsik Choi commented on GIRAPH-64:


In my case, 'mvn package' is ok, but 'mvn assembly:assembly' incurs the error 
as I mentioned above.

{code}
hyunsik@code:~$ mvn --version
Apache Maven 3.0.3 (r1075438; 2011-03-01 02:31:09+0900)
Maven home: /home/hyunsik/Local/maven-3
Java version: 1.6.0_26, vendor: Sun Microsystems Inc.
Java home: /usr/lib/jvm/java-6-sun-1.6.0.26/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.0.0-12-generic", arch: "amd64", family: "unix"
{code}

> Create VertexRunner to make it easier to run users' computations
> 
>
> Key: GIRAPH-64
> URL: https://issues.apache.org/jira/browse/GIRAPH-64
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Jakob Homan
>Assignee: Jakob Homan
> Attachments: GIRAPH-64.patch
>
>
> Currently, if a user wants to implement a Giraph algorithm by extending 
> {{Vertex}} they must also write all the boilerplate around the {{Tool}} 
> interface and bundle it with the Giraph jar (or get Giraph on the classpath 
> and playing nice with the implementation).  For example, what is included in 
> the PageRankBenchmark and what Kohei has done: 
> https://github.com/smly/java-Giraph-LabelPropagation  It would be better if 
> we had perhaps a Vertex implementation to be subclassed that already had all 
> the standard Tooling included such that all one had to run would be (assuming 
> the Giraph jar was already on the classpath):
> {noformat}hadoop jar my-awesome-vertex.jar my.awesome.vertex -i jazz_input -o 
> jazz_output -if org.apache.giraph.lib.in.text.adjacency-list.LongDoubleDouble 
> -of org.apache.giraph.lib.out.text.adjacency-list.LongDoubleDouble{noformat} 
> This wouldn't work with every algorithm, but would be useful in a large 
> number of cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[Claudio Martella]

OK, thanks!

On Mon, Nov 7, 2011 at 11:12 PM, Hudson (Commented) (JIRA)
 wrote:
>
>    [ 
> https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145874#comment-13145874
>  ]
>
> Hudson commented on GIRAPH-47:
> --
>
> Integrated in Giraph-trunk-Commit #24 (See 
> [https://builds.apache.org/job/Giraph-trunk-Commit/24/])
>    GIRAPH-47: Export Worker's Context/State to vertices through
> pre/post/Application/Superstep. (cmartella via aching)
>
> aching : 
> http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198972
> Files :
> * /incubator/giraph/trunk/CHANGELOG
> * /incubator/giraph/trunk/CODE_CONVENTIONS
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
> * /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java
> * /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
> * /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
> * 
> /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerContext.java
> * 
> /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java
> * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
> * 
> /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java
> * 
> /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java
> * 
> /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestVertexRangeBalancer.java
>
>
>> Export Worker's Context/State to vertices through 
>> pre/post/Application/Superstep
>> 
>>
>>                 Key: GIRAPH-47
>>                 URL: https://issues.apache.org/jira/browse/GIRAPH-47
>>             Project: Giraph
>>          Issue Type: Improvement
>>          Components: graph
>>    Affects Versions: 0.70.0
>>            Reporter: Claudio Martella
>>            Assignee: Claudio Martella
>>         Attachments: GIRAPH-47.diff, GIRAPH-47.diff, GIRAPH-47.diff
>>
>>
>> It would be quite useful for vertices to reach some worker-related 
>> information stored i.e. in the GraphState class.
>> This information could be exported as a parameter to 
>> pre/post/Application/Superstep like this:
>> public void preApplication(Configurable workerObject);
>> public void postApplication(Configurable workerObject);
>> public void preSuperstep(Configurable workerObject);
>> public void postSuperstep(Configurable workerObject);
>> public Configurable getWorkerObject();
>> Another possibility is to add a Context inner class to BasicVertex to store 
>> this information.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA 
> administrators: 
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>



-- 
    Claudio Martella
    claudio.marte...@gmail.com

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[Avery Ching (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145879#comment-13145879
 ] 

Avery Ching commented on GIRAPH-47:
---

I filed issue https://issues.apache.org/jira/browse/INFRA-4097.

Something is weird with hudson, cannot find mvn.

https://builds.apache.org/job/Giraph-trunk-Commit/24/console

[Giraph-trunk-Commit] $ /bin/bash -x /tmp/hudson6174557603739055037.sh
+ export JAVA_HOME=/home/jenkins/tools/java/latest
+ JAVA_HOME=/home/jenkins/tools/java/latest
+ export MAVEN_HOME=/home/jenkins/tools/maven/latest
+ MAVEN_HOME=/home/jenkins/tools/maven/latest
+ export 
PATH=/home/jenkins/tools/java/latest/bin:/home/jenkins/tools/maven/latest/bin:/home/hudson/tools/java/latest1.6/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/games:/home/hudson/.rvm/bin
+ 
PATH=/home/jenkins/tools/java/latest/bin:/home/jenkins/tools/maven/latest/bin:/home/hudson/tools/java/latest1.6/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/games:/home/hudson/.rvm/bin
+ which java
/home/hudson/tools/java/latest1.6/bin/java
+ cd /home/hudson/hudson-slave/workspace/Giraph-trunk-Commit/trunk
+ /home/jenkins/tools/maven/latest/bin/mvn clean compile test
/tmp/hudson6174557603739055037.sh: line 9: 
/home/jenkins/tools/maven/latest/bin/mvn: No such file or directory
Build step 'Execute shell' marked build as failure
Updating GIRAPH-47
Recording test results
Finished: FAILURE


> Export Worker's Context/State to vertices through 
> pre/post/Application/Superstep
> 
>
> Key: GIRAPH-47
> URL: https://issues.apache.org/jira/browse/GIRAPH-47
> Project: Giraph
>  Issue Type: Improvement
>  Components: graph
>Affects Versions: 0.70.0
>Reporter: Claudio Martella
>Assignee: Claudio Martella
> Attachments: GIRAPH-47.diff, GIRAPH-47.diff, GIRAPH-47.diff
>
>
> It would be quite useful for vertices to reach some worker-related 
> information stored i.e. in the GraphState class.
> This information could be exported as a parameter to 
> pre/post/Application/Superstep like this:
> public void preApplication(Configurable workerObject);
> public void postApplication(Configurable workerObject);
> public void preSuperstep(Configurable workerObject);
> public void postSuperstep(Configurable workerObject);
> public Configurable getWorkerObject();
> Another possibility is to add a Context inner class to BasicVertex to store 
> this information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145874#comment-13145874
 ] 

Hudson commented on GIRAPH-47:
--

Integrated in Giraph-trunk-Commit #24 (See 
[https://builds.apache.org/job/Giraph-trunk-Commit/24/])
GIRAPH-47: Export Worker's Context/State to vertices through
pre/post/Application/Superstep. (cmartella via aching)

aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198972
Files : 
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/CODE_CONVENTIONS
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerContext.java
* 
/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
* 
/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java
* 
/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java
* 
/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestVertexRangeBalancer.java


> Export Worker's Context/State to vertices through 
> pre/post/Application/Superstep
> 
>
> Key: GIRAPH-47
> URL: https://issues.apache.org/jira/browse/GIRAPH-47
> Project: Giraph
>  Issue Type: Improvement
>  Components: graph
>Affects Versions: 0.70.0
>Reporter: Claudio Martella
>Assignee: Claudio Martella
> Attachments: GIRAPH-47.diff, GIRAPH-47.diff, GIRAPH-47.diff
>
>
> It would be quite useful for vertices to reach some worker-related 
> information stored i.e. in the GraphState class.
> This information could be exported as a parameter to 
> pre/post/Application/Superstep like this:
> public void preApplication(Configurable workerObject);
> public void postApplication(Configurable workerObject);
> public void preSuperstep(Configurable workerObject);
> public void postSuperstep(Configurable workerObject);
> public Configurable getWorkerObject();
> Another possibility is to add a Context inner class to BasicVertex to store 
> this information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[Avery Ching (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145868#comment-13145868
 ] 

Avery Ching commented on GIRAPH-47:
---

+1
Thanks Claudio. I'm going to commit on your behalf.  I made a few small changes 
to fix the code conventions.  I also fixed a bug in the distributed unittests 
(WorkerContext not set for TestAutoCheckpoint).  The local unittests can't 
catch that one.  Next time, you'll want to run against a real Hadoop instance 
to catch problems (i.e.  mvn test -Dprop.mapred.job.tracker=localhost:50300).  
You'll want to replace 'localhost:50300' with your actual Hadoop jobtracker and 
port settings.  



> Export Worker's Context/State to vertices through 
> pre/post/Application/Superstep
> 
>
> Key: GIRAPH-47
> URL: https://issues.apache.org/jira/browse/GIRAPH-47
> Project: Giraph
>  Issue Type: Improvement
>  Components: graph
>Affects Versions: 0.70.0
>Reporter: Claudio Martella
>Assignee: Claudio Martella
> Attachments: GIRAPH-47.diff, GIRAPH-47.diff, GIRAPH-47.diff
>
>
> It would be quite useful for vertices to reach some worker-related 
> information stored i.e. in the GraphState class.
> This information could be exported as a parameter to 
> pre/post/Application/Superstep like this:
> public void preApplication(Configurable workerObject);
> public void postApplication(Configurable workerObject);
> public void preSuperstep(Configurable workerObject);
> public void postSuperstep(Configurable workerObject);
> public Configurable getWorkerObject();
> Another possibility is to add a Context inner class to BasicVertex to store 
> this information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: FOSDEM

[Avery Ching]

I think it would be great if someone could talk about Giraph at FOSDEM.  
Thanks for volunteering, Claudio.  I'm not planning to be there 
unfortunately.


Avery

On 11/7/11 12:33 PM, Claudio Martella wrote:

Hello list,

I was thinking about submitting for a talk at fosdem with topic Pregel
&  Giraph. Am I overlapping with somebody else?


Best,
Claudio

FOSDEM

[Claudio Martella]

Hello list,

I was thinking about submitting for a talk at fosdem with topic Pregel
& Giraph. Am I overlapping with somebody else?


Best,
Claudio

-- 
    Claudio Martella
    claudio.marte...@gmail.com

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[jirapos...@reviews.apache.org (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145766#comment-13145766
 ] 

jirapos...@reviews.apache.org commented on GIRAPH-47:
-



bq.  On 2011-11-07 19:12:55, Avery Ching wrote:
bq.  > Claudio, really nice stuff here.  Most of my comments are related to 
indenting.  But otherwise, this is a lot better IMO.  Please take a look at 
CODE_CONVENTIONS and fix accordingly.  While the official policy is 2 space, at 
this time, for the 4 space indented files, please keep to 4 spaces for 
consistency.  We will transition everything over at some point.  New files can 
be 2 space (new convention) if desired.
bq.  
bq.  Claudio Martella wrote:
bq.  Ok, still have to understand a bit the code conventions. Trying to 
stick to them. Maybe an Eclipse format conf file would help? Could you share 
yours, if you have one?

Mine is all messed up too.  I have to manually fix some things.


bq.  On 2011-11-07 19:12:55, Avery Ching wrote:
bq.  > 
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java,
 line 150
bq.  > 
bq.  >
bq.  > This doesn't need to be static anymore.
bq.  
bq.  Claudio Martella wrote:
bq.  Can't make it non static. Won't be able to read from tests.

Sorry I wasn't more clear, I was suggesting that we fix this.  But it's not 
really related to this issue.  So don't worry about it.  Please ignore my 
comment.


bq.  On 2011-11-07 19:12:55, Avery Ching wrote:
bq.  > 
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java,
 lines 91-92
bq.  > 
bq.  >
bq.  > These no longer need to be static anymore, could be private 
variables that have public accessor method.
bq.  
bq.  Claudio Martella wrote:
bq.  Not sure we can do this. How will tests get to their values. Can't 
access those members if not static.

I was suggesting that we fix this, maybe give the user the worker context at 
the end.  Actually not sure it's the right solution and it's not really related 
to this issue.  So don't worry about it.  Please ignore my comment.


- Avery


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2746/#review3082
---


On 2011-11-07 19:09:08, Avery Ching wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2746/
bq.  ---
bq.  
bq.  (Updated 2011-11-07 19:09:08)
bq.  
bq.  
bq.  Review request for giraph.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Claudio's patch for GIRAPH-47.
bq.  
bq.  
bq.  This addresses bug GIRAPH-47.
bq.  https://issues.apache.org/jira/browse/GIRAPH-47
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
 PRE-CREATION 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerC

[jira] [Updated] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[Claudio Martella (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claudio Martella updated GIRAPH-47:
---

Attachment: GIRAPH-47.diff

Should fix the issues from review. Also, I added the implementation of 
AggregatorUsage to WorkerContext.

> Export Worker's Context/State to vertices through 
> pre/post/Application/Superstep
> 
>
> Key: GIRAPH-47
> URL: https://issues.apache.org/jira/browse/GIRAPH-47
> Project: Giraph
>  Issue Type: Improvement
>  Components: graph
>Affects Versions: 0.70.0
>Reporter: Claudio Martella
>Assignee: Claudio Martella
> Attachments: GIRAPH-47.diff, GIRAPH-47.diff, GIRAPH-47.diff
>
>
> It would be quite useful for vertices to reach some worker-related 
> information stored i.e. in the GraphState class.
> This information could be exported as a parameter to 
> pre/post/Application/Superstep like this:
> public void preApplication(Configurable workerObject);
> public void postApplication(Configurable workerObject);
> public void preSuperstep(Configurable workerObject);
> public void postSuperstep(Configurable workerObject);
> public Configurable getWorkerObject();
> Another possibility is to add a Context inner class to BasicVertex to store 
> this information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Review Request: GIRAPH-47 Export Worker's Context/State to vertices through pre/post/Application/Superstep

[Avery Ching]

> On 2011-11-07 19:12:55, Avery Ching wrote:
> > Claudio, really nice stuff here.  Most of my comments are related to 
> > indenting.  But otherwise, this is a lot better IMO.  Please take a look at 
> > CODE_CONVENTIONS and fix accordingly.  While the official policy is 2 
> > space, at this time, for the 4 space indented files, please keep to 4 
> > spaces for consistency.  We will transition everything over at some point.  
> > New files can be 2 space (new convention) if desired.
> 
> Claudio Martella wrote:
> Ok, still have to understand a bit the code conventions. Trying to stick 
> to them. Maybe an Eclipse format conf file would help? Could you share yours, 
> if you have one?

Mine is all messed up too.  I have to manually fix some things.


> On 2011-11-07 19:12:55, Avery Ching wrote:
> > http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java,
> >  line 150
> > 
> >
> > This doesn't need to be static anymore.
> 
> Claudio Martella wrote:
> Can't make it non static. Won't be able to read from tests.

Sorry I wasn't more clear, I was suggesting that we fix this.  But it's not 
really related to this issue.  So don't worry about it.  Please ignore my 
comment.


> On 2011-11-07 19:12:55, Avery Ching wrote:
> > http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java,
> >  lines 91-92
> > 
> >
> > These no longer need to be static anymore, could be private variables 
> > that have public accessor method.
> 
> Claudio Martella wrote:
> Not sure we can do this. How will tests get to their values. Can't access 
> those members if not static.

I was suggesting that we fix this, maybe give the user the worker context at 
the end.  Actually not sure it's the right solution and it's not really related 
to this issue.  So don't worry about it.  Please ignore my comment.


- Avery


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2746/#review3082
---


On 2011-11-07 19:09:08, Avery Ching wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2746/
> ---
> 
> (Updated 2011-11-07 19:09:08)
> 
> 
> Review request for giraph.
> 
> 
> Summary
> ---
> 
> Claudio's patch for GIRAPH-47.
> 
> 
> This addresses bug GIRAPH-47.
> https://issues.apache.org/jira/browse/GIRAPH-47
> 
> 
> Diffs
> -
> 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
>  PRE-CREATION 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java
>  PRE-CREATION 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/gi

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[jirapos...@reviews.apache.org (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145754#comment-13145754
 ] 

jirapos...@reviews.apache.org commented on GIRAPH-47:
-



bq.  On 2011-11-07 19:12:55, Avery Ching wrote:
bq.  > Claudio, really nice stuff here.  Most of my comments are related to 
indenting.  But otherwise, this is a lot better IMO.  Please take a look at 
CODE_CONVENTIONS and fix accordingly.  While the official policy is 2 space, at 
this time, for the 4 space indented files, please keep to 4 spaces for 
consistency.  We will transition everything over at some point.  New files can 
be 2 space (new convention) if desired.

Ok, still have to understand a bit the code conventions. Trying to stick to 
them. Maybe an Eclipse format conf file would help? Could you share yours, if 
you have one?


bq.  On 2011-11-07 19:12:55, Avery Ching wrote:
bq.  > 
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java,
 lines 91-92
bq.  > 
bq.  >
bq.  > These no longer need to be static anymore, could be private 
variables that have public accessor method.

Not sure we can do this. How will tests get to their values. Can't access those 
members if not static.


bq.  On 2011-11-07 19:12:55, Avery Ching wrote:
bq.  > 
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java,
 lines 250-251
bq.  > 
bq.  >
bq.  > Align to GiraphJob.WORKER_CONTEXT_CLASS

What do you mean? I aligned to the example, all classes are set with 
.setClass() there. Fixing the whole thing.


bq.  On 2011-11-07 19:12:55, Avery Ching wrote:
bq.  > 
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java,
 line 150
bq.  > 
bq.  >
bq.  > This doesn't need to be static anymore.

Can't make it non static. Won't be able to read from tests.


- Claudio


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2746/#review3082
---


On 2011-11-07 19:09:08, Avery Ching wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2746/
bq.  ---
bq.  
bq.  (Updated 2011-11-07 19:09:08)
bq.  
bq.  
bq.  Review request for giraph.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Claudio's patch for GIRAPH-47.
bq.  
bq.  
bq.  This addresses bug GIRAPH-47.
bq.  https://issues.apache.org/jira/browse/GIRAPH-47
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
 PRE-CREATION 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
 1198865 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java
 PRE-CREATION 
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Girap

Re: Review Request: GIRAPH-47 Export Worker's Context/State to vertices through pre/post/Application/Superstep

[Claudio Martella]

> On 2011-11-07 19:12:55, Avery Ching wrote:
> > Claudio, really nice stuff here.  Most of my comments are related to 
> > indenting.  But otherwise, this is a lot better IMO.  Please take a look at 
> > CODE_CONVENTIONS and fix accordingly.  While the official policy is 2 
> > space, at this time, for the 4 space indented files, please keep to 4 
> > spaces for consistency.  We will transition everything over at some point.  
> > New files can be 2 space (new convention) if desired.

Ok, still have to understand a bit the code conventions. Trying to stick to 
them. Maybe an Eclipse format conf file would help? Could you share yours, if 
you have one?


> On 2011-11-07 19:12:55, Avery Ching wrote:
> > http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java,
> >  lines 91-92
> > 
> >
> > These no longer need to be static anymore, could be private variables 
> > that have public accessor method.

Not sure we can do this. How will tests get to their values. Can't access those 
members if not static.


> On 2011-11-07 19:12:55, Avery Ching wrote:
> > http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java,
> >  lines 250-251
> > 
> >
> > Align to GiraphJob.WORKER_CONTEXT_CLASS

What do you mean? I aligned to the example, all classes are set with 
.setClass() there. Fixing the whole thing.


> On 2011-11-07 19:12:55, Avery Ching wrote:
> > http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java,
> >  line 150
> > 
> >
> > This doesn't need to be static anymore.

Can't make it non static. Won't be able to read from tests.


- Claudio


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2746/#review3082
---


On 2011-11-07 19:09:08, Avery Ching wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2746/
> ---
> 
> (Updated 2011-11-07 19:09:08)
> 
> 
> Review request for giraph.
> 
> 
> Summary
> ---
> 
> Claudio's patch for GIRAPH-47.
> 
> 
> This addresses bug GIRAPH-47.
> https://issues.apache.org/jira/browse/GIRAPH-47
> 
> 
> Diffs
> -
> 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
>  PRE-CREATION 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java
>  PRE-CREATION 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
>  1198865 
>   
> http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/ma

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[jirapos...@reviews.apache.org (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145716#comment-13145716
 ] 

jirapos...@reviews.apache.org commented on GIRAPH-47:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2746/#review3082
---


Claudio, really nice stuff here.  Most of my comments are related to indenting. 
 But otherwise, this is a lot better IMO.  Please take a look at 
CODE_CONVENTIONS and fix accordingly.  While the official policy is 2 space, at 
this time, for the 4 space indented files, please keep to 4 spaces for 
consistency.  We will transition everything over at some point.  New files can 
be 2 space (new convention) if desired.


http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


This doesn't need to be static anymore.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


Indenting should be 8 spaces.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


extra line.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


extra line.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


4 spaces.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


4 spaces indenting.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


4 spaces indenting.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


Align to GiraphJob.WORKER_CONTEXT_CLASS



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java


VERTEX_COUNT shouldn't be capitalized.  All caps should be reserved for 
only static values.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java


EDGE_COUNT shouldn't be capitalized.  All caps should be reserved for only 
static values.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java


These no longer need to be static anymore, could be private variables that 
have public accessor method.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java


Might want to add a comment about this example.  I.e.

/**
 * Fully runnable example of how to 
 * emit worker data to HDFS during a graph
 * computation.
 */



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java


extra line.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java


Awesome, I hated this.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java


indenting.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java


extra line.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerContext.java


Other javadoc has lines in between comment and params (i.e.

* superstep starts.
*
* @throws IllegalAccessException


- Avery


On 2011-11-07 19:09:08, Avery Ching wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq

Re: Review Request: GIRAPH-47 Export Worker's Context/State to vertices through pre/post/Application/Superstep

[Avery Ching]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2746/#review3082
---


Claudio, really nice stuff here.  Most of my comments are related to indenting. 
 But otherwise, this is a lot better IMO.  Please take a look at 
CODE_CONVENTIONS and fix accordingly.  While the official policy is 2 space, at 
this time, for the 4 space indented files, please keep to 4 spaces for 
consistency.  We will transition everything over at some point.  New files can 
be 2 space (new convention) if desired.


http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


This doesn't need to be static anymore.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


Indenting should be 8 spaces.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


extra line.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


extra line.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


4 spaces.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


4 spaces indenting.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


4 spaces indenting.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java


Align to GiraphJob.WORKER_CONTEXT_CLASS



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java


VERTEX_COUNT shouldn't be capitalized.  All caps should be reserved for 
only static values.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java


EDGE_COUNT shouldn't be capitalized.  All caps should be reserved for only 
static values.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java


These no longer need to be static anymore, could be private variables that 
have public accessor method.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java


Might want to add a comment about this example.  I.e.

/**
 * Fully runnable example of how to 
 * emit worker data to HDFS during a graph
 * computation.
 */



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java


extra line.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java


Awesome, I hated this.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java


indenting.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java


extra line.



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerContext.java


Other javadoc has lines in between comment and params (i.e.

* superstep starts.
*
* @throws IllegalAccessException


- Avery


On 2011-11-07 19:09:08, Avery Ching wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2746/
> ---
> 
> (Updated 2011-11-07 19:09:08)
> 
> 
> Review request for giraph.
> 
> 
> Summary
> ---
> 
> Claudio's patch for GIRAPH-47.
> 
> 
> This addresses bug GIRAPH-47.
> https://issues.apac

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[jirapos...@reviews.apache.org (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145715#comment-13145715
 ] 

jirapos...@reviews.apache.org commented on GIRAPH-47:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2746/
---

Review request for giraph.


Summary
---

Claudio's patch for GIRAPH-47.


This addresses bug GIRAPH-47.
https://issues.apache.org/jira/browse/GIRAPH-47


Diffs
-

  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerContext.java
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestVertexRangeBalancer.java
 1198865 

Diff: https://reviews.apache.org/r/2746/diff


Testing
---

mvn install


Thanks,

Avery



> Export Worker's Context/State to vertices through 
> pre/post/Application/Superstep
> 
>
> Key: GIRAPH-47
> URL: https://issues.apache.org/jira/browse/GIRAPH-47
> Project: Giraph
>  Issue Type: Improvement
>  Components: graph
>Affects Versions: 0.70.0
>Reporter: Claudio Martella
>Assignee: Claudio Martella
> Attachments: GIRAPH-47.diff, GIRAPH-47.diff
>
>
> It would be quite useful for vertices to reach some worker-related 
> information stored i.e. in the GraphState class.
> This information could be exported as a parameter to 
> pre/post/Application/Superstep like this:
> public void preApplication(Configurable workerObject);
> public void postApplication(Configurable workerObject);
> public void preSuperstep(Configurable workerObject);
> public void postSuperstep(Configurable workerObject);
> public Configurable getWorkerObject();
> Another possibility is to add a Context inner class to BasicVertex to store 
> this information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIR

Review Request: GIRAPH-47 Export Worker's Context/State to vertices through pre/post/Application/Superstep

[Avery Ching]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2746/
---

Review request for giraph.


Summary
---

Claudio's patch for GIRAPH-47.


This addresses bug GIRAPH-47.
https://issues.apache.org/jira/browse/GIRAPH-47


Diffs
-

  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerContext.java
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java
 1198865 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestVertexRangeBalancer.java
 1198865 

Diff: https://reviews.apache.org/r/2746/diff


Testing
---

mvn install


Thanks,

Avery

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[Avery Ching (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145694#comment-13145694
 ] 

Avery Ching commented on GIRAPH-47:
---

Sorry, Claudio, my bad.  I still had remnants of GIRAPH-64.  It's fine and 
passes local unittests.  

> Export Worker's Context/State to vertices through 
> pre/post/Application/Superstep
> 
>
> Key: GIRAPH-47
> URL: https://issues.apache.org/jira/browse/GIRAPH-47
> Project: Giraph
>  Issue Type: Improvement
>  Components: graph
>Affects Versions: 0.70.0
>Reporter: Claudio Martella
>Assignee: Claudio Martella
> Attachments: GIRAPH-47.diff, GIRAPH-47.diff
>
>
> It would be quite useful for vertices to reach some worker-related 
> information stored i.e. in the GraphState class.
> This information could be exported as a parameter to 
> pre/post/Application/Superstep like this:
> public void preApplication(Configurable workerObject);
> public void postApplication(Configurable workerObject);
> public void preSuperstep(Configurable workerObject);
> public void postSuperstep(Configurable workerObject);
> public Configurable getWorkerObject();
> Another possibility is to add a Context inner class to BasicVertex to store 
> this information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-64) Create VertexRunner to make it easier to run users' computations

[Avery Ching (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145687#comment-13145687
 ] 

Avery Ching commented on GIRAPH-64:
---

$ mvn --version
Apache Maven 3.0.3 (r1075438; 2011-02-28 09:31:09-0800)
Maven home: /usr/share/maven
Java version: 1.6.0_26, vendor: Apple Inc.
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: en_US, platform encoding: MacRoman
OS name: "mac os x", version: "10.6.8", arch: "x86_64", family: "mac"

> Create VertexRunner to make it easier to run users' computations
> 
>
> Key: GIRAPH-64
> URL: https://issues.apache.org/jira/browse/GIRAPH-64
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Jakob Homan
>Assignee: Jakob Homan
> Attachments: GIRAPH-64.patch
>
>
> Currently, if a user wants to implement a Giraph algorithm by extending 
> {{Vertex}} they must also write all the boilerplate around the {{Tool}} 
> interface and bundle it with the Giraph jar (or get Giraph on the classpath 
> and playing nice with the implementation).  For example, what is included in 
> the PageRankBenchmark and what Kohei has done: 
> https://github.com/smly/java-Giraph-LabelPropagation  It would be better if 
> we had perhaps a Vertex implementation to be subclassed that already had all 
> the standard Tooling included such that all one had to run would be (assuming 
> the Giraph jar was already on the classpath):
> {noformat}hadoop jar my-awesome-vertex.jar my.awesome.vertex -i jazz_input -o 
> jazz_output -if org.apache.giraph.lib.in.text.adjacency-list.LongDoubleDouble 
> -of org.apache.giraph.lib.out.text.adjacency-list.LongDoubleDouble{noformat} 
> This wouldn't work with every algorithm, but would be useful in a large 
> number of cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira