[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars
[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192385#comment-13192385 ] Jakob Homan commented on GIRAPH-129: This builds the javadoc and source jars with each run of package. I'm ok with this, but is there any reason to only create these jars when directly called? > enable creation of javadoc and sources jars > --- > > Key: GIRAPH-129 > URL: https://issues.apache.org/jira/browse/GIRAPH-129 > Project: Giraph > Issue Type: Improvement > Components: build >Affects Versions: 0.1.0 >Reporter: André Kelpe >Priority: Minor > Attachments: GIRAPH-129.patch > > > It is pretty useful to enable the creation if javadoc and sources jars during > the build, so that people using IDEs like eclipse can easily jump into the > code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars
[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192405#comment-13192405 ] André Kelpe commented on GIRAPH-129: What exactly do you mean with "when directly called"? > enable creation of javadoc and sources jars > --- > > Key: GIRAPH-129 > URL: https://issues.apache.org/jira/browse/GIRAPH-129 > Project: Giraph > Issue Type: Improvement > Components: build >Affects Versions: 0.1.0 >Reporter: André Kelpe >Assignee: André Kelpe >Priority: Minor > Attachments: GIRAPH-129.patch > > > It is pretty useful to enable the creation if javadoc and sources jars during > the build, so that people using IDEs like eclipse can easily jump into the > code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars
[
https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192430#comment-13192430
]
Jakob Homan commented on GIRAPH-129:
In contrast to {{mvn javadoc:jar}} and {{mvn source:jar}}. One can call those
directly, with this change one gets them each time one builds the regular jar.
> enable creation of javadoc and sources jars
> ---
>
> Key: GIRAPH-129
> URL: https://issues.apache.org/jira/browse/GIRAPH-129
> Project: Giraph
> Issue Type: Improvement
> Components: build
>Affects Versions: 0.1.0
>Reporter: André Kelpe
>Assignee: André Kelpe
>Priority: Minor
> Attachments: GIRAPH-129.patch
>
>
> It is pretty useful to enable the creation if javadoc and sources jars during
> the build, so that people using IDEs like eclipse can easily jump into the
> code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars
[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192449#comment-13192449 ] André Kelpe commented on GIRAPH-129: It's good practice to enable them by default. I am used to do continuous integration with a central CI server that builds new snapshot-jars on every commit and then you always want to have the sources and javadoc jars available. I also tend to do everything automatically in poms I work with in contrast to working with lots or commandline options, b/c then you do not have to remember all the differences between all projects you are working on. (P.S.: Shouldn't the version of giraph be something like 0.1-SNAPSHOT? That would make it easier to introduce releases via the maven-release plugin later on.) > enable creation of javadoc and sources jars > --- > > Key: GIRAPH-129 > URL: https://issues.apache.org/jira/browse/GIRAPH-129 > Project: Giraph > Issue Type: Improvement > Components: build >Affects Versions: 0.1.0 >Reporter: André Kelpe >Assignee: André Kelpe >Priority: Minor > Attachments: GIRAPH-129.patch > > > It is pretty useful to enable the creation if javadoc and sources jars during > the build, so that people using IDEs like eclipse can easily jump into the > code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars
[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192887#comment-13192887 ] Avery Ching commented on GIRAPH-129: As long as mvn compile doesn't build the javadoc, I am happy. =) > enable creation of javadoc and sources jars > --- > > Key: GIRAPH-129 > URL: https://issues.apache.org/jira/browse/GIRAPH-129 > Project: Giraph > Issue Type: Improvement > Components: build >Affects Versions: 0.1.0 >Reporter: André Kelpe >Assignee: André Kelpe >Priority: Minor > Attachments: GIRAPH-129.patch > > > It is pretty useful to enable the creation if javadoc and sources jars during > the build, so that people using IDEs like eclipse can easily jump into the > code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars
[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192930#comment-13192930 ] André Kelpe commented on GIRAPH-129: No, no, it's bound to the package phase, don't worry :-) > enable creation of javadoc and sources jars > --- > > Key: GIRAPH-129 > URL: https://issues.apache.org/jira/browse/GIRAPH-129 > Project: Giraph > Issue Type: Improvement > Components: build >Affects Versions: 0.1.0 >Reporter: André Kelpe >Assignee: André Kelpe >Priority: Minor > Attachments: GIRAPH-129.patch > > > It is pretty useful to enable the creation if javadoc and sources jars during > the build, so that people using IDEs like eclipse can easily jump into the > code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars
[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193282#comment-13193282 ] Jakob Homan commented on GIRAPH-129: ok, sounds good. +1 on the patch. I'll commit it. > enable creation of javadoc and sources jars > --- > > Key: GIRAPH-129 > URL: https://issues.apache.org/jira/browse/GIRAPH-129 > Project: Giraph > Issue Type: Improvement > Components: build >Affects Versions: 0.1.0 >Reporter: André Kelpe >Assignee: André Kelpe >Priority: Minor > Attachments: GIRAPH-129.patch > > > It is pretty useful to enable the creation if javadoc and sources jars during > the build, so that people using IDEs like eclipse can easily jump into the > code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars
[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193308#comment-13193308 ] Jakob Homan commented on GIRAPH-129: bq. (P.S.: Shouldn't the version of giraph be something like 0.1-SNAPSHOT? That would make it easier to introduce releases via the maven-release plugin later on.) Yep. Wanna spin up a quick patch? > enable creation of javadoc and sources jars > --- > > Key: GIRAPH-129 > URL: https://issues.apache.org/jira/browse/GIRAPH-129 > Project: Giraph > Issue Type: Improvement > Components: build >Affects Versions: 0.1.0 >Reporter: André Kelpe >Assignee: André Kelpe >Priority: Minor > Fix For: 0.1.0 > > Attachments: GIRAPH-129.patch > > > It is pretty useful to enable the creation if javadoc and sources jars during > the build, so that people using IDEs like eclipse can easily jump into the > code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars
[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193361#comment-13193361 ] André Kelpe commented on GIRAPH-129: First of all thanks for accepting the patch. :-) What is your preferred way of dealing with those kind of small patches. One JIRA to collect them or do you want one per patch? I am asking, since I have one more idea to improve the project, which is enabling the creation of test-jars. Those are the unit tests packaged in a jar, which is super-useful if you want to use the MockUtils for writing tests in projects using giraph. I do this right now in a copy I maintain for usage within the company I work for, but it would be useful for everyone using giraph. If you want, I can make a general pom JIRA and add those things over there. > enable creation of javadoc and sources jars > --- > > Key: GIRAPH-129 > URL: https://issues.apache.org/jira/browse/GIRAPH-129 > Project: Giraph > Issue Type: Improvement > Components: build >Affects Versions: 0.1.0 >Reporter: André Kelpe >Assignee: André Kelpe >Priority: Minor > Fix For: 0.1.0 > > Attachments: GIRAPH-129.patch > > > It is pretty useful to enable the creation if javadoc and sources jars during > the build, so that people using IDEs like eclipse can easily jump into the > code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars
[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193373#comment-13193373 ] Jakob Homan commented on GIRAPH-129: I'm fine with either. I'm hoping to work on getting a release out this weekend, so if you've not got something by then, I'll probably throw one out. Generally, it's better to have separate patches, but this is a small thing, so any way it's done should be fine. > enable creation of javadoc and sources jars > --- > > Key: GIRAPH-129 > URL: https://issues.apache.org/jira/browse/GIRAPH-129 > Project: Giraph > Issue Type: Improvement > Components: build >Affects Versions: 0.1.0 >Reporter: André Kelpe >Assignee: André Kelpe >Priority: Minor > Fix For: 0.1.0 > > Attachments: GIRAPH-129.patch > > > It is pretty useful to enable the creation if javadoc and sources jars during > the build, so that people using IDEs like eclipse can easily jump into the > code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
