[jira] [Commented] (GIRAPH-171) total time in MasterThread.run() is calculated incorrectly
[ https://issues.apache.org/jira/browse/GIRAPH-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248175#comment-13248175 ] Avery Ching commented on GIRAPH-171: +1 Argh, it is inconsistent with the counter, GIRAPH_TIMERS_COUNTER_GROUP_NAME. Thanks for the fix Eugene! total time in MasterThread.run() is calculated incorrectly -- Key: GIRAPH-171 URL: https://issues.apache.org/jira/browse/GIRAPH-171 Project: Giraph Issue Type: Bug Reporter: Eugene Koontz Assignee: Eugene Koontz Attachments: GIRAPH-171.patch While running PageMarkBenchMark, I was seeing in the output: {{graph.MasterThread(172): total: Took 1.3336739262910001E9 seconds.}} This was because currently, in {{MasterThread.run()}}, we have: {code} LOG.info(total: Took + ((System.currentTimeMillis() / 1000.0d) - setupSecs) + seconds.); {code} but it should be: {code} LOG.info(total: Took + ((System.currentTimeMillis() - startMillis) / 1000.0d) + seconds.); {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-171) total time in MasterThread.run() is calculated incorrectly
[ https://issues.apache.org/jira/browse/GIRAPH-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248179#comment-13248179 ] Hudson commented on GIRAPH-171: --- Integrated in Giraph-trunk-Commit #96 (See [https://builds.apache.org/job/Giraph-trunk-Commit/96/]) GIRAPH-171: Total time in MasterThread.run() is calculated incorrectly (ekoontz via aching). (Revision 1310224) Result = SUCCESS aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1310224 Files : * /incubator/giraph/trunk/CHANGELOG * /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/MasterThread.java total time in MasterThread.run() is calculated incorrectly -- Key: GIRAPH-171 URL: https://issues.apache.org/jira/browse/GIRAPH-171 Project: Giraph Issue Type: Bug Reporter: Eugene Koontz Assignee: Eugene Koontz Attachments: GIRAPH-171.patch While running PageMarkBenchMark, I was seeing in the output: {{graph.MasterThread(172): total: Took 1.3336739262910001E9 seconds.}} This was because currently, in {{MasterThread.run()}}, we have: {code} LOG.info(total: Took + ((System.currentTimeMillis() / 1000.0d) - setupSecs) + seconds.); {code} but it should be: {code} LOG.info(total: Took + ((System.currentTimeMillis() - startMillis) / 1000.0d) + seconds.); {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira