[
https://issues.apache.org/jira/browse/GIRAPH-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Mannix updated GIRAPH-31:
------------------------------
Attachment: GIRAPH-31.diff
Updated patch - remove isSorted(), document the fact that the iterator may or
may not be sorted (and in fact is, in Vertex), and that users may subclass
either Vertex *or* MutableVertex.
I have not tested subclassing BasicVertex, which I suspect would fail in
various ways, as VertexReader, GraphMapper, and some other classes may expect
to get a MutableVertex for some methods.
> Hide the SortedMap<I, Edge<I,E>> in Vertex from client visibility (impl.
> detail), replace with appropriate accessor methods
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-31
> URL: https://issues.apache.org/jira/browse/GIRAPH-31
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Jake Mannix
> Assignee: Jake Mannix
> Attachments: GIRAPH-31.diff, GIRAPH-31.diff
>
>
> As discussed on the list, and on GIRAPH-28, the SortedMap<I, Edge<I,E>> is an
> implementation detail which needs not be exposed to application developers -
> they need to iterate over the edges, and possibly access them one-by-one, and
> remove them (in the Mutable case), but they don't need the SortedMap, and
> creating primitive-optimized BasicVertex implementations is hampered by the
> fact that clients expect this Map to exist.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
