[EGIT] [website/www-content] master 01/01: Wiki page yocto-start changed with summary [] by Philippe Jean Guillaumie
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=204893488ac17304f48cff8621bdc05757e39f0a commit 204893488ac17304f48cff8621bdc05757e39f0a Author: Philippe Jean Guillaumie Date: Thu Nov 30 23:54:15 2017 -0800 Wiki page yocto-start changed with summary [] by Philippe Jean Guillaumie --- pages/docs/distros/yocto-start.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/docs/distros/yocto-start.txt b/pages/docs/distros/yocto-start.txt index 7f185a43e..6dab90b88 100644 --- a/pages/docs/distros/yocto-start.txt +++ b/pages/docs/distros/yocto-start.txt @@ -1,4 +1,4 @@ -~~Title: Yocto~~ +~~Title: EFL on Yocto~~ Yocto In Yocto, a ''meta-efl'' layer is provided by the ''meta-openembedded'' layer. It contains EFL, Elementary, Enlightenment, Terminology and other recipes. --
[EGIT] [website/www-content] master 01/01: Wiki page opensuse-start changed with summary [] by Philippe Jean Guillaumie
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=82159fb37c572e46b3c9e48920dc0ba679e04f58 commit 82159fb37c572e46b3c9e48920dc0ba679e04f58 Author: Philippe Jean Guillaumie Date: Thu Nov 30 23:53:52 2017 -0800 Wiki page opensuse-start changed with summary [] by Philippe Jean Guillaumie --- pages/docs/distros/opensuse-start.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/docs/distros/opensuse-start.txt b/pages/docs/distros/opensuse-start.txt index a70123b9e..95abf9327 100644 --- a/pages/docs/distros/opensuse-start.txt +++ b/pages/docs/distros/opensuse-start.txt @@ -1,4 +1,4 @@ -~~Title: openSUSE~~ +~~Title: EFL on openSUSE~~ openSUSE Enlightenment and EFL are available for multiple versions of openSUSE: --
[EGIT] [website/www-content] master 01/01: Wiki page debian-start changed with summary [] by Philippe Jean Guillaumie
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=a2a3bf2d39d923093927d2ae3f4ed723bd7f5ac9 commit a2a3bf2d39d923093927d2ae3f4ed723bd7f5ac9 Author: Philippe Jean Guillaumie Date: Thu Nov 30 23:53:22 2017 -0800 Wiki page debian-start changed with summary [] by Philippe Jean Guillaumie --- pages/docs/distros/debian-start.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/docs/distros/debian-start.txt b/pages/docs/distros/debian-start.txt index 7da9f4091..c60485a63 100644 --- a/pages/docs/distros/debian-start.txt +++ b/pages/docs/distros/debian-start.txt @@ -1,4 +1,4 @@ -~~Title: Debian~~ +~~Title: EFL on Debian~~ = Debian = Enlightenment and EFL Debian official packages are outdated. --
[EGIT] [website/www-content] master 01/01: Wiki page archlinux-start changed with summary [] by Philippe Jean Guillaumie
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=218c5e9a3b4d443ca9de140ee1bfa4792660ce87 commit 218c5e9a3b4d443ca9de140ee1bfa4792660ce87 Author: Philippe Jean Guillaumie Date: Thu Nov 30 23:52:46 2017 -0800 Wiki page archlinux-start changed with summary [] by Philippe Jean Guillaumie --- pages/docs/distros/archlinux-start.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/docs/distros/archlinux-start.txt b/pages/docs/distros/archlinux-start.txt index f554d2c8d..823b61eb1 100644 --- a/pages/docs/distros/archlinux-start.txt +++ b/pages/docs/distros/archlinux-start.txt @@ -1,4 +1,4 @@ -~~Title: Arch Linux~~ +~~Title: EFL on Arch Linux~~ Arch The way to install Enlightenment on Arch Linux is quite easy, use the official repo: --
[EGIT] [website/www-content] master 01/01: Wiki page git-guide.md changed with summary [The build your own branch (BYOB) idea never really worked out] by Stefan Schmidt
WWW-www.enlightenment.org pushed a commit to branch master.
http://git.enlightenment.org/website/www-content.git/commit/?id=5a13ad1d2641d4100852e9a76bef1a0ad763bd6c
commit 5a13ad1d2641d4100852e9a76bef1a0ad763bd6c
Author: Stefan Schmidt
Date: Thu Nov 30 23:49:50 2017 -0800
Wiki page git-guide.md changed with summary [The build your own branch
(BYOB) idea never really worked out] by Stefan Schmidt
---
pages/contrib/devs/git-guide.md.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/pages/contrib/devs/git-guide.md.txt
b/pages/contrib/devs/git-guide.md.txt
index 98bfaa39d..e5a174ea6 100644
--- a/pages/contrib/devs/git-guide.md.txt
+++ b/pages/contrib/devs/git-guide.md.txt
@@ -123,8 +123,6 @@ Every developer can create their own branches inside a
repository. The naming mu
These branches can be used if you're implementing a larger feature and want to
share your progress with other developers.
-The branch named ``devs/{devname}/jenkins`` has a special meaning: Jenkins
will automatically try to build this branch for you and report any warnings and
errors. The results are available [from the Jenkins BYOB
page](http://jenkins.enlightenment.org/view/BYOB/).
-
Creating a Developer Branch
Create a developer branch by pushing it to the remote repository:
--
[EGIT] [core/efl] master 01/01: efl_ui_spin_button: check focus state
jaehyun pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=9fac52134c532440a120b512dff1d5bea0a21ddb
commit 9fac52134c532440a120b512dff1d5bea0a21ddb
Author: Yeongjong Lee
Date: Fri Dec 1 12:05:10 2017 +0900
efl_ui_spin_button: check focus state
Summary:
Because toggle_entry function control entry focus, it need to check
focus state in focus changed callback
Test Plan:
1. elementary_test - Efl.Ui.Spin.Button
2. Click the entry of spin_button
Reviewers: Jaehyun_Cho, CHAN
Reviewed By: Jaehyun_Cho
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5569
---
src/lib/elementary/efl_ui_spin_button.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/lib/elementary/efl_ui_spin_button.c
b/src/lib/elementary/efl_ui_spin_button.c
index 23e149af32..059c3786c1 100644
--- a/src/lib/elementary/efl_ui_spin_button.c
+++ b/src/lib/elementary/efl_ui_spin_button.c
@@ -494,9 +494,10 @@ _inc_dec_button_mouse_move_cb(void *data, const Efl_Event
*event)
}
static void
-_text_button_focus_changed_cb(void *data, const Efl_Event *event EINA_UNUSED)
+_text_button_focus_changed_cb(void *data, const Efl_Event *event)
{
- _toggle_entry(data);
+ if (efl_ui_focus_object_focus_get(event->object))
+ _toggle_entry(data);
}
static void
@@ -506,9 +507,10 @@ _entry_activated_cb(void *data, const Efl_Event *event
EINA_UNUSED)
}
static void
-_entry_focus_changed_cb(void *data, const Efl_Event *event EINA_UNUSED)
+_entry_focus_changed_cb(void *data, const Efl_Event *event)
{
- _toggle_entry(data);
+ if (!efl_ui_focus_object_focus_get(event->object))
+ _toggle_entry(data);
}
static void
--
[EGIT] [core/efl] master 01/01: edje: fix NULL ptr dereference
ami pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=769aeb5fccfc752c3fde2c0e423a84689d94c571
commit 769aeb5fccfc752c3fde2c0e423a84689d94c571
Author: Amitesh Singh
Date: Fri Dec 1 10:59:58 2017 +0900
edje: fix NULL ptr dereference
Fixes CID 1383425
---
src/lib/edje/edje_util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/edje/edje_util.c b/src/lib/edje/edje_util.c
index 2872317b13..a82620f5d4 100644
--- a/src/lib/edje/edje_util.c
+++ b/src/lib/edje/edje_util.c
@@ -396,12 +396,12 @@ _edje_object_efl_ui_base_scale_get(Eo *obj EINA_UNUSED,
Edje *ed)
}
EAPI double
-edje_object_base_scale_get(const Eo *obj)
+edje_object_base_scale_get(const Evas_Object *obj)
{
Edje *ed;
ed = _edje_fetch(obj);
- if (!ed->file) return 1.0;
+ if (!ed || !ed->file) return 1.0;
return TO_DOUBLE(ed->file->base_scale);
}
--
[EGIT] [apps/ephoto] master 01/01: Improve slideshow gadget theme
okra pushed a commit to branch master.
http://git.enlightenment.org/apps/ephoto.git/commit/?id=ced5750c9b44b7bfeabe02e1cc940c29291cd29d
commit ced5750c9b44b7bfeabe02e1cc940c29291cd29d
Author: Stephen Houston
Date: Thu Nov 30 16:23:27 2017 -0600
Improve slideshow gadget theme
---
data/themes/ephoto.edc | 32
src/bin/ephoto_main.c | 2 +-
src/bin/ephoto_slideshow.c | 4
3 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/data/themes/ephoto.edc b/data/themes/ephoto.edc
index b0a3df4..d8b2a87 100644
--- a/data/themes/ephoto.edc
+++ b/data/themes/ephoto.edc
@@ -40,6 +40,10 @@ collections {
state: "default" 0.0;
color: 0 0 0 255;
}
+description {
+ state: "gadget" 0.0;
+ color: 115 115 115 45;
+}
}
rect { "slide_clip";
scale: 1;
@@ -120,6 +124,18 @@ collections {
}
programs {
program {
+signal: "gadget";
+source: "ephoto";
+action: STATE_SET "gadget" 0.0;
+target: "background";
+ }
+ program {
+signal: "default";
+source: "ephoto";
+action: STATE_SET "default" 0.0;
+target: "background";
+ }
+ program {
signal: "ephoto,fade";
source: "ephoto";
action: STATE_SET "default" 0.0;
@@ -330,6 +346,10 @@ collections {
state: "default" 0.0;
color: 0 0 0 255;
}
+description {
+ state: "gadget" 0.0;
+ color: 0 0 0 0;
+}
}
rect { "slide_clip";
scale: 1;
@@ -669,6 +689,18 @@ collections {
}
programs {
program {
+signal: "gadget";
+source: "ephoto";
+action: STATE_SET "gadget" 0.0;
+target: "background";
+ }
+ program {
+signal: "default";
+source: "ephoto";
+action: STATE_SET "default" 0.0;
+target: "background";
+ }
+ program {
signal: "ephoto,slideshow,move,left,to,right";
source: "ephoto";
script {
diff --git a/src/bin/ephoto_main.c b/src/bin/ephoto_main.c
index 0dcea9f..9b5e6ed 100644
--- a/src/bin/ephoto_main.c
+++ b/src/bin/ephoto_main.c
@@ -400,7 +400,7 @@ ephoto_window_add(const char *path, int gadget)
ephoto->win = elm_win_add(NULL, "ephoto", ELM_WIN_BASIC);
elm_win_title_set(ephoto->win, "Ephoto");
elm_win_alpha_set(ephoto->win, 1);
-evas_object_size_hint_aspect_set(ephoto->win,
EVAS_ASPECT_CONTROL_BOTH, 1, 1);
+evas_object_size_hint_aspect_set(ephoto->win,
EVAS_ASPECT_CONTROL_BOTH, 1,1);
}
if (!ephoto->win)
{
diff --git a/src/bin/ephoto_slideshow.c b/src/bin/ephoto_slideshow.c
index 0d0929a..fd57277 100644
--- a/src/bin/ephoto_slideshow.c
+++ b/src/bin/ephoto_slideshow.c
@@ -418,6 +418,8 @@ _slideshow_item_get(Ephoto_Slideshow *ss, Ephoto_Entry
*entry, Evas_Object *pare
layout = elm_layout_add(parent);
elm_layout_file_set(layout, PACKAGE_DATA_DIR "/themes/ephoto.edj",
"ephoto,slideshow,item");
+ if (ss->ephoto->gadget)
+ elm_layout_signal_emit(layout, "gadget", "ephoto");
EPHOTO_EXPAND(layout);
EPHOTO_FILL(layout);
evas_object_data_set(layout, "entry", entry);
@@ -1076,6 +1078,8 @@ ephoto_slideshow_add(Ephoto *ephoto, Evas_Object *parent)
elm_layout_file_set(slideshow, PACKAGE_DATA_DIR "/themes/ephoto.edj",
"ephoto,slideshow,base");
+ if (ephoto->gadget)
+ elm_layout_signal_emit(slideshow, "gadget", "ephoto");
evas_object_event_callback_add(slideshow, EVAS_CALLBACK_DEL, _slideshow_del,
ss);
if (!ephoto->gadget)
--
[EGIT] [apps/ephoto] master 01/01: Don't show files in fileselector for gadget and keep aspect and don't crop images.
okra pushed a commit to branch master.
http://git.enlightenment.org/apps/ephoto.git/commit/?id=f56395a2ba69413e1b847cb3899a18ff80498bd0
commit f56395a2ba69413e1b847cb3899a18ff80498bd0
Author: Stephen Houston
Date: Thu Nov 30 16:02:26 2017 -0600
Don't show files in fileselector for gadget and keep aspect and don't crop
images.
---
src/bin/ephoto_slideshow.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/src/bin/ephoto_slideshow.c b/src/bin/ephoto_slideshow.c
index f72735b..0d0929a 100644
--- a/src/bin/ephoto_slideshow.c
+++ b/src/bin/ephoto_slideshow.c
@@ -423,10 +423,19 @@ _slideshow_item_get(Ephoto_Slideshow *ss, Ephoto_Entry
*entry, Evas_Object *pare
evas_object_data_set(layout, "entry", entry);
image = elm_image_add(parent);
- elm_image_preload_disabled_set(image, EINA_FALSE);
- elm_image_smooth_set(image, EINA_FALSE);
+ if (ss->ephoto->config->movess && !ss->ephoto->gadget)
+ {
+elm_image_preload_disabled_set(image, EINA_FALSE);
+elm_image_smooth_set(image, EINA_FALSE);
+elm_image_fill_outside_set(image, EINA_TRUE);
+ }
+ else if (!ss->ephoto->config->movess || ss->ephoto->gadget)
+ {
+evas_object_image_load_orientation_set(image, EINA_TRUE);
+evas_object_image_filled_set(image, EINA_TRUE);
+evas_object_image_preload(image, EINA_FALSE);
+ }
elm_image_file_set(image, entry->path, group);
- elm_image_fill_outside_set(image, EINA_TRUE);
EPHOTO_EXPAND(image);
EPHOTO_FILL(image);
evas_object_event_callback_add(image, EVAS_CALLBACK_SHOW, _image_shown,
@@ -830,6 +839,7 @@ _gadget_settings(void *data, Evas_Object *obj EINA_UNUSED,
elm_fileselector_expandable_set(fentry, EINA_FALSE);
elm_fileselector_path_set(fentry, ss->ephoto->config->directory);
elm_fileselector_buttons_ok_cancel_set(fentry, EINA_FALSE);
+ elm_fileselector_folder_only_set(fentry, EINA_TRUE);
evas_object_size_hint_weight_set(fentry, EVAS_HINT_EXPAND,
EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(fentry, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_table_pack(table, fentry, 0, 0, 2, 5);
--
[EGIT] [core/efl] master 01/01: elm_genlist: use the correct elm_object_focus_get function
bu5hm4n pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=38b3ef1b8c660f8089b95f9939992b8aac1a75f0 commit 38b3ef1b8c660f8089b95f9939992b8aac1a75f0 Author: Marcel Hollerbach Date: Thu Nov 30 19:28:18 2017 +0100 elm_genlist: use the correct elm_object_focus_get function genlist does not get focus anymore, only its children are getting them. fix T6425 --- src/lib/elementary/elm_genlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_genlist.c index 9ae57c1ef5..8a59d2fa54 100644 --- a/src/lib/elementary/elm_genlist.c +++ b/src/lib/elementary/elm_genlist.c @@ -6132,7 +6132,7 @@ _elm_genlist_item_elm_widget_item_focus_set(Eo *eo_it, Elm_Gen_Item *it, Eina_Bo if (!elm_object_focus_get(obj)) elm_object_focus_set(obj, EINA_TRUE); -if (!efl_ui_focus_object_focus_get(obj)) +if (!elm_object_focus_get(obj)) return; if (eo_it != sd->focused_item) --
[EGIT] [core/efl] master 01/01: efl_ui_focus_composition: fix docs
bu5hm4n pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=1d7833a4b2992e51813c24c6c8714cf4524940ea
commit 1d7833a4b2992e51813c24c6c8714cf4524940ea
Author: Marcel Hollerbach
Date: Thu Nov 30 15:12:44 2017 +0100
efl_ui_focus_composition: fix docs
---
src/lib/elementary/efl_ui_focus_composition.eo | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/lib/elementary/efl_ui_focus_composition.eo
b/src/lib/elementary/efl_ui_focus_composition.eo
index ef724757f6..dd7fcaa856 100644
--- a/src/lib/elementary/efl_ui_focus_composition.eo
+++ b/src/lib/elementary/efl_ui_focus_composition.eo
@@ -34,7 +34,10 @@ mixin Efl.Ui.Focus.Composition (Efl.Interface, Elm.Widget ) {
]]
}
@property custom_manager @protected {
- [[Every widget will be registered in this manager]]
+ [[Register all children in this manager
+
+ Set to $null to register them in the same manager as the
implementor is
+ ]]
values {
custom_manager : Efl.Ui.Focus.Manager;
}
--
[EGIT] [core/efl] master 01/02: elm_code: Call parent theme_apply when we're applying
ajwillia-ms pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=3e5e9943601fe84b7a3ebb1d4a0c9a10bb49bf27 commit 3e5e9943601fe84b7a3ebb1d4a0c9a10bb49bf27 Author: Andy Williams Date: Thu Nov 30 17:36:30 2017 + elm_code: Call parent theme_apply when we're applying --- src/lib/elementary/elm_code_widget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/elementary/elm_code_widget.c b/src/lib/elementary/elm_code_widget.c index eb4a83800e..f7fa879127 100644 --- a/src/lib/elementary/elm_code_widget.c +++ b/src/lib/elementary/elm_code_widget.c @@ -2202,6 +2202,8 @@ _elm_code_widget_elm_widget_theme_apply(Eo *obj, Elm_Code_Widget_Data *pd) unsigned int i; Evas_Object *grid, *background; + efl_ui_widget_theme_apply(efl_super(obj, MY_CLASS)); + edje = elm_layout_edje_get(obj); edje_object_color_class_get(edje, "elm/code/status/default", &r, &g, &b, &a, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL); --
[EGIT] [core/efl] master 02/02: elm_code: Make test buttons more meaningful
ajwillia-ms pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=3a86af7db47816449082e02c28ece1b84a023a06
commit 3a86af7db47816449082e02c28ece1b84a023a06
Author: Andy Williams
Date: Thu Nov 30 17:37:19 2017 +
elm_code: Make test buttons more meaningful
And match window titles to buttons for clarity
---
src/bin/elementary/test.c | 4 ++--
src/bin/elementary/test_code.c | 8
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/bin/elementary/test.c b/src/bin/elementary/test.c
index 726fc4bb67..c88bca9b13 100644
--- a/src/bin/elementary/test.c
+++ b/src/bin/elementary/test.c
@@ -825,9 +825,9 @@ add_tests:
ADD_TEST_EO(NULL, "Entries", "Efl.Ui.Text.Async", test_efl_ui_text_async);
//--//
- ADD_TEST(NULL, "Advanced Entries", "Code Entry Markup", test_code_welcome);
- ADD_TEST(NULL, "Advanced Entries", "Code Editor", test_code_editor);
ADD_TEST(NULL, "Advanced Entries", "Code Syntax", test_code_syntax);
+ ADD_TEST(NULL, "Advanced Entries", "Entry Markup", test_code_welcome);
+ ADD_TEST(NULL, "Advanced Entries", "Text Editor", test_code_editor);
ADD_TEST(NULL, "Advanced Entries", "Mirrored Editor", test_code_mirror);
ADD_TEST(NULL, "Advanced Entries", "Logger", test_code_log);
ADD_TEST(NULL, "Advanced Entries", "Diff Comparison", test_code_diff);
diff --git a/src/bin/elementary/test_code.c b/src/bin/elementary/test_code.c
index 235adde00b..b05240c1af 100644
--- a/src/bin/elementary/test_code.c
+++ b/src/bin/elementary/test_code.c
@@ -217,7 +217,7 @@ test_code_editor(void *data EINA_UNUSED, Evas_Object *obj
EINA_UNUSED, void *eve
{
Evas_Object *win, *screen;
- win = _test_code_win_create("code-editor", "Code Editor");
+ win = _test_code_win_create("code-editor", "Text Editor");
screen = elm_box_add(win);
evas_object_size_hint_weight_set(screen, EVAS_HINT_EXPAND,
EVAS_HINT_EXPAND);
elm_box_pack_end(screen, _elm_code_test_editor_setup(screen, EINA_FALSE));
@@ -295,7 +295,7 @@ test_code_diff_inline(void *data EINA_UNUSED, Evas_Object
*obj EINA_UNUSED, void
{
Evas_Object *win, *screen;
- win = _test_code_win_create("code-diff-inline", "Code Diff Inline");
+ win = _test_code_win_create("code-diff-inline", "Diff Inline");
screen = elm_box_add(win);
evas_object_size_hint_weight_set(screen, EVAS_HINT_EXPAND,
EVAS_HINT_EXPAND);
elm_box_pack_end(screen, _elm_code_test_diff_inline_setup(screen));
@@ -310,7 +310,7 @@ test_code_diff(void *data EINA_UNUSED, Evas_Object *obj
EINA_UNUSED, void *event
{
Evas_Object *win, *screen;
- win = _test_code_win_create("code-diff", "Code Diff");
+ win = _test_code_win_create("code-diff", "Diff Comparison");
screen = elm_box_add(win);
evas_object_size_hint_weight_set(screen, EVAS_HINT_EXPAND,
EVAS_HINT_EXPAND);
elm_box_pack_end(screen, _elm_code_test_diff_setup(screen));
@@ -325,7 +325,7 @@ test_code_welcome(void *data EINA_UNUSED, Evas_Object *obj
EINA_UNUSED, void *ev
{
Evas_Object *win, *screen;
- win = _test_code_win_create("code-welcome", "Code Welcome");
+ win = _test_code_win_create("code-welcome", "Entry Markup");
screen = elm_box_add(win);
evas_object_size_hint_weight_set(screen, EVAS_HINT_EXPAND,
EVAS_HINT_EXPAND);
elm_box_pack_end(screen, _elm_code_test_welcome_setup(screen));
--
[EGIT] [enlightenment/gadgets/wireless] master 01/01: Update aps and their corresponding settings when things change.
okra pushed a commit to branch master.
http://git.enlightenment.org/enlightenment/gadgets/wireless.git/commit/?id=d1788bde1f21ef30a2f168f93890cf2401975e59
commit d1788bde1f21ef30a2f168f93890cf2401975e59
Author: Stephen Houston
Date: Thu Nov 30 10:52:35 2017 -0600
Update aps and their corresponding settings when things change.
---
TODO | 4 +++-
src/networkmanager.c | 25 ++---
2 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/TODO b/TODO
index 8c98b9e..453ca3b 100644
--- a/TODO
+++ b/TODO
@@ -2,13 +2,15 @@ NetworkManager Support:
--Untested--
DNS config editing - DNS domain and name servers are likely not stored
correctly.
+
Proxy config editing
--Issues--
Doesn't always update the icon correctly - Forgetting a wifi network goes back
to ethernet mode... why?
+
Random crashes -- Are they sandbox related or wireless related?
-When forgetting a network the connection setting is removed and thus doesn't
show up in the network list anymore -- however the access point is still
available so this should somehow update that the connection setting is removed
but not the access point.
+There is a duplicate entry for settings and aps in the wifi list -- This is so
that when you delete a setting, the ap still exists. Is there a better way to
do that?
--Needed--
Add WEP support to agent. Currently only WPA will work.
diff --git a/src/networkmanager.c b/src/networkmanager.c
index d3e74c8..eaa124a 100644
--- a/src/networkmanager.c
+++ b/src/networkmanager.c
@@ -1506,7 +1506,8 @@ static void
_networkmanager_manager_getap(void *data, const void *msg, Eldbus_Message_Iter
*it)
{
const char *setting = msg;
- NetworkManager_Service *ns = data;
+ Eina_List *l;
+ NetworkManager_Service *ns = data, *nss;
if (eina_streq(setting, "Ssid"))
{
@@ -1573,6 +1574,26 @@ _networkmanager_manager_getap(void *data, const void
*msg, Eldbus_Message_Iter *
ns->security = WIRELESS_NETWORK_SECURITY_IEEE8021X;
}
}
+ EINA_LIST_FOREACH(networkmanager_services_list[ns->type], l, nss)
+ {
+if (!nss->access_point)
+ {
+ if (!nss->conn_ssid) continue;
+ if (eina_streq(ns->name, nss->conn_ssid))
+ {
+ if (nss->strength < ns->strength)
+{
+ nss->strength = ns->strength;
+ nss->security = ns->security;
+ if (nss->wn)
+ free(nss->wn);
+ _networkmanager_service_convert(nss);
+ if (_networkmanager_service_is_connected(nss))
+ _networkmanager_update_current_network(nss,
nss->type);
+}
+ }
+ }
+ }
}
static void
@@ -1805,8 +1826,6 @@ _networkmanager_service_ap_new(int type, const char
*path, Eldbus_Message_Iter *
free(nss->wn);
_networkmanager_service_convert(nss);
}
- _networkmanager_service_free_nolist(ns);
- return NULL;
}
}
}
--
[EGIT] [website/www-content] master 01/01: Wiki page start changed with summary [] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=8a5877d684b2e801033f095d18385d3b45db7460 commit 8a5877d684b2e801033f095d18385d3b45db7460 Author: Gareth Halfacree Date: Thu Nov 30 08:28:00 2017 -0800 Wiki page start changed with summary [] by Gareth Halfacree --- pages/contrib/start.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/contrib/start.txt b/pages/contrib/start.txt index 3f32c8546..575177300 100644 --- a/pages/contrib/start.txt +++ b/pages/contrib/start.txt @@ -6,7 +6,7 @@ Whether you're an end-user or a developer there are ways to get involved in the However you want to contribute, know that your contribution will always be warmly received and go towards making the Enlightenment Project the best it can possibly be. -Information on the current status of Enlightenment Project development, along with a list of open issues requiring attention, can be found on the [Phabricator Ticketing System](https://phab.enlightenment.org/). Assistance with any and all of the listed tickets is always welcome. +Information on the current status of Enlightenment Project development, along with a list of open issues requiring attention, can be found on the [[https://phab.enlightenment.org/|Phabricator Ticket System]]. Assistance with any and all of the listed tickets is always welcome. = Contributing Time = --
[EGIT] [website/www-content] master 01/01: Wiki page start changed with summary [] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=05a0c6a06fbf8419ef4df4fccea2dcc7269868a5 commit 05a0c6a06fbf8419ef4df4fccea2dcc7269868a5 Author: Gareth Halfacree Date: Thu Nov 30 08:27:32 2017 -0800 Wiki page start changed with summary [] by Gareth Halfacree --- pages/contrib/start.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pages/contrib/start.txt b/pages/contrib/start.txt index b206c6968..3f32c8546 100644 --- a/pages/contrib/start.txt +++ b/pages/contrib/start.txt @@ -6,6 +6,8 @@ Whether you're an end-user or a developer there are ways to get involved in the However you want to contribute, know that your contribution will always be warmly received and go towards making the Enlightenment Project the best it can possibly be. +Information on the current status of Enlightenment Project development, along with a list of open issues requiring attention, can be found on the [Phabricator Ticketing System](https://phab.enlightenment.org/). Assistance with any and all of the listed tickets is always welcome. + = Contributing Time = If you have free time help is always welcome, with a variety of areas suited to different skill sets. --
[EGIT] [enlightenment/gadgets/wireless] master 01/01: Update when access points are added/removed.
okra pushed a commit to branch master.
http://git.enlightenment.org/enlightenment/gadgets/wireless.git/commit/?id=e4f8c89899d3287e4639566bffb2e248bd82d0e1
commit e4f8c89899d3287e4639566bffb2e248bd82d0e1
Author: Stephen Houston
Date: Thu Nov 30 10:21:24 2017 -0600
Update when access points are added/removed.
---
TODO | 12
src/networkmanager.c | 47 +++
2 files changed, 55 insertions(+), 4 deletions(-)
diff --git a/TODO b/TODO
index d7072ce..8c98b9e 100644
--- a/TODO
+++ b/TODO
@@ -1,10 +1,14 @@
NetworkManager Support:
+
--Untested--
-Dns config editing - DNS domain and name servers are likely not stored
correctly.
+DNS config editing - DNS domain and name servers are likely not stored
correctly.
Proxy config editing
+
--Issues--
-Doesn't update the icon correctly when activing connections on separate devices
-Random crashes
+Doesn't always update the icon correctly - Forgetting a wifi network goes back
to ethernet mode... why?
+Random crashes -- Are they sandbox related or wireless related?
+
+When forgetting a network the connection setting is removed and thus doesn't
show up in the network list anymore -- however the access point is still
available so this should somehow update that the connection setting is removed
but not the access point.
+
--Needed--
-Update when connections and access points are added/removed
Add WEP support to agent. Currently only WPA will work.
diff --git a/src/networkmanager.c b/src/networkmanager.c
index 55f627a..d3e74c8 100644
--- a/src/networkmanager.c
+++ b/src/networkmanager.c
@@ -2077,6 +2077,47 @@ _networkmanager_manager_technology_event_property(void
*data, const Eldbus_Messa
}
static void
+_networkmanager_manager_ap_add(void *data, const Eldbus_Message *msg)
+{
+ const char *path;
+ Eldbus_Object *obj;
+ Eldbus_Proxy *proxy;
+ Eldbus_Pending *pend;
+ NetworkManager_Technology *nt = data;
+
+ if (!eldbus_message_arguments_get(msg, "o", &path))
+ {
+ERR("Could not parse connection update %p", msg);
+return;
+ }
+ obj = eldbus_object_get(dbus_conn, NETWORKMANAGER_BUS_NAME, path);
+ proxy = eldbus_proxy_get(obj,
+NETWORKMANAGER_BUS_INTERFACE ".AccessPoint");
+ pend = eldbus_proxy_property_get_all(proxy,
+ _networkmanager_manager_getaps, nt);
+ pending_technologies = eina_list_append(pending_technologies, pend);
+}
+
+static void
+_networkmanager_manager_ap_remove(void *data EINA_UNUSED, const Eldbus_Message
*msg)
+{
+ const char *path;
+ NetworkManager_Service *ns;
+ int i;
+
+ if (!eldbus_message_arguments_get(msg, "o", &path))
+ {
+ERR("Could not parse property update %p", msg);
+return;
+ }
+ ns = _networkmanager_service_find_path(path);
+ EINA_SAFETY_ON_NULL_RETURN(ns);
+ i = ns->type;
+ _networkmanager_service_free(ns);
+ _networkmanager_update_networks(i);
+}
+
+static void
_networkmanager_manager_gettechnologies(void *data, const Eldbus_Message *msg,
Eldbus_Pending *pending)
{
const char *name, *text;
@@ -2150,6 +2191,12 @@ _networkmanager_manager_gettechnologies(void *data,
const Eldbus_Message *msg, E
pend = eldbus_proxy_call(proxy, "GetAllAccessPoints",
_networkmanager_manager_gettechnologies_prop_aps, nt, -1,
"");
pending_technologies = eina_list_append(pending_technologies, pend);
+sig_handlers = eina_list_append(sig_handlers,
+ eldbus_proxy_signal_handler_add(proxy,
"AccessPointAdded",
+ _networkmanager_manager_ap_add, nt));
+sig_handlers = eina_list_append(sig_handlers,
+ eldbus_proxy_signal_handler_add(proxy,
"AccessPointRemoved",
+ _networkmanager_manager_ap_remove, NULL));
}
}
--
[EGIT] [website/www] master 01/01: redirect old links
ajwillia-ms pushed a commit to branch master.
http://git.enlightenment.org/website/www.git/commit/?id=d61570c40c5a80d4732fccbfd0a7624a5114d6ee
commit d61570c40c5a80d4732fccbfd0a7624a5114d6ee
Author: Andy Williams
Date: Thu Nov 30 16:15:24 2017 +
redirect old links
---
public_html/.htaccess | 3 +++
1 file changed, 3 insertions(+)
diff --git a/public_html/.htaccess b/public_html/.htaccess
index 015100aa..2331b026 100644
--- a/public_html/.htaccess
+++ b/public_html/.htaccess
@@ -2,6 +2,8 @@ Options FollowSymlinks
RewriteEngine On
+RewriteRule ^docs$ /docs/ [R,L]
+
# refactoring of content without the need for redirect files
RewriteRule ^docs-efl-debug/contrib/efl-debug
[R,L]
RewriteRule ^debugging/enlightenment_debugging
/contrib/enlightenment_debugging[R,L]
@@ -53,6 +55,7 @@ RewriteRule ^samples/elm_min_size_control
/develop/legacy/samples/elm_min_size_c
RewriteRule ^tutorials/(.*)$ /develop/legacy/tutorials/$1
[R,L]
RewriteRule ^program_guide/(.*)$ /develop/legacy/program_guide/$1
[R,L]
+RewriteRule ^themes/(.*)$ /docs/themes/$1 [R,L]
#end refactoring rules
RewriteCond %{HTTP_HOST} =enlightenment.org [NC]
--
[EGIT] [website/www-content] master 01/01: navigation: Add nav to /docs/ and remove link lists from the text body
ajwillia-ms pushed a commit to branch master.
http://git.enlightenment.org/website/www-content.git/commit/?id=68b39ed334a1caee0d6586ad01202fcd46286257
commit 68b39ed334a1caee0d6586ad01202fcd46286257
Author: Andy Williams
Date: Thu Nov 30 16:14:35 2017 +
navigation: Add nav to /docs/ and remove link lists from the text body
---
pages/develop/navigation.txt | 2 --
pages/docs/navigation.txt| 17 ++
pages/docs/sidebar.txt | 3 ++
pages/{docs.txt => docs/start.txt} | 56 +---
pages/{ => docs}/themes/knob_example.txt | 0
pages/{ => docs}/themes/start.txt| 0
6 files changed, 35 insertions(+), 43 deletions(-)
diff --git a/pages/develop/navigation.txt b/pages/develop/navigation.txt
index 20526dbb0..a68cb4196 100644
--- a/pages/develop/navigation.txt
+++ b/pages/develop/navigation.txt
@@ -1,5 +1,3 @@
-~~NOCACHE~~
-
* [[/develop/start.md] | Developing with EFL]]
* [[/develop/setup/start.md | Setting Up EFL]]
* [[/develop/setup/c/start.md | EFL for C Development [TODO]]]
diff --git a/pages/docs/navigation.txt b/pages/docs/navigation.txt
new file mode 100644
index 0..906060331
--- /dev/null
+++ b/pages/docs/navigation.txt
@@ -0,0 +1,17 @@
+ * [[/docs/distros/|Installing EFL]]
+* [[/docs/distros/ubuntu-start|EFL on Ubuntu]]
+* [[/docs/distros/archlinux-start|EFL on Arch Linux]]
+* [[/docs/distros/debian-start|EFL on Debian]]
+* [[/docs/distros/fedora-start|EFL on Fedora]]
+* [[/docs/distros/freebsd-start|EFL on FreeBSD]]
+* [[/docs/distros/opensuse-start|EFL on openSUSE]]
+* [[/docs/distros/yocto-start|EFL on Yocto]]
+* [[/docs/distros/osx-start|EFL on Mac OS X]]
+ * [[/docs/c/start]]
+ * [[/develop/efl/|Getting started with EFL Development]]
+ * [[/develop/legacy/api/c/|EFL API (C language)]]
+ * [[/docs/themes/start|Themeing EFL apps]]
+* [[/about-eflete|Eflete - GUI Theme design tool]]
+* [[/about-enventor|Enventor - GUI Edje file design tool]]
+* [[/docs/themes/knob_example|Edje theme example]]
+
diff --git a/pages/docs/sidebar.txt b/pages/docs/sidebar.txt
new file mode 100644
index 0..4986dcf3b
--- /dev/null
+++ b/pages/docs/sidebar.txt
@@ -0,0 +1,3 @@
+~~NOCACHE~~
+
+{{navi>:docs:navigation}}
diff --git a/pages/docs.txt b/pages/docs/start.txt
similarity index 68%
rename from pages/docs.txt
rename to pages/docs/start.txt
index 68d295f10..7f50bf33f 100755
--- a/pages/docs.txt
+++ b/pages/docs/start.txt
@@ -10,8 +10,6 @@ Aimed primarily at slick graphical presentation and optimal
runtime we
created the Enlightenment Foundation Libraries and have created the following
documentation to help everyone get involved - thanks for stopping by.
-
-
Getting Started
If you are going to use EFL, we encourage you to actually work with
@@ -23,51 +21,27 @@ course you can use stable packages for your distribution as
well.
=== Getting EFL ===
- * [[docs/distros/|Get EFL installed from source]]
- * [[docs/distros/ubuntu-start|EFL on Ubuntu]]
- * [[docs/distros/archlinux-start|EFL on Arch Linux]]
- * [[docs/distros/debian-start|EFL on Debian]]
- * [[docs/distros/fedora-start|EFL on Fedora]]
- * [[docs/distros/freebsd-start|EFL on FreeBSD]]
- * [[docs/distros/opensuse-start|EFL on openSUSE]]
- * [[docs/distros/yocto-start|EFL on Yocto]]
- * [[docs/distros/osx-start|EFL on Mac OS X]]
-
-Go check the current available version of EFL on each distro/platform:
-[[https://phab.enlightenment.org/w/packaging_status/|Table of current version
of EFL]]
-
-=== Working with Code ===
-
- * [[docs/c/start|A basic primer on C]]
+Many operating systems have packages of EFL, Enlightenment and many of our
apps.
+The specific information for each platform is available from [[/docs/distros/]]
+and sub-pages.
+We also track the current available version of EFL and our apps on each
+distro/platform, you can see the latest information at
+[[https://phab.enlightenment.org/w/packaging_status/|Table of current version
of EFL]]
-
+
EFL Documentation
The EFL is currently undergoing a significant redesign to give a better
-developer experience when building apps using our platform.
-For now we recommend using the stable API and it's Bindings.
-
-=== Working with EFL ===
-
- * [[develop/efl/start|Get started with EFL]]
- * [[develop/efl/advanced/start|Advanced EFL Topics]]
- * [[develop/apps_efl_debugging|EFL application debugging]]
- * [[develop/remote_debugging|Remote Debugging]]
+developer experience when building apps using our platform. We will be
+announcing the new API shortly to get early feedback from developers but
+for now we recommend using the stable API and it's Bindings.
-=== Stable API ===
-
- * [[/develop/legacy/api/c/|C (our main language)]]
- * [[/develop/legacy/api/cpp/|C++ Bindings]]
- * [[https://docs.enlightenment.org/python-efl/current|Python Bindings]]
-
-=== Beta API using EO ===
-
-
[EGIT] [website/www-content] master 01/01: Wiki page start.md changed with summary [] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=414d255946dad0e3f4346ae3d2886a6df1d4b3ec commit 414d255946dad0e3f4346ae3d2886a6df1d4b3ec Author: Gareth Halfacree Date: Thu Nov 30 07:51:59 2017 -0800 Wiki page start.md changed with summary [] by Gareth Halfacree --- pages/develop/start.md.txt | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/pages/develop/start.md.txt b/pages/develop/start.md.txt index 61b21fa78..3df6b3072 100644 --- a/pages/develop/start.md.txt +++ b/pages/develop/start.md.txt @@ -7,13 +7,13 @@ The Enlightenment Foundation Libraries (EFL) are designed to build on top of each other in layers, steadily becoming higher level yet allowing access to each individual level as they go. Whether you're looking for the types of low-level helpers contained in the ``Eina`` library or the high-level abstractions of Elemetary you'll find a wealth of assistance within EFL. -More information on EFL can be found on the [About EFL page](https://www.enlightenment.org/about-efl), including a breakdown of its various features and components. +More information on EFL can be found on the [About EFL page](/about-efl), including a breakdown of its various features and components. ## Current vs. Beta ## The documentation on this section of the website is written with a focus on the next-generation release, currently in beta. While this means that the documentation is only partial in places, it will get you started with the very latest revision of EFL and all the new and improved features it brings. -Documentation on the current version of EFL can be found in the [Legacy section](https://www.enlightenment.org/develop/legacy/). When working through the documentation on the site, keep in mind that if a document is located in ``/develop/legacy`` it is referring to the current release of EFL; if it is located in any other section of ``/develop`` it is referring to the beta release. +Documentation on the current version of EFL can be found in the [Legacy section](legacy/). When working through the documentation on the site, keep in mind that if a document is located in ``/develop/legacy`` it is referring to the current release of EFL; if it is located in any other section of ``/develop`` it is referring to the beta release. Information on porting software between the current and beta releases of EFL can be found as part of the [Programming Guides](#Programming_Guides) section. @@ -27,30 +27,33 @@ A full list of the languages available is available on the landing page for each ## Setting up the Development Environment [TODO] ## -Information on downloading EFL and configuring a development environment can be found in the [Setup section](https://www.enlightenment.org/develop/setup/). +Information on downloading EFL and configuring a development environment can be found in the [Setup section](setup/). ## Tutorials ## -The [EFL Tutorials](https://www.enlightenment.org/develop/tutorials/) are designed to introduce the functions and features of EFL to those who already have programming experience. Each tutorial walks through the implementation of a particular EFL feature or function, building upon previous tutorials to offer a step-by-step guide to getting comfortable with developing using EFL. +The [EFL Tutorials](tutorials/start.md) are designed to introduce the functions and features of EFL to those who already have programming experience. Each tutorial walks through the implementation of a particular EFL feature or function, building upon previous tutorials to offer a step-by-step guide to getting comfortable with developing using EFL. Although you do not need previous experience with EFL to work through the tutorials, general programming knowledge is required. - ## Programming Guides ## -The [Programming Guides](https://www.enlightenment.org/develop/guides/start.md) are designed to provide informative material to developers working with EFL, including code snippets demonstrating the use of various features. They are provided both as a reference guide for experienced EFL developers and as an alternative or extension to the tutorials for those who prefer less guided experimentation. +The [Programming Guides](guides/start.md) are designed to provide informative material to developers working with EFL, including code snippets demonstrating the use of various features. They are provided both as a reference guide for experienced EFL developers and as an alternative or extension to the tutorials for those who prefer less guided experimentation. ## API Reference Documentation ## -A reference to the features and functions of the beta-release API can be found in the [API Reference section](https://www.enlightenment.org/develop/api/). +A reference to the features and functions of the beta-release API can be found in the [AP
[EGIT] [website/www-content] master 01/01: Wiki page start.md changed with summary [created] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=15176be6e803987a25112e13f1fa4434410711cf commit 15176be6e803987a25112e13f1fa4434410711cf Author: Gareth Halfacree Date: Thu Nov 30 07:47:01 2017 -0800 Wiki page start.md changed with summary [created] by Gareth Halfacree --- pages/develop/debug/c/start.md.txt | 23 +++ 1 file changed, 23 insertions(+) diff --git a/pages/develop/debug/c/start.md.txt b/pages/develop/debug/c/start.md.txt new file mode 100644 index 0..46eb78f88 --- /dev/null +++ b/pages/develop/debug/c/start.md.txt @@ -0,0 +1,23 @@ +--- +~~Title: Debugging EFL C Applications~~ +--- + +# Debugging EFL C Applications # + +The following documentation contains guides demonstrating tool-based debugging based on examples written in the C language. Language-agnostic debugging documentation and links to examples for other languages, where available, can be found in [Debugging EFL Applications](/develop/debug/start.md). + +## Debugging with GDB ## + +[Debugging with GDB](gdb.md) demonstrates the use of the GNU Debugger to handle common issues encountered when programming with the Enlightenment Foundation Libraries (EFL). + +## Debugging with Valgrind ## + +[Debugging with Valgrind](valgrind.md) demonstrates how to track down memory issues, such as memory leaks, using the Valgrind debugger. + +## Debugging with Clouseau ## + +[Debugging with Clouseau](valgrind.md) demonstrates how to install and use Clouseau, the EFL user interface inspection tool, to explore and debug a basic graphical application written with EFL. + +## Remote Debugging ## + +[Remote Debugging](remote-debug.md) explains how GDB and Clouseau can be used to debug a remote device over serial or network connections, allowing for easier diagnosis of issues on esoteric platforms or which result in graphical corruption or loss of user control when executed on the local system. \ No newline at end of file --
[EGIT] [website/www-content] master 01/01: Wiki page start.md changed with summary [created] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=c2b9402cf94b33b49153202fd3fb05439fa4ca17 commit c2b9402cf94b33b49153202fd3fb05439fa4ca17 Author: Gareth Halfacree Date: Thu Nov 30 07:40:27 2017 -0800 Wiki page start.md changed with summary [created] by Gareth Halfacree --- pages/develop/debug/start.md.txt | 29 + 1 file changed, 29 insertions(+) diff --git a/pages/develop/debug/start.md.txt b/pages/develop/debug/start.md.txt new file mode 100644 index 0..01c48c49b --- /dev/null +++ b/pages/develop/debug/start.md.txt @@ -0,0 +1,29 @@ +--- +~~Title: Debugging EFL Applications~~ +--- + +# Debugging EFL Applications # + +While the process of developing with the Enlightenment Foundation Libraries should be a smooth one, bugs are an inevitability of the programming process. The following documentation will provide you with tools and resources that will allow you to track down the source of these bugs quickly and easily, getting your development back on track with a minimum of fuss. + +## Recompiling with Debug Symbols ## + +[Recompiling with Debug Symbols](debug-symbols.md) demonstrates how to get the most out of the available debugging tools by compiling your application and the EFL with debugging symbols activated. + +## Log Levels ## + +[Log Levels](log-levels.md) explains the different verbosity levels of EFL's ``Eina_Log`` method, allowing you to control the amount of information recorded and better document the issue you have encountered. + +## Language Specific Debugging ## + +EFL applications can be written in a variety of languages. These sections provide hands-on examples using the GNU Debugger, Valgrind, and Clouseau tools using code from the following programming languages: + +* [C](c/start.md) + +## Reporting EFL Bugs ## + +If you believe a bug lies in EFL itself, rather than in your application, then please report the issue via the [Phabricator ticketing system](​https://phab.enlightenment.org/maniphest/task/create). Don't send bug reports and patches to the Enlightenment mailing list; the list system strips most patches and bug reports can get lost if they're only discussed on the mailing list. If more discussion is needed then add a Phabricator bug report before or after the discussion on the mailing lis [...] + +Always test multiple times to make sure there really is a reproducible bug before making a ticket, in order to avoid unnecessary tickets. Please ensure that issues aren't related to modified system settings, as per [Ticket T1145](https://phab.enlightenment.org/T1145). Please draft and check your ticket thoroughly before submitting it; the ticket system tracks and alerts on every edit, so a constant stream of modifications as per [Ticket T1143](https://phab.enlightenment.org/T1143) create [...] + +If the debugging process produces large log files, please attach these as file uploads rather than by copying and pasting their content directly into the ticket body. If reporting a visual bug, please test with the default theme; support is not provided for third-party themes, and bugs related to these themes must be sent directly to the theme's author. \ No newline at end of file --
[EGIT] [website/www-content] master 01/01: Wiki page docs changed with summary [] by Andrew Williams
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=06b0a879c493d2c15aa358b4aa7f7c2df0b789ab commit 06b0a879c493d2c15aa358b4aa7f7c2df0b789ab Author: Andrew Williams Date: Thu Nov 30 07:11:31 2017 -0800 Wiki page docs changed with summary [] by Andrew Williams --- pages/docs.txt | 15 --- 1 file changed, 15 deletions(-) diff --git a/pages/docs.txt b/pages/docs.txt index cdd6d3b73..68d295f10 100755 --- a/pages/docs.txt +++ b/pages/docs.txt @@ -104,19 +104,4 @@ To start with it's easiest to see which area you would like to work on and get involved in bug reporting, fixing or other types of [[contrib/|contributing]]. From there you can get to know the team, how we work, and earn a place on the team as a core developer :) -=== Feedback === - - * [[contrib/reporting_bugs|Report bugs on Phabricator]] - * [[contrib/patching|Submit patch on Phabricator]] - -=== Debugging === - - * [[contrib/efl-debug|Debugging EFL and Enlightenment]] - * [[contrib/enlightenment_debugging|Enlightenment specific debugging]] - -=== Coding === - - * [[/contrib/devs/coding-conventions|EFL Coding Style]] - * [[/contrib/devs/git-guide|Git Practices]] - --
[EGIT] [website/www-content] master 01/01: Wiki page remote-debug.md changed with summary [] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=fc5f60346af1cf4bb5a9ecf04fb45d82b2b758a8 commit fc5f60346af1cf4bb5a9ecf04fb45d82b2b758a8 Author: Gareth Halfacree Date: Thu Nov 30 07:04:46 2017 -0800 Wiki page remote-debug.md changed with summary [] by Gareth Halfacree --- pages/develop/debug/c/remote-debug.md.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pages/develop/debug/c/remote-debug.md.txt b/pages/develop/debug/c/remote-debug.md.txt index ac9085b82..a71ee2efc 100644 --- a/pages/develop/debug/c/remote-debug.md.txt +++ b/pages/develop/debug/c/remote-debug.md.txt @@ -65,8 +65,7 @@ $ Program received signal SIGSEGV, Segmentation fault. $ 0x00400b71 in ?? () ``` -You can now use ``gdb`` as it is explaines in [[apps_efl_debugging#Segfault in -callback function]], for example print the backtrace: +You can now use the GNU Debugger as demonstrated in [Debugging with GDB](gdb.md), for example by printing a backtrace: ```gdb (gdb) bt --
[EGIT] [website/www-content] master 01/01: Wiki page remote-debug.md changed with summary [] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=18a5f7943eefdde0a2690c725d8be296c4e5bc1d commit 18a5f7943eefdde0a2690c725d8be296c4e5bc1d Author: Gareth Halfacree Date: Thu Nov 30 07:02:23 2017 -0800 Wiki page remote-debug.md changed with summary [] by Gareth Halfacree --- pages/develop/debug/c/remote-debug.md.txt | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/pages/develop/debug/c/remote-debug.md.txt b/pages/develop/debug/c/remote-debug.md.txt index e1fd663f2..ac9085b82 100644 --- a/pages/develop/debug/c/remote-debug.md.txt +++ b/pages/develop/debug/c/remote-debug.md.txt @@ -28,8 +28,7 @@ Run the "helloworld" binary through ``gdbserver``: ```bash #target gdbserver localhost:2000 helloworld - -$ Process hello created; pid = 2763 +$ Process helloworld created; pid = 2763 $ Listening on port 2000 ``` @@ -38,19 +37,7 @@ At this point ``gdbserver`` is waiting for a connection on port 2000 of the targ > **NOTE:** > The GNU Debugger can be launched as multiple processes using ``gdbserver > --multi localhost:2000``. -On the client side, with a run ``gdb``: - -```gdb -#client -gdb hello -``` -```bash -... -$ Type "apropos word" to search for commands related to "word"... -$ Reading symbols from test...(no debugging symbols found)...done. -``` - -Use ``target remote`` to connect to the target system, replacing ``[target-ip]`` with the IP address of the target system. +Run ``gdb`` on your local client machine and use ``target remote`` to connect to the target system, replacing ``[target-ip]`` with the IP address of the target system. ```gdb #client --
[EGIT] [website/www-content] master 01/01: Wiki page remote-debug.md changed with summary [created] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=9d9cb47292b32e91eca3e04e358919ed7f912e89 commit 9d9cb47292b32e91eca3e04e358919ed7f912e89 Author: Gareth Halfacree Date: Thu Nov 30 07:00:31 2017 -0800 Wiki page remote-debug.md changed with summary [created] by Gareth Halfacree --- pages/develop/debug/c/remote-debug.md.txt | 134 ++ 1 file changed, 134 insertions(+) diff --git a/pages/develop/debug/c/remote-debug.md.txt b/pages/develop/debug/c/remote-debug.md.txt new file mode 100644 index 0..e1fd663f2 --- /dev/null +++ b/pages/develop/debug/c/remote-debug.md.txt @@ -0,0 +1,134 @@ +--- +~~Title: Remote Debugging~~ +--- + +# Remote Debugging # + +The debugging tools [GDB](gdb.md) and [Clouseau](clouseau.md) are most commonly used to debug an application locally, but can also be used remotely in order to debug a program running on one system using a different system entirely. This can be vital for debugging issues which result in display corruption or loss of user input capabilities on the host device. + +This document aims to provide a brief overview of the server capabilities available for remote debugging using these two tools. You will need an SSH server running on the system to be debugged, and an SSH client on the system you are controlling. + +## GDB Server ## + +Information on debugging local programs with the GNU Debugger (GDB) can be found in [Debugging with GDB](gdb.md). The GNU Debugger Server ``gdbserver`` is a control program for Unix-like systems which allows you to connect your program with a remote ``gdb`` via ``target remote`` but without linking in the usual debugging stub. + +``gdbserver`` is not a complete replacement for the debugging stubs because it requires essentially the same operating-system facilities that ``gdb`` itself does. In fact, a system that can run ``gdbserver`` to connect to a remote ``gdb`` could also run ``gdb`` locally. ``gdbserver`` is nevertheless sometimes useful because it is a much smaller program than ``gdb`` itself. It is also easier to port than all of ``gdb``, so you may be able to get started more quickly on a new system by usi [...] + +``gdb`` and ``gdbserver`` communicate via either a serial line or a TCP connection, using the standard GDB remote serial protocol. + +> **NOTE:** +> ``gdbserver`` does not have any security built-in. Do not run ``gdbserver`` while connected to any public network. A ``gdb`` connection to ``gdbserver`` provides access to the target system with the same privileges as the user running ``gdbserver``. + +### Remote Debugging with GDB ### + +Install ``gdbserver`` on your target system, then create and compile the "helloworld.c" program from [Debugging with GDB](gdb.md#Debugging_a_Callback_Function). + +Run the "helloworld" binary through ``gdbserver``: + +```bash +#target +gdbserver localhost:2000 helloworld + +$ Process hello created; pid = 2763 +$ Listening on port 2000 +``` + +At this point ``gdbserver`` is waiting for a connection on port 2000 of the target system. + +> **NOTE:** +> The GNU Debugger can be launched as multiple processes using ``gdbserver --multi localhost:2000``. + +On the client side, with a run ``gdb``: + +```gdb +#client +gdb hello +``` +```bash +... +$ Type "apropos word" to search for commands related to "word"... +$ Reading symbols from test...(no debugging symbols found)...done. +``` + +Use ``target remote`` to connect to the target system, replacing ``[target-ip]`` with the IP address of the target system. + +```gdb +#client +gdb +(gdb) target remote [target-ip]:2000 +$ Remote debugging using [target-ip]:2000 +$ Reading symbols from /lib64/ld-linux-x86-64.so.2...Reading symbols from +$ /usr/lib/debug//lib/x86_64-linux-gnu/ld-2.19.so...done. +$ done. +$ Loaded symbols for /lib64/ld-linux-x86-64.so.2 +$ 0x77ddb2d0 in _start () from /lib64/ld-linux-x86-64.so.2 +``` + +At this point you can add breakpoints or carry out other debugging tasks. Note, however, that if you continue the program's execution the output will display on the target system, not your local client. + +```gdb +#client +(gdb) continue +``` + +Return to the target system and click the "seg" button to trigger the segmentation fault condition. When the program crashes, the traces will appear on the local client system: + +```gdb +$ Program received signal SIGSEGV, Segmentation fault. +$ 0x00400b71 in ?? () +``` + +You can now use ``gdb`` as it is explaines in [[apps_efl_debugging#Segfault in +callback function]], for example print the backtrace: + +```gdb +(gdb) bt +$ 0 0x00400b71 in ?? () +$ 1 0x0073a9a0 in ?? () +$ 2 0x774e4f6c in _eo_evas_smart_cb (data=, eo_obj=, desc=, event_info=) at lib/evas/canvas/evas_object_smart.c:65 +$ 3 0x7561a8b7 in _eo_base_event_callback_call (obj_id=0x8007e040, pd=0x73a3f0, desc=0x85d4c0, event_
[EGIT] [website/www-content] master 01/01: Wiki page clouseau.md changed with summary [] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master.
http://git.enlightenment.org/website/www-content.git/commit/?id=16ae53e9c45c21ad7f1146207eaed17d2bb41371
commit 16ae53e9c45c21ad7f1146207eaed17d2bb41371
Author: Gareth Halfacree
Date: Thu Nov 30 06:54:53 2017 -0800
Wiki page clouseau.md changed with summary [] by Gareth Halfacree
---
pages/develop/debug/c/clouseau.md.txt | 4 +-
pages/develop/debug/clouseau.md.txt | 137 --
2 files changed, 2 insertions(+), 139 deletions(-)
diff --git a/pages/develop/debug/c/clouseau.md.txt
b/pages/develop/debug/c/clouseau.md.txt
index 56ea1838e..b261d1f3f 100644
--- a/pages/develop/debug/c/clouseau.md.txt
+++ b/pages/develop/debug/c/clouseau.md.txt
@@ -1,8 +1,8 @@
---
-~~Title: Clouseau~~
+~~Title: Debugging with Clouseau~~
---
-# Clouseau #
+# Debugging with Clouseau #
Clouseau is the EFL user interface inspection tool. It is designed to make it
easy to query UI components and structure. It supports remote debugging and
works with GDB. Clouseau can also provide information about different widgets
along with their properties.
diff --git a/pages/develop/debug/clouseau.md.txt
b/pages/develop/debug/clouseau.md.txt
deleted file mode 100644
index 56ea1838e..0
--- a/pages/develop/debug/clouseau.md.txt
+++ /dev/null
@@ -1,137 +0,0 @@
-~~Title: Clouseau~~
-
-# Clouseau #
-
-Clouseau is the EFL user interface inspection tool. It is designed to make it
easy to query UI components and structure. It supports remote debugging and
works with GDB. Clouseau can also provide information about different widgets
along with their properties.
-
-## Installing Clouseau ##
-
-Clouseau is available from the Enlightenment git repository using the
following command:
-
-```bash
-git clone https://git.enlightenment.org/tools/clouseau.git
-```
-
-## Debugging with Clouseau ##
-
-The following sections will demonstrate the use of Clouseau to debug a simple
"Hello World" program.
-
-### A Hello World Example ###
-
-Create the following program in your development environment or text editor:
-
-```c
-#include
-
-static void
-on_done(void *data, Evas_Object *obj, void *event_info)
-{
- `` quit the mainloop (elm_run function will return)
- elm_exit();
-}
-
-EAPI_MAIN int
-elm_main(int argc, char **argv)
-{
- Evas_Object *win, *box, *lab, *btn;
-
- `` new window - new background
- win = elm_win_util_standard_add("hello", "Hello");
- `` when the user clicks "close" on a window there is a request to delete
- evas_object_smart_callback_add(win, "delete,request", on_done, NULL);
- `` add a box object - default is vertical. a box holds children in a row,
- `` either horizontally or vertically. nothing more.
- box = elm_box_add(win);
- `` make the box horizontal
- elm_box_horizontal_set(box, EINA_TRUE);
- `` add object as a resize object for the window (controls window minimum
- `` size as well as gets resized if window is resized)
- elm_win_resize_object_add(win, box);
- evas_object_show(box);
- `` add a label widget, set the text and put it in the pad frame
- lab = elm_label_add(win);
- `` set default text of the label
- elm_object_text_set(lab, "Hello out there world!");
- `` pack the label at the end of the box
- elm_box_pack_end(box, lab);
- evas_object_show(lab);
- `` add an ok button
- btn = elm_button_add(win);
- `` set default text of button to "OK"
- elm_object_text_set(btn, "OK");
- `` pack the button at the end of the box
- elm_box_pack_end(box, btn);
- evas_object_show(btn);
- `` call on_done when button is clicked
- evas_object_smart_callback_add(btn, "clicked", on_done, NULL);
- `` now we are done, show the window
- evas_object_show(win);
-
- `` run the mainloop and process events and callbacks
- elm_run();
- return 0;
-}
-ELM_MAIN()
-```
-
-Save and compile the program as "helloworld".
-
-### Debugging Hello World with Clouseau ###
-
-Run the "helloworld" program through Clouseau with the following command:
-
-```bash
-clouseau ./helloworld
-```
-
-The following screenshot demonstrates Clouseau's output:
-
-
-
-* Yellow - The "helloworld" application
-* Red - the composition of the "helloworld" application
-* Blue - the characteristic of ``Elm`` and ``Evas_object``
-
-### Exploring Hello World ###
-
-The application is composed of three main widgets : ``Elm_win``, ``Elm_bg``,
and ``Elm_box``.
-
-```c
-win = elm_win_util_standard_add("hello", "Hello");
-[...]
-box = elm_box_add(win);
-```
-
-The ``elm_win_util_standard_add()`` function creates the window widget,
``win``, which is the root widget often used in an application. It also adds a
standard background (``Elm_bg``). Then the ``elm_box_add`` function creates a
``box`` widget.
-
-```c
-elm_box_pack_end(box, lab);
-[...]
-elm_box_pack_end(box, btn);
-```
-
-The ``elm_box_pack_end()`` functions add ``lab`` and ``btn`` widgets at the
end of the pack list, so the ``lab`` and ``bt
[EGIT] [website/www-content] master 01/01: Wiki page clouseau.md changed with summary [created] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master.
http://git.enlightenment.org/website/www-content.git/commit/?id=a702506f0fecc08f82a562ae38ad323c17fde578
commit a702506f0fecc08f82a562ae38ad323c17fde578
Author: Gareth Halfacree
Date: Thu Nov 30 06:53:02 2017 -0800
Wiki page clouseau.md changed with summary [created] by Gareth Halfacree
---
pages/develop/debug/c/clouseau.md.txt | 137 ++
1 file changed, 137 insertions(+)
diff --git a/pages/develop/debug/c/clouseau.md.txt
b/pages/develop/debug/c/clouseau.md.txt
new file mode 100644
index 0..56ea1838e
--- /dev/null
+++ b/pages/develop/debug/c/clouseau.md.txt
@@ -0,0 +1,137 @@
+---
+~~Title: Clouseau~~
+---
+
+# Clouseau #
+
+Clouseau is the EFL user interface inspection tool. It is designed to make it
easy to query UI components and structure. It supports remote debugging and
works with GDB. Clouseau can also provide information about different widgets
along with their properties.
+
+## Installing Clouseau ##
+
+Clouseau is available from the Enlightenment git repository using the
following command:
+
+```bash
+git clone https://git.enlightenment.org/tools/clouseau.git
+```
+
+## Debugging with Clouseau ##
+
+The following sections will demonstrate the use of Clouseau to debug a simple
"Hello World" program.
+
+### A Hello World Example ###
+
+Create the following program in your development environment or text editor:
+
+```c
+#include
+
+static void
+on_done(void *data, Evas_Object *obj, void *event_info)
+{
+ `` quit the mainloop (elm_run function will return)
+ elm_exit();
+}
+
+EAPI_MAIN int
+elm_main(int argc, char **argv)
+{
+ Evas_Object *win, *box, *lab, *btn;
+
+ `` new window - new background
+ win = elm_win_util_standard_add("hello", "Hello");
+ `` when the user clicks "close" on a window there is a request to delete
+ evas_object_smart_callback_add(win, "delete,request", on_done, NULL);
+ `` add a box object - default is vertical. a box holds children in a row,
+ `` either horizontally or vertically. nothing more.
+ box = elm_box_add(win);
+ `` make the box horizontal
+ elm_box_horizontal_set(box, EINA_TRUE);
+ `` add object as a resize object for the window (controls window minimum
+ `` size as well as gets resized if window is resized)
+ elm_win_resize_object_add(win, box);
+ evas_object_show(box);
+ `` add a label widget, set the text and put it in the pad frame
+ lab = elm_label_add(win);
+ `` set default text of the label
+ elm_object_text_set(lab, "Hello out there world!");
+ `` pack the label at the end of the box
+ elm_box_pack_end(box, lab);
+ evas_object_show(lab);
+ `` add an ok button
+ btn = elm_button_add(win);
+ `` set default text of button to "OK"
+ elm_object_text_set(btn, "OK");
+ `` pack the button at the end of the box
+ elm_box_pack_end(box, btn);
+ evas_object_show(btn);
+ `` call on_done when button is clicked
+ evas_object_smart_callback_add(btn, "clicked", on_done, NULL);
+ `` now we are done, show the window
+ evas_object_show(win);
+
+ `` run the mainloop and process events and callbacks
+ elm_run();
+ return 0;
+}
+ELM_MAIN()
+```
+
+Save and compile the program as "helloworld".
+
+### Debugging Hello World with Clouseau ###
+
+Run the "helloworld" program through Clouseau with the following command:
+
+```bash
+clouseau ./helloworld
+```
+
+The following screenshot demonstrates Clouseau's output:
+
+
+
+* Yellow - The "helloworld" application
+* Red - the composition of the "helloworld" application
+* Blue - the characteristic of ``Elm`` and ``Evas_object``
+
+### Exploring Hello World ###
+
+The application is composed of three main widgets : ``Elm_win``, ``Elm_bg``,
and ``Elm_box``.
+
+```c
+win = elm_win_util_standard_add("hello", "Hello");
+[...]
+box = elm_box_add(win);
+```
+
+The ``elm_win_util_standard_add()`` function creates the window widget,
``win``, which is the root widget often used in an application. It also adds a
standard background (``Elm_bg``). Then the ``elm_box_add`` function creates a
``box`` widget.
+
+```c
+elm_box_pack_end(box, lab);
+[...]
+elm_box_pack_end(box, btn);
+```
+
+The ``elm_box_pack_end()`` functions add ``lab`` and ``btn`` widgets at the
end of the pack list, so the ``lab`` and ``btn`` widgets appear inside the
``box`` widget.
+
+The blue section of the screenshot shows certain characteristics of the object
and widget: their position, size, color and so on. Some of these
characteristics are dynamic and can be updated with the reload button in
Clouseau.
+
+```c
+elm_win_resize_object_add(win, box);
+```
+
+The ``elm_win_resize_object_add()`` function controls the size of the window
such that it takes up the minimum of space. You can see in the blue section
that the minimum and maximum size are equal as a consequence of this function
call.
+
+### Displaying All Objects ##
+
+To control the objects that are displayed, click on the "
[EGIT] [website/www-content] master 01/01: Wiki page documentation-guide.md changed with summary [] by Andrew Williams
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=48b288fde7fadd015b3176864805e2a7d6b074fb commit 48b288fde7fadd015b3176864805e2a7d6b074fb Author: Andrew Williams Date: Thu Nov 30 06:46:49 2017 -0800 Wiki page documentation-guide.md changed with summary [] by Andrew Williams --- pages/contrib/docs/documentation-guide.md.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pages/contrib/docs/documentation-guide.md.txt b/pages/contrib/docs/documentation-guide.md.txt index 843a1e78b..a460753ad 100644 --- a/pages/contrib/docs/documentation-guide.md.txt +++ b/pages/contrib/docs/documentation-guide.md.txt @@ -252,9 +252,10 @@ The format of a sidebar is shown below: * [[/contrib/reporting_bugs]] * [[/contrib/efl-debug]] * [[/contrib/enlightenment_debugging]] - * [[/contrib/devs/git-guide.md]] - * [[contrib/devs/arcanist-guide.md]] - * [[contrib/docs/documentation-guide.md]] + * [[/contrib/devs/ | EFL Developer guide]] +* [[/contrib/devs/git-guide.md]] +* [[/contrib/devs/arcanist-guide.md]] +* [[/contrib/docs/documentation-guide.md]] * [[/contrib/docs/ | Documentation]] * [[/contrib/docs/eo-guide | Eolian Documentation Guide]] * [[/contrib/docs/eo | Eolian File Format]] --
[EGIT] [website/www-content] master 01/01: Wiki page documentation-guide.md changed with summary [sidebar -> navigation] by Andrew Williams
WWW-www.enlightenment.org pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=64d919509d1cb1e64781b7b886ee84230aa9a2bb commit 64d919509d1cb1e64781b7b886ee84230aa9a2bb Author: Andrew Williams Date: Thu Nov 30 06:43:12 2017 -0800 Wiki page documentation-guide.md changed with summary [sidebar -> navigation] by Andrew Williams --- pages/contrib/docs/documentation-guide.md.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pages/contrib/docs/documentation-guide.md.txt b/pages/contrib/docs/documentation-guide.md.txt index 3e28436e1..843a1e78b 100644 --- a/pages/contrib/docs/documentation-guide.md.txt +++ b/pages/contrib/docs/documentation-guide.md.txt @@ -239,11 +239,11 @@ Note that although Markdown does not require the numbers to be in the right orde At present, sub-lists are only correctly rendered in unordered bullet list format and will not display correctly in numbered list format. -## Sidebars ## +## Navigation ## -Documentation namespaces should have *sidebars*, permanent boxes visible on all pages providing quick navigation through that namespace. These sidebars exist as a page named "sidebar" in the parent namespace. +Documentation namespaces should have *navigation* sidebars, permanent boxes visible on all pages providing quick navigation through that namespace. These navigation elements are controlled by a page named "navigation" in the root of each top level namespace. Each navigation file is a hierarchical list of links for the entire namespace tree - child pages will be displayed when the parent page is being displayed so we can keep the navigation manageable. -When creating a new document in a namespace, or moving an existing document, always update the sidebar. To do so, find the sidebar file: the sidebar for the "/contrib" namespace, for example, is "/contrib/sidebar". +When creating a new document in a namespace, or moving an existing document, always update the navigation file. To do so, find the right file for the namespace: the navigation file for the "/contrib" namespace, for example, is "/contrib/navigation". The format of a sidebar is shown below: @@ -260,7 +260,7 @@ The format of a sidebar is shown below: * [[/contrib/docs/eo | Eolian File Format]] ``` -Note that these pages are in DokuWiki markup format, not Markdown Extra. Each entry in the sidebar should be in the form of a DokuWiki link; if the page to which you are linking has the DokuWiki title set in the frontmatter this will be pulled through and used as the display text. To override this title, or to link to a page which does not yet exist and thus has no title, use a pipe character followed by your preferred link text. +Note that these pages are in DokuWiki markup format, not Markdown Extra. Each entry in the navigation should be in the form of a DokuWiki link; if the page to which you are linking has the DokuWiki title set in the frontmatter this will be pulled through and used as the display text. To override this title, or to link to a page which does not yet exist and thus has no title, use a pipe character followed by your preferred link text. > **NOTE:** > Always include the ``.md`` extension when linking to a page in Markdown > format. Although the link will work without it, DokuWiki will not be able to > retrieve the title tag for sidebar display. --
[EGIT] [website/www-content] master 01/01: navigation: Move the contrib navigation to expanding nav plugin
ajwillia-ms pushed a commit to branch master.
http://git.enlightenment.org/website/www-content.git/commit/?id=a9b8498ad8112ce6ac4b90f13e076ab4583f9821
commit a9b8498ad8112ce6ac4b90f13e076ab4583f9821
Author: Andy Williams
Date: Thu Nov 30 14:29:53 2017 +
navigation: Move the contrib navigation to expanding nav plugin
---
pages/contrib/{sidebar.txt => navigation.txt} | 4 +---
pages/contrib/sidebar.txt | 13 +
2 files changed, 2 insertions(+), 15 deletions(-)
diff --git a/pages/contrib/sidebar.txt b/pages/contrib/navigation.txt
similarity index 91%
copy from pages/contrib/sidebar.txt
copy to pages/contrib/navigation.txt
index e9a551b4d..450e61172 100644
--- a/pages/contrib/sidebar.txt
+++ b/pages/contrib/navigation.txt
@@ -1,5 +1,3 @@
-~~NOCACHE~~
-
* [[/contrib/start]]
* [[/contrib/reporting_bugs]]
* [[/contrib/efl-debug]]
@@ -11,4 +9,4 @@
* [[/contrib/docs/start.md]]
* [[contrib/docs/documentation-guide.md | Writing Documentation]]
* [[/contrib/docs/eo-guide.md ]]
-* [[/contrib/docs/eo.md ]]
\ No newline at end of file
+* [[/contrib/docs/eo.md ]]
diff --git a/pages/contrib/sidebar.txt b/pages/contrib/sidebar.txt
index e9a551b4d..05ccbb1f4 100644
--- a/pages/contrib/sidebar.txt
+++ b/pages/contrib/sidebar.txt
@@ -1,14 +1,3 @@
~~NOCACHE~~
- * [[/contrib/start]]
- * [[/contrib/reporting_bugs]]
- * [[/contrib/efl-debug]]
- * [[/contrib/enlightenment_debugging]]
- * [[/contrib/devs/start.md ]]
-* [[/contrib/devs/coding-conventions.md]]
-* [[/contrib/devs/git-guide.md]]
-* [[/contrib/devs/arcanist-guide.md | Patch Submission and Review]]
- * [[/contrib/docs/start.md]]
-* [[contrib/docs/documentation-guide.md | Writing Documentation]]
-* [[/contrib/docs/eo-guide.md ]]
-* [[/contrib/docs/eo.md ]]
\ No newline at end of file
+{{navi>:contrib:navigation?ns}}
--
[EGIT] [core/efl] master 01/01: eina_file: make sure we use a stringshare when virtualized.
netstar pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=a538f478545e094ae4f158aaf6293ccef4bfb99d
commit a538f478545e094ae4f158aaf6293ccef4bfb99d
Author: Al Poole
Date: Thu Nov 30 13:57:25 2017 +
eina_file: make sure we use a stringshare when virtualized.
As the filename is now a stringshare, also make sure virtual
files use stringshares for the filename! Also when unmapping
we still need to test whether it is copied or not as unmap
will break on less tolerant architectures.
@fix T6449
---
src/lib/eina/eina_file.c| 2 +-
src/lib/eina/eina_file_common.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lib/eina/eina_file.c b/src/lib/eina/eina_file.c
index d56612fc75..bf02410ff5 100644
--- a/src/lib/eina/eina_file.c
+++ b/src/lib/eina/eina_file.c
@@ -300,7 +300,7 @@ eina_file_real_close(Eina_File *file)
if (file->fd != -1)
{
-if (file->global_map != MAP_FAILED)
+if (!file->copied && file->global_map != MAP_FAILED)
munmap(file->global_map, file->length);
close(file->fd);
}
diff --git a/src/lib/eina/eina_file_common.c b/src/lib/eina/eina_file_common.c
index edebaed326..1c53226a35 100644
--- a/src/lib/eina/eina_file_common.c
+++ b/src/lib/eina/eina_file_common.c
@@ -422,9 +422,9 @@ eina_file_virtualize(const char *virtual_name, const void
*data, unsigned long l
EINA_MAGIC_SET(file, EINA_FILE_MAGIC);
file->filename = (char *)(file + 1);
if (virtual_name)
- strcpy((char *)file->filename, virtual_name);
+ file->filename = eina_stringshare_add(virtual_name);
else
- sprintf((char *)file->filename, tmpname, ti);
+ file->filename = eina_stringshare_printf(tmpname, ti);
eina_lock_recursive_new(&file->lock);
file->mtime = ti / 1000;
--
[EGIT] [website/www-content] master 01/01: Wiki page valgrind.md changed with summary [created] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master.
http://git.enlightenment.org/website/www-content.git/commit/?id=06ec72372964661c8acae8883e27cf81abd20220
commit 06ec72372964661c8acae8883e27cf81abd20220
Author: Gareth Halfacree
Date: Thu Nov 30 05:26:40 2017 -0800
Wiki page valgrind.md changed with summary [created] by Gareth Halfacree
---
pages/develop/debug/c/valgrind.md.txt | 102 ++
1 file changed, 102 insertions(+)
diff --git a/pages/develop/debug/c/valgrind.md.txt
b/pages/develop/debug/c/valgrind.md.txt
new file mode 100644
index 0..ac61f051b
--- /dev/null
+++ b/pages/develop/debug/c/valgrind.md.txt
@@ -0,0 +1,102 @@
+---
+~~Title: Debugging with Valgrind~~
+---
+
+# Debugging with Valgrind #
+
+Valgrind is a collection of tools for tracking down memory-related issues,
from memory leaks through to uninitialized variables. While more information on
Valgrind is available on the [Valgrind
website](http://valgrind.org/docs/manual/manual.html), this document introduces
its use specifically for debugging applications written with the Enlightenment
Foundation Libraries (EFL).
+
+## Debugging a Memory Leak ##
+
+In this example an ``Eina`` array is created in a callback function but it is
never freed. This generates a memory leak. Begin by creating the following
program:
+
+```c
+#include
+
+static void
+on_done(void *data, Evas_Object *obj, void *event_info)
+{
+ Eina_Array *array;
+ unsigned int i;
+
+ eina_init();
+ array = eina_array_new(100);
+ eina_array_step_set(array, sizeof(*array), 20);
+ for (i = 0; i < 20; i++) eina_array_push(array, strdup("hello"));
+
+ /To free array/
+ //while (eina_array_count(array))
+ //free(eina_array_pop(array));
+ //eina_array_free(array);
+
+ //eina_shutdown();
+
+ // quit the mainloop (elm_run function will return)
+ elm_exit();
+}
+
+EAPI_MAIN int
+elm_main(int argc, char **argv)
+{
+ Evas_Object *win, *box, *btn;
+
+ // new window
+ win = elm_win_util_standard_add("hello", "Hello");
+ // add a box object
+ box = elm_box_add(win);
+ // add object as a resize object for the window (controls window minimum
+ // size as well as gets resized if window is resized)
+ elm_win_resize_object_add(win, box);
+ evas_object_show(box);
+ // add a button
+ btn = elm_button_add(win);
+ // set default text of button to "SEG"
+ elm_object_text_set(btn, "SEG");
+ // pack the button at the end of the box
+ elm_box_pack_end(box, btn);
+ evas_object_show(btn);
+ // call on_done when button is clicked
+ evas_object_smart_callback_add(btn, "clicked", on_done, NULL);
+ //show the window
+ evas_object_show(win);
+
+ // run the mainloop and process events and callbacks
+ elm_run();
+ return 0;
+}
+ELM_MAIN()
+```
+
+Save the program as "hello.", compile it, and run it through Valgrind:
+
+```bash
+valgrind --leak-check=full --track-origins=yes ./hello
+[...]
+==22370== 312 (32 direct, 280 indirect) bytes in 1 blocks are definitely lost
+in loss record 349 of 417
+==22370==at 0x4C28C20: malloc (vg_replace_malloc.c:296)
+==22370==by 0x55A585D: eina_array_new (eina_array.c:279)
+==22370==by 0x400E4C: on_done (hello.c:7)
+==22370==by 0x5CD1B83: _eo_evas_smart_cb (evas_object_smart.c:65)
+==22370==by 0x6BCFD21: _eo_base_event_callback_call (eo_base_class.c:716)
+==22370==by 0x6BCEA96: eo_event_callback_call (in
+/usr/local/lib/libeo.so.1.14.99)
+==22370==by 0x5CD3BAC: evas_object_smart_callback_call
+(evas_object_smart.c:791)
+==22370==by 0x4F34B8B: _activate (elm_button.c:69)
+==22370==by 0x4F34BC1: _on_clicked_signal (elm_button.c:191)
+==22370==by 0x6970424: edje_match_callback_exec_check_finals
+(edje_match.c:556)
+==22370==by 0x6970424: edje_match_callback_exec (edje_match.c:712)
+==22370==by 0x697673C: _edje_emit_cb (edje_program.c:1392)
+==22370==by 0x697673C: _edje_emit_handle (edje_program.c:1345)
+==22370==by 0x6971295: _edje_message_process (edje_message_queue.c:651)
+[...]
+```
+
+All the memory accesses pass through Valgrind, so it shows you a backtrace
when an allocation is made and not freed.
+
+> **NOTE:**
+> There can be other traces in the ``HEAD SUMMARY``, but this example focuses
on the memory leak within the application. As a result you may have to ignore
things not relevant to that code.
+
+This backtrace demonstrates that an allocation took place in the
``eina_array_new()`` function. This function is called from the ``on_done()``
function. You can go further up the backtrace, but remember that a callback
function is called from ``Evas`` so there is a good chance that the allocation
is made in your specific callback function.
\ No newline at end of file
--
[EGIT] [website/www-content] master 01/01: Wiki page gdb.md changed with summary [created] by Gareth Halfacree
WWW-www.enlightenment.org pushed a commit to branch master.
http://git.enlightenment.org/website/www-content.git/commit/?id=7bd74a834d75ecf510334b242cb603c445aa5a7f
commit 7bd74a834d75ecf510334b242cb603c445aa5a7f
Author: Gareth Halfacree
Date: Thu Nov 30 05:07:07 2017 -0800
Wiki page gdb.md changed with summary [created] by Gareth Halfacree
---
pages/develop/debug/c/gdb.md.txt | 231 +++
1 file changed, 231 insertions(+)
diff --git a/pages/develop/debug/c/gdb.md.txt b/pages/develop/debug/c/gdb.md.txt
new file mode 100644
index 0..b00c5e259
--- /dev/null
+++ b/pages/develop/debug/c/gdb.md.txt
@@ -0,0 +1,231 @@
+## Wrong function on an object ##
+
+---
+~~Title: Debugging with GDB~~
+---
+
+# Debugging with GDB #
+
+The GNU Debugger (GDB) is an invaluable tool for tracking down the precise
cause of a crash or other error. While more information on GDB is available on
the [GNU website](https://www.gnu.org/software/gdb/documentation/), this
document introduces its use specifically for debugging applications written
with the Enlightenment Foundation Libraries (EFL).
+
+> **NOTE:** Always begin by running the problem application and walking
through the steps needed to reproduce the crash. GDB is of most use when you
have a reliable reproduction for your issue.
+
+## Debugging an Incorrect Object ##
+
+The code below creates three Elementary objects: ``win``, ``box`` and ``btn``.
It displays a window with an "OK" button which closes the window when it is
clicked. Enter the following and save it as "hello.c":
+
+```c
+#include
+
+static void
+on_done(void *data, Evas_Object *obj, void *event_info)
+{
+ `` quit the mainloop (elm_run function will return)
+ elm_exit();
+}
+
+EAPI_MAIN int
+elm_main(int argc, char **argv)
+{
+ Evas_Object *win, *box, *btn;
+
+ `` new window
+ win = elm_win_util_standard_add("hello", "Hello");
+ `` add a box object
+ box = elm_box_add(win);
+ `` add object as a resize object for the window (controls window minimum
+ `` size as well as gets resized if window is resized)
+ elm_win_resize_object_add(win, box);
+ evas_object_show(box);
+ `` add a button
+ btn = elm_button_add(win);
+ `` set default text of button to "OK"
+ elm_object_text_set(btn, "OK");
+ `` pack the button at the end of the box
+ /ERROR/
+ elm_box_pack_end(win, btn); ``win instead of box
+ evas_object_show(btn);
+ `` call on_done when button is clicked
+ evas_object_smart_callback_add(win, "clicked", on_done, NULL);
+ ``show the window
+ evas_object_show(win);
+
+ `` run the mainloop and process events and callbacks
+ elm_run();
+ return 0;
+}
+ELM_MAIN()
+```
+
+Compile with the ``-g`` flag to enable debugging symbols:
+
+```bash
+gcc -Wall -O1 -march=native -g -ggdb3 -o hello hello.c `pkg-config --cflags
--libs elementary`
+```
+
+Then execute the program:
+
+```bash
+./hello
+ERR<13670>:eo lib/eo/eo.c:780 _eo_api_op_id_get() in elm_box.eo.c:48: unable
to resolve regular api func 'elm_obj_box_pack_end' 0x7f1128f50faf in class
'Elm_Win'.
+```
+
+The cause of this error is that the ``elm_box_pack_end()`` function is called
on the incorrect object, ``win``. The error log says that the
``elm_obj_box_pack_end`` is not in the ``Elm_win`` API, and so that the error
is coming from the application and not from EFL itself.
+
+For a more complicated application, this basic trace is not enough to track
down the precise location of the error. Fortunately, EFL provides a macro for
backtraces: ``EINA_LOG_ABORT``.
+
+A message generated by CRI macro can automatically call ``abort()`` once a
message of a given log level is printed. This is controlled by the environment
variable ``EINA_LOG_ABORT`` and the level to be considered critical with
``EINA_LOG_ABORT_LEVEL``. This means the program will stop at the first error
which meets these two requirements.
+
+Run GDB over your application to receive the following backtrace:
+
+```gdb
+EINA_LOG_ABORT_LEVEL=4 EINA_LOG_ABORT=1 gdb hello
+(gdb) run
+Starting program: /home/efl/test/hello
+[Thread debugging using libthread_db enabled]
+Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
+[New Thread 0x7fffea2da700 (LWP 13679)]
+ERR<13675>:eo lib/eo/eo.c:780 _eo_api_op_id_get() in elm_box.eo.c:48: unable
+to resolve regular api func 'elm_obj_box_pack_end' 0x77991faf in class
+'Elm_Win'.
+
+Program received signal SIGABRT, Aborted.
+0x76c76cc9 in __GI_raise (sig=sig@entry=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:56
+56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
+(gdb) bt
+#0 0x76c76cc9 in __GI_raise (sig=sig@entry=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:56
+#1 0x76c7a0d8 in __GI_abort () at abort.c:89
+#2 0x76387919 in eina_log_print_unlocked (args=0x7fffdac8,
fmt=0x7561c970 "in %s:%d: unable to resolve %s api func '%s' %p in class
'%s'.", line=780,fnc=0x7561d330 <__FU
[EGIT] [core/efl] master 01/01: edje legacy: replace Edje_Object with Evas_Object
ami pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=5b113aaa38a09454f60b4b4423e9b908002c53a6 commit 5b113aaa38a09454f60b4b4423e9b908002c53a6 Author: Amitesh Singh Date: Thu Nov 30 20:05:49 2017 +0900 edje legacy: replace Edje_Object with Evas_Object --- src/lib/edje/Edje_Legacy.h | 268 ++--- 1 file changed, 134 insertions(+), 134 deletions(-) diff --git a/src/lib/edje/Edje_Legacy.h b/src/lib/edje/Edje_Legacy.h index e13aef9a50..aaecf138bc 100644 --- a/src/lib/edje/Edje_Legacy.h +++ b/src/lib/edje/Edje_Legacy.h @@ -250,7 +250,7 @@ EAPI const char *edje_load_error_str (Edje_Load_Error error); * * @ingroup Edje_Object */ -EAPI Eina_Bool edje_object_part_geometry_get(const Edje_Object *obj, const char * part, int *x, int *y, int *w, int *h); +EAPI Eina_Bool edje_object_part_geometry_get(const Evas_Object *obj, const char * part, int *x, int *y, int *w, int *h); /** * @brief Returns the state of the Edje part. @@ -262,7 +262,7 @@ EAPI Eina_Bool edje_object_part_geometry_get(const Edje_Object *obj, const char * * @ingroup Edje_Object */ -EAPI const char *edje_object_part_state_get(const Edje_Object *obj, const char * part, double *val_ret); +EAPI const char *edje_object_part_state_get(const Evas_Object *obj, const char * part, double *val_ret); /** * @brief Gets a handle to the Evas object implementing a given Edje part, in @@ -288,7 +288,7 @@ EAPI const char *edje_object_part_state_get(const Edje_Object *obj, const char * * * @ingroup Edje_Object */ -EAPI const Efl_Canvas_Object *edje_object_part_object_get(const Edje_Object *obj, const char * part); +EAPI const Efl_Canvas_Object *edje_object_part_object_get(const Evas_Object *obj, const char * part); /** * @brief Whether this object updates its size hints automatically. @@ -309,7 +309,7 @@ EAPI const Efl_Canvas_Object *edje_object_part_object_get(const Edje_Object *obj * * @ingroup Edje_Object */ -EAPI void edje_object_update_hints_set(Edje_Object *obj, Eina_Bool update); +EAPI void edje_object_update_hints_set(Evas_Object *obj, Eina_Bool update); /** * @brief Whether this object updates its size hints automatically. @@ -330,7 +330,7 @@ EAPI void edje_object_update_hints_set(Edje_Object *obj, Eina_Bool update); * * @ingroup Edje_Object */ -EAPI Eina_Bool edje_object_update_hints_get(const Edje_Object *obj); +EAPI Eina_Bool edje_object_update_hints_get(const Evas_Object *obj); /** * @brief Calculates the minimum required size for a given Edje object. @@ -343,7 +343,7 @@ EAPI Eina_Bool edje_object_update_hints_get(const Edje_Object *obj); * * @ingroup Edje_Object */ -EAPI void edje_object_size_min_calc(Edje_Object *obj, int *minw, int *minh); +EAPI void edje_object_size_min_calc(Evas_Object *obj, int *minw, int *minh); /** * @brief Calculates the minimum required size for a given Edje object. @@ -370,7 +370,7 @@ EAPI void edje_object_size_min_calc(Edje_Object *obj, int *minw, int *minh); * * @ingroup Edje_Object */ -EAPI void edje_object_size_min_restricted_calc(Edje_Object *obj, int *minw, int *minh, int restrictedw, int restrictedh); +EAPI void edje_object_size_min_restricted_calc(Evas_Object *obj, int *minw, int *minh, int restrictedw, int restrictedh); /** * @brief Calculates the geometry of the region, relative to a given Edje @@ -394,7 +394,7 @@ EAPI void edje_object_size_min_restricted_calc(Edje_Object *obj, int *minw, int * * @ingroup Edje_Object */ -EAPI Eina_Bool edje_object_parts_extends_calc(Edje_Object *obj, int *x, int *y, int *w, int *h); +EAPI Eina_Bool edje_object_parts_extends_calc(Evas_Object *obj, int *x, int *y, int *w, int *h); /** * @brief Forces a Size/Geometry calculation. @@ -405,7 +405,7 @@ EAPI Eina_Bool edje_object_parts_extends_calc(Edje_Object *obj, int *x, int *y, * * @ingroup Edje_Object */ -EAPI void edje_object_calc_force(Edje_Object *obj); +EAPI void edje_object_calc_force(Evas_Object *obj); /** * @brief Freezes the Edje object. @@ -419,7 +419,7 @@ EAPI void edje_object_calc_force(Edje_Object *obj); * * @ingroup Edje_Object */ -EAPI int edje_object_freeze(Edje_Object *obj); +EAPI int edje_object_freeze(Evas_Object *obj); /** * @brief Thaws the Edje object. @@ -435,7 +435,7 @@ EAPI int edje_object_freeze(Edje_Object *obj); * * @ingroup Edje_Object */ -EAPI int edje_object_thaw(Edje_Object *obj); +EAPI int edje_object_thaw(Evas_Object *obj); /** * @typedef (*Edje_Text_Change_Cb) @@ -459,7 +459,7 @@ typedef void (*Edje_Text_Change_Cb) (void *data, Evas_Object *obj, c * @param[in] func The callback function to handle the text change * @param[in] data The data associated to the callback function. */ -EAPI void edje_object_text_change_cb_set(Edje_Object *obj, Edje_Text_Change_Cb func, void *data); +EAPI void edje_object_text_change_cb_set(Evas_Object *obj, Edje_Text_Ch
[EGIT] [tools/examples] master 02/02: texteditor: Add a "new" button
ajwillia-ms pushed a commit to branch master.
http://git.enlightenment.org/tools/examples.git/commit/?id=f6dd1b7ab3b1af3f69271863f5f07365599e64d9
commit f6dd1b7ab3b1af3f69271863f5f07365599e64d9
Author: Andy Williams
Date: Thu Nov 30 10:35:26 2017 +
texteditor: Add a "new" button
Also make the textarea multiline... oops
---
apps/c/texteditor/src/texteditor_main.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/apps/c/texteditor/src/texteditor_main.c
b/apps/c/texteditor/src/texteditor_main.c
index 41080e4..d0b0f5e 100644
--- a/apps/c/texteditor/src/texteditor_main.c
+++ b/apps/c/texteditor/src/texteditor_main.c
@@ -8,6 +8,12 @@
Efl_Ui_Text *_editor;
static void
+_gui_new_clicked_cb(void *data EINA_UNUSED, const Efl_Event *event EINA_UNUSED)
+{
+ efl_text_set(_editor, "");
+}
+
+static void
_gui_quit_clicked_cb(void *data EINA_UNUSED, const Efl_Event *event
EINA_UNUSED)
{
efl_exit(0);
@@ -40,6 +46,12 @@ _gui_toolbar_setup(Efl_Ui_Box *parent)
efl_gfx_size_hint_weight_set(efl_added, 1, 0),
efl_ui_direction_set(efl_added, EFL_UI_DIR_HORIZONTAL));
+ _gui_toolbar_button_add(bar, "New", "document-new", _gui_new_clicked_cb);
+
+ // spacer box
+ efl_add(EFL_UI_BOX_CLASS, parent,
+ efl_pack(bar, efl_added),
+ efl_gfx_size_hint_weight_set(efl_added, 10, 0));
_gui_toolbar_button_add(bar, "Quit", "application-exit",
_gui_quit_clicked_cb);
}
@@ -62,6 +74,7 @@ _gui_setup()
_editor = efl_add(EFL_UI_TEXT_CLASS, box,
efl_text_set(efl_added, "Edit me"),
efl_text_font_set(efl_added, "Mono", 14),
+ efl_text_multiline_set(efl_added, EINA_TRUE),
efl_ui_text_interactive_editable_set(efl_added,
EINA_TRUE),
efl_ui_text_scrollable_set(efl_added, EINA_TRUE),
efl_pack(box, efl_added));
--
[EGIT] [tools/examples] master 01/02: texteditor: Better simulate a toolbar until we have one ready
ajwillia-ms pushed a commit to branch master. http://git.enlightenment.org/tools/examples.git/commit/?id=93af3a55ae189ded4741ca2e459de643cb85a743 commit 93af3a55ae189ded4741ca2e459de643cb85a743 Author: Andy Williams Date: Thu Nov 30 10:34:58 2017 + texteditor: Better simulate a toolbar until we have one ready --- apps/c/texteditor/src/texteditor_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/c/texteditor/src/texteditor_main.c b/apps/c/texteditor/src/texteditor_main.c index f8c0417..41080e4 100644 --- a/apps/c/texteditor/src/texteditor_main.c +++ b/apps/c/texteditor/src/texteditor_main.c @@ -24,10 +24,10 @@ _gui_toolbar_button_add(Efl_Ui_Box *toolbar, const char *name, efl_pack(toolbar, efl_added), efl_event_callback_add(efl_added, EFL_UI_EVENT_CLICKED, func, efl_added)); - // TODO actually show the icon in the button + efl_add(EFL_UI_IMAGE_CLASS, toolbar, efl_ui_image_icon_set(efl_added, icon_name), - efl_content_set(efl_part(button, "icon"), efl_added)); + efl_content_set(efl_part(button, "elm.swallow.content"), efl_added)); } static void @@ -37,7 +37,7 @@ _gui_toolbar_setup(Efl_Ui_Box *parent) bar = efl_add(EFL_UI_BOX_CLASS, parent, efl_pack(parent, efl_added), - efl_gfx_size_hint_max_set(efl_added, EINA_SIZE2D(1, 40)), + efl_gfx_size_hint_weight_set(efl_added, 1, 0), efl_ui_direction_set(efl_added, EFL_UI_DIR_HORIZONTAL)); _gui_toolbar_button_add(bar, "Quit", "application-exit", _gui_quit_clicked_cb); --
[EGIT] [core/efl] master 01/01: edje: fix the typo in prev commit
ami pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=864fbede3e5cc36fcde0f791478bf0928217314a commit 864fbede3e5cc36fcde0f791478bf0928217314a Author: Amitesh Singh Date: Thu Nov 30 20:02:36 2017 +0900 edje: fix the typo in prev commit --- src/lib/edje/edje_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/edje/edje_util.c b/src/lib/edje/edje_util.c index 06bc9ee1ba..2872317b13 100644 --- a/src/lib/edje/edje_util.c +++ b/src/lib/edje/edje_util.c @@ -402,7 +402,7 @@ edje_object_base_scale_get(const Eo *obj) ed = _edje_fetch(obj); if (!ed->file) return 1.0; - return TO_DOUBLE(ed->scale); + return TO_DOUBLE(ed->file->base_scale); } EOLIAN Eina_Bool --
[EGIT] [tools/examples] master 01/01: lifecycle: EAPI_MAIN need to be used as it is an application symbol, not a library one.
cedric pushed a commit to branch master.
http://git.enlightenment.org/tools/examples.git/commit/?id=91934fe8ec3f3b3dd9daa8bec6c897fd683c4371
commit 91934fe8ec3f3b3dd9daa8bec6c897fd683c4371
Author: Cedric Bail
Date: Thu Nov 30 02:47:40 2017 -0800
lifecycle: EAPI_MAIN need to be used as it is an application symbol, not a
library one.
---
tutorial/c/lifecycle/src/lifecycle_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tutorial/c/lifecycle/src/lifecycle_main.c
b/tutorial/c/lifecycle/src/lifecycle_main.c
index e3a8ba5..8e962ce 100644
--- a/tutorial/c/lifecycle/src/lifecycle_main.c
+++ b/tutorial/c/lifecycle/src/lifecycle_main.c
@@ -44,19 +44,19 @@ _simulate_app_background(void *data, const Efl_Event *ev)
}
/* end helper methods - what follows below is efl event handling that you can
use in your apps. */
-EAPI void
+EAPI_MAIN void
efl_pause(void *data EINA_UNUSED, const Efl_Event *ev EINA_UNUSED)
{
printf("Lifecycle: paused\n");
}
-EAPI void
+EAPI_MAIN void
efl_resume(void *data EINA_UNUSED, const Efl_Event *ev EINA_UNUSED)
{
printf("Lifecycle: resumed\n");
}
-EAPI void
+EAPI_MAIN void
efl_terminate(void *data EINA_UNUSED, const Efl_Event *ev EINA_UNUSED)
{
printf("Lifecycle: terminated\n");
--
[EGIT] [core/efl] master 01/01: Efl.Ui.Base: remove base_scale.get{} from interface.
ami pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=2ddea7065f0bd60764ad7b7f8118463a14a37085
commit 2ddea7065f0bd60764ad7b7f8118463a14a37085
Author: Amitesh Singh
Date: Thu Nov 30 19:27:04 2017 +0900
Efl.Ui.Base: remove base_scale.get{} from interface.
base_scale for edje would be legacy now.
---
src/lib/edje/Edje_Legacy.h| 2 +-
src/lib/edje/edje_object.eo | 1 -
src/lib/edje/edje_util.c | 13 +
src/lib/efl/interfaces/efl_ui_base.eo | 21 -
4 files changed, 6 insertions(+), 31 deletions(-)
diff --git a/src/lib/edje/Edje_Legacy.h b/src/lib/edje/Edje_Legacy.h
index 78d9656bfe..e13aef9a50 100644
--- a/src/lib/edje/Edje_Legacy.h
+++ b/src/lib/edje/Edje_Legacy.h
@@ -1507,7 +1507,7 @@ EAPI double edje_object_scale_get(const Edje_Object *obj);
*
* @ingroup Edje_Object
*/
-EAPI double edje_object_base_scale_get(const Edje_Object *obj);
+EAPI double edje_object_base_scale_get(const Evas_Object *obj);
/**
* @defgroup Edje_Part_Drag Edje Drag
diff --git a/src/lib/edje/edje_object.eo b/src/lib/edje/edje_object.eo
index d077b6a3e0..2be3869e9a 100644
--- a/src/lib/edje/edje_object.eo
+++ b/src/lib/edje/edje_object.eo
@@ -126,7 +126,6 @@ class Edje.Object (Efl.Canvas.Group, Efl.File,
Efl.Container, Efl.Part,
Efl.Ui.Base.mirrored { set; get; }
Efl.Ui.Base.language { set; get; }
Efl.Ui.Base.scale { set; get; }
- Efl.Ui.Base.base_scale { get; }
Efl.File.load_error { get; }
Efl.File.mmap { get; set; }
Efl.Container.content_remove;
diff --git a/src/lib/edje/edje_util.c b/src/lib/edje/edje_util.c
index fc47e43b13..06bc9ee1ba 100644
--- a/src/lib/edje/edje_util.c
+++ b/src/lib/edje/edje_util.c
@@ -395,17 +395,14 @@ _edje_object_efl_ui_base_scale_get(Eo *obj EINA_UNUSED,
Edje *ed)
return TO_DOUBLE(ed->scale);
}
-EOLIAN double
-_edje_object_efl_ui_base_base_scale_get(Eo *obj EINA_UNUSED, Edje *ed)
-{
- if (!ed->file) return 1.0;
- return TO_DOUBLE(ed->file->base_scale);
-}
-
EAPI double
edje_object_base_scale_get(const Eo *obj)
{
- return efl_ui_base_scale_get(obj);
+ Edje *ed;
+
+ ed = _edje_fetch(obj);
+ if (!ed->file) return 1.0;
+ return TO_DOUBLE(ed->scale);
}
EOLIAN Eina_Bool
diff --git a/src/lib/efl/interfaces/efl_ui_base.eo
b/src/lib/efl/interfaces/efl_ui_base.eo
index 7ddcbf0336..eb00535a2d 100644
--- a/src/lib/efl/interfaces/efl_ui_base.eo
+++ b/src/lib/efl/interfaces/efl_ui_base.eo
@@ -65,26 +65,5 @@ interface Efl.Ui.Base
meaning individual scaling is not set)]]
}
}
- @property base_scale {
- [[The base scale of a layout object (read-only).
-
- The base scale refers to the scale for which the backing EDC file
- was designed. By default it is 1.0 which means the EDC file was
- designed for a scale of 1.0.
-
- This base scale can be specified in an EDC file as the
- collections' "base_scale" field.
-
- If the object is not a layout, this will return 1.0.
- ]]
- get {
-[[Gets a given layout object's base_scale factor.]]
- }
- values {
-base_scale: double(1.0); [[The base_scale factor (the default value
- is 1.0, meaning that the edc file was
- designed based on scale 1.0).]]
- }
- }
}
}
--
[EGIT] [core/efl] master 01/01: elm tests: show nstate & slider_interval widgets in Efl.Ui scope
ami pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=3ed9271bf4f2ac8262387a250f07877a3524aa39 commit 3ed9271bf4f2ac8262387a250f07877a3524aa39 Author: Amitesh Singh Date: Thu Nov 30 18:47:57 2017 +0900 elm tests: show nstate & slider_interval widgets in Efl.Ui scope --- src/bin/elementary/test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/elementary/test.c b/src/bin/elementary/test.c index f23b37d4ee..726fc4bb67 100644 --- a/src/bin/elementary/test.c +++ b/src/bin/elementary/test.c @@ -1029,8 +1029,8 @@ add_tests: ADD_TEST(NULL, "Range Values", "Slider", test_slider); ADD_TEST(NULL, "Range Values", "Progressbar", test_progressbar); ADD_TEST(NULL, "Range Values", "Progressbar 2", test_progressbar2); - ADD_TEST_EO(NULL, "Range Values", "Nstate", test_nstate); - ADD_TEST_EO(NULL, "Range Values", "Interval Slider", test_slider_interval); + ADD_TEST_EO(NULL, "Range Values", "Efl.Ui.Nstate", test_nstate); + ADD_TEST_EO(NULL, "Range Values", "Efl.Ui.Slider_Interval", test_slider_interval); //--// ADD_TEST(NULL, "Booleans", "Check", test_check); --
[EGIT] [core/efl] feature/eo_theme 01/01: efl_ui_popup: remove unnecessary overides
jaehyun pushed a commit to branch feature/eo_theme.
http://git.enlightenment.org/core/efl.git/commit/?id=8e2639fdd693176b7a7c95166c9aecede3a92024
commit 8e2639fdd693176b7a7c95166c9aecede3a92024
Author: Sungtaek Hong
Date: Thu Nov 30 18:15:11 2017 +0900
efl_ui_popup: remove unnecessary overides
Summary:
efl_ui_popup parts overrides efl_content and efl_text
which are sometimes not needed.
Test Plan: Run elementary_test -> efl_ui_popup tests
Reviewers: jpeg, cedric, woohyun, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: Jaehyun_Cho, Blackmole, herb
Differential Revision: https://phab.enlightenment.org/D5556
---
src/lib/elementary/efl_ui_popup.c | 24 -
src/lib/elementary/efl_ui_popup_alert.c | 37 ---
src/lib/elementary/efl_ui_popup_alert_part.eo | 4 +--
src/lib/elementary/efl_ui_popup_part.eo | 4 +--
4 files changed, 13 insertions(+), 56 deletions(-)
diff --git a/src/lib/elementary/efl_ui_popup.c
b/src/lib/elementary/efl_ui_popup.c
index 285ae39935..ab9ce2cce8 100644
--- a/src/lib/elementary/efl_ui_popup.c
+++ b/src/lib/elementary/efl_ui_popup.c
@@ -241,35 +241,11 @@ _efl_ui_popup_elm_layout_sizing_eval(Eo *obj,
Efl_Ui_Popup_Data *pd EINA_UNUSED)
_calc_align(obj);
}
-static Eina_Bool
-_efl_ui_popup_content_set(Eo *obj, Efl_Ui_Popup_Data *pd EINA_UNUSED, const
char *part, Eo *content)
-{
- return efl_content_set(efl_part(efl_super(obj, MY_CLASS), part), content);
-}
-
-Eo *
-_efl_ui_popup_content_get(Eo *obj, Efl_Ui_Popup_Data *pd EINA_UNUSED, const
char *part)
-{
- return efl_content_get(efl_part(efl_super(obj, MY_CLASS), part));
-}
-
-static Eo *
-_efl_ui_popup_content_unset(Eo *obj, Efl_Ui_Popup_Data *pd EINA_UNUSED, const
char *part)
-{
- return efl_content_unset(efl_part(efl_super(obj, MY_CLASS), part));
-}
-
/* Standard widget overrides */
ELM_PART_CONTENT_DEFAULT_SET(efl_ui_popup, "elm.swallow.content")
ELM_PART_CONTENT_DEFAULT_IMPLEMENT(efl_ui_popup, Efl_Ui_Popup_Data)
-/* Efl.Part begin */
-
-ELM_PART_OVERRIDE_CONTENT_SET(efl_ui_popup, EFL_UI_POPUP, Efl_Ui_Popup_Data)
-ELM_PART_OVERRIDE_CONTENT_GET(efl_ui_popup, EFL_UI_POPUP, Efl_Ui_Popup_Data)
-ELM_PART_OVERRIDE_CONTENT_UNSET(efl_ui_popup, EFL_UI_POPUP, Efl_Ui_Popup_Data)
-
EOLIAN static Eo *
_efl_ui_popup_efl_part_part(const Eo *obj, Efl_Ui_Popup_Data *_pd EINA_UNUSED,
const char *part)
{
diff --git a/src/lib/elementary/efl_ui_popup_alert.c
b/src/lib/elementary/efl_ui_popup_alert.c
index 9a23d23f49..0249977dea 100644
--- a/src/lib/elementary/efl_ui_popup_alert.c
+++ b/src/lib/elementary/efl_ui_popup_alert.c
@@ -12,6 +12,13 @@
#define MY_CLASS EFL_UI_POPUP_ALERT_CLASS
#define MY_CLASS_NAME "Efl.Ui.Popup.Alert"
+static const Elm_Layout_Part_Alias_Description _text_aliases[] =
+{
+ {"title", "title"},
+ {"elm.text.title", "elm.text.title"},
+ {NULL, NULL}
+};
+
static const char PART_NAME_BUTTON[] = "button";
static const char PART_NAME_BUTTON_LAYOUT[EFL_UI_POPUP_ALERT_BUTTON_COUNT][15]
=
{"button_layout1",
@@ -35,7 +42,7 @@ _efl_ui_popup_alert_elm_layout_sizing_eval(Eo *obj,
Efl_Ui_Popup_Alert_Data *pd
static Eina_Bool
_efl_ui_popup_alert_text_set(Eo *obj, Efl_Ui_Popup_Alert_Data *pd, const char
*part, const char *label)
{
- if (part && !strcmp(part, "title"))
+ if (eina_streq(part, "title") || eina_streq(part, "elm.text.title"))
{
if (pd->title_text)
{
@@ -44,7 +51,7 @@ _efl_ui_popup_alert_text_set(Eo *obj, Efl_Ui_Popup_Alert_Data
*pd, const char *p
}
pd->title_text = eina_stringshare_add(label);
-elm_object_part_text_set(obj, "elm.text.title", label);
+efl_text_set(efl_part(efl_super(obj, MY_CLASS), "elm.text.title"),
label);
elm_layout_signal_emit(obj, "elm,title,show", "elm");
ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd, EINA_FALSE);
@@ -60,7 +67,7 @@ _efl_ui_popup_alert_text_set(Eo *obj, Efl_Ui_Popup_Alert_Data
*pd, const char *p
const char *
_efl_ui_popup_alert_text_get(Eo *obj EINA_UNUSED, Efl_Ui_Popup_Alert_Data *pd,
const char *part)
{
- if (part && !strcmp(part, "title"))
+ if (eina_streq(part, "title") || eina_streq(part, "elm.text.title"))
{
if (pd->title_text)
return pd->title_text;
@@ -71,24 +78,6 @@ _efl_ui_popup_alert_text_get(Eo *obj EINA_UNUSED,
Efl_Ui_Popup_Alert_Data *pd, c
return efl_text_get(efl_part(efl_super(obj, MY_CLASS), part));
}
-static Eina_Bool
-_efl_ui_popup_alert_content_set(Eo *obj, Efl_Ui_Popup_Alert_Data *pd
EINA_UNUSED, const char *part, Eo *content)
-{
- return efl_content_set(efl_part(efl_super(obj, MY_CLASS), part), content);
-}
-
-Eo *
-_efl_ui_popup_alert_content_get(Eo *obj, Efl_Ui_Popup_Alert_Data *pd
EINA_UNUSED, const char *part)
-{
- return efl_content_get(efl_part(efl_super(obj, MY_CLASS), part));
-}
-
-static Eo *
-_efl_ui_p
[EGIT] [core/efl] feature/eo_theme 01/01: efl_ui_spin_button: Replace legacy widgets to efl ui widgets.
jaehyun pushed a commit to branch feature/eo_theme.
http://git.enlightenment.org/core/efl.git/commit/?id=d89c0330c21101b2333dadf6fd5b0ee785877fea
commit d89c0330c21101b2333dadf6fd5b0ee785877fea
Author: Woochan Lee
Date: Thu Nov 30 16:52:42 2017 +0900
efl_ui_spin_button: Replace legacy widgets to efl ui widgets.
Summary:
elm_button -> efl_ui_button class.
elm_entry will be changed after filter feature added.
Reviewers: Jaehyun_Cho, jpeg, woohyun
Reviewed By: Jaehyun_Cho
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D
---
src/lib/elementary/efl_ui_spin_button.c | 47 ++---
1 file changed, 20 insertions(+), 27 deletions(-)
diff --git a/src/lib/elementary/efl_ui_spin_button.c
b/src/lib/elementary/efl_ui_spin_button.c
index 21b0e28072..9a79ef66b8 100644
--- a/src/lib/elementary/efl_ui_spin_button.c
+++ b/src/lib/elementary/efl_ui_spin_button.c
@@ -352,6 +352,9 @@ _toggle_entry(Evas_Object *obj)
{
if (!sd->ent)
{
+ //FIXME: elm_entry will be changed to efl_ui_text after
+ // filter feature implemented.
+ // (Current efl_ui_text has missed filter feature.)
sd->ent = elm_entry_add(obj);
Eina_Strbuf *buf = eina_strbuf_new();
eina_strbuf_append_printf(buf, "spinner/%s",
elm_widget_style_get(obj));
@@ -769,33 +772,23 @@ _efl_ui_spin_button_efl_object_finalize(Eo *obj,
Efl_Ui_Spin_Button_Data *sd)
elm_widget_style_get(obj)))
CRI("Failed to set layout!");
- sd->inc_button = elm_button_add(obj);
- elm_object_style_set(sd->inc_button, "spinner/increase/default");
-
- efl_event_callback_array_add(sd->inc_button, _inc_dec_button_cb(), obj);
-
- elm_layout_content_set(obj, "elm.swallow.inc_button", sd->inc_button);
- elm_widget_sub_object_add(obj, sd->inc_button);
-
- sd->text_button = elm_button_add(obj);
- elm_object_style_set(sd->text_button, "spinner/default");
-
- efl_event_callback_add(sd->text_button, EFL_UI_EVENT_CLICKED,
- _text_button_clicked_cb, obj);
- efl_event_callback_add(sd->text_button,
- EFL_UI_FOCUS_OBJECT_EVENT_FOCUS_CHANGED,
- _text_button_focus_changed_cb, obj);
-
- elm_layout_content_set(obj, "elm.swallow.text_button", sd->text_button);
- elm_widget_sub_object_add(obj, sd->text_button);
-
- sd->dec_button = elm_button_add(obj);
- elm_object_style_set(sd->dec_button, "spinner/decrease/default");
-
- efl_event_callback_array_add(sd->dec_button, _inc_dec_button_cb(), obj);
-
- elm_layout_content_set(obj, "elm.swallow.dec_button", sd->dec_button);
- elm_widget_sub_object_add(obj, sd->dec_button);
+ sd->inc_button = efl_add(EFL_UI_BUTTON_CLASS, obj,
+efl_ui_widget_style_set(efl_added,
"spinner/increase/default"),
+efl_event_callback_array_add(efl_added,
_inc_dec_button_cb(), obj),
+efl_content_set(efl_part(obj,
"elm.swallow.inc_button"), efl_added));
+
+ sd->text_button = efl_add(EFL_UI_BUTTON_CLASS, obj,
+ efl_ui_widget_style_set(efl_added,
"spinner/default"),
+ efl_event_callback_add(efl_added,
EFL_UI_EVENT_CLICKED,
+_text_button_clicked_cb,
obj),
+ efl_event_callback_add(efl_added,
EFL_UI_FOCUS_OBJECT_EVENT_FOCUS_CHANGED,
+
_text_button_focus_changed_cb, obj),
+ efl_content_set(efl_part(obj,
"elm.swallow.text_button"), efl_added));
+
+ sd->dec_button = efl_add(EFL_UI_BUTTON_CLASS, obj,
+efl_ui_widget_style_set(efl_added,
"spinner/decrease/default"),
+efl_event_callback_array_add(efl_added,
_inc_dec_button_cb(), obj),
+efl_content_set(efl_part(obj,
"elm.swallow.dec_button"), efl_added));
{
Eina_List *items = NULL;
--
