[EGIT] [core/efl] efl-1.20 15/47: example: improve location example, fix crash

2017-11-07 Thread Prince Kumar Dubey 
raster pushed a commit to branch efl-1.20.

http://git.enlightenment.org/core/efl.git/commit/?id=ea4de5c2e34dbbf7d01ecf7e7601e07e59df5c82

commit ea4de5c2e34dbbf7d01ecf7e7601e07e59df5c82
Author: Prince Kumar Dubey 
Date:   Tue Oct 24 15:29:22 2017 +0900

example: improve location example, fix crash

Summary: Printing Address detail with Position. Label added to show the
detail of address.

Test Plan:
Compiled with cmd:
  gcc -o location_example_01 \
  location_example_01.c -g `pkg-config --cflags --libs elementary \
  elocation`

Reviewers: raster, cedric

Subscribers: rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5356
---
 src/examples/elementary/location_example_01.c | 78 +++
 1 file changed, 68 insertions(+), 10 deletions(-)

diff --git a/src/examples/elementary/location_example_01.c 
b/src/examples/elementary/location_example_01.c
index a46bf75fc5..96ca818069 100644
--- a/src/examples/elementary/location_example_01.c
+++ b/src/examples/elementary/location_example_01.c
@@ -1,12 +1,13 @@
 //Compile with:
 //gcc -o location_example_01 location_example_01.c -g `pkg-config --cflags 
--libs elementary elocation`
 
+#define EFL_BETA_API_SUPPORT
 #include 
 #ifdef ELM_ELOCATION
 #include 
 #endif
 
-static Evas_Object *label, *win;
+static Evas_Object *pos_label, *addr_label, *box, *win;
 
 #ifdef ELM_ELOCATION
 static void
@@ -16,6 +17,7 @@ _print_position(Elocation_Position *position)
 
if (!position) return;
snprintf(buffer, sizeof(buffer),
+"### Position Detail ###"
 "GeoClue position reply with data from timestamp %i"
 "Latitude: %f"
 "Longitude: %f"
@@ -26,7 +28,32 @@ _print_position(Elocation_Position *position)
 position->timestamp, position->latitude, position->longitude,
 position->altitude, position->accur->level,
 position->accur->horizontal, position->accur->vertical);
-   elm_object_text_set(label, buffer);
+   elm_object_text_set(pos_label, buffer);
+}
+
+static void
+_print_address(Elocation_Address *address)
+{
+   char buffer[1024];
+
+   if (!address) return;
+   snprintf(buffer, sizeof(buffer),
+"### Address Detail ###"
+"Address update with data from timestamp: %i"
+"Country: %s"
+"Countrycode: %s"
+"Locality: %s"
+"Postalcode: %s"
+"Region: %s"
+"Timezone: %s"
+"Accuracy level: %i"
+"Accuracy horizontal: %f"
+"Accuracy vertical: %f",
+address->timestamp, address->country, address->countrycode,
+address->locality, address->postalcode, address->region,
+address->timezone, address->accur->level, 
address->accur->horizontal,
+address->accur->vertical);
+   elm_object_text_set(addr_label, buffer);
 }
 
 static Eina_Bool
@@ -38,6 +65,17 @@ _position_changed(void *data, int ev_type, void *event)
_print_position(position);
return ECORE_CALLBACK_DONE;
 }
+
+static Eina_Bool
+_address_changed(void *data EINA_UNUSED, int ev_type EINA_UNUSED, void *event)
+{
+   Elocation_Address *address;
+
+   address = event;
+   _print_address(address);
+
+   return ECORE_CALLBACK_DONE;
+}
 #endif
 
 EAPI_MAIN int
@@ -57,25 +95,45 @@ elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
win = elm_win_util_standard_add("elocation", "Elocation example");
elm_win_autodel_set(win, EINA_TRUE);
 
-   label = elm_label_add(win);
-   elm_label_line_wrap_set(label, ELM_WRAP_CHAR);
-   elm_object_text_set(label, "Getting location ...");
-   evas_object_size_hint_weight_set(label, EVAS_HINT_EXPAND, 0.0);
-   evas_object_size_hint_align_set(label, EVAS_HINT_FILL, EVAS_HINT_FILL);
-   elm_label_slide_mode_set(label, ELM_LABEL_SLIDE_MODE_ALWAYS);
-   evas_object_resize(label, 600, 480);
-   evas_object_show(label);
+   box = elm_box_add(win);
+   elm_win_resize_object_add(win, box);
+   evas_object_size_hint_weight_set(box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
+   evas_object_size_hint_align_set(box, EVAS_HINT_FILL, EVAS_HINT_FILL);
+
+   pos_label = elm_label_add(box);
+   elm_label_line_wrap_set(pos_label, ELM_WRAP_CHAR);
+   elm_object_text_set(pos_label, "Getting location ...");
+   evas_object_size_hint_weight_set(pos_label, EVAS_HINT_EXPAND, 0.0);
+   evas_object_size_hint_align_set(pos_label, EVAS_HINT_FILL, EVAS_HINT_FILL);
+   elm_label_slide_mode_set(pos_label, ELM_LABEL_SLIDE_MODE_ALWAYS);
+   elm_box_pack_end(box, pos_label);
+   evas_object_show(pos_label);
+   elm_box_padding_set(box, 0, 50);
+
+   addr_label = elm_label_add(box);
+   elm_l

[EGIT] [core/efl] efl-1.20 08/47: eina: fix warning if EINA_SAFETY_CHECKS is disabled

2017-11-07 Thread Prince Kumar Dubey 
raster pushed a commit to branch efl-1.20.

http://git.enlightenment.org/core/efl.git/commit/?id=6019806af3e3db50fce52d9aaa76c4b9250018c2

commit 6019806af3e3db50fce52d9aaa76c4b9250018c2
Author: Prince Kumar Dubey 
Date:   Mon Oct 16 13:36:09 2017 -0700

eina: fix warning if EINA_SAFETY_CHECKS is disabled

Summary:
Putting local variable "d" under preprocessor flag "EINA_SAFETY_CHECKS" to 
avoid below warning, if "EINA_SAFETY_CHECKS" is disabled.
1. local variable "d" is assigned but not used.
2. If warning 1 is resolved then variable "d" will be unused.

Reviewers: raster, cedric

Reviewed By: cedric

Subscribers: jpeg, rajeshps

Differential Revision: https://phab.enlightenment.org/D5321

Signed-off-by: Cedric BAIL 
---
 src/lib/eina/eina_log.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/lib/eina/eina_log.c b/src/lib/eina/eina_log.c
index 2b2a240d54..c6630fc473 100644
--- a/src/lib/eina/eina_log.c
+++ b/src/lib/eina/eina_log.c
@@ -2350,12 +2350,16 @@ eina_log_timing(int domain,
 Eina_Log_State state,
 const char *phase)
 {
+#ifdef EINA_SAFETY_CHECKS
Eina_Log_Domain *d;
+#endif
Eina_Log_Timing *t;
 
if (_disable_timing) return;
 
+#ifdef EINA_SAFETY_CHECKS
d = _log_domains + domain;
+#endif
t = _log_timing + domain;
 #ifdef EINA_SAFETY_CHECKS
if (EINA_UNLIKELY(d->deleted))

--

[EGIT] [core/efl] efl-1.20 09/47: elementary: fix double assignment

2017-11-07 Thread Prince Kumar Dubey 
raster pushed a commit to branch efl-1.20.

http://git.enlightenment.org/core/efl.git/commit/?id=8f02704a1e93a5c031f4cb29135f6f9dedeb675c

commit 8f02704a1e93a5c031f4cb29135f6f9dedeb675c
Author: Prince Kumar Dubey 
Date:   Tue Oct 17 11:03:10 2017 -0700

elementary: fix double assignment

Summary: local variable "bp" assigned twice unnecessarily. The duplicate 
assignment is removed.

Reviewers: raster, cedric, jpeg

Subscribers: jpeg, rajeshps

Differential Revision: https://phab.enlightenment.org/D5323

Signed-off-by: Cedric Bail 
---
 src/lib/elementary/elm_config.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/lib/elementary/elm_config.c b/src/lib/elementary/elm_config.c
index 83715c563d..62e5f80f01 100644
--- a/src/lib/elementary/elm_config.c
+++ b/src/lib/elementary/elm_config.c
@@ -798,7 +798,6 @@ _elm_config_derived_option_apply(Elm_Config *cfg, const 
char *option)
char *bp = buf;
 
p = option;
-   bp = buf;
for (;;)
  {
 if ((*p == 0) || (*p == ' '))

--

[EGIT] [core/efl] master 01/01: example: improve location example, fix crash

2017-10-23 Thread Prince Kumar Dubey 
jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=9d2dcd92f795a89513883cf42bbe85be7cf562cf

commit 9d2dcd92f795a89513883cf42bbe85be7cf562cf
Author: Prince Kumar Dubey 
Date:   Tue Oct 24 15:29:22 2017 +0900

example: improve location example, fix crash

Summary: Printing Address detail with Position. Label added to show the
detail of address.

Test Plan:
Compiled with cmd:
  gcc -o location_example_01 \
  location_example_01.c -g `pkg-config --cflags --libs elementary \
  elocation`

Reviewers: raster, cedric

Subscribers: rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5356
---
 src/examples/elementary/location_example_01.c | 78 +++
 1 file changed, 68 insertions(+), 10 deletions(-)

diff --git a/src/examples/elementary/location_example_01.c 
b/src/examples/elementary/location_example_01.c
index a46bf75fc5..96ca818069 100644
--- a/src/examples/elementary/location_example_01.c
+++ b/src/examples/elementary/location_example_01.c
@@ -1,12 +1,13 @@
 //Compile with:
 //gcc -o location_example_01 location_example_01.c -g `pkg-config --cflags 
--libs elementary elocation`
 
+#define EFL_BETA_API_SUPPORT
 #include 
 #ifdef ELM_ELOCATION
 #include 
 #endif
 
-static Evas_Object *label, *win;
+static Evas_Object *pos_label, *addr_label, *box, *win;
 
 #ifdef ELM_ELOCATION
 static void
@@ -16,6 +17,7 @@ _print_position(Elocation_Position *position)
 
if (!position) return;
snprintf(buffer, sizeof(buffer),
+"### Position Detail ###"
 "GeoClue position reply with data from timestamp %i"
 "Latitude: %f"
 "Longitude: %f"
@@ -26,7 +28,32 @@ _print_position(Elocation_Position *position)
 position->timestamp, position->latitude, position->longitude,
 position->altitude, position->accur->level,
 position->accur->horizontal, position->accur->vertical);
-   elm_object_text_set(label, buffer);
+   elm_object_text_set(pos_label, buffer);
+}
+
+static void
+_print_address(Elocation_Address *address)
+{
+   char buffer[1024];
+
+   if (!address) return;
+   snprintf(buffer, sizeof(buffer),
+"### Address Detail ###"
+"Address update with data from timestamp: %i"
+"Country: %s"
+"Countrycode: %s"
+"Locality: %s"
+"Postalcode: %s"
+"Region: %s"
+"Timezone: %s"
+"Accuracy level: %i"
+"Accuracy horizontal: %f"
+"Accuracy vertical: %f",
+address->timestamp, address->country, address->countrycode,
+address->locality, address->postalcode, address->region,
+address->timezone, address->accur->level, 
address->accur->horizontal,
+address->accur->vertical);
+   elm_object_text_set(addr_label, buffer);
 }
 
 static Eina_Bool
@@ -38,6 +65,17 @@ _position_changed(void *data, int ev_type, void *event)
_print_position(position);
return ECORE_CALLBACK_DONE;
 }
+
+static Eina_Bool
+_address_changed(void *data EINA_UNUSED, int ev_type EINA_UNUSED, void *event)
+{
+   Elocation_Address *address;
+
+   address = event;
+   _print_address(address);
+
+   return ECORE_CALLBACK_DONE;
+}
 #endif
 
 EAPI_MAIN int
@@ -57,25 +95,45 @@ elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
win = elm_win_util_standard_add("elocation", "Elocation example");
elm_win_autodel_set(win, EINA_TRUE);
 
-   label = elm_label_add(win);
-   elm_label_line_wrap_set(label, ELM_WRAP_CHAR);
-   elm_object_text_set(label, "Getting location ...");
-   evas_object_size_hint_weight_set(label, EVAS_HINT_EXPAND, 0.0);
-   evas_object_size_hint_align_set(label, EVAS_HINT_FILL, EVAS_HINT_FILL);
-   elm_label_slide_mode_set(label, ELM_LABEL_SLIDE_MODE_ALWAYS);
-   evas_object_resize(label, 600, 480);
-   evas_object_show(label);
+   box = elm_box_add(win);
+   elm_win_resize_object_add(win, box);
+   evas_object_size_hint_weight_set(box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
+   evas_object_size_hint_align_set(box, EVAS_HINT_FILL, EVAS_HINT_FILL);
+
+   pos_label = elm_label_add(box);
+   elm_label_line_wrap_set(pos_label, ELM_WRAP_CHAR);
+   elm_object_text_set(pos_label, "Getting location ...");
+   evas_object_size_hint_weight_set(pos_label, EVAS_HINT_EXPAND, 0.0);
+   evas_object_size_hint_align_set(pos_label, EVAS_HINT_FILL, EVAS_HINT_FILL);
+   elm_label_slide_mode_set(pos_label, ELM_LABEL_SLIDE_MODE_ALWAYS);
+   elm_box_pack_end(box, pos_label);
+   evas_object_show(pos_label);
+   elm_box_padding_set(box, 0, 50);
+
+   addr_label = elm_label_add(box);
+   elm_l

[EGIT] [core/efl] master 04/04: elementary: fix double assignment

2017-10-17 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=28ce98c411d6c8c082b2ba2d1ea5909d44e8ce2a

commit 28ce98c411d6c8c082b2ba2d1ea5909d44e8ce2a
Author: Prince Kumar Dubey 
Date:   Tue Oct 17 11:03:10 2017 -0700

elementary: fix double assignment

Summary: local variable "bp" assigned twice unnecessarily. The duplicate 
assignment is removed.

Reviewers: raster, cedric, jpeg

Subscribers: jpeg, rajeshps

Differential Revision: https://phab.enlightenment.org/D5323

Signed-off-by: Cedric Bail 
---
 src/lib/elementary/elm_config.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/lib/elementary/elm_config.c b/src/lib/elementary/elm_config.c
index da198ea8f3..cfbfc0f871 100644
--- a/src/lib/elementary/elm_config.c
+++ b/src/lib/elementary/elm_config.c
@@ -797,7 +797,6 @@ _elm_config_derived_option_apply(Elm_Config *cfg, const 
char *option)
char *bp = buf;
 
p = option;
-   bp = buf;
for (;;)
  {
 if ((*p == 0) || (*p == ' '))

--

[EGIT] [core/efl] master 03/04: example: print format correction to avoid warning.

2017-10-17 Thread Prince Kumar Dubey 
jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=2866358a5dc4fcf30b10bea0fe4ed32c7ccdddb7

commit 2866358a5dc4fcf30b10bea0fe4ed32c7ccdddb7
Author: Prince Kumar Dubey 
Date:   Tue Oct 17 13:45:17 2017 +0900

example: print format correction to avoid warning.

Reviewers: raster, cedric, jpeg

Subscribers: rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5312
---
 src/examples/elementary/gengrid_example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/examples/elementary/gengrid_example.c 
b/src/examples/elementary/gengrid_example.c
index 9c786b8d91..b342f6c60e 100644
--- a/src/examples/elementary/gengrid_example.c
+++ b/src/examples/elementary/gengrid_example.c
@@ -131,7 +131,7 @@ _grid_sel(void*data,
 
elm_gengrid_item_pos_get(event_info, &x, &y);
 
-   printf("Item [%p], with data [%p], path %s, at position (%d, %d),"
+   printf("Item [%p], with data [%p], path %s, at position (%u, %u),"
" has been selected\n", event_info, data, it->path, x, y);
 }
 

--

[EGIT] [core/efl] master 05/06: efreet: putting local variable "data" under preprocessor flag "SLOPPY_SPEC" to avoid below warning, if "SLOPPY_SPEC" is disabled.

2017-10-16 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=e8b2a954b54973ecdce92c30ff9fddd0e7a77739

commit e8b2a954b54973ecdce92c30ff9fddd0e7a77739
Author: Prince Kumar Dubey 
Date:   Mon Oct 16 13:36:35 2017 -0700

efreet: putting local variable "data" under preprocessor flag "SLOPPY_SPEC" 
to avoid below warning, if "SLOPPY_SPEC" is disabled.

Reviewers: raster, cedric

Subscribers: jpeg, rajeshps

Differential Revision: https://phab.enlightenment.org/D5322

Signed-off-by: Cedric BAIL 
---
 src/lib/efreet/efreet_icon.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lib/efreet/efreet_icon.c b/src/lib/efreet/efreet_icon.c
index 47c62eb2da..5f17397fed 100644
--- a/src/lib/efreet/efreet_icon.c
+++ b/src/lib/efreet/efreet_icon.c
@@ -267,7 +267,9 @@ efreet_icon_list_find(const char *theme_name, Eina_List 
*icons,
 Eina_List *tmps = NULL;
 const char *icon = NULL;
 const char *value = NULL;
+#ifdef SLOPPY_SPEC
 char *data;
+#endif
 Efreet_Icon_Theme *theme;
 
 EINA_SAFETY_ON_NULL_RETURN_VAL(icons, NULL);

--

[EGIT] [core/efl] master 04/06: eina: fix warning if EINA_SAFETY_CHECKS is disabled

2017-10-16 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=030a3448fb0b4c075cafe359a15c4dec6933e3c8

commit 030a3448fb0b4c075cafe359a15c4dec6933e3c8
Author: Prince Kumar Dubey 
Date:   Mon Oct 16 13:36:09 2017 -0700

eina: fix warning if EINA_SAFETY_CHECKS is disabled

Summary:
Putting local variable "d" under preprocessor flag "EINA_SAFETY_CHECKS" to 
avoid below warning, if "EINA_SAFETY_CHECKS" is disabled.
1. local variable "d" is assigned but not used.
2. If warning 1 is resolved then variable "d" will be unused.

Reviewers: raster, cedric

Reviewed By: cedric

Subscribers: jpeg, rajeshps

Differential Revision: https://phab.enlightenment.org/D5321

Signed-off-by: Cedric BAIL 
---
 src/lib/eina/eina_log.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/lib/eina/eina_log.c b/src/lib/eina/eina_log.c
index 68cb948232..549640802e 100644
--- a/src/lib/eina/eina_log.c
+++ b/src/lib/eina/eina_log.c
@@ -2350,12 +2350,16 @@ eina_log_timing(int domain,
 Eina_Log_State state,
 const char *phase)
 {
+#ifdef EINA_SAFETY_CHECKS
Eina_Log_Domain *d;
+#endif
Eina_Log_Timing *t;
 
if (_disable_timing) return;
 
+#ifdef EINA_SAFETY_CHECKS
d = _log_domains + domain;
+#endif
t = _log_timing + domain;
 #ifdef EINA_SAFETY_CHECKS
if (EINA_UNLIKELY(d->deleted))

--

[EGIT] [core/efl] master 03/06: ecore: removing assignment operation to avoid warning.

2017-10-16 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=284276b2ece07c605e49f5432bf2dac7ad80bcaa

commit 284276b2ece07c605e49f5432bf2dac7ad80bcaa
Author: Prince Kumar Dubey 
Date:   Mon Oct 16 13:29:01 2017 -0700

ecore: removing assignment operation to avoid warning.

Summary: assignment to local variable "ret" has no meaning as it is not 
used after assignment. So, removing assignment operation to avoid warning.

Reviewers: raster, cedric

Subscribers: jpeg, rajeshps

Differential Revision: https://phab.enlightenment.org/D5303

Signed-off-by: Cedric BAIL 
---
 src/lib/ecore_x/ecore_x_keygrab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/ecore_x/ecore_x_keygrab.c 
b/src/lib/ecore_x/ecore_x_keygrab.c
index 64f342b887..dbd69f20ca 100644
--- a/src/lib/ecore_x/ecore_x_keygrab.c
+++ b/src/lib/ecore_x/ecore_x_keygrab.c
@@ -229,7 +229,7 @@ 
_ecore_x_window_keytable_possible_global_exclusiveness_unset(int keycode)
 return EINA_FALSE;
  }
else
- ret = _ecore_x_window_keytable_key_del(&keytable, keycode, 
_atom_grab_excl_win);
+ _ecore_x_window_keytable_key_del(&keytable, keycode, _atom_grab_excl_win);
 
_keytable_free(&keytable);
return EINA_FALSE;

--

[EGIT] [core/efl] master 15/23: efl: unused variable removed, removing local variable assignment which has no use at all.

2017-10-13 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=1235459ed3cd78f6efb811295afc49668d2438a6

commit 1235459ed3cd78f6efb811295afc49668d2438a6
Author: Prince Kumar Dubey 
Date:   Fri Oct 13 12:11:41 2017 -0700

efl: unused variable removed, removing local variable assignment which has 
no use at all.

Reviewers: raster, cedric

Reviewed By: cedric

Subscribers: rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5304

Signed-off-by: Cedric Bail 
---
 src/lib/evil/evil_stdlib.c| 1 -
 src/tests/eina/eina_test_lock.c   | 4 ++--
 src/tests/eina/eina_test_log.c| 1 -
 src/tests/eina/eina_test_strbuf.c | 2 --
 src/tests/eina/eina_test_ustr.c   | 2 +-
 5 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/lib/evil/evil_stdlib.c b/src/lib/evil/evil_stdlib.c
index 56d0ede881..dbb9779ee4 100644
--- a/src/lib/evil/evil_stdlib.c
+++ b/src/lib/evil/evil_stdlib.c
@@ -119,7 +119,6 @@ _mkstemp(char *suffix, int val)
suffix[4] = lookup[v % 62];
v /= 62;
suffix[5] = lookup[v % 62];
-   v /= 62;
 
val += ;
 
diff --git a/src/tests/eina/eina_test_lock.c b/src/tests/eina/eina_test_lock.c
index c0b45bd885..6636706288 100644
--- a/src/tests/eina/eina_test_lock.c
+++ b/src/tests/eina/eina_test_lock.c
@@ -137,12 +137,12 @@ _eina_test_tls_thread(void *data EINA_UNUSED, Eina_Thread 
t EINA_UNUSED)
int *ptr;
 
ptr = eina_tls_get(key);
-   fail_if(eina_tls_get(key) != NULL);
+   fail_if(ptr != NULL);
 
fail_if(!eina_tls_set(key, _eina_test_tls_alloc(24)));
 
ptr = eina_tls_get(key);
-   fail_if(eina_tls_get(key) == NULL);
+   fail_if(ptr == NULL);
fail_if(*ptr != 24);
 
return NULL;
diff --git a/src/tests/eina/eina_test_log.c b/src/tests/eina/eina_test_log.c
index cc20bfc98b..44bea28816 100644
--- a/src/tests/eina/eina_test_log.c
+++ b/src/tests/eina/eina_test_log.c
@@ -376,7 +376,6 @@ END_TEST
 
 START_TEST(eina_log_customize)
 {
-   struct log_ctx ctx;
int d;
 
/* please don't define EINA_LOG_LEVELS for it */
diff --git a/src/tests/eina/eina_test_strbuf.c 
b/src/tests/eina/eina_test_strbuf.c
index b4e1cd1d02..85176ccf67 100644
--- a/src/tests/eina/eina_test_strbuf.c
+++ b/src/tests/eina/eina_test_strbuf.c
@@ -390,8 +390,6 @@ START_TEST(strbuf_realloc)
 
eina_strbuf_remove(buf, 0, 0 + 32);
fail_if(eina_strbuf_length_get(buf) != sz - 32);
-   sz -= 32;
-
 
eina_strbuf_free(buf);
 
diff --git a/src/tests/eina/eina_test_ustr.c b/src/tests/eina/eina_test_ustr.c
index eba07e37e2..5bf7bbee8f 100644
--- a/src/tests/eina/eina_test_ustr.c
+++ b/src/tests/eina/eina_test_ustr.c
@@ -161,7 +161,7 @@ START_TEST(eina_unicode_strncpy_test)
fail_if(buf[9] != 0);
 
buf[0] = '7';
-   rv = eina_unicode_strncpy(buf, STR1, 0);
+   eina_unicode_strncpy(buf, STR1, 0);
fail_if(buf[0] != '7');
 
 #ifdef EINA_SAFETY_CHECKS

--

[EGIT] [core/efl] master 10/23: edje: no case is defined for Preprocessor Flag "EDJE_EXTRA_MODULE_NAME". So removing it to avoid printf warning.

2017-10-13 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=72a807a51c4ad36b82c4001d5eb1ba0aff312d10

commit 72a807a51c4ad36b82c4001d5eb1ba0aff312d10
Author: Prince Kumar Dubey 
Date:   Fri Oct 13 12:04:35 2017 -0700

edje: no case is defined for Preprocessor Flag "EDJE_EXTRA_MODULE_NAME". So 
removing it to avoid printf warning.

Reviewers: raster, cedric

Subscribers: rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5298

Signed-off-by: Cedric Bail 
---
 src/lib/edje/edje_module.c | 6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/lib/edje/edje_module.c b/src/lib/edje/edje_module.c
index 80ae9c78e4..318393d704 100644
--- a/src/lib/edje/edje_module.c
+++ b/src/lib/edje/edje_module.c
@@ -165,11 +165,7 @@ edje_available_modules_get(void)
 
 EINA_ITERATOR_FOREACH(it, info)
   {
- eina_strbuf_append_printf(buf, "%s/%s/" EDJE_MODULE_NAME, 
info->path, MODULE_ARCH
-#ifdef EDJE_EXTRA_MODULE_NAME
-   , info->path + info->name_start
-#endif
-   );
+ eina_strbuf_append_printf(buf, "%s/%s/" EDJE_MODULE_NAME, 
info->path, MODULE_ARCH);
 
  if (ecore_file_exists(eina_strbuf_string_get(buf)))
result = eina_list_append(result, 
eina_stringshare_add(info->path + info->name_start));

--

[EGIT] [core/efl] master 09/23: eina: uninitialization of array leads to unwanted outcome of "eina_strlcat"

2017-10-13 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=393560748380b635bb161a71358d15f1cee0ccac

commit 393560748380b635bb161a71358d15f1cee0ccac
Author: Prince Kumar Dubey 
Date:   Fri Oct 13 12:03:52 2017 -0700

eina: uninitialization of array leads to unwanted outcome of "eina_strlcat"

Reviewers: raster, cedric, rajeshps

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5297

Signed-off-by: Cedric Bail 
---
 src/examples/eina/eina_simple_xml_parser_01.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/examples/eina/eina_simple_xml_parser_01.c 
b/src/examples/eina/eina_simple_xml_parser_01.c
index de27e0bb18..a4f6ca4456 100644
--- a/src/examples/eina/eina_simple_xml_parser_01.c
+++ b/src/examples/eina/eina_simple_xml_parser_01.c
@@ -63,7 +63,7 @@ _xml_tag_cb(void *data, Eina_Simple_XML_Type type, const char 
*content,
 {
char buffer[length+1];
Eina_Array *array = data;
-   char str[512];
+   char str[512] = {'\0'};
 
if (type == EINA_SIMPLE_XML_OPEN)
  {

--

[EGIT] [core/efl] master 13/23: evas: parameter length is not used, so removing it. to fix static analyzer tool warning.

2017-10-13 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=71e62840e45319f3580504106c7a79f89545c07c

commit 71e62840e45319f3580504106c7a79f89545c07c
Author: Prince Kumar Dubey 
Date:   Fri Oct 13 12:08:24 2017 -0700

evas: parameter length is not used, so removing it. to fix static analyzer 
tool warning.

Reviewers: raster, cedric

Subscribers: jpeg, rajeshps

Differential Revision: https://phab.enlightenment.org/D5301

Signed-off-by: Cedric Bail 
---
 src/bin/evas/evas_cserve2_slave.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/bin/evas/evas_cserve2_slave.c 
b/src/bin/evas/evas_cserve2_slave.c
index 137e6ae3dc..015429706d 100644
--- a/src/bin/evas/evas_cserve2_slave.c
+++ b/src/bin/evas/evas_cserve2_slave.c
@@ -23,7 +23,6 @@ static Eina_Prefix *pfx = NULL;
 
 struct ext_loader_s
 {
-   unsigned int length;
const char *extension;
const char *loader;
 };

--

[EGIT] [core/efl] master 12/23: efl: unsigned int/long never be less than zero. Fixed.

2017-10-13 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=41197981abcfe6a01b4208e30f700c714dc1d648

commit 41197981abcfe6a01b4208e30f700c714dc1d648
Author: Prince Kumar Dubey 
Date:   Fri Oct 13 12:07:25 2017 -0700

efl: unsigned int/long never be less than zero. Fixed.

Reviewers: raster, cedric

Subscribers: rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5300

Signed-off-by: Cedric Bail 
---
 src/bin/evas/evas_cserve2_index.c| 2 +-
 src/examples/eina/eina_simple_xml_parser_02.c| 2 +-
 src/lib/ecore_con/ecore_con_local_win32.c| 4 ++--
 src/lib/ecore_win32/ecore_win32_window.c | 2 +-
 src/lib/ecore_x/ecore_x_e.c  | 4 ++--
 src/lib/ecore_x/ecore_x_keygrab.c| 2 +-
 src/modules/evas/image_loaders/ico/evas_image_load_ico.c | 4 ++--
 7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/bin/evas/evas_cserve2_index.c 
b/src/bin/evas/evas_cserve2_index.c
index 42bcffad37..76d4e62ecb 100644
--- a/src/bin/evas/evas_cserve2_index.c
+++ b/src/bin/evas/evas_cserve2_index.c
@@ -200,7 +200,7 @@ _shared_data_shm_resize(Data_Shm *ds, size_t newsize)
Shm_Handle *shm;
size_t mapping_size;
 
-   if (newsize <= 0)
+   if (newsize == 0)
  return -1;
 
mapping_size = cserve2_shm_size_normalize(newsize, ARRAY_MINSIZE);
diff --git a/src/examples/eina/eina_simple_xml_parser_02.c 
b/src/examples/eina/eina_simple_xml_parser_02.c
index 0d8269a8fd..5c0cf08858 100644
--- a/src/examples/eina/eina_simple_xml_parser_02.c
+++ b/src/examples/eina/eina_simple_xml_parser_02.c
@@ -17,7 +17,7 @@ static Eina_Bool
 _xml_tag_parse_cb(void *data, Eina_Simple_XML_Type type, const char *content,
   unsigned offset EINA_UNUSED, unsigned int length)
 {
-   if (length <= 0) return EINA_FALSE;
+   if (length == 0) return EINA_FALSE;
 
if (type == EINA_SIMPLE_XML_OPEN)
  {
diff --git a/src/lib/ecore_con/ecore_con_local_win32.c 
b/src/lib/ecore_con/ecore_con_local_win32.c
index 4bd0ba4069..9a5b731f6d 100644
--- a/src/lib/ecore_con/ecore_con_local_win32.c
+++ b/src/lib/ecore_con/ecore_con_local_win32.c
@@ -681,7 +681,7 @@ ecore_con_local_win32_server_flush(Ecore_Con_Server *obj)
  return EINA_FALSE;
 
num = eina_binbuf_length_get(svr->buf) - svr->write_buf_offset;
-   if (num <= 0) return EINA_TRUE;
+   if (num == 0) return EINA_TRUE;
 
res = WriteFile(svr->pipe, eina_binbuf_string_get(svr->buf) + 
svr->write_buf_offset, num, &written, NULL);
if (!res)
@@ -732,7 +732,7 @@ ecore_con_local_win32_client_flush(Ecore_Con_Client *obj)
  return EINA_FALSE;
 
num = eina_binbuf_length_get(cl->buf) - cl->buf_offset;
-   if (num <= 0) return EINA_TRUE;
+   if (num == 0) return EINA_TRUE;
 
res = WriteFile(svr->pipe, eina_binbuf_string_get(cl->buf) + 
cl->buf_offset, num, &written, NULL);
if (!res)
diff --git a/src/lib/ecore_win32/ecore_win32_window.c 
b/src/lib/ecore_win32/ecore_win32_window.c
index f9629f735c..628264d7b3 100644
--- a/src/lib/ecore_win32/ecore_win32_window.c
+++ b/src/lib/ecore_win32/ecore_win32_window.c
@@ -1477,7 +1477,7 @@ ecore_win32_window_state_set(Ecore_Win32_Window   
*window,
 {
unsigned int i;
 
-   if (!window || !state || (num <= 0))
+   if (!window || !state || (num == 0))
  return;
 
INF("setting window state");
diff --git a/src/lib/ecore_x/ecore_x_e.c b/src/lib/ecore_x/ecore_x_e.c
index af1065..8d10ba0700 100644
--- a/src/lib/ecore_x/ecore_x_e.c
+++ b/src/lib/ecore_x/ecore_x_e.c
@@ -1173,7 +1173,7 @@ ecore_x_e_window_profile_list_set(Ecore_X_Window  win,
if (!win)
  return;
 
-   if ((!profiles) || (num_profiles <= 0))
+   if ((!profiles) || (num_profiles == 0))
  ecore_x_window_prop_property_del(win, 
ECORE_X_ATOM_E_WINDOW_PROFILE_AVAILABLE_LIST);
else
  {
@@ -1382,7 +1382,7 @@ ecore_x_e_window_available_profiles_set(Ecore_X_Window  
win,
if (!win)
  return;
 
-   if ((!profiles) || (count <= 0))
+   if ((!profiles) || (count == 0))
  ecore_x_window_prop_property_del(win, 
ECORE_X_ATOM_E_WINDOW_PROFILE_AVAILABLE_LIST);
else
  {
diff --git a/src/lib/ecore_x/ecore_x_keygrab.c 
b/src/lib/ecore_x/ecore_x_keygrab.c
index 4ed762d39b..64f342b887 100644
--- a/src/lib/ecore_x/ecore_x_keygrab.c
+++ b/src/lib/ecore_x/ecore_x_keygrab.c
@@ -542,7 +542,7 @@ _ecore_x_window_keygrab_unset_internal(Ecore_X_Window win,
if (!_ecore_x_window_keytable_get(win, &keytable))
   return EINA_FALSE;
 
-   if (keytable.key_cnt <= 0)
+   if (keytable.key_cnt == 0)
  return EINA_FALSE;
 
i = _ecore_x_window_keytable_key_search(&keytable, keycode);
diff --git a/src/modules/evas/image_loaders/ico/evas_image_load_ico.c 
b/src/modules/evas/image_loaders/ico/evas_image_load_ico.c
index 0754ba4f79..53ce8e83c2 100644

[EGIT] [core/efl] master 16/23: evas: to avoid warning unused variable and unnecessary assignment is removed.

2017-10-13 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=df5f404f090591421278a631e0159be583d2052e

commit df5f404f090591421278a631e0159be583d2052e
Author: Prince Kumar Dubey 
Date:   Fri Oct 13 12:14:20 2017 -0700

evas: to avoid warning unused variable and unnecessary assignment is 
removed.

Reviewers: raster, cedric

Subscribers: rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5305

Signed-off-by: Cedric Bail 
---
 src/modules/evas/engines/software_x11/evas_xlib_color.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/modules/evas/engines/software_x11/evas_xlib_color.c 
b/src/modules/evas/engines/software_x11/evas_xlib_color.c
index 4070c48418..a016bb5505 100644
--- a/src/modules/evas/engines/software_x11/evas_xlib_color.c
+++ b/src/modules/evas/engines/software_x11/evas_xlib_color.c
@@ -41,11 +41,14 @@ x_color_alloc_rgb(int nr, int ng, int nb, Display *d, 
Colormap cmap, Visual *v)
 {
int r, g, b, i;
DATA8 *color_lut;
-   int sig_mask = 0, delt = 0;
+   int delt = 0;
+/*
+   int sig_mask = 0;
 
for (i = 0; i < v->bits_per_rgb; i++)
  sig_mask |= (0x1 << i);
sig_mask <<= (16 - v->bits_per_rgb);
+*/
i = 0;
color_lut = malloc((nr) * (ng) * (nb));
if (!color_lut) return NULL;

--

[EGIT] [core/efl] master 14/23: ecore_audio: unused variables are removed to fix warning.

2017-10-13 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=68a455d10c394c228c1eb71638ff3699e1b19edd

commit 68a455d10c394c228c1eb71638ff3699e1b19edd
Author: Prince Kumar Dubey 
Date:   Fri Oct 13 12:09:08 2017 -0700

ecore_audio: unused variables are removed to fix warning.

Reviewers: raster, cedric

Reviewed By: cedric

Subscribers: rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5302

Signed-off-by: Cedric Bail 
---
 src/lib/ecore_audio/ecore_audio_alsa.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/src/lib/ecore_audio/ecore_audio_alsa.c 
b/src/lib/ecore_audio/ecore_audio_alsa.c
index b0f48c6b5e..2496426d80 100644
--- a/src/lib/ecore_audio/ecore_audio_alsa.c
+++ b/src/lib/ecore_audio/ecore_audio_alsa.c
@@ -103,10 +103,6 @@ recover:
 static void
 _alsa_output_add_input(Ecore_Audio_Object *output, Ecore_Audio_Object *input)
 {
-   Ecore_Audio_Module *outmod = output->module;
-   Ecore_Audio_Module *inmod = input->module;
-   struct _Ecore_Audio_Alsa *alsa = (struct _Ecore_Audio_Alsa 
*)output->module_data;
-
ecore_timer_add(0.3, _alsa_output_async_cb, output);
 }
 

--

[EGIT] [core/efl] master 11/23: ecore_evas: preprocessor flag "BUILD_ECORE_EVAS_SOFTWARE_GDI" is not closed properly, if not defined, leads to build break.

2017-10-13 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=cb4a17ab22885c81dfaa20c7eed73659a7037641

commit cb4a17ab22885c81dfaa20c7eed73659a7037641
Author: Prince Kumar Dubey 
Date:   Fri Oct 13 12:05:38 2017 -0700

ecore_evas: preprocessor flag "BUILD_ECORE_EVAS_SOFTWARE_GDI" is not closed 
properly, if not defined, leads to build break.

Reviewers: raster, cedric

Reviewed By: cedric

Subscribers: rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5299

Signed-off-by: Cedric Bail 
---
 src/modules/ecore_evas/engines/win32/ecore_evas_win32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/modules/ecore_evas/engines/win32/ecore_evas_win32.c 
b/src/modules/ecore_evas/engines/win32/ecore_evas_win32.c
index bdf0a485f7..46c795b60b 100644
--- a/src/modules/ecore_evas/engines/win32/ecore_evas_win32.c
+++ b/src/modules/ecore_evas/engines/win32/ecore_evas_win32.c
@@ -790,8 +790,8 @@ _ecore_evas_win32_shaped_set(Ecore_Evas *ee, int shaped)
  if (ee->shaped)
evas_damage_rectangle_add(ee->evas, 0, 0, ee->w, ee->h);
   }
-#endif /* BUILD_ECORE_EVAS_SOFTWARE_GDI */
  }
+#endif /* BUILD_ECORE_EVAS_SOFTWARE_GDI */
 }
 
 static void

--

[EGIT] [core/elementary] elementary-1.17 01/01: [gengrid] possible crash issue fixed.

2016-02-12 Thread Prince Kumar Dubey 
hermet pushed a commit to branch elementary-1.17.

http://git.enlightenment.org/core/elementary.git/commit/?id=aba1072c39f3fac26db08504a5141bc788710254

commit aba1072c39f3fac26db08504a5141bc788710254
Author: Prince Kumar Dubey 
Date:   Fri Feb 12 19:42:25 2016 +0900

[gengrid] possible crash issue fixed.

Summary: reset show_it, bring_in_it and corresponding flags on item deletion

Test Plan: delete item with animation and rotate the handset display.

Reviewers: raster, cedric

Subscribers: shilpasingh, godlytalias, govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D3672
---
 src/lib/elm_gengrid.c | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/src/lib/elm_gengrid.c b/src/lib/elm_gengrid.c
index 034236a..729f9cd 100644
--- a/src/lib/elm_gengrid.c
+++ b/src/lib/elm_gengrid.c
@@ -3789,6 +3789,17 @@ _elm_gengrid_item_del_not_serious(Elm_Gen_Item *it)
 
if (it->walking > 0) return;
 
+   if (sd->show_it == eo_it)
+ {
+sd->show_it = NULL;
+sd->show_region = EINA_FALSE;
+ }
+   if (sd->bring_in_it == eo_it)
+ {
+sd->bring_in_it = NULL;
+sd->bring_in = EINA_FALSE;
+ }
+
if (it->selected)
  sd->selected = eina_list_remove(sd->selected, eo_it);
if (sd->last_selected_item == eo_it)

--

[EGIT] [core/elementary] master 01/01: [gengrid] possible crash issue fixed.

2016-02-12 Thread Prince Kumar Dubey 
hermet pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=087e19a8e1d72a159ee9731d468cf30b999adbef

commit 087e19a8e1d72a159ee9731d468cf30b999adbef
Author: Prince Kumar Dubey 
Date:   Fri Feb 12 19:42:25 2016 +0900

[gengrid] possible crash issue fixed.

Summary: reset show_it, bring_in_it and corresponding flags on item deletion

Test Plan: delete item with animation and rotate the handset display.

Reviewers: raster, cedric

Subscribers: shilpasingh, godlytalias, govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D3672
---
 src/lib/elm_gengrid.c | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/src/lib/elm_gengrid.c b/src/lib/elm_gengrid.c
index 034236a..729f9cd 100644
--- a/src/lib/elm_gengrid.c
+++ b/src/lib/elm_gengrid.c
@@ -3789,6 +3789,17 @@ _elm_gengrid_item_del_not_serious(Elm_Gen_Item *it)
 
if (it->walking > 0) return;
 
+   if (sd->show_it == eo_it)
+ {
+sd->show_it = NULL;
+sd->show_region = EINA_FALSE;
+ }
+   if (sd->bring_in_it == eo_it)
+ {
+sd->bring_in_it = NULL;
+sd->bring_in = EINA_FALSE;
+ }
+
if (it->selected)
  sd->selected = eina_list_remove(sd->selected, eo_it);
if (sd->last_selected_item == eo_it)

--

[EGIT] [core/elementary] master 03/09: conform: if window is in background, indicator must not update the plug information.

2015-11-09 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=b71e25bc0f1ce828dbfb4b686506166a18229cb1

commit b71e25bc0f1ce828dbfb4b686506166a18229cb1
Author: Prince Kumar Dubey 
Date:   Mon Nov 9 12:22:32 2015 -0800

conform: if window is in background, indicator must not update the plug 
information.

Summary:
When the window is in background, for associated conformant, indicator must 
not update the plug information.
To fix this issue, On window goes to background, the associated plug 
handled by confromant is deleted.

Test Plan:
On any device (like handset) which should have indicator support, this 
scenario can be reproduce. I tested on a handset
with gdb attach to running process having window and confromant with 
indicator support.

Reviewers: raster, Hermet, cedric

Reviewed By: cedric

Subscribers: rajeshps, govi

Differential Revision: https://phab.enlightenment.org/D3177

Signed-off-by: Cedric BAIL 
---
 src/lib/elm_conform.c| 42 ++
 src/lib/elm_widget_conform.h |  1 +
 2 files changed, 43 insertions(+)

diff --git a/src/lib/elm_conform.c b/src/lib/elm_conform.c
index 12d3477..491a1bf 100644
--- a/src/lib/elm_conform.c
+++ b/src/lib/elm_conform.c
@@ -833,6 +833,48 @@ _on_prop_change(void *data,
pid = (int)getpid();
 #endif
 
+   Evas_Object *conformant = (Evas_Object *)data;
+   ELM_CONFORMANT_DATA_GET(conformant, sd);
+   if ((ev->atom == ECORE_X_ATOM_NET_WM_STATE) && !sd->win_hidden)
+ {
+unsigned int i, num;
+Ecore_X_Window_State *state;
+ecore_x_netwm_window_state_get(ev->win, &state, &num);
+if (state)
+  {
+  for (i = 0; i < num; i++)
+{
+   if (state[i] == ECORE_X_WINDOW_STATE_HIDDEN)
+ {
+sd->win_hidden = EINA_TRUE;
+
+ecore_timer_del(sd->port_indi_timer);
+sd->port_indi_timer = NULL;
+
+ecore_timer_del(sd->land_indi_timer);
+sd->land_indi_timer = NULL;
+
+evas_object_del(sd->portrait_indicator);
+sd->portrait_indicator = NULL;
+
+evas_object_del(sd->landscape_indicator);
+sd->landscape_indicator = NULL;
+
+return ECORE_CALLBACK_DONE;
+ }
+}
+  }
+ }
+   else if (sd->win_hidden)
+ {
+sd->win_hidden = EINA_FALSE;
+sd->indmode = elm_win_indicator_mode_get(sd->win);
+sd->ind_o_mode = elm_win_indicator_opacity_get(sd->win);
+
+_indicator_mode_set(conformant, sd->indmode);
+_indicator_opacity_set(conformant, sd->ind_o_mode);
+ }
+
if (ev->atom == ECORE_X_ATOM_E_ILLUME_ZONE)
  {
 DBG("pid=%d, win=0x%x, ECORE_X_ATOM_E_ILLUME_ZONE.\n", pid, ev->win);
diff --git a/src/lib/elm_widget_conform.h b/src/lib/elm_widget_conform.h
index c312314..d54dc87 100644
--- a/src/lib/elm_widget_conform.h
+++ b/src/lib/elm_widget_conform.h
@@ -52,6 +52,7 @@ struct _Elm_Conformant_Data
Ecore_Timer   *port_indi_timer;
 
introt;
+   Eina_Bool  win_hidden;
 };
 
 /* Enum to identify conformant swallow parts */

--

[EGIT] [core/elementary] elementary-1.15 01/01: [elm_win] Possible memory leak Fixed.

2015-09-22 Thread Prince Kumar Dubey 
hermet pushed a commit to branch elementary-1.15.

http://git.enlightenment.org/core/elementary.git/commit/?id=f281b3f1f748bd854a732e399668e5a8739f20b2

commit f281b3f1f748bd854a732e399668e5a8739f20b2
Author: Prince Kumar Dubey 
Date:   Wed Sep 23 09:40:31 2015 +0900

[elm_win] Possible memory leak Fixed.

Summary: Memory assigned to variable "sd->wm_rot.rots" is not freed on 
window deletion.

Test Plan: Valgrind catch this memory leak.

Reviewers: raster, cedric, Hermet

Reviewed By: Hermet

Subscribers: govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D3041
---
 src/lib/elm_win.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lib/elm_win.c b/src/lib/elm_win.c
index 6e478f6..53c2ce9 100644
--- a/src/lib/elm_win.c
+++ b/src/lib/elm_win.c
@@ -1921,6 +1921,8 @@ _elm_win_evas_object_smart_del(Eo *obj, Elm_Win_Data *sd)
_elm_win_profile_del(sd);
_elm_win_available_profiles_del(sd);
 
+   free(sd->wm_rot.rots);
+
/* Don't let callback in the air that point to sd */
ecore_evas_callback_delete_request_set(sd->ee, NULL);
ecore_evas_callback_resize_set(sd->ee, NULL);

--

[EGIT] [core/elementary] master 01/01: [elm_win] Possible memory leak Fixed.

2015-09-22 Thread Prince Kumar Dubey 
hermet pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=aebbc66503f53477076400a9102b7ab5d5d2d3da

commit aebbc66503f53477076400a9102b7ab5d5d2d3da
Author: Prince Kumar Dubey 
Date:   Wed Sep 23 09:40:31 2015 +0900

[elm_win] Possible memory leak Fixed.

Summary: Memory assigned to variable "sd->wm_rot.rots" is not freed on 
window deletion.

Test Plan: Valgrind catch this memory leak.

Reviewers: raster, cedric, Hermet

Reviewed By: Hermet

Subscribers: govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D3041
---
 src/lib/elm_win.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lib/elm_win.c b/src/lib/elm_win.c
index c918b51..e6de231 100644
--- a/src/lib/elm_win.c
+++ b/src/lib/elm_win.c
@@ -1941,6 +1941,8 @@ _elm_win_evas_object_smart_del(Eo *obj, Elm_Win_Data *sd)
_elm_win_profile_del(sd);
_elm_win_available_profiles_del(sd);
 
+   free(sd->wm_rot.rots);
+
/* Don't let callback in the air that point to sd */
ecore_evas_callback_delete_request_set(sd->ee, NULL);
ecore_evas_callback_resize_set(sd->ee, NULL);

--

[EGIT] [core/elementary] master 05/10: entry: few times the hit_rect is not clipped properly during genlist scrolling, with entry as content.

2015-07-28 Thread Prince Kumar Dubey 
cedric pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=3a018721d83f2efc220572c29c3a17bcb575fc85

commit 3a018721d83f2efc220572c29c3a17bcb575fc85
Author: Prince Kumar Dubey 
Date:   Tue Jul 28 21:00:58 2015 +0200

entry: few times the hit_rect is not clipped properly during genlist 
scrolling, with entry as content.

Summary: It has been observed that while scrolling of genlist with entry, 
clipping is not happening and "hit_rect" comes over navi item title. e.g. 
During theme change such scenario comes.

@fix

Test Plan: Scenario not in elementary test. Entry as content of genlist 
item. Same genlist should be the content of naviframe item. In this scenario 
genlist height must be grater than viewport sie so scrolling possible.

Reviewers: cedric, raster, Hermet, woohyun

Subscribers: rajeshps, govi

Differential Revision: https://phab.enlightenment.org/D2836

Signed-off-by: Cedric BAIL 
---
 src/lib/elm_entry.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
index dda0057..ea7d3c4 100644
--- a/src/lib/elm_entry.c
+++ b/src/lib/elm_entry.c
@@ -839,6 +839,9 @@ _elm_entry_elm_widget_theme_apply(Eo *obj, Elm_Entry_Data 
*sd)
 
edje_object_message_signal_process(sd->entry_edje);
 
+   Evas_Object* clip = evas_object_clip_get(sd->entry_edje);
+   evas_object_clip_set(sd->hit_rect, clip);
+
if (sd->scroll)
  {
 Eina_Bool ok = EINA_FALSE;
@@ -3407,6 +3410,10 @@ _elm_entry_evas_object_smart_add(Eo *obj, Elm_Entry_Data 
*priv)
 
priv->hit_rect = evas_object_rectangle_add(evas_object_evas_get(obj));
evas_object_data_set(priv->hit_rect, "_elm_leaveme", obj);
+
+   Evas_Object* clip = evas_object_clip_get(priv->entry_edje);
+   evas_object_clip_set(priv->hit_rect, clip);
+
evas_object_smart_member_add(priv->hit_rect, obj);
elm_widget_sub_object_add(obj, priv->hit_rect);
 

--