devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=04d1fe7299f73376902ec3d28e5568ed52e9b374

commit 04d1fe7299f73376902ec3d28e5568ed52e9b374
Author: Chris Michael <cp.mich...@samsung.com>
Date:   Mon Nov 6 10:10:50 2017 -0500

    evas-object-main: Fix null dereference
    
    Coverity reports that EVAS_OBJECT_DATA_SAFE_GET returns NULL here (184
    out of 188 times). The _all_animation_objects_cancel function directly
    dereferences the obj parameter passed into it, so lets null check it
    before calling that function.
    
    Fixes Coverity CID1381710
    
    @fix
    
    Signed-off-by: Chris Michael <cp.mich...@samsung.com>
---
 src/lib/evas/canvas/evas_object_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/evas/canvas/evas_object_main.c 
b/src/lib/evas/canvas/evas_object_main.c
index 65b1817b4a..4ed5888cd5 100644
--- a/src/lib/evas/canvas/evas_object_main.c
+++ b/src/lib/evas/canvas/evas_object_main.c
@@ -209,7 +209,7 @@ _animation_intercept_hide(void *data, Evas_Object *eo_obj)
      {
         event_anim->hide_anim_started = EINA_TRUE;
 
-        _all_animation_objects_cancel(obj);
+        if (obj) _all_animation_objects_cancel(obj);
 
         //Create animation object to start animation
         event_anim->anim_obj = efl_animation_object_create(event_anim->anim);

-- 


Reply via email to