Re: Bug? diff.submodule=log adds text to commit -v message

2013-11-11 Thread Ari Pollak
Jens Lehmann writes:
 And after adding a modified file the log message also shows the diff of
 that file (and without leading # s too), so I doubt that diffs aren't
 normally included in the commit message with -v. What am I missing?

Ah, it is true that -v normally does not prefix the diffs with #, but there 
must be some filter in place after I save  quit my editor when a normal file 
diff is present, since that does not get included in the final commit 
message. But the submodule log does get included, which does not seem 
intentional.

Cheers,
Ari


--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Bug? diff.submodule=log adds text to commit -v message

2013-11-10 Thread Ari Pollak
Hi,

I'm using git 1.8.4.2, and I've set the diff.submodule = log option 
globally. If I change the revision that a submodule is set to, then run
git commit -av, The submodule shortlog is appended to the log message without 
any #s before it, so the log messages get included in my own log message. 
This seems like a bug and not a feature, as diffs aren't normally included in 
the commit message with -v.

Cheers,
Ari

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html