Re: [PATCH] grep: provide a noop --recursive option

2018-10-05 Thread Christoph Berg
Re: Stefan Beller 2018-10-01 

> git-grep is always file/tree recursive, but there is --recurse-submodules
> which is off by default. Instead of providing a short alias to a noop,
> we could use -r for submodules. (And if you happen to have no
> submodules, this is a noop for you)

That would be fine for me.

Thanks,
Christoph


Re: [PATCH] grep: provide a noop --recursive option

2018-09-29 Thread Christoph Berg
Re: Junio C Hamano 2018-09-29 
> I also expect folks who are used to "git grep --re" to summon
> the only option of the command that begins with that prefix to start
> complaining that they now have to type "--recurs" instead.

Fwiw I was just asking about -r. There doesn't have to be a
corresponding long option if the short one is a no-op.

Christoph


wishlist: git grep -r

2018-09-29 Thread Christoph Berg
I often use "grep -r $pattern" to recursively grep a source tree. If
that takes too long, I hit ^C and tag "git" in front of the command
line and re-run it. git then complains "error: unknown switch `r'"
because "git grep" is naturally recursive.

Could we have "git grep -r" accept the argument for compatibility?
Other important grep switches like "-i" are compatible, adding -r
would improve usability.

Thanks,
Christoph


signature.asc
Description: PGP signature