[PATCH v2] remotes-hg: bugfix for fetching non local remotes
6796d49 introduced a bug by making shared_path == .git/hg' which will most likely exist already, causing a new remote never to be cloned and subsequently causing hg.share to fail with error msg: mercurial.error.RepoError: repository .git/hg not found Changing shared_path to .git/hg/.shared will solve this problem and create a shared local mercurial repository for non local remotes. The initial dot circumvents a name clash problem should a remote be called shared. Signed-off-by: Joern Hees d...@joernhees.de Mentored-by: Antoine Pelisse apeli...@gmail.com --- contrib/remote-helpers/git-remote-hg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 0194c67..4a7d7a8 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remote-helpers/git-remote-hg @@ -390,7 +390,7 @@ def get_repo(url, alias): if not os.path.exists(dirname): os.makedirs(dirname) else: -shared_path = os.path.join(gitdir, 'hg') +shared_path = os.path.join(gitdir, 'hg', '.share') if not os.path.exists(shared_path): try: hg.clone(myui, {}, url, shared_path, update=False, pull=True) -- 1.8.3.4 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3] remotes-hg: bugfix for fetching non local remotes
6796d49 introduced a bug by making shared_path == .git/hg' which will most likely exist already, causing a new remote never to be cloned and subsequently causing hg.share to fail with error msg: mercurial.error.RepoError: repository .git/hg not found Changing shared_path to .git/hg/.shared will solve this problem and create a shared local mercurial repository for non local remotes. The initial dot circumvents a name clash problem should a remote be called shared. Signed-off-by: Joern Hees d...@joernhees.de Mentored-by: Antoine Pelisse apeli...@gmail.com Thanks-to: Junio C Hamano gits...@pobox.com --- contrib/remote-helpers/git-remote-hg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 0194c67..f4e9d1c 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remote-helpers/git-remote-hg @@ -390,7 +390,7 @@ def get_repo(url, alias): if not os.path.exists(dirname): os.makedirs(dirname) else: -shared_path = os.path.join(gitdir, 'hg') +shared_path = os.path.join(gitdir, 'hg', '.shared') if not os.path.exists(shared_path): try: hg.clone(myui, {}, url, shared_path, update=False, pull=True) -- 1.8.3.4 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] [SIGNED-OFF] remotes-hg: bugfix for fetching non local remotes
6796d49 introduced a bug by making shared_path == .git/hg' which will most likely exist already, causing a new remote never to be cloned and subsequently causing hg.share to fail with error msg: mercurial.error.RepoError: repository .git/hg not found Changing gitdir to dirname causes shared_path == .git/hg/remote_name/hg. The call to hg.share with local_path == .git/hg/remote_name/clone works again. Signed-off-by: Joern Hees d...@joernhees.de --- contrib/remote-helpers/git-remote-hg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 0194c67..89dd4cc 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remote-helpers/git-remote-hg @@ -390,7 +390,7 @@ def get_repo(url, alias): if not os.path.exists(dirname): os.makedirs(dirname) else: -shared_path = os.path.join(gitdir, 'hg') +shared_path = os.path.join(dirname, 'hg') if not os.path.exists(shared_path): try: hg.clone(myui, {}, url, shared_path, update=False, pull=True) -- 1.8.3.3 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] remotes-hg: bugfix for fetching non local remotes
6796d49 introduced a bug by making shared_path == .git/hg' which will most likely exist already, causing a new remote never to be cloned and subsequently causing hg.share to fail with error msg: mercurial.error.RepoError: repository .git/hg not found Changing gitdir to dirname causes shared_path == .git/hg/remote_name/hg. The call to hg.share with local_path == .git/hg/remote_name/clone works again. --- contrib/remote-helpers/git-remote-hg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 0194c67..89dd4cc 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remote-helpers/git-remote-hg @@ -390,7 +390,7 @@ def get_repo(url, alias): if not os.path.exists(dirname): os.makedirs(dirname) else: -shared_path = os.path.join(gitdir, 'hg') +shared_path = os.path.join(dirname, 'hg') if not os.path.exists(shared_path): try: hg.clone(myui, {}, url, shared_path, update=False, pull=True) -- 1.8.3.3 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html