Re: [PATCH] CodingGuidelines: updating 'rough' rule count

2015-04-12 Thread Eric Sunshine 
On Sun, Apr 12, 2015 at 7:47 PM, Julian Gindi juliangi...@gmail.com wrote:
 Changed inaccurate count of rough rules from three to four.

 Signed-off-by: Julian Gindi juliangi...@gmail.com
 ---
 diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
 index 0f8cccf..c422ecd 100644
 --- a/Documentation/CodingGuidelines
 +++ b/Documentation/CodingGuidelines
 @@ -1,5 +1,5 @@
  Like other projects, we also have some guidelines to keep to the
 -code.  For Git in general, three rough rules are:
 +code.  For Git in general, four rough rules are:

Although this change is technically accurate, this sentence is still a
potential maintenance burden. How about taking a more generic
approach, and saying something like:

For Git, in general, the rough rules are:

?

   - Most importantly, we never say It's in POSIX; we'll happily
 ignore your needs should your system not conform to it.
 --
 2.3.5
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] CodingGuidelines: updating 'rough' rule count

2015-04-12 Thread Julian Gindi 
Changed inaccurate count of rough rules from three to four.

Signed-off-by: Julian Gindi juliangi...@gmail.com
---
 Documentation/CodingGuidelines | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 0f8cccf..c422ecd 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -1,5 +1,5 @@
 Like other projects, we also have some guidelines to keep to the
-code.  For Git in general, three rough rules are:
+code.  For Git in general, four rough rules are:
 
  - Most importantly, we never say It's in POSIX; we'll happily
ignore your needs should your system not conform to it.
-- 
2.3.5

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html