Re: [PATCH] branch: fix shortening of non-remote symrefs
Hello,
On Sun, Apr 3, 2016 at 9:44 AM, Jeff King wrote:
> On Sun, Apr 03, 2016 at 02:54:22PM +1200, Phil Sainty wrote:
>
>> Given the following symbolic reference:
>>
>> $ git symbolic-ref refs/heads/m refs/heads/master
>>
>>
>> Correct in 2.6.6:
>>
>> $ PATH=~/git/git-2.6.6:$PATH git branch
>> m -> master
>> * master
>>
>>
>> Wrong in 2.7.0:
>>
>> $ PATH=~/git/git-2.7.0:$PATH git branch
>> m -> m
>> * master
Thanks for reporting this.
>
> Thanks for an easy test case. Though we don't officially support
> arbitrary symrefs in the ref namespace, they do mostly work. And
> certainly the current output is nonsense, and it worked before. This
> bisects to aedcb7d (branch.c: use 'ref-filter' APIs, 2015-09-23).
>
> The fix is below. Karthik, I didn't look at all how this interacts with
> your work to convert branch to ref-filter for printing. I imagine it
> drops this code completely, but we should make sure that ref-filter gets
> this case right. I almost didn't prepare this patch at all, but I
> suspect we may want it for "maint", while the full conversion would wait
> for "master".
>
It's dropped in my latest series. I should be able to replicate what you've done
here onto ref-filter.c. Since I'm re-rolling my patches, I'll add this
one along too.
> -- >8 --
> Subject: branch: fix shortening of non-remote symrefs
>
> Commit aedcb7d (branch.c: use 'ref-filter' APIs, 2015-09-23)
> adjusted the symref-printing code to look like this:
>
> if (item->symref) {
> skip_prefix(item->symref, "refs/remotes/", &desc);
> strbuf_addf(&out, " -> %s", desc);
> }
>
> This has three bugs in it:
>
> 1. It always skips past "refs/remotes/", instead of
> skipping past the prefix associated with the branch we
> are showing (so commonly we see "refs/remotes/" for the
> refs/remotes/origin/HEAD symref, but the previous code
> would skip "refs/heads/" when showing a symref it found
> in refs/heads/.
>
> 2. If skip_prefix() does not match, it leaves "desc"
> untouched, and we show whatever happened to be in it
> (which is the refname from a call to skip_prefix()
> earlier in the function).
>
> 3. If we do match with skip_prefix(), we stomp on the
> "desc" variable, which is later passed to
> add_verbose_info(). We probably want to retain the
> original refname there (though it likely doesn't matter
> in practice, since after all, one points to the other).
>
> The fix to match the original code is fairly easy: record
> the prefix to strip based on item->kind, and use it here.
> However, since we already have a local variable named "prefix",
> let's give the two prefixes verbose names so we don't
> confuse them.
>
> Signed-off-by: Jeff King
> ---
> The test makes sure we restored the v2.6.x behavior, namely that
> cross-prefix symrefs will not be shortened at all. It might be nice to
> show:
>
> ref-to-remote -> remotes/origin/branch-one
>
> or something, but that should be separate from the fix (and I don't
> overly care either way, so I probably won't work on it).
>
> builtin/branch.c | 19 ---
> t/t3203-branch-output.sh | 12
> 2 files changed, 24 insertions(+), 7 deletions(-)
>
> diff --git a/builtin/branch.c b/builtin/branch.c
> index 7b45b6b..f6c23bf 100644
> --- a/builtin/branch.c
> +++ b/builtin/branch.c
> @@ -393,22 +393,25 @@ static void format_and_print_ref_item(struct
> ref_array_item *item, int maxwidth,
> int current = 0;
> int color;
> struct strbuf out = STRBUF_INIT, name = STRBUF_INIT;
> - const char *prefix = "";
> + const char *prefix_to_show = "";
> + const char *prefix_to_skip = NULL;
> const char *desc = item->refname;
> char *to_free = NULL;
>
> switch (item->kind) {
> case FILTER_REFS_BRANCHES:
> - skip_prefix(desc, "refs/heads/", &desc);
> + prefix_to_skip = "refs/heads/";
> + skip_prefix(desc, prefix_to_skip, &desc);
> if (!filter->detached && !strcmp(desc, head))
> current = 1;
> else
> color = BRANCH_COLOR_LOCAL;
> break;
> case FILTER_REFS_REMOTES:
> - skip_prefix(desc, "refs/remotes/", &desc);
> + prefix_to_skip = "refs/remotes/";
> + skip_prefix(desc, prefix_to_skip, &desc);
> color = BRANCH_COLOR_REMOTE;
> - prefix = remote_prefix;
> + prefix_to_show = remote_prefix;
> break;
> case FILTER_REFS_DETACHED_HEAD:
> desc = to_free = get_head_description();
> @@ -425,7 +428,7 @@ static void format_and_print_ref_item(struct
> ref_array_item *item, int maxwidth,
> color = BRANCH_COLOR_CURRENT;
> }
>
> - strbuf_addf(&name, "%s%s", prefix, desc);
> + strbuf_addf(&name, "%s%s", prefix_to_show,
[PATCH] branch: fix shortening of non-remote symrefs
On Sun, Apr 03, 2016 at 02:54:22PM +1200, Phil Sainty wrote:
> Given the following symbolic reference:
>
> $ git symbolic-ref refs/heads/m refs/heads/master
>
>
> Correct in 2.6.6:
>
> $ PATH=~/git/git-2.6.6:$PATH git branch
> m -> master
> * master
>
>
> Wrong in 2.7.0:
>
> $ PATH=~/git/git-2.7.0:$PATH git branch
> m -> m
> * master
Thanks for an easy test case. Though we don't officially support
arbitrary symrefs in the ref namespace, they do mostly work. And
certainly the current output is nonsense, and it worked before. This
bisects to aedcb7d (branch.c: use 'ref-filter' APIs, 2015-09-23).
The fix is below. Karthik, I didn't look at all how this interacts with
your work to convert branch to ref-filter for printing. I imagine it
drops this code completely, but we should make sure that ref-filter gets
this case right. I almost didn't prepare this patch at all, but I
suspect we may want it for "maint", while the full conversion would wait
for "master".
-- >8 --
Subject: branch: fix shortening of non-remote symrefs
Commit aedcb7d (branch.c: use 'ref-filter' APIs, 2015-09-23)
adjusted the symref-printing code to look like this:
if (item->symref) {
skip_prefix(item->symref, "refs/remotes/", &desc);
strbuf_addf(&out, " -> %s", desc);
}
This has three bugs in it:
1. It always skips past "refs/remotes/", instead of
skipping past the prefix associated with the branch we
are showing (so commonly we see "refs/remotes/" for the
refs/remotes/origin/HEAD symref, but the previous code
would skip "refs/heads/" when showing a symref it found
in refs/heads/.
2. If skip_prefix() does not match, it leaves "desc"
untouched, and we show whatever happened to be in it
(which is the refname from a call to skip_prefix()
earlier in the function).
3. If we do match with skip_prefix(), we stomp on the
"desc" variable, which is later passed to
add_verbose_info(). We probably want to retain the
original refname there (though it likely doesn't matter
in practice, since after all, one points to the other).
The fix to match the original code is fairly easy: record
the prefix to strip based on item->kind, and use it here.
However, since we already have a local variable named "prefix",
let's give the two prefixes verbose names so we don't
confuse them.
Signed-off-by: Jeff King
---
The test makes sure we restored the v2.6.x behavior, namely that
cross-prefix symrefs will not be shortened at all. It might be nice to
show:
ref-to-remote -> remotes/origin/branch-one
or something, but that should be separate from the fix (and I don't
overly care either way, so I probably won't work on it).
builtin/branch.c | 19 ---
t/t3203-branch-output.sh | 12
2 files changed, 24 insertions(+), 7 deletions(-)
diff --git a/builtin/branch.c b/builtin/branch.c
index 7b45b6b..f6c23bf 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -393,22 +393,25 @@ static void format_and_print_ref_item(struct
ref_array_item *item, int maxwidth,
int current = 0;
int color;
struct strbuf out = STRBUF_INIT, name = STRBUF_INIT;
- const char *prefix = "";
+ const char *prefix_to_show = "";
+ const char *prefix_to_skip = NULL;
const char *desc = item->refname;
char *to_free = NULL;
switch (item->kind) {
case FILTER_REFS_BRANCHES:
- skip_prefix(desc, "refs/heads/", &desc);
+ prefix_to_skip = "refs/heads/";
+ skip_prefix(desc, prefix_to_skip, &desc);
if (!filter->detached && !strcmp(desc, head))
current = 1;
else
color = BRANCH_COLOR_LOCAL;
break;
case FILTER_REFS_REMOTES:
- skip_prefix(desc, "refs/remotes/", &desc);
+ prefix_to_skip = "refs/remotes/";
+ skip_prefix(desc, prefix_to_skip, &desc);
color = BRANCH_COLOR_REMOTE;
- prefix = remote_prefix;
+ prefix_to_show = remote_prefix;
break;
case FILTER_REFS_DETACHED_HEAD:
desc = to_free = get_head_description();
@@ -425,7 +428,7 @@ static void format_and_print_ref_item(struct ref_array_item
*item, int maxwidth,
color = BRANCH_COLOR_CURRENT;
}
- strbuf_addf(&name, "%s%s", prefix, desc);
+ strbuf_addf(&name, "%s%s", prefix_to_show, desc);
if (filter->verbose) {
int utf8_compensation = strlen(name.buf) -
utf8_strwidth(name.buf);
strbuf_addf(&out, "%c %s%-*s%s", c, branch_get_color(color),
@@ -436,8 +439,10 @@ static void format_and_print_ref_item(struct
ref_array_item *item, int maxwidth,
name.buf, branch_get_color(BRANCH_COLOR_RESET));
if (item->symref) {
- skip_prefix(item->symref, "refs/remot
