Re: [PATCH] doc: update information about windows build

[Kaartic Sivaraam]

On Monday 18 September 2017 12:32 AM, Phillip Wood wrote:

May be the Windows build exit with failure on other repos rather than
saying it passes?


I'm not quite sure what you're asking. If the tests aren't run it 
needs to look like a pass or everyone's branches would be marked as 
failing on github and more importantly it wouldn't be clear when there 
was a real failure on linux/macos. If the tests are run then it will 
pass/fail depending on the test result.

I thought failing wasn't a big issue because the macOS build failed most
of the time due to time-outs, at least for me. Most of the failed builds in
my build history were just the macOS builds timing out. That was some
time ago. They seem to be passing quite often recently.

---
Kaartic

Re: [PATCH] doc: update information about windows build

[Phillip Wood]

On 17/09/17 14:42, Kaartic Sivaraam wrote:


On Sun, 2017-09-17 at 14:24 +0100, Phillip Wood wrote:


  From that commit:
diff --git a/ci/run-windows-build.sh b/ci/run-windows-build.sh
new file mode 100755
index 0..4e3a50b60
--- /dev/null
+++ b/ci/run-windows-build.sh
@@ -0,0 +1,74 @@
+#!/usr/bin/env bash
+#
+# Script to trigger the a Git for Windows build and test run.
+# Set the $GFW_CI_TOKEN as environment variable.
+# Pass the branch (only branches on https://github.com/git/git are
+# supported) and a commit hash.
+#

so only git/git from github gets built on windows, not other peoples
trees. One cannot use travis to test ones changes on windows before
submitting them



Thanks for pointing it out didn't notice it. I have been confused by
the presence of the build named 'Windows' that I see even on my tree. I
  always see a green check mark near it which tricked me into believing
that they were running successfully. I didn't know they were being
skipped all these days!


Yes I only noticed the other day that the windows job only ran for a 
minute so I looked at the output log and saw it checks the repo and just 
exits if it's not git/git



May be the Windows build exit with failure on other repos rather than
saying it passes?


I'm not quite sure what you're asking. If the tests aren't run it needs 
to look like a pass or everyone's branches would be marked as failing on 
github and more importantly it wouldn't be clear when there was a real 
failure on linux/macos. If the tests are run then it will pass/fail 
depending on the test result.


Best Wishes

Phillip


---
Kaartic

Re: [PATCH] doc: update information about windows build

[Kaartic Sivaraam]

On Sun, 2017-09-17 at 14:24 +0100, Phillip Wood wrote:
> 
>  From that commit:
> diff --git a/ci/run-windows-build.sh b/ci/run-windows-build.sh
> new file mode 100755
> index 0..4e3a50b60
> --- /dev/null
> +++ b/ci/run-windows-build.sh
> @@ -0,0 +1,74 @@
> +#!/usr/bin/env bash
> +#
> +# Script to trigger the a Git for Windows build and test run.
> +# Set the $GFW_CI_TOKEN as environment variable.
> +# Pass the branch (only branches on https://github.com/git/git are
> +# supported) and a commit hash.
> +#
> 
> so only git/git from github gets built on windows, not other peoples 
> trees. One cannot use travis to test ones changes on windows before 
> submitting them
> 

Thanks for pointing it out didn't notice it. I have been confused by
the presence of the build named 'Windows' that I see even on my tree. I
 always see a green check mark near it which tricked me into believing
that they were running successfully. I didn't know they were being
skipped all these days! 

May be the Windows build exit with failure on other repos rather than
saying it passes?

---
Kaartic

Re: [PATCH] doc: update information about windows build

[Phillip Wood]

On 17/09/17 06:28, Kaartic Sivaraam wrote:


029aeeed5 (travis-ci: build and test Git on Windows, 2017-03-24) added
support for testing the git build for Windows.

So, update the documentation and the example used in it.


From that commit:
diff --git a/ci/run-windows-build.sh b/ci/run-windows-build.sh
new file mode 100755
index 0..4e3a50b60
--- /dev/null
+++ b/ci/run-windows-build.sh
@@ -0,0 +1,74 @@
+#!/usr/bin/env bash
+#
+# Script to trigger the a Git for Windows build and test run.
+# Set the $GFW_CI_TOKEN as environment variable.
+# Pass the branch (only branches on https://github.com/git/git are
+# supported) and a commit hash.
+#

so only git/git from github gets built on windows, not other peoples 
trees. One cannot use travis to test ones changes on windows before 
submitting them


Best wishes

Phillip

Signed-off-by: Kaartic Sivaraam 
---
  Documentation/SubmittingPatches | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 558d465b656a0..43c9b9ae49298 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -395,8 +395,9 @@ GitHub-Travis CI hints
  
  With an account at GitHub (you can get one for free to work on open

  source projects), you can use Travis CI to test your changes on Linux,
-Mac (and hopefully soon Windows).  You can find a successful example
-test build here: https://travis-ci.org/git/git/builds/120473209
+Mac.  Though Travis CI doesn't support Windows we have worked around
+that temporarily!  You can find a successful example test build
+here: https://travis-ci.org/git/git/builds/264560175
  
  Follow these steps for the initial setup:
  


--
https://github.com/git/git/pull/402

[PATCH] doc: update information about windows build

[Kaartic Sivaraam]

029aeeed5 (travis-ci: build and test Git on Windows, 2017-03-24) added
support for testing the git build for Windows.

So, update the documentation and the example used in it.

Signed-off-by: Kaartic Sivaraam 
---
 Documentation/SubmittingPatches | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 558d465b656a0..43c9b9ae49298 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -395,8 +395,9 @@ GitHub-Travis CI hints
 
 With an account at GitHub (you can get one for free to work on open
 source projects), you can use Travis CI to test your changes on Linux,
-Mac (and hopefully soon Windows).  You can find a successful example
-test build here: https://travis-ci.org/git/git/builds/120473209
+Mac.  Though Travis CI doesn't support Windows we have worked around
+that temporarily!  You can find a successful example test build
+here: https://travis-ci.org/git/git/builds/264560175
 
 Follow these steps for the initial setup:
 

--
https://github.com/git/git/pull/402